a74c1106d1
Address review comment on bug 9458 that depends on bug 367247 by making nsFrame::IsContainingBlock not check display type, but making it purely frame-class-based.
2007-01-27 18:45:35 +00:00
baec9bd166
Make mComputedWidth private, with a getter/setter, and make the setter update
...
the resize flags. Bug 367442, r+sr=dbaron
2007-01-26 00:05:12 +00:00
7413db90f4
Address review comment I missed. Bug 367749.
2007-01-24 20:23:08 +00:00
27ca5847eb
Fix various bugs in the column iterator's keeping track of the current row.
...
Bug 367749, r=bernd, sr=roc
2007-01-24 20:18:04 +00:00
f6245f0ed9
Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc
2007-01-23 04:06:56 +00:00
ed9ad7b7bf
Make it possible for callers who want to iterate all the row groups and
...
GetMapFor() for all of them do so in about O(N) time instead of O(N^2) (in
number of row groups). Bug 366892, r=bernd, sr=roc
2007-01-22 04:35:25 +00:00
21d73573a8
Have a faster way of iterating down the columns of a table. Bug 352461,
...
r=bernd, sr=roc
2007-01-22 04:32:33 +00:00
97b5794242
Stronger band-aid to prevent table splitting inside columns bug 362275 r/sr=roc
2007-01-21 17:51:33 +00:00
e47180b9d5
Make PushStackMemory never fail to simplify callers, and deCOMtaminate the stack memory API. b=366866 r+sr=bzbarsky
2007-01-17 23:53:47 +00:00
df3f524c0f
When possible, distribute min width of colspanning cells so it fits within the pref width of the spanned columns. b=363144 r=bernd sr=bzbarsky
2007-01-17 19:19:50 +00:00
52d0e2d098
Fix incorrectly placed PR_MAX(), since the span* values are additions to the base values. b=365173 r=bernd sr=bzbarsky
2007-01-13 01:08:18 +00:00
b32b8039f8
Accumulate column-spanning cells into column intrinsic widths separately for each number of columns spanned, in increasing order. b=363329 r=bernd sr=bzbarsky
2007-01-13 01:04:56 +00:00
13abe1b209
Zerorowspans are expanded during cellmap entry creation. There is no need to adapt the rowspan value later, bug 364318 r/sr=bzbarsky
2007-01-01 18:18:53 +00:00
27757bb08d
initialize variables before use bug 365075 r/sr=bzbarsky
2006-12-27 08:46:30 +00:00
4e651390ef
Bug 355300 There should be only one nsGkAtoms creature
...
r=dbaron
2006-12-26 17:47:52 +00:00
5f3f2bb2d3
be carefull with row indices when deleting cells bug=364318, patch by bz, r=me sr=roc
2006-12-26 14:24:15 +00:00
ea94fabefd
rename variable rename mRowCount to mContentRowCount so that it becomes obvious what it contains. Adjust the cellmap grow mechanism to the new nsTArray world bug=363370 r/sr=bzbarsky
2006-12-26 14:04:20 +00:00
0f8c9c56cf
add again bound checks that the BC code relies on. bug 364150 r/sr=bzbarsky
2006-12-26 13:55:32 +00:00
b80d119b57
Untabify.
2006-12-25 19:44:34 +00:00
146c1af6e5
Fix shadowing variable name. No bug.
2006-12-18 22:35:01 +00:00
1e894edf9f
Fix handling of columns in which no cell originates (i.e., unneeded extra colspan). b=363329 Patch from Bernd Mielke, bmlk%gmx.de, with review comments addressed by me. r+sr=dbaron
2006-12-18 22:34:30 +00:00
6705ad44ff
Remove some unused table code. Bug 359139, r=bernd, sr=roc
2006-12-18 03:04:25 +00:00
6ee857d0b7
Make the CSS 'ch' length unit work in most cases. b=363573 r+sr=dbaron
2006-12-17 14:06:42 +00:00
f10ce086e7
Use unsigned value with 1-bit field width, per sicking's advice. No bug.
2006-12-16 02:11:38 +00:00
d5af630c22
Better API for used padding/border/margin: remove deprecated Calc*For on nsStyleStructs and add GetUsed* to nsIFrame. b=332922 r+sr=roc
2006-12-13 23:04:57 +00:00
824d3cb3bf
Fix bustage. b=363524
2006-12-13 04:21:05 +00:00
79275357a7
Reflow all of the table structure (although not its descendants) when frame structure within the table is changed. b=363524 r=bernd sr=bzbarsky
2006-12-13 03:45:28 +00:00
52d6f885ce
report frames currently on the overflow list as frames on a additional childlist to get their views reparented if a frame higher in the tree needs to reparent the views bug 362724 r/sr=roc
2006-12-10 06:46:17 +00:00
f05e8007d1
Fix bad interaction of colspan handling with AddMinCoord's magic to deal with specified coord widths. Substantive changes by bzbarsky, comments by me. r+sr=dbaron/bzbarsky b=363150
2006-12-09 05:38:19 +00:00
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
99ed82e864
Fix build orange. Bug 356335, reviews hopefully coming up.
2006-12-07 03:43:52 +00:00
66d9ef86aa
Fix build bustage. See bug 356335 comment 18 for what I forgot to do in the
...
initial checkin for that bug... I need a longer-term memory, clearly. :(
2006-12-07 02:53:35 +00:00
132cdda426
Allocate the celldata structs from the presshell arena instead of allocating
...
them from the malloc heap with new. Use nsTArray to store them and an nsTArray
to store those arrays instead of using nsVoidArray. Bug 356335, r=bernd,
sr=sicking
2006-12-07 02:32:57 +00:00
5bbcbbdb17
colframes are referenced via the firstinflow bug 362348 r/sr=roc
2006-12-02 06:52:55 +00:00
d3be21f08f
don't rely on framconstructor to deliver a valid sibling for insert of colgroups and rowgroups as they are siblings contentwise but live on different childlists, bug 337124 r/sr=roc
2006-11-11 13:38:09 +00:00
dff951d9ff
mark only cells where the colspan/rowspan offset is != 0 as zero colspans/rowspans if those properties apply bug 358871 r/sr=bzbarsky
2006-11-01 18:45:41 +00:00
95696f562c
call the correct GetCellFrame function bug 358679 r/sr=bzbarsky
2006-10-30 19:21:05 +00:00
489591b510
make zero rowspans dependent on the content row count and not how many rows are currently in the cellmap, this cause otherwise problems during rebuild of the cellmap bug 339129 r/sr=bzbarsky
2006-10-28 10:14:43 +00:00
2722eb51e3
Revert a old design decision how to expand zero colspans in the cellmap. Once a cellmap hole was hit via the GetDataAt function the old code tried to repair this cellmap position by walking up and left till a possible origin of a zero span was hit. The new code uses a mark and sweep approach, which should remove the burden that ordinary tables without zero spans but large cellmap holes have to pay. bug 351942 r/sr=bzbarsky
2006-10-20 07:37:24 +00:00
516ce211dd
Bug 241796. Fix comments and handle OOM in SetProperty. Followup to the real fix. r+sr=bzbarsky
2006-09-22 01:56:04 +00:00
56f7eba7ce
mark for all reflows the rowgroup as incomplete if there are still nextinflows bug 347367 r/sr=roc
2006-09-21 09:55:07 +00:00
eb996179db
When painting backgrounds, don't loop over all rows. Just do the ones that
...
might intersect the dirty rect. Use the row cursor to optimize this. Bug
353455, r+sr=roc
2006-09-20 16:42:13 +00:00
c5f6e4e0b1
Bug 241796. Use a row cursor to speed up painting and event handling in large tables, similar to what we do for large blocks already. r+sr=bzbarsky
2006-09-19 21:39:33 +00:00
feea3a45cc
Reinstate reflow count painting when it's needed. Bug 352851, r+sr=roc
2006-09-19 04:26:20 +00:00
3640d5a918
enable old assert (from 2001) to catch cellmap errors, fix one erroneus caller bug 351691 r/sr=bzbarsky
2006-09-11 18:27:35 +00:00
06d5ebe18c
recover more gracefully from a error condition where cells are inserted into the cellmap after the last column bug 351328 r/sr=bzbarsky
2006-09-11 18:18:08 +00:00
9fa638f000
make sure the nextinflow will be pushed bug 347367 r/sr=roc
2006-09-02 09:14:02 +00:00
b6cec66d11
compute the BC information only if there are cells bug 350906 r/sr=bzbarsky
2006-09-02 08:48:39 +00:00
ccfb295963
expand zerospans before one tries to mark them as dead cells bug 350524 r/sr=bzbarsky
2006-09-02 08:33:52 +00:00
6fa9482b95
mark the whole table ofr bc recomputation if the rowgroups change bug 347796 r/sr=bzbarsky
2006-08-28 17:41:46 +00:00
6f250e7252
match the numer of columnss in the cellmap and the col cache bug 350081 r/sr=bzbarsky
2006-08-28 17:39:36 +00:00
260c8a2aa1
adjust col frames instead of asserting that the number of cols is wrong bug 347725 r/sr=bzbarsky
2006-08-22 06:08:15 +00:00
02eaae11b6
Improve error handling in nsCSSFrameConstructor::CreateContinuingFrame() and its callers. b=337419 r+sr=roc
2006-08-22 01:33:46 +00:00
2c818d7977
Bugzilla Bug 344883
...
print previewing url freezes bon echo (and minefield if you zoom too)
Patch by leon.sha@sun.com
bernd_mozilla: review+
roc: superreview+
2006-08-07 11:03:43 +00:00
fc6d5370ff
fix VC6 build bustage
2006-08-04 20:32:46 +00:00
d4f3eadccd
take special care when tfoot are manipulated and the cellmap changes rather drastical bug 343087 r/sr=bzbarsky
2006-08-04 19:15:50 +00:00
8c0e3dd5b7
Handle returning nulls from CheckLineOrder correctly. bug=345616 r=smotagu sr=roc
2006-08-04 05:40:57 +00:00
103658af2a
fix a coding error in the patch for bug 339246 bug 343588 r/sr=bzbarsky
2006-08-02 12:02:37 +00:00
2c35fc2818
fix cellmap errors with the num of rows in the cellmap vs the num of rows in the content bug 344000 r/sr=bzbarsky
2006-08-02 11:57:48 +00:00
26a1119b47
[Debug only] Add nsTableCaptionFrame::GetFrameName() returning "Caption". b=343386 r+sr=bzbarsky
2006-07-20 08:50:26 +00:00
9a79b08c79
when we remove cells the number of columns in the cellmap may rise if rowspans are involved bug 343778 r/sr=bzbarsky
2006-07-19 19:21:50 +00:00
153ab238ca
Fix crash when recreating <caption> frames. Add ASSERTIONs to detect similar frame construction errors in the future. b=341382 r+sr=bzbarsky
2006-06-29 02:32:36 +00:00
822b5ee5b0
reset row indices if rowgroups may have moved bug 342559 r/sr=bzbarsky
2006-06-28 19:00:01 +00:00
424fb80e20
reset column info for all cellmaps if they need to be reset, bug 339246 r/sr=bzbarsky
2006-06-28 18:56:10 +00:00
12ffb8ee63
adjust the starting column index always if a entire colgroup needs adjusted colindices bug 339315 r/sr=bzbarsky
2006-06-24 05:42:38 +00:00
70ec56f2d3
reorder cellmaps if the rowgroup order might have changed bug 339130 r7sr=bzbarsky
2006-06-22 04:19:36 +00:00
6da332dd07
Bug 338770. Don't even start trying to split a rowgroup in columns mode. r=bernd,sr=bzbarsky
2006-06-06 22:45:14 +00:00
a714532cd0
avoid memory leak on early return bug 333354 r/sr=bzbarsky
2006-05-25 14:56:44 +00:00
4571423968
Fixing bustage
2006-05-01 01:41:41 +00:00
dd16b28d00
Bug 334690. Fix regression in z-ordering of table cell content for event handling. r=bernd
2006-05-01 01:18:32 +00:00
8956f1d8a1
Bug 334942. ExplodeAnonymousChildLists before sorting table parts. r=bernd
2006-04-27 02:25:23 +00:00
aac1b0d44f
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 02:01:07 +00:00
ee089f28b9
Bug 333481. Sort table-part event-handling display items to ensure that the table comes before all row-groups, which come before all rows, which come before all cells. r=bernd
2006-04-17 22:16:24 +00:00
10e108eef9
remove deadcode and fix a potential 0 deref, bug 333356 r/sr=bzbarsky
2006-04-15 04:56:52 +00:00
049d72f6e1
fix potential 0 deref bug 333351 r/sr=roc
2006-04-14 16:21:21 +00:00
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
1d47f5e73d
prevent a second call to SetInitialChildList bug=333288 r/sr=bzbarsky
2006-04-09 18:43:46 +00:00
04b8c33eda
Remove uses of MOZ_DECL_CTOR_COUNTER, which is always defined to nothing. b=332745 rs=roc,bzbarsky
2006-04-05 00:00:44 +00:00
20837f71e1
fixes bug 328925 "Replace NS_WARN_IF_FALSE with NS_ASSERTION (where appropriate)" r=dbaron
2006-03-30 18:40:56 +00:00
1e650e3784
Bug 331415: some printing code cleanup. r+sr=roc.
2006-03-30 00:27:42 +00:00
dc6b06b190
don't rely on the inner cell frame but catch events on the cell frame itself bug 326308 r/sr=roc
2006-03-29 04:33:34 +00:00
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
129b81296d
adjust start col index when looping over rtl colspans bug 331344 r/sr=roc
2006-03-26 15:58:34 +00:00
14f0791bf3
insist on an inner table frame, resistance to any other childlist, bug 329768, r/sr=bzbarsky
2006-03-18 07:18:54 +00:00
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
6fd863f2dd
Bug 330300. Move mFrame from nsDisplayItem subclasses up to nsDisplayItem itself, and make GetUnderlyingFrame an inline non-virtual function. Patch by Alfred Peng, r+sr=roc
2006-03-14 20:43:18 +00:00
c2801ebbd7
Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell
2006-03-09 18:55:21 +00:00
1c6c74da4a
Don't create dead cells if the position is outside the cellmap boundaries. bug 328339 r/sr=bz
2006-03-04 05:32:38 +00:00
20b85ffac2
Make visibility:collapse work again after the display list change. Implement overflow handling and view synchronization for collapsed frames. bug 326551 r/sr=roc
2006-03-04 05:26:57 +00:00
426f83aecc
Bug 298277 remove useless references to nsVoidArray
...
r=dbaron sr=dbaron
2006-02-23 10:30:59 +00:00
c7032d59bb
Bug 299065: Bidi resolution needs to split inlines in addition to text frames. r+sr=dbaron
2006-02-21 21:33:47 +00:00
32e0b4f487
don't shrink cells below borderpadding in fixed layout, bug 308019 r/sr=bzbarsky
2006-02-11 11:12:40 +00:00
f96a096c2c
Fix leak bug 324969 -- make sure to call virtual destructors.
2006-01-29 18:48:58 +00:00
430211b413
reorder row groups to keep them in sync when the nextinflow changes underneath bug 302911 r/sr=roc
2006-01-28 06:14:11 +00:00
77bca74243
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
1bb0037d58
error in the patch for bug 307367, spotted by jag
2006-01-21 10:14:38 +00:00
ef5d2c73ea
use scaledpixels to convert from CSS pixels to realword pixels bug=307367 r/sr=roc
2006-01-21 09:54:07 +00:00
6400a4a6ba
Make sure to call the right destructor on cellmap info structs. Bug 302725,
...
r=bernd, sr=dbaron
2006-01-13 21:08:17 +00:00
b91b76b673
insert new rowgroup cellmaps in the order predicted by OrderRowGroups, bug=317554 r/sr=roc
2005-12-16 19:10:56 +00:00
5663eeaaaa
Do not prevent the creation of multiple captions, but display only the first one, bug 309322 r/sr=bzbarsky
2005-12-03 15:13:08 +00:00
d80bb5e08d
fix for null pointer deref, only rowspans span into the row below. bug 316636 r/sr=bzbarsky
2005-11-28 19:29:26 +00:00
9e0ea03b7a
fix for a regression from bug 271789, deadcells are nearly equivalent to complete cellmap holes, bug 317148 r/sr=bzbarsky
2005-11-21 18:08:30 +00:00
1c34e68034
Bug 106386 Correct misspellings in source code
...
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
2005-11-20 22:05:24 +00:00
78f6d0683d
Bug 313309 part 2 - change the NS_DEFINE_STATIC_IID_ACCESSOR macro to NS_DECLARE, and make a NS_DEFINE_ macro that's outside the class declaration, r=shaver
2005-11-11 14:36:26 +00:00
2163d4caa2
mark cell hooles that are not caused by zero spans as dead, this will limit searches when a search is initiated at other cell hooles. bug 271789 r/sr=bzbarsky
2005-11-11 05:22:18 +00:00
e7a8486231
limit search for real table cells to place where they can be expected, bug 313295 r/sr=bzbarsky
2005-11-04 18:41:32 +00:00
520b30a7f7
Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell
2005-11-04 02:38:33 +00:00
43ac693e27
look for originating table cells only at places where they are supposed to be bug 313295 r/sr=bzbarsky
2005-10-29 13:45:38 +00:00
3d5f7550f7
bug 314197: Change this often-firing table assertion into a warning. r=bernd sr=bzbarsky
2005-10-28 19:49:51 +00:00
9125d9fa0e
Return the frame count for the given line 'aLineNumber', not the line where we find the first frame. b=308052 r=bernd sr=bzbarsky
2005-10-17 00:03:05 +00:00
8d2cb2369f
handle baseline for empty table cells closer to the new description in CSS2.1, bug 291060 r/sr=dbaron
2005-10-04 15:47:21 +00:00
6b18d5aa23
Do not rely on addcells to compute correctly mRowCount. bug 308752 r/sr=bzbarsky
2005-09-25 18:42:31 +00:00
fed343c43a
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
e6c127026a
Fix crash bug 302118, patch by bernd, r+sr=bzbarsky
2005-09-12 13:44:15 +00:00
cf64715ae5
Remove the pointless nsIContent arg of nsIFrame::AttributeChanged. Bug 281390,
...
patch by Vidar Braut Haarr <vhaarr+bmo@gmail.com>, r+sr=bzbarsky
2005-09-07 16:49:21 +00:00
77004905b6
limit pctHeightObserver to quirks mode bug 305975 r/sr=bzbarsky
2005-08-30 16:14:53 +00:00
b4d01d069d
Bug 277553 clicking on Textarea with a RTL direction doesnt work
...
patch by uriber@gmail.com r=bz sr=bz a=bsmedberg
2005-08-02 21:55:55 +00:00
fb7a593376
fix reflow reason for special height reflow, reevaluate height reflow conditions as tables with fixed layout might have one reflow less bug 293761 r/sr=roc a=asa
2005-06-21 04:50:42 +00:00
9da0ce304f
Bug 294823 ASSERTION: max element width exceeded desired width: 'PR_FALSE'
...
patch by bernd r=roc sr=roc a=asa
2005-06-16 18:22:38 +00:00
2f16a8de39
Fix leak in table background painting. Bug 295236, r=bernd, sr=dveditz, a=asa
2005-05-24 04:15:05 +00:00
e61e1e1935
Fix border width inheritance by keeping track of both the border width we'd
...
have if our style were not none/hidden and the actual computed border width.
Bug 290377, r+sr=dbaron, a=asa
2005-04-29 15:44:38 +00:00
84b0577142
Bug 240276. Make nsHTMLScrollFrame be a regular HTML frame, not a box frame, so we don't have to go through box layout. It gets its own reflow implementation that handles min-max and lots of other good stuff. rs+sr=dbaron,a=asa
2005-04-28 21:57:22 +00:00
06ee318b44
Fix too-much-overflow regression by making border-collapse cells store the full width of the border rather than just the inside half of it. Also make BCPixelSize 16-bit instead of 8-bit and use it in more places, and a little other cleanup. b=286794 r=bernd sr=roc a=brendan
2005-04-07 18:04:38 +00:00
432b12afd2
we need enough space to insert a cell even at the end of a row, bug=284575 r/sr=bzbarsky
2005-04-04 17:20:08 +00:00
3d2bafdf0a
prevent negative available widths for rowgroups when changing from an empty table to one with cells and cellspacing, bug 271047 r/sr=roc
2005-03-30 07:42:49 +00:00
9309f3621b
Fix coverity uninitialized variable warnings in layout. b=288092 r=bernd sr=roc
2005-03-30 01:50:56 +00:00
dfa6f80fa5
build warnings (shadow + unused variables) bug 287097 r/sr=bzbarsky
2005-03-24 19:02:59 +00:00
50f90a7217
take vertical margins into account during height constrained situations like printing. bug 285006 r/sr=roc
2005-03-19 17:59:11 +00:00
d41e093134
Make overflow area for border-collapse table cells include the whole border (and maybe a pixel more) so that style change invalidation of border-collapse table cells will invalidate what got changed. b=271755 r=bernd sr=roc
2005-03-18 02:15:44 +00:00
1d9c9b1e48
Bug 285030. Ensure BCData::mCornerBevel is initialized. r=bernd, sr=bzbarsky
2005-03-06 21:18:54 +00:00
1c6747ce96
limit the nowrap + width hack to quirks mode bug 277232 r/sr=bzbarsky
2005-03-06 18:33:12 +00:00
a4dea01a20
make colframe cache nonpublic bug 278644 r/sr=bzbarsky
2005-03-05 16:43:07 +00:00
996d1e3d9e
Bug 274516. Tables should use the ordered rowgroup array to decide which children to push, not just follow the sibling list. Also, repeating footers should not be pushed. r=bernd, sr=bzbarsky, a=choffman
2005-02-16 20:02:14 +00:00
e042c2f571
Move reflow command construction into nsPresShell::AppendReflowCommand, remove
...
some members, switch some callers to the non-COM-ish apis. Bug 267085, r+sr=rbs
2005-02-08 00:59:52 +00:00
064c7eb606
Remove unneeded nsIFrameLoader interface (bug 280992). r+sr=jst.
2005-02-07 23:53:47 +00:00
54d585f2af
Remove prescontext args for some nsIFrame methods
...
(Append/Insert/Remove/ReplaceFrames) and for some methods in table land. Patch
by Vidar Braut Haarr <bugmail@q1n.org>, r+sr=bzbarsky
2005-02-07 01:58:25 +00:00
92858c988e
Don't page-break before or after a repeated frame. b=278983 r+sr=bzbarsky
2005-02-05 04:23:52 +00:00
6296aebe00
Insert only one column group at a time and not all following siblings, bug 277062 r/sr=bzbarsky
2005-02-01 18:07:44 +00:00
e2081a89e6
Bug 236476: Change GetHTMLAttribute to GetParsedAttr. Also fixes bug 232706 by removing final uses of nsHTMLValue.
...
r=bz sr=jst
2005-01-25 00:02:58 +00:00
a8073f18a3
Remove nsIHTMLContent interface (bug 276959). r+sr=jst.
2005-01-12 19:45:38 +00:00
3818dd1bf9
improve the splitting of row groups in pagination mode, bug 272830 r/sr=bzbarsky
2005-01-01 18:23:33 +00:00
74e2aa375a
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
3d7261604c
Bug 270708 remove nsPresContext variable from AttributeChanged and cleaned up comment in nsIFrame.h
...
p=bugmail@q1n.org r=pkwarren sr=bzbarsky
2004-12-31 01:13:27 +00:00
70482809ca
Bug 113580 switch uses of getAttribute to hasAttributeValue whenever possible
...
p=bugmail@q1n.org r=dbaron sr=bzbarsky
2004-12-31 00:41:58 +00:00
a11cf38d3a
style lookup correction for border collapse computation under rtl conditions, bug 267420 r=fantasai sr=dbaron
2004-12-27 18:43:55 +00:00
ca3e9f85c3
remove unused prescontext from PlaceFrameView, PlaceChildsView, ConsiderChildOverflow bug 276092 r/sr=dbaron
2004-12-27 15:05:18 +00:00
1a43dc79c0
Fix misspellings of 'pseudo' in comments. Bug 106386. Patch by Alex Vincent <ajvincent@gmail.com>. r=timeless sr=peterv
2004-12-19 21:45:51 +00:00
60567bb185
Bug 275605 - libxul step 3 (all of tier 9, except libmozjs.so which will remain separate indefinitely) r=darin
2004-12-15 04:07:01 +00:00
953fdd4a1f
Bug 272151: reorganize files within layout, r+sr=roc: add new Makefiles.
2004-12-07 18:09:28 +00:00
3afdea9ca5
switch the frame sorting from the frame constructor to the table frame + a couple of build warning fixes, bug 269648, r/sr=bzbarsky
2004-12-01 18:47:34 +00:00
05b01d4b46
Fix painting of backgrounds on scrollable rowgroups (which aren't kids of the
...
table, so require slightly more complicated computation of the coordinate
transformations). Bug 267592, r=fantasai, sr=roc
2004-12-01 03:51:35 +00:00
f162e6b75d
Do size adjustments for empty cells only when 'empty-cells' says empty cells don't have borders. b=271955 r=bernd sr=roc
2004-12-01 03:50:03 +00:00
da145480c7
Fix asserts by making sure that border-spacing is always computed to coord
...
values. Bug 270325, r+sr=dbaron
2004-11-30 18:30:58 +00:00
c59dda520c
Bug 271869. mBorderWidths need not be per-nsStyleBorder/nsStyleOutline, put it in the prescontext instead. r+sr=dbaron
2004-11-26 18:40:58 +00:00
cf27365150
update the block overflow area if we shorten a cell in fixed layout, bug 266868 r/sr=roc
2004-11-14 14:47:59 +00:00
ce51183fce
Split row groups works only for paginated media bug 268231 r/sr=bzbarsky
2004-11-11 17:27:38 +00:00
9f011feb30
Part of bug 250269. Outline missing on some elements. r+sr=roc
2004-11-11 15:21:52 +00:00
2ba6814444
Bug 250269. Outlines not getting painted on buttons, radios, checkboxes, tables and table cells. r+sr=roc
2004-11-11 15:07:22 +00:00
2eda0dd986
during pseudo frame creation pseudo colgroup frames should not taken into account when analyzing the pseudostackframe depth, bug 266015 r=me sr=bzbarsky
2004-11-06 07:07:43 +00:00
38ed40934b
fix build bustage
2004-10-31 16:55:12 +00:00
68d0ad36e1
paint borders rtl in border collapsed tables when dir=rtl is specified for the table, initial patch by dbaron bug 174470 r/sr=dbaron
2004-10-31 15:52:52 +00:00
4f05ce3a62
change ref to pointer to catch spurious crash bug=264733 r/sr=bzbarsky
2004-10-29 17:44:29 +00:00
22a3945caa
fix flawed reflow logic for empty table cells bug 226637 r/sr=bzbarsky
2004-10-29 17:31:53 +00:00
5be60c13bc
query the reflow path only during incr. reflow bug 264620 r/sr=bzbarsky
2004-10-16 18:21:15 +00:00
d833f65d56
mark previously destroyed row frame as nsnull so that the pointer will not be reused bug 263738 r/sr=bzbarsky
2004-10-13 05:49:39 +00:00
6a161de41d
hide the overflow that results from overconstrained percentage heights inside table cell frames only in quirks mode, bug 245434 r/sr=dbaron
2004-10-10 07:31:35 +00:00
dc7f3d55d0
reorganize CalCDominantBorder, reduce the number of arguments, change the border structure. make the rules handling more evident, bug 229883, With more than a little help from my friends (fantasai, boris) r/sr=bzbarsky
2004-10-09 12:04:52 +00:00
bc7e872edd
at the table bottom use this row as it is the only place where we dont paint above the row, bug 254538 r/sr=bzbarsky
2004-09-19 18:15:37 +00:00
ddf4e18bb2
ensure a correct overflow area, even if the overflow is clipped, it should be the frame size under these conditions bug = 260241 r/sr=dbaron
2004-09-19 09:50:41 +00:00
8a2853a92c
valign content that overflows the table cell from the celltop bug=114430 r/sr=bzbarsky
2004-09-18 19:04:13 +00:00
44a2fd5b52
Bug 259032. DeCOMtaminate nsIFrame::GetNext/PrevInFlow. r+sr=roc, patch by Will Levine
2004-09-14 02:28:03 +00:00
939c392649
CalcDesiredHeight might change the overflow area, so it needs to be included in the reflowmetrics bug=231275 r/sr=dbaron
2004-09-13 18:21:03 +00:00
02de8104c7
don't cause twice a initial reflow on a caption bug 258379 r/sr=bzbarsky
2004-09-11 06:08:53 +00:00
6255acffd9
Bug 254039. deCOMtaminate nsIScrollableFrame. r+sr=roc, patch by Will Levine
2004-09-06 02:44:43 +00:00
a6249cf9b7
1. enhancement of the debug code so that coltypes become visible
...
2. remove the isanonymous flag which is unused
3. make the col dump routine #ifdef DEBUG
4. stop to defer the appending of the colgroup frame. bug 248474 r/sr=bzbarsky
2004-09-04 16:02:50 +00:00
01f5e54ff0
Land bug 72747 in pieces: use new functions for common overflow tests. b=72747 r+sr=roc
2004-09-02 23:27:23 +00:00
eb2e3f075e
tables without cells should not add vertical cellspacing bug 246534 r/sr=bzbarsky
2004-09-02 06:36:56 +00:00
9fe7e8650d
Bug 257430. nsImageFrame and nsTableRowFrame need to always include their frame bounds in their overflow area. r+sr=dbaron
2004-09-01 13:33:17 +00:00
879d8114ba
bring condition and action in better sync when oversized nested pct based table frames are reduced in size bug 254344 r/sr=bzbarsky
2004-08-31 18:57:06 +00:00
d082d2bf5e
More nsIPresShell deCOMtamination:
...
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.
Bug 253889, r+sr=roc.
2004-08-29 03:08:44 +00:00
c200b49750
Back out the rest of bug 72747 due to Tp regression.
2004-08-27 01:26:55 +00:00
5948a3cb75
Implement 'overflow-x' and 'overflow-y' CSS properties, long implemented by IE for Windows and proposed for CSS3. Implement scrolling='yes' and equivalents on frame and iframe. Various pieces of related cleanup (see comment 22 in bug). b=72747 r+sr=roc
2004-08-26 17:11:20 +00:00
dba4f07f62
Bug 133165. Draw the outline outside the frame's normal overflow area. r+sr=dbaron. Also, correct some trivial misuses of nsChangeHint, r+sr=mozbot
2004-08-26 00:07:56 +00:00
b88692c5a1
Trying again to land support for content node properties (bug 253888). r=jst, sr=dbaron.
2004-08-24 18:50:29 +00:00
0c08074b27
Backing out 253888 again due to Tp regression plus another problem I noticed (frame properties not getting destroyed on frame destruction)
2004-08-22 07:10:50 +00:00
d86c91ac3a
Second try at landing support for content node properties (bug 253888). r=jst, sr=dbaron.
2004-08-22 04:58:44 +00:00
8c24cc7e63
Backing out bug 253888 until I can figure out how to fix the crash
2004-08-21 06:27:54 +00:00
11d98b36e5
Refactor the frame property code and use it for supporting properties on dom elements. Bug 253888, r=jst, sr=dbaron.
2004-08-21 05:09:50 +00:00
94bc9d26c8
Fix names of constants to correspond to the new definitions of the values of the 'overflow' property. b=69355 r+sr=roc
2004-08-10 01:32:10 +00:00
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
0fd21c3872
Consolidate PresContext classes into a single nsIPresContext implementation, and finish deCOMtaminating it. Bug 253470, r+sr=roc.
2004-07-29 19:41:39 +00:00
b751c53c83
Bug 251501. Refactor handling where frames get inserted on content insertion. r+sr=dbaron
2004-07-18 12:02:53 +00:00
910e44a7d5
Bug 151375. Implement css2 outline (still called -moz-outline for now). Makes -moz-outline draw outside of the current frame. Improves appearance of focus outline. Lots of help from roc. r+sr=dbaron
2004-07-16 16:56:21 +00:00
f158d730dc
Fix bug 241599 - Speed up table layotu code by reducing GetCellInfoAt() calls. r=bernd sr=dbaron
2004-07-16 01:49:18 +00:00
692a414811
Backing out bug 151375 for now, because of scrolling regressions in HTML and XUL listboxes and comboboxes
2004-07-15 18:57:47 +00:00
be1b821056
Bug 151375. Implement css2 outline (still called -moz-outline for now). Makes -moz-outline draw outside of the current frame. Improves appearance of focus outline. Lots of help from roc. r+sr=dbaron
2004-07-14 21:58:34 +00:00
aa063dc0db
empty tables should not have a size in quirks mode. bug 241161 r/sr=bzbarsky
2004-06-09 04:13:53 +00:00
790167bd82
Bug 241454. Enforce the rule that if a frame ever reflows its child asking for MEW, then it *always* reflows the child asking for MEW. r=bernd,sr=dbaron
2004-06-06 20:45:23 +00:00
890df88cf5
during incr. reflow table cells have a unconstrained computed size, they need to ensure that a second constrained reflow is issued on the children, bug 237366, initial idea by saito@densan.co.jp r/sr=dbaron
2004-06-05 16:59:46 +00:00
307143cf2a
reset the cell offset when a row becomes again visible, order the rowgroups before collapsing the rows bug 242253 r/sr=dbaron
2004-05-08 05:11:29 +00:00
1b62f506e5
remove unused code that causes crashes, bug 242368, p=fantasai r=bernd sr=rbs a=asa
2004-05-05 16:03:55 +00:00
5a1e4899be
add colframe documentation, fix a colframe renumbering problem, bug 238999 r/sr=bzbarsky
2004-05-03 18:31:34 +00:00
3b5407ab45
remove bogus conversions bug 241997 r/sr=bzbarsky
2004-05-02 09:51:57 +00:00
f857105001
make visibility collapse work during incr reflows bug 77019 r= bzbarsky sr=dbaron
2004-04-28 16:42:59 +00:00
f5904c3c32
remove special handling for rows with rowspans as table frames report now the overflow area. bug 240275 r/sr=roc
2004-04-26 17:56:48 +00:00
d44c8e2932
Change mCBReflowState to mean the containing block of _this_ reflow state
...
instead of the containing block of kids. Fix the containing block calculations
for various cases of absolutely positioned descendants of relatively positioned
inlines (eg make "right" and "bottom" work in those situations). Bug 135082,
r+sr=dbaron
2004-04-24 17:56:23 +00:00
868dd94ecb
Bug 240274 - remove unused argument of SetClip{Rect,Region}.
...
r=blizzard, sr=bryner
2004-04-23 15:21:24 +00:00
775215ff0d
fix bustage
2004-04-21 16:45:42 +00:00
de5b842be2
Remove unused functions bug 240559 r/sr =bzbarsky
2004-04-21 15:49:29 +00:00
05b675f299
remove table background quirk use standards painting instead bug 237078 patch by fantasai@escape.com r=bernd sr=dbaron
...
crash prevention when colframes return bogus colindices bug 240854 r/sr=bzbarsky
2004-04-18 18:17:00 +00:00
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
83eb215db9
Bug 240274 - remove PopState() argument. r=blizzard, sr=bryner
2004-04-18 13:13:35 +00:00
fcfa993e38
use the desiredsize and not the previous mrect size for the overflow area, bug 233438, r/sr=dbaron
2004-04-15 04:28:28 +00:00
ad43c63bf3
make table pixel rounding IE compatible, bug 188377 patch by croo@nm.ru, r=me sr=dbaron
2004-04-15 04:13:11 +00:00
5171d71d60
row view needs to synced after we resized the cells bug 239101 r/sr=roc
2004-04-14 06:22:52 +00:00
edff141de5
Fix logic error causing certain patterns of table rows to spread themselves over many pages when printing. b=231823,212984 r=bernd sr=roc
2004-04-13 20:47:52 +00:00
8c2f50790a
move HasMoreThanOneCell from nsTableRowGroupFrame.cpp into nsCellMap.cpp where it belongs. Don't try to repair the cellmap on every reflow, this might help with with large table rendering performance, bug 240318 r/sr=bzbarsky
2004-04-13 06:21:16 +00:00
cd708d9afb
Fix Bug 236703 - Make the table layout code faster and smaller.
...
r=bernd sr=bzbarsky
2004-04-12 23:51:33 +00:00
b30731f177
Bug 239962 Incorrect table layout caused by Sun compiler with -xO5
...
r=roland.mainz, sr=roc, a=mkaply
a workaround for the Sun Forte compiler's bug.
2004-04-08 13:46:57 +00:00
1a0dd341a6
synchronize the view of a table cell if we dont realign the cell content vertically, bug 237734, r/sr=roc a=chofmann
2004-03-28 15:13:31 +00:00
26b1761add
snychronize the view of a table cell once we have vertically aligned the cell content and know the correct overflow area, bug 230730, r/sr=roc a=chofmann
2004-03-28 06:31:03 +00:00
83d28ac5d6
Protect during border collapse computations against zero child frames. This is another fallout from the checkin 3.556 for bug 4510, bug 238537, patch by fantasai@escape.com sr=dbaron r=bernd a=chofmann
2004-03-27 06:02:09 +00:00
77c174ed49
bring col frames and cellmap in sync when due to row removal the number of column rises, as rowspans will then span in the rows below, bug 237421, r/sr=dbaron a=chofmann
2004-03-24 17:22:12 +00:00
95b610d0ce
wallpaper over a zero pointer deref rev2, bug 237421, r/sr=dbaron a=asa
2004-03-19 17:25:16 +00:00
d35090f0e2
wallpaper over a zero pointer deref, bug 237421, r/sr=dbaron a=chofmann
2004-03-15 16:09:40 +00:00
41c16857c2
DeCOMify nsIFrame::IsPercentageBase and rename to IsContainingBlock. b=237169 r+sr=bzbarsky a=brendan
2004-03-12 04:40:17 +00:00
79fc69cf20
Bug 237067 Solaris (forte) build is broken since nsTablePainter.h landing
...
r/sr/a=dbaron
Fix the bustage on Solaris.
2004-03-11 02:41:34 +00:00
8397ac8d8f
Bug 235264. Clean up invalidation to go through a single nsIFrame::Invalidate function and take account of 'outline' where necessary. r+sr=dbaron
2004-03-10 03:09:05 +00:00
ea9e726b8b
implement standards compliant (CSS2.1) table background rendering patch by fantasai@escape.com r=bernd sr=bz, dbaron
2004-03-09 06:48:35 +00:00
ab4ac54b6f
inline IsPaginated, SetPaginatedScrolling, and GetPaginatedScrolling. Bug 229371, r+sr=roc.
2004-03-03 18:24:20 +00:00
2e4b1165aa
when dead cells are replaced in the cellmap, the corresponding column should be informed that it now contains one more cell bug 235535 r/sr=bzbarsky
2004-03-03 17:45:50 +00:00
26521d3245
Table rows/cols and groups don't paint their backgrounds, so CanPaintBackground must return false. b=236053 r+sr=roc
2004-03-01 08:17:59 +00:00
225298a99e
Get rid of nsIFrameManager abstract interface to the frame manager. Bug 233972, r+sr=roc.
2004-02-23 21:29:06 +00:00
92499cbd13
Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron.
2004-02-11 04:57:07 +00:00
d5a23a72e6
Bug 232706: Remove unneccesary datatypes from nsHTMLValue and cleanup AttributeToString.
...
r=caillon sr=jst
2004-02-11 00:38:12 +00:00
871c57c63b
recover overflow area during incr. reflows in table frames, bug 219220 r/sr=dbaron
2004-01-28 18:44:41 +00:00
bc74f0b352
More nsIPresContext deCOMtamination (bug 229371). Removed GetBaseURL, rename GetMedium to Medium and inline it, remove virtual style resolution methods that forward to style set (callers will call style set methods directly). Removed PresContext parameter to StyleSet style resolution functions. r+sr=dbaron.
2004-01-28 00:18:22 +00:00
23ecb8ff4e
DeCOMtaminate nsCSSFrameConstructor (bug 231157). This gets rid of the nsIStyleFrameConstruction and nsICSSFrameConstructor interfaces. The frame constructor now has the same lifetime as the pres shell. r+sr=dbaron.
2004-01-21 23:05:10 +00:00
ef5c330583
Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky.
2004-01-21 09:35:59 +00:00
379d6c8a41
Miscellaneous cleanup. r/sr=jst.
2004-01-18 10:45:26 +00:00
a217311c27
remove unneccesary prescontext arguments bug 230923 r/sr=roc
2004-01-18 10:28:40 +00:00
e7f165c614
Bug 190735. deCOMtaminate nsIFrame::FirstChild and nsIFrame::GetAdditionalChildListName. r+sr=bz
2004-01-09 14:20:53 +00:00
e65d2d2fe5
Eliminate nsIStyleSet as an XPCOM interface, making the implementation internal to layout. Frame constructor ownership moves to the pres shell, and the style set methods that forward to the frame constructor are gone. Rewrote style set sheet add/remove to reduce code size. For more details, see bug 64116. r+sr=dbaron.
2004-01-07 22:30:53 +00:00
688ce265b9
dont paint border collapse borders if the damage area is not covered by the borders, bug 225266 r/sr=dbaron
2004-01-02 08:26:36 +00:00
e763429e44
prescontext removal part 2 bug 229631 r/sr=roc
2003-12-29 16:58:20 +00:00
09f24b47f1
function name change to be more compliant with naming conventions, bug 229620 r/sr=brendan
2003-12-29 07:32:32 +00:00
d481d3e19e
reduce prescontext usage in basic layout strategy bug 229457 r/sr=roc
2003-12-28 17:02:40 +00:00
d572bc76cf
deCOMtaminate nsIPresContext::GetCompatibilityMode / SetCompatibilityMode (bug 229081). r+sr=bzbarsky.
2003-12-24 21:51:50 +00:00
6312f04201
make code more readable bug 226619, patch by mats.palmgreen@bredband.net r=bzbarsky sr= dbaron
2003-12-23 08:49:48 +00:00
dbaron%dbaron.org
bzbarsky%mit.edu
bmlk%gmx.de
timeless%mozdev.org
mats.palmgren%bredband.net
roc+%cs.cmu.edu
leon.sha%sun.com
uriber%gmail.com
darin%meer.net
sharparrow1%yahoo.com
pavlov%pavlov.net
bsmedberg%covad.net
mrbkap%gmail.com
bryner%brianryner.com
cvshook%sicking.cc
neil%parkwaycc.co.uk
bugzilla%arlen.demon.co.uk
aaronleventhal%moonset.net
jim_nance%yahoo.com
tor%cs.brown.edu
gerv%gerv.net
kyle.yuan%sun.com
sicking%bigfoot.com
peterv%propagandism.org