I didn't pay attention while copying telemetry events. We send cancel when dismissing
the prompt, action when the user selects the suggested prompt action.
MozReview-Commit-ID: IAOMRRemCiz
--HG--
extra : amend_source : 0a940fa3109009c85d81765cd4380cd7c227814d
* urlbar-show-origin-only: Only show origin in URL bar instead of full URL (Bug 1236431)
* urlbar-show-ev-cert-owner: Show name of organization (EV cert) instead of full URL in URL bar (Bug 1249594)
MozReview-Commit-ID: AxbrB1gsobh
--HG--
extra : rebase_source : 185088d363fdfe9ba395caa07f05b9c17201e19a
extra : amend_source : 7879f2f122892a1af93f29c9e64f1076ee20191e
This patch was generated by the command:
find . -name "*.css" -exec sed -i -f mozpropsub {} \;
in the root of a mozilla-central tree, with the file mozpropsub
containing the contents:
s/-moz-padding-end\>/padding-inline-end/g
s/-moz-padding-start\>/padding-inline-start/g
s/-moz-margin-end\>/margin-inline-end/g
s/-moz-margin-start\>/margin-inline-start/g
s/-moz-border-end\>/border-inline-end/g
s/-moz-border-end-color\>/border-inline-end-color/g
s/-moz-border-end-style\>/border-inline-end-style/g
s/-moz-border-end-width\>/border-inline-end-width/g
s/-moz-border-start\>/border-inline-start/g
s/-moz-border-start-color\>/border-inline-start-color/g
s/-moz-border-start-style\>/border-inline-start-style/g
s/-moz-border-start-width\>/border-inline-start-width/g
While I didn't manually review all the changes, I did review the list of
files, and manually reviewed the changes in the files that I thought
were more interesting.
Note that there are a few tests that should be fixed up as well, but
I'll do that in a later patch.
MozReview-Commit-ID: EiQTuuV0MNQ
This was prompted in review and was discussed in bug so I didn't request
review.
MozReview-Commit-ID: ERgQ3hQnZai
--HG--
extra : rebase_source : c197b93febf275265e0d13891b241ae93c465a0d
Future patches will change the remaining code - This is not yet expected
to compile.
MozReview-Commit-ID: FpqfThcV7dj
--HG--
extra : rebase_source : e01ea217aadd88853d6643c5642d866ba796aa81
These will be used by the Store in the upcoming patches.
MozReview-Commit-ID: 7sPICagdLMu
--HG--
extra : rebase_source : a7ec0a82f48fde4480ab89ec6f39f6e073c31c71
See added comment (and bug it references) for details.
MozReview-Commit-ID: CqS5Oy7MPln
--HG--
extra : rebase_source : a64c5d134d0f2d4bc46ede356a5e8517654e9c62
We already return null if the host is empty and all callers seem to handle null values.
MozReview-Commit-ID: 4utRbvf7To3
--HG--
extra : rebase_source : 3236e7d6c518cf1041699101f8eef34b0ef19609
We want to have equal paddings for the top and right hand side of the
menu, whereas we previously had 24dp padding for the top, and only 8dp
on the right.
Note: the padding is defined in the 9-patch files, this commit simply
removes empty vertical space from the top of the menu background images.
MozReview-Commit-ID: Db0hXsPOVpp
Note: this commit alone results in the menu looking slightly odd
due to different top and right paddings. These are fixed in the
next commit.
MozReview-Commit-ID: AWzYU067K0W
The icons in the first row require more padding. In the second
row the share icons should have more padding, but only on phones,
and all other icons should remain the same size. (On tablets
the share icon can be shown beside the bookmark star, hence
we use an inset drawable to add padding on phones, and then
provide an alternative 0-inset on tablets to avoid any changes
there.)
MozReview-Commit-ID: 54NzYtUpzuV
--HG--
rename : mobile/android/base/resources/drawable-hdpi/ic_menu_share.png => mobile/android/base/resources/drawable-hdpi/ic_menu_share_icon.png
rename : mobile/android/base/resources/drawable-xhdpi/ic_menu_share.png => mobile/android/base/resources/drawable-xhdpi/ic_menu_share_icon.png
rename : mobile/android/base/resources/drawable-xxhdpi/ic_menu_share.png => mobile/android/base/resources/drawable-xxhdpi/ic_menu_share_icon.png
These images were incorrectly saved, leading to the loss of the smooth
edges they should have. This commit replaces the edited bookmark stars
with higher quality versions.
MozReview-Commit-ID: 1Z8FfWrvl8H
BrowserApp has a snippet that tries to restart in guest profile if we're
supposed to be in it, but are currently not. This is vestigial code from
lock screen widget support, and should not be needed anymore.
When we try to restart Fennec immediately after launching Fennec, it's
possible for onPause to be called without a corresponding onResume being
called first. This patch guards against registering events twice due to
this quirk.
Wes Kocher
Andrzej Hunt
Phil Ringnalda
Mark Capella
Sebastian Kaspari
Michael Comella
Kartikaya Gupta
Dylan Roeh
Jan-Ivar Bruaroey
Carsten "Tomcat" Book
L. David Baron
Margaret Leibovic
Grigory Kruglov
Andrzej Hunt
Matthew Wein
Randall Barker
Mathieu Leplatre
Jim Chen
Eugen Sawin
Jorick Caberio