Given by the WebDriver specification each command has to check if
the appropriate browsing context it operates in is still open. If
it's not the case a "no such window" error will be thrown.
Until now the code only checked the top-level browsing context for
each of the supported commands. That means if the current browsing
context was not open anymore a command running in a specific frame
of the website has thrown unknown or type errors.
That change makes our implementation WebDriver compliant.
Differential Revision: https://phabricator.services.mozilla.com/D88951
Formerly some tests were not running at all because the wptrunner
triggered an error when loading the test page. With the changes
to the navigation in Marionette this error is no longer present,
and as such allows the tests to actually run even when they still
fail or timeout.
Differential Revision: https://phabricator.services.mozilla.com/D89921
Now that all the navigation related code runs in the parent process
there is no need anymore for handling pending commands. This was
only necessary for navigation commands which could have caused
remoteness changes and as such new instances of the framescript.
In these cases the reply cannot be sent to the client unless the
command has been finished.
Differential Revision: https://phabricator.services.mozilla.com/D89717
Adjust is-where-parsing.html to work with both the new and old behavior,
and add a test for the new behavior.
Depends on D90049
Differential Revision: https://phabricator.services.mozilla.com/D90050
Previously, if we encounter a page where there are no real scroll
roots, WR would attach the picture cache slices to the root reference
frame.
This means that in some cases, no shared clips will be found for the
content slices. This is not currently a performance issue, since the
content slices are fixed and don't scroll. However, future patches
for this bug will only select shared clips that are ancestors of
the picture cache scroll root.
This patch ensures that in these cases, we still select the outermost
defined scroll frame, allowing shared clips to be correctly found
for these pages with a single scroll frame that doesn't scroll.
Differential Revision: https://phabricator.services.mozilla.com/D90051
This regressed by the patch on bug 1658928, which changed the type of
URL Marionette returns. While before we were returning the visible
URL from the location bar, the new and broken behavior includes
"about:error" prefixes for broken navigation requests.
Differential Revision: https://phabricator.services.mozilla.com/D89936
Adjust is-where-parsing.html to work with both the new and old behavior,
and add a test for the new behavior.
Depends on D90049
Differential Revision: https://phabricator.services.mozilla.com/D90050
Per spec we shouldn't behave differently depending on how we blocked the
image/object/etc.
This may have made sense in the past when ad blockers were implemented
via nsIContentPolicy, but I think nowadays it doesn't make sense, and
showing fallback is preferred.
There's a couple extra cleanups we can do after this lands, like
removing HTMLImageElement.imageBlockingStatus and simplifying a bit that
code. But I'll do that in a separate bug.
Differential Revision: https://phabricator.services.mozilla.com/D89912
Per spec we shouldn't behave differently depending on how we blocked the
image/object/etc.
This may have made sense in the past when ad blockers were implemented
via nsIContentPolicy, but I think nowadays it doesn't make sense, and
showing fallback is preferred.
There's a couple extra cleanups we can do after this lands, like
removing HTMLImageElement.imageBlockingStatus and simplifying a bit that
code. But I'll do that in a separate bug.
Differential Revision: https://phabricator.services.mozilla.com/D89912
Since a lot of cases are tested in the tests, they may time out when the
environment is a little bit busy. For now, we should allow them to run
longer. But adding new tests may cause timing out again. If so, we need to
split them at runtime.
Differential Revision: https://phabricator.services.mozilla.com/D89992
This happens when nsColumnSetFrame reflows its last column in an
unconstrained available block-size.
The wpt test can trigger the bug in a debug build easily. In opt builds like
Nightly, if one wants to load the test manually, additional incremental reflow
(such as opening devtools) may be needed to trigger the bug.
Co-authored-by: Mats Palmgren <mats@mozilla.com>
Differential Revision: https://phabricator.services.mozilla.com/D86672
This commit remove the following preferences, which have been
disabled since Firefox 70:
- mathml.nonzero_unitless_lengths.disabled
- mathml.legacy_number_syntax.disabled
These are edge syntaxes for MathML3 lengths that don't align well
with CSS and we haven't received any bug report about it since they
were disabled. Tests are updated to treat attributes using such
values as invalid.
update tests
Differential Revision: https://phabricator.services.mozilla.com/D89920
When mochitest-chrome (or a11y) tests are run, e10s is disabled for the suite; that conflicts
with the fission option, if enabled on the command line. This patch disables fission along
with e10s for non-e10s test suites.
Differential Revision: https://phabricator.services.mozilla.com/D89931
By mistake the specification used to say that, for items spanning
multiple tracks, the growth limits of the tracks with an intrinsic max
track sizing function should grow to accommodate the minimum
contribution of the item.
But this was a mistake, because an intrinsic max track sizing function
can only be min-content or max-content. So instead of distributing the
minimum contribution, it should be the min-content contribution.
The spec has been fixed and there is a CSSWG resolution in
https://github.com/w3c/csswg-drafts/issues/4790
This patch fixes the problem by reverting 2b923d48ea7e. The change is
likely web compatible, since it only affects a rare edge case with
'minmax()' where the min sizing function is 'auto' or a fixed value
smaller than the min-content contribution, the max sizing function is
'min-content', and an item whose minimum contribution is forced to be
smaller than the min-content contribution, and spans multiple tracks.
Differential Revision: https://phabricator.services.mozilla.com/D89145
Automatic update from web-platform-tests
Fix wildcard host matching in CSPEE subsume algorithm
The previous implementation returned `true` for `*.example.com`
subsumes `example.com`. However, since `*.example.com` does not match
`example.com`, this should not be the case. And indeed according to
2.3.3 in
https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in
this case the subsume algorithm should return `false`.
Bug: 1086857
Change-Id: I449f72d2db0a918478fc1ba4250335ae57a4ae2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210463
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805286}
--
wpt-commits: 4d8bfc649f692738a27b35468b7984b6061ab485
wpt-pr: 25321
Automatic update from web-platform-tests
WPT: Refactor contacts tests to use test-only-api.js
use of test-only-api.js in preparation for launching official MojoJS support
in WPT. This would not change the test results on Chromium waterfall
(everything should continue to pass) or upstream WPT (tests currently
fail because MojoJS isn't enabled).
Bug: 1123989
Change-Id: Ib7fed092b37243b82fbbf38d871bb75728cb7744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395395
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805272}
--
wpt-commits: 226f994feca843b12b1976e4bd4050809c4cc481
wpt-pr: 25421
Henrik Skupin
Tim Huang
Andrea Marchesini
Luca Greco
Valentin Gosu
Paul Adenot
Masayuki Nakano
Razvan Maries
Emilio Cobos Álvarez
Glenn Watson
Mihai Alexandru Michis
Kershaw Chang
pbz
Cristina Coroiu
Joel Maher
Bob Clary
Henri Sivonen
Delan Azabani
Noemi Erli
Ting-Yu Lin
Frederic Wang
Botond Ballo
Brian Grinstead
Dorel Luca
Punam Dahiya
Dave Hunt
Geoff Brown
Oriol Brufau
moz-wptsync-bot
Stephen McGruer
Antonio Sartori
Arnaud Mandy
Tarek Ziadé
Cosmin Sabou