Ian Moody
3e2a03dd32
Bug 1536659 - docshell/ manual ESLint no-throw-literal fixes. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D24368
--HG--
extra : moz-landing-system : lando
2019-03-21 22:40:36 +00:00
Ian Moody
b6cbc669dc
Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika
...
Result of running:
$ mach eslint -funix docshell/ | sed -Ee 's/:.+//' - | xargs sed -E \
-e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
-e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
-e 's/throw \(/throw new Error(/g' -i
Differential Revision: https://phabricator.services.mozilla.com/D24367
--HG--
extra : moz-landing-system : lando
2019-03-21 16:53:45 +00:00
dlee
d7d67be8c9
Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
...
This patch uses the flag to exempt channels from classification, but it
doesn't include the use cases of this flag.
See Bug 1442496 for the list of the call sites should use this flag.
Differential Revision: https://phabricator.services.mozilla.com/D22112
--HG--
extra : moz-landing-system : lando
2019-03-25 12:48:25 +00:00
dlee
9878ae650d
Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan
...
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.
Differential Revision: https://phabricator.services.mozilla.com/D22111
--HG--
extra : moz-landing-system : lando
2019-03-25 12:47:57 +00:00
sakshaat
d781937a67
Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
...
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.
Differential Revision: https://phabricator.services.mozilla.com/D22532
--HG--
extra : moz-landing-system : lando
2019-03-24 20:36:25 +00:00
Botond Ballo
c0526d30f3
Bug 1531535 - Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats
...
Differential Revision: https://phabricator.services.mozilla.com/D24554
--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:44 +00:00
Botond Ballo
e6c2c99584
Bug 1531535 - Add visual smooth scroll support to nsIPresShell. r=kats
...
This patch renames nsIPresShell::SetPendingVisualScrollUpdate() to
ScrollToVisual(), and adds an instant vs. smooth option.
SetPendingVisualScrollUpdate() still exists, as a helper for the instant case.
Differential Revision: https://phabricator.services.mozilla.com/D24553
--HG--
extra : moz-landing-system : lando
2019-03-23 20:23:35 +00:00
Mellina Yonashiro
db352af17e
Bug 1508817 - Enable ESLint for docshell (manual changes). r=Standard8,bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D23038
--HG--
extra : moz-landing-system : lando
2019-03-22 07:53:32 +00:00
Mellina Yonashiro
679a8809c5
Bug 1508817 - Enable ESLint for docshell (automatic changes). r=Standard8,bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D23037
--HG--
extra : moz-landing-system : lando
2019-03-22 18:13:25 +00:00
Edwin Gao
dc7a7ccbb7
Bug 1533819, 1533814, 1532775 - disable additional tests in mochitest-chrome suite that fails for windows10-aarch64 r=jmaher
...
- test_bug1163447_selectItems_through_shortcut.xul
- test_bug301397.xul
- test_bug364461.xul
Differential Revision: https://phabricator.services.mozilla.com/D24309
--HG--
extra : moz-landing-system : lando
2019-03-21 15:34:04 +00:00
Gurzau Raul
2666e16a53
Backed out 7 changesets (bug 1522412) for xpcshell failures at test_shouldclassify.js on a CLOSED TREE.
...
Backed out changeset 7c998456e1fd (bug 1522412)
Backed out changeset ebb581ddf1d1 (bug 1522412)
Backed out changeset 850e1c68d978 (bug 1522412)
Backed out changeset fe288a48cecb (bug 1522412)
Backed out changeset 5399bca472b1 (bug 1522412)
Backed out changeset 91e5b339fe11 (bug 1522412)
Backed out changeset b80098d0a5c4 (bug 1522412)
2019-03-21 11:02:09 +02:00
Dimi Lee
fe284ca3d4
Bug 1522412 - P3. Adopt nsIChannel.LOAD_BYPASS_URL_CLASSIFIER in the algorithm determining if we should classify a channel's URI. r=Ehsan,mayhemer
...
This patch uses the flag to exempt channels from classification, but it
doesn't include the use cases of this flag.
See Bug 1442496 for the list of the call sites should use this flag.
Differential Revision: https://phabricator.services.mozilla.com/D22112
--HG--
extra : moz-landing-system : lando
2019-03-21 07:32:46 +00:00
Dimi Lee
8f1caf4049
Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan
...
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.
Differential Revision: https://phabricator.services.mozilla.com/D22111
--HG--
extra : moz-landing-system : lando
2019-03-21 07:30:51 +00:00
Alastor Wu
bbb2e64dde
Bug 1524065 - part1 : implement the way to resume delayed autoplay media via browsing context. r=farre
...
After enable Fission, we're not able to resume media in the different process, because the current way we use can only notify one process and would cause the media on other process can't be resumed.
Therefore, we should use the browsing context to notify the web content which might be on different processes.
Differential Revision: https://phabricator.services.mozilla.com/D18136
--HG--
extra : moz-landing-system : lando
2019-03-20 03:15:36 +00:00
Andrew McCreight
cce04c17b8
Bug 1535453 - BrowsingContext does not need to inherit from LinkedListElement. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D23586
--HG--
extra : moz-landing-system : lando
2019-03-19 21:33:40 +00:00
Sebastian Hengst
cbbed3707e
Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440: replace 'Core :: Keyboard: Navigation'. r=me DONTBUILD
...
--HG--
extra : amend_source : d2099ea98dbd1a814c1257e276cec58db9be907a
2019-03-18 00:39:30 +01:00
Sebastian Hengst
cee711baf9
Bug 1535353 - update Core :: DOM: * bugzilla product and component meta data in moz.build files after reorganization in bug 1533440 r=hsinyi
...
Differential Revision: https://phabricator.services.mozilla.com/D23546
--HG--
extra : moz-landing-system : lando
2019-03-17 23:13:22 +00:00
Christoph Kerschbaumer
23b1d42b45
Bug 1534971: Add helper function within CSP to check if two CSPs are equal. r=jkt
...
Differential Revision: https://phabricator.services.mozilla.com/D23567
--HG--
extra : moz-landing-system : lando
2019-03-15 12:20:52 +00:00
Thomas Nguyen
33d78105b7
Bug 1528695 - Part 1 : Use referrerInfo in openWindow, cpp file r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D21910
--HG--
extra : moz-landing-system : lando
2019-03-15 05:11:43 +00:00
Nika Layzell
75c02c72ea
Bug 1532661 - Part 6: Clean up BrowsingContext references more reliably, r=farre
...
Depends on D23047
Differential Revision: https://phabricator.services.mozilla.com/D23048
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:13 +00:00
Nika Layzell
f6a5c73c2a
Bug 1532661 - Part 5: Make the BrowsingContext opener edge a weak reference, r=farre
...
Depends on D22193
Differential Revision: https://phabricator.services.mozilla.com/D23047
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:11 +00:00
Nika Layzell
1b8834985a
Bug 1532661 - Part 4: Support initializing complete BrowsingContextGroups in a single op with an IPCInitializer struct, r=farre
...
Depends on D22192
Differential Revision: https://phabricator.services.mozilla.com/D22193
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:09 +00:00
Nika Layzell
e936e7d33b
Bug 1532661 - Part 3: Add WillSetX and DidSetX callbacks for BrowsingContext synced fields, r=farre
...
Depends on D22191
Differential Revision: https://phabricator.services.mozilla.com/D22192
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:07 +00:00
Nika Layzell
1ebd4ff025
Bug 1532661 - Part 2: Use a field list macro header for synced fields, r=farre
...
Depends on D22190
Differential Revision: https://phabricator.services.mozilla.com/D22191
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:05 +00:00
Nika Layzell
88e15f606d
Bug 1532661 - Part 1: Perform basic validation on CanonicalBrowsingContext, r=farre
...
Depends on D21134
Differential Revision: https://phabricator.services.mozilla.com/D22190
--HG--
extra : moz-landing-system : lando
2019-03-14 18:51:03 +00:00
Nika Layzell
b388b0df00
Bug 1530550 - Synchronize mOpener and mIsActivatedByUserGesture with SYNCED_BC_FIELD, r=farre
...
Depends on D22764
Differential Revision: https://phabricator.services.mozilla.com/D21134
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:55 +00:00
Nika Layzell
a26325ea58
Bug 1529684 - Part 6: Store a mIsInProcess flag to preserve WindowProxy behaviour, r=farre
...
Currently when we have an in-process WindowProxy object, we will attempt
to either use the cached mWindowProxy value, or fetch the
nsGlobalWindowOuter object from through the nsDocShell. Unfortunately,
when the BrowsingContext is detached, we will fail to get the
nsGlobalWindowOuter object. This happens to be OK for our test cases, as
the cached mWindowProxy value doesn't have the chance to go away, but
isn't acceptable long-term.
These patches exascerbated that issue by causing the nsDocShell pointer
itself to be cleared when it is destroyed, which caused the Remote
WindowProxy logic to be triggered. To deal with that case, this patch
adds a new mIsInProcess flag to continue to act like the old code-path.
In the future, we will need to also handle ensuring that the
nsGlobalWindowOuter lives for long enough, however that is not being
done in this patch in order to land it sooner rather than later.
Depends on D22763
Differential Revision: https://phabricator.services.mozilla.com/D22764
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:54 +00:00
Nika Layzell
24638a0faf
Bug 1529684 - Part 5: Support using remote window proxy objects in the parent process, r=farre
...
Depends on D22762
Differential Revision: https://phabricator.services.mozilla.com/D22763
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:52 +00:00
Nika Layzell
48d0049694
Bug 1529684 - Part 4: Add a GetContentParent method to CanonicalBrowsingContext, r=farre
...
Depends on D21097
Differential Revision: https://phabricator.services.mozilla.com/D22762
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:50 +00:00
Nika Layzell
eaf6c2306e
Bug 1529684 - Part 2: Create BrowsingContext for remote browsers in parent, r=farre
...
Depends on D21095
Differential Revision: https://phabricator.services.mozilla.com/D21096
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:45 +00:00
Nika Layzell
6a04609cc9
Bug 1529684 - Part 1: Allow Attaching BrowsingContext from parent to child, r=farre
...
This is important to allow creating BrowsingContexts outside of the process
where they are going to be used. This is largely a re-arrangement of existing
code.
There is currently no way to do this type of attaching for browsing contexts in
existing BrowsingContextGroups, which creates some limitations, but happens to
be sufficient for us in the current situation.
Differential Revision: https://phabricator.services.mozilla.com/D21095
--HG--
extra : moz-landing-system : lando
2019-03-14 18:50:38 +00:00
Sylvestre Ledru
4aa92e3091
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Botond Ballo
4911e7b692
Bug 1517895 - Scroll the visual viewport in nsDocShell::SetCurScrollPosEx(). r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D20031
--HG--
extra : moz-landing-system : lando
2019-03-13 23:07:17 +00:00
Boris Zbarsky
6d1f77b386
Bug 1534370 part 2. Annotate doCommand as MOZ_CAN_RUN_SCRIPT. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D23041
--HG--
extra : moz-landing-system : lando
2019-03-12 01:57:42 +00:00
Boris Zbarsky
ccfb4f16b1
Bug 1534370 part 1. Annotate doCommandWithParams as MOZ_CAN_RUN_SCRIPT. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D23036
--HG--
extra : moz-landing-system : lando
2019-03-13 00:43:48 +00:00
James Willcox
e163a5bcea
Bug 1524992 - Don't trigger crash in about:crash* when opened from external apps r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D20891
--HG--
extra : moz-landing-system : lando
2019-03-12 20:16:07 +00:00
Valentin Gosu
21bfdeb265
Bug 1525036
- Add CrossOriginPolicy to the browsing context r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21418
--HG--
extra : moz-landing-system : lando
2019-03-12 08:04:01 +00:00
Boris Zbarsky
68863e1004
Bug 1533617 part 4. Mark virtual methods with CAN_RUN_SCRIPT overrides as CAN_RUN_SCRIPT. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D22838
--HG--
extra : moz-landing-system : lando
2019-03-11 14:20:29 +00:00
Nika Layzell
b6acd0f16c
Bug 1413735
- Rewrite test_bug580069.html to avoid a potential race condition, r=qdot
...
Differential Revision: https://phabricator.services.mozilla.com/D22581
--HG--
extra : moz-landing-system : lando
2019-03-09 02:27:35 +00:00
Csoregi Natalia
d086070187
Backed out 5 changesets (bug 1525036
) for browser_httpCrossOriginHeader.js failures. CLOSED TREE
...
Backed out changeset 6717beb3ac53 (bug 1525036
)
Backed out changeset 0c05686bd62a (bug 1525036
)
Backed out changeset 502b0bb796cd (bug 1525036
)
Backed out changeset fa0363d33dbd (bug 1525036
)
Backed out changeset 6391f42aaa6d (bug 1525036
)
2019-03-09 02:39:11 +02:00
Valentin Gosu
d12177cb53
Bug 1525036
- Add CrossOriginPolicy to the browsing context r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21418
--HG--
extra : moz-landing-system : lando
2019-03-08 15:34:54 +00:00
Alex Gaynor
e5279ff3f7
Bug 1532727 - replace OptionalURIParams with URIParams? in IPDL; r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D22138
--HG--
extra : moz-landing-system : lando
2019-03-06 14:05:50 +00:00
Felipe Gomes
96dfb4e813
Bug 827976 - Teach leaks.py to ignore the hidden window. r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D21089
--HG--
extra : moz-landing-system : lando
2019-03-04 20:21:31 +00:00
Brindusan Cristian
8a1c4fbd47
Backed out 4 changesets (bug 1530550, bug 1529684) for bc crashes at [@ mozilla::dom::BrowsingContext::Detach(bool)]. CLOSED TREE
...
Backed out changeset 289c2b4126c9 (bug 1530550)
Backed out changeset 9f3e65f6b1dd (bug 1529684)
Backed out changeset 257d45117af3 (bug 1529684)
Backed out changeset 7f2bda80e479 (bug 1529684)
2019-03-05 23:11:48 +02:00
Nika Layzell
8b4e459999
Bug 1530550 - Synchronize mOpener and mIsActivatedByUserGesture with SYNCED_BC_FIELD, r=farre
...
Differential Revision: https://phabricator.services.mozilla.com/D21134
--HG--
extra : moz-landing-system : lando
2019-03-05 17:33:52 +00:00
Nika Layzell
332f3940ad
Bug 1529684 - Part 2: Create BrowsingContext for remote browsers in parent, r=farre
...
Depends on D21095
Differential Revision: https://phabricator.services.mozilla.com/D21096
--HG--
extra : moz-landing-system : lando
2019-03-05 17:33:22 +00:00
Nika Layzell
95cc8c68c0
Bug 1529684 - Part 1: Allow Attaching BrowsingContext from parent to child, r=farre
...
This is important to allow creating BrowsingContexts outside of the process
where they are going to be used. This is largely a re-arrangement of existing
code.
There is currently no way to do this type of attaching for browsing contexts in
existing BrowsingContextGroups, which creates some limitations, but happens to
be sufficient for us in the current situation.
Differential Revision: https://phabricator.services.mozilla.com/D21095
--HG--
extra : moz-landing-system : lando
2019-03-05 17:33:19 +00:00
Andreea Pavel
be960187e1
Backed out 3 changesets (bug 1524992) for valgrind failures on a CLOSED TREE
...
Backed out changeset face9d1e8868 (bug 1524992)
Backed out changeset ae1e20a595c4 (bug 1524992)
Backed out changeset b0b9322c7a59 (bug 1524992)
2019-03-05 01:36:59 +02:00
James Willcox
f13f6cf657
Bug 1524992 - Don't trigger crash in about:crash* when opened from external apps r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D20891
--HG--
extra : moz-landing-system : lando
2019-03-04 22:06:55 +00:00
Cosmin Sabou
a706bb3916
Backed out 16 changesets (bug 827976) for causing bug 1532054. a=backout
...
Backed out changeset 54c0b12443ed (bug 827976)
Backed out changeset 92b45080d080 (bug 827976)
Backed out changeset 443087a359f9 (bug 827976)
Backed out changeset f976c2d4cebb (bug 827976)
Backed out changeset 66cffb171024 (bug 827976)
Backed out changeset 845e1d0b2402 (bug 827976)
Backed out changeset fd94066a1d76 (bug 827976)
Backed out changeset e253b264e7bd (bug 827976)
Backed out changeset 07ef335770a8 (bug 827976)
Backed out changeset 9d3805d77b99 (bug 827976)
Backed out changeset eed600ceb606 (bug 827976)
Backed out changeset 3b64368cff52 (bug 827976)
Backed out changeset 69d0378e0c09 (bug 827976)
Backed out changeset 9203871a5c6f (bug 827976)
Backed out changeset 96a507c818e2 (bug 827976)
Backed out changeset e254496ff95b (bug 827976)
2019-03-02 20:40:01 +02:00