Wes Kocher
677438b338
Backed out 4 changesets (bug 1286041) for making various media tests really failure prone a=backout
...
Backed out changeset af4c053741f1 (bug 1286041)
Backed out changeset b5be689abefa (bug 1286041)
Backed out changeset 2aad01ffac9f (bug 1286041)
Backed out changeset 48117ed311a1 (bug 1286041)
2016-09-12 15:17:23 -07:00
Alex Chronopoulos
c498e1f9a0
Bug 1286041 - AudioStream disable the assert when backend audio is winmm. r=padenot
2016-09-12 12:25:19 +03:00
Alex Chronopoulos
6a23c81135
Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang
2016-07-12 16:53:58 +02:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Sebastian Hengst
8df190bd97
Backed out changeset 71b9d48efac6 (bug 1286041) for failing wpt mediasource-seek-beyond-duration.html on Linux. r=backout on a CLOSED TREE
2016-09-06 19:08:20 +02:00
Sebastian Hengst
c150583370
Backed out changeset bb04b5569ab9 (bug 1286041)
2016-09-06 19:06:51 +02:00
Paul Adenot
bf8d30bacd
Bug 1286041 - Disable an assert when using winmm, on a CLOSED TREE. r=achronop
...
MozReview-Commit-ID: HHWIDARNPft
2016-09-06 15:34:57 +02:00
Alex Chronopoulos
379cc5172a
Bug 1286041 - Assert audio callback is not called in initialized state. r=jwwang
...
MozReview-Commit-ID: 3epBfvUHYFo
2016-07-12 16:53:58 +02:00
Igor
175543fda8
Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj
2016-08-14 23:43:21 -07:00
Igor
a57972337d
Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj
2016-08-14 23:44:00 -07:00
Paul Adenot
5ce5a2cc20
Bug 1283020 - Update cubeb consumers to pass in latency in frames and not in ms. r=achronop
...
MozReview-Commit-ID: D7HjHNPRIre
2016-07-20 15:02:23 +02:00
Wes Kocher
cdd7fc4a11
Backed out changeset 344300260f4c (bug 1283020) for frequent m(gl) failures CLOSED TREE
2016-07-20 15:08:09 -07:00
Paul Adenot
4e73b0eead
Bug 1283020 - Update cubeb consumers to pass in latency in frames and not in ms. r=achronop
...
MozReview-Commit-ID: D7HjHNPRIre
2016-07-20 15:02:23 +02:00
Paul Adenot
be6cf8e090
Bug 1280630 - Add telemetry probes to know which cubeb back-end is used the most. r=kinetik data-review=bsmedberg
...
MozReview-Commit-ID: AxJlcxjYh3M
2016-06-23 17:50:52 +02:00
JW Wang
6c194b8486
Bug 1277473 - fix data race in gDumpedAudioCount. r=kinetik.
...
MozReview-Commit-ID: F9Twn0MlDBV
--HG--
extra : rebase_source : aaab07dbdb236ced54e01d0ce26692b2479d355b
2016-06-02 15:53:39 +08:00
JW Wang
ed7bec1506
Bug 1277198
. Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.
...
MozReview-Commit-ID: KTiyzO8VEZh
--HG--
extra : rebase_source : 49589d5bd8ea1b2575caaf608569c64fab307c5b
2016-06-01 18:00:15 +08:00
JW Wang
510020f774
Bug 1277198
. Part 2 - fix OpenDumpFile(). r=kinetik.
...
MozReview-Commit-ID: IWzvlWnhuFe
--HG--
extra : rebase_source : 39c105ad766947ebe350b8b2afc2685bb00339dc
2016-06-01 17:54:37 +08:00
JW Wang
51c02cde54
Bug 1277198
. Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik.
...
MozReview-Commit-ID: HsaiSq83MtD
--HG--
extra : rebase_source : d578e00f15300fbcf1cc41fb5242868a4b31b57d
2016-06-01 17:38:47 +08:00
JW Wang
d292fa5e3a
Bug 1277776 - Use SaferMultDiv in AudioClock::GetPositionInFrames(). r=jya.
...
MozReview-Commit-ID: 711czooNf55
--HG--
extra : rebase_source : cf2ba4ab351775be5ab08a820de9d4a1ac356dac
2016-06-06 11:13:34 +08:00
JW Wang
59371c367d
Bug 1277188
. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). r=kinetik.
...
MozReview-Commit-ID: C7m8xeMAJES
--HG--
extra : rebase_source : 2a94db443d9696e9f4b1ee5caa4915df69e745af
2016-06-01 16:45:32 +08:00
JW Wang
e84f041b19
Bug 1277188
. Part 4 - remove AudioClock::mAudioStream. r=kinetik.
...
MozReview-Commit-ID: KjrfgHIg8z4
--HG--
extra : rebase_source : 8208e3ead2d8dfbe02fb899e5fb376651715be61
2016-06-01 16:36:10 +08:00
JW Wang
2a587ee2df
Bug 1277188
. Part 3 - remove AudioClock::GetPositionUnlocked(). r=kinetik.
...
MozReview-Commit-ID: 9g3wqI63OsR
--HG--
extra : rebase_source : 216e0a7e9909572ad828c262063e348df462a5ef
2016-06-01 16:30:54 +08:00
JW Wang
0b95bcdd11
Bug 1277188
. Part 2 - fix AudioStream::GetPositionInFrames(). r=kinetik.
...
MozReview-Commit-ID: 3NhoRCPu8fU
--HG--
extra : rebase_source : d3b177d25a86f03ac65c5231dc389e66cbb5aba5
2016-06-01 16:18:56 +08:00
JW Wang
050beb7609
Bug 1277188
. Part 1 - fix AudioStream::GetPosition(). r=kinetik.
...
MozReview-Commit-ID: ECGPX04hM6U
--HG--
extra : rebase_source : 0a0762173432be070582ea789ea58ca4e63b73cf
2016-06-01 16:19:35 +08:00
JW Wang
e34042f5dc
Bug 1277175 - Remove AudioStream::IsPaused(). r=kinetik.
...
MozReview-Commit-ID: K2CHJ0E90MW
--HG--
extra : rebase_source : 4f0bd8f2e46ad8850a15c7a1102c9bae5217e6bc
2016-05-31 15:59:20 +08:00
JW Wang
407f35f204
Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.
...
MozReview-Commit-ID: 8UXg49yZVHd
--HG--
extra : rebase_source : d6455b1172641329bbe88e73056c9df73efd093b
2016-05-31 15:00:55 +08:00
JW Wang
925bd5c7c6
Bug 1276852 - Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.
...
MozReview-Commit-ID: DeGSEpSWYSM
--HG--
extra : rebase_source : d2ab8b8abb7e9893934783b99939bbfe359e93d0
2016-05-31 14:33:03 +08:00
JW Wang
17e4b1d7d8
Bug 1276851 - Remove AudioStream::mIsFirst. r=kinetik.
...
MozReview-Commit-ID: H9KCM2zZulA
--HG--
extra : rebase_source : 51387a1bd37f1b22bdb5100abe83af17c0caa481
2016-05-31 14:18:58 +08:00
JW Wang
8d11127d3c
Bug 1276849 - some AudioStream::OpenCubeb code cleanup. r=kinetik.
...
MozReview-Commit-ID: 1X1DXa8fEZN
--HG--
extra : rebase_source : 79ab44ea8cbfd5710006731789925daaad80dc3a
2016-05-31 13:55:27 +08:00
JW Wang
f587ac226e
Bug 1276840 - Remove AudioStream::RUNNING. r=kinetik.
...
MozReview-Commit-ID: 3sCGYifUxJO
--HG--
extra : rebase_source : f20ee5647bb92b7bf1a35fde9bb131f4585cb32c
2016-05-31 11:54:30 +08:00
JW Wang
378ce6e9b8
Bug 1276838 - improve coding style of calling cubeb functions. r=kinetik.
...
MozReview-Commit-ID: 1KjjF6StM0a
--HG--
extra : rebase_source : 5174bedd6400c88b01cb0018f9ff64f1eadb2d4a
2016-05-30 21:12:35 +08:00
JW Wang
330fa8cab9
Bug 1276569. Part 4 - remove mStartTime. r=kinetik.
...
MozReview-Commit-ID: EbTqf4nY8NR
--HG--
extra : rebase_source : d7bd2f5fe21e45e53d252950bcd9ebbcaff1a5cd
2016-05-30 16:38:37 +08:00
JW Wang
f86775fb24
Bug 1276569. Part 3 - replace use of MOZ_LOG with LOG. r=kinetik.
...
MozReview-Commit-ID: BbVtPIgxPSU
--HG--
extra : rebase_source : f160904cb14800d5b9123b0e421a2ae8836556c5
2016-05-30 16:08:50 +08:00
JW Wang
9b3b5f90d2
Bug 1276569. Part 2 - merge StartUnlocked() with Start() r=kinetik.
...
MozReview-Commit-ID: DuEXdkvt7je
--HG--
extra : rebase_source : c8fb5f479ba61f9763b64cc0a90a1c29ff8e0e0d
2016-05-30 16:05:30 +08:00
JW Wang
01902c9e8e
Bug 1276569. Part 1 - remove null checks. r=kinetik.
...
MozReview-Commit-ID: IpX4B2GTr9k
--HG--
extra : rebase_source : 806b4eff3b6e43964bb6fd8d9e7a735a6bcfa5e6
2016-05-30 16:05:28 +08:00
Jean-Yves Avenard
33f592b6a5
Bug 1264199: P5. Perform all downmixing operations in DecodedAudioDataSink. r=kinetik
...
Performing all audio processing operations in the same place, allows to simplify the code.
Additionally, if accessibility.monoaudio.enable is not set, we always upmix mono to stereo so that if the first audio stream seen was mono, we aren't stuck playing all future streams in mono.
MozReview-Commit-ID: 5yANN6PLFhX
--HG--
extra : rebase_source : 8b2138368d97f4ec2857c021ed9605c633282ed2
2016-04-13 20:25:50 +10:00
Carsten "Tomcat" Book
ba17b2d751
Backed out changeset 93ab5d1b04b0 (bug 1264199)
...
--HG--
extra : rebase_source : 0c5ec4b3526d6cfcc86d40221f298790f262227d
2016-04-21 16:31:55 +02:00
Jean-Yves Avenard
427e2852c6
Bug 1264199: P5. Perform all downmixing operations in DecodedAudioDataSink. r=kinetik
...
Performing all audio processing operations in the same place, allows to simplify the code.
Additionally, if accessibility.monoaudio.enable is not set, we always upmix mono to stereo so that if the first audio stream seen was mono, we aren't stuck playing all future streams in mono.
MozReview-Commit-ID: 5yANN6PLFhX
--HG--
extra : rebase_source : f40dfacc9fc323794325de0431c4958854012180
2016-04-13 20:25:50 +10:00
Wes Kocher
b8f98ffe9f
Backed out 8 changesets (bug 1264199) for permafailing media mochitests on OSX 10.6 a=backout
...
Backed out changeset 0f20f2080824 (bug 1264199)
Backed out changeset 90351d2719be (bug 1264199)
Backed out changeset f484b42cbdda (bug 1264199)
Backed out changeset b79b62146120 (bug 1264199)
Backed out changeset f587df589b69 (bug 1264199)
Backed out changeset 02f781a573b4 (bug 1264199)
Backed out changeset d3677ae4c8ec (bug 1264199)
Backed out changeset d08288654ec9 (bug 1264199)
MozReview-Commit-ID: HVtiBSOxf7t
2016-04-20 11:01:36 -07:00
Jean-Yves Avenard
29ce436a1b
Bug 1264199: P5. Perform all downmixing operations in DecodedAudioDataSink. r=kinetik
...
Performing all audio processing operations in the same place, allows to simplify the code.
Additionally, if accessibility.monoaudio.enable is not set, we always upmix mono to stereo so that if the first audio stream seen was mono, we aren't stuck playing all future streams in mono.
MozReview-Commit-ID: 5yANN6PLFhX
2016-04-20 15:03:34 +10:00
Carsten "Tomcat" Book
fbf1d00b15
Backed out changeset f323c504b5a5 (bug 1264199)
2016-04-18 14:22:02 +02:00
Jean-Yves Avenard
7e4703cb30
Bug 1264199: P5. Perform all downmixing operations in DecodedAudioDataSink. r=kinetik
...
Performing all audio processing operations in the same place, allows to simplify the code.
Additionally, if accessibility.monoaudio.enable is not set, we always upmix mono to stereo so that if the first audio stream seen was mono, we aren't stuck playing all future streams in mono.
MozReview-Commit-ID: 5yANN6PLFhX
--HG--
extra : rebase_source : c789ba66fa168bc11064b2a329311d90b046c7fc
2016-04-13 20:25:50 +10:00
Jean-Yves Avenard
4132e3555b
Bug 1262753: P6. Perform downmixing in DecodeAudioDataSink. r=kinetik
...
Rather than performing the audio processing a few frames at a time, we perform the operation when popping the audio data block.
The only downmixing task left to AudioStream is to handle the force mono preference.
Resampling is currently disabled.
MozReview-Commit-ID: GNQA1h0xcp7
--HG--
extra : rebase_source : c58aa4514a0dc4de06be6dc1da6a598742caa262
2016-04-11 21:16:17 +10:00
Jean-Yves Avenard
b382680a6a
Bug 1262753: P5. Pass number of frames rather than the number of bytes. r=gerald
...
The Process API was originally planned to be used to also convert data type. However, this task is now the responsibility of the AudioDataBuffer class.
We can simplify the logic and use frames everywhere.
MozReview-Commit-ID: KvKn1d1yHqQ
--HG--
extra : rebase_source : cd5a3ec2c0293fa39274828ebfd9e80103126cc5
2016-04-12 12:16:38 +10:00
Jean-Yves Avenard
698b349cd9
Bug 1262746: P2. Use AudioConvert in AudioStream to downmix samples. r=jwwang
...
MozReview-Commit-ID: 4jgKR8xw1dc
--HG--
extra : rebase_source : 68c2e488eac40edcd91416447ba85b823b3bd8ad
2016-04-08 17:37:31 +10:00
JW Wang
0cff6d9802
Bug 1239911 - Remove unused |mAudioChannel|. r=bechen.
...
MozReview-Commit-ID: F10HLXyHGKk
2016-04-01 07:41:28 +08:00
JW Wang
c08fd0c5f3
Bug 1248513 - Fix static analysis errors in non-unified build for AudioStream.cpp. r=gerald.
...
MozReview-Commit-ID: 77AC9c2TKqb
2016-02-18 11:34:04 +08:00
Birunthan Mohanathas
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
Phil Ringnalda
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00