Razvan Maries
16156cddff
Backed out changeset 8d5f1790048c (bug 1653276) for very frequently failures on ActorsChild.cpp. CLOSED TREE
2020-10-07 14:57:40 +03:00
Simon Giesecke
4d08a1e344
Bug 1653276 - Ensure that IndexedDB operations are cancelled when nsGlobalWindowInner::FreeInnerObjects is called. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D92209
2020-10-07 09:58:37 +00:00
Butkovits Atila
e79bd0d8bb
Backed out changeset 0f0d637acf76 (bug 1653276) for failures complaining about ActorsChild.cpp. CLOSED TREE
2020-10-06 21:35:10 +03:00
Simon Giesecke
56cc540be9
Bug 1653276 - Ensure that IndexedDB operations are cancelled when nsGlobalWindowInner::FreeInnerObjects is called. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D92209
2020-10-06 15:27:19 +00:00
Simon Giesecke
e19b65b863
Bug 1663924 - Replace output parameter of PromptIfNeeded by return value. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D91158
2020-10-06 08:39:40 +00:00
Simon Giesecke
20a9b720d4
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-02 13:23:49 +00:00
Sebastian Hengst
ae5e3a0d7c
Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
...
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
Simon Giesecke
8598a731fc
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 15:37:50 +00:00
Bogdan Tara
104db9798f
Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
...
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
Simon Giesecke
4c5b983d6f
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 12:02:26 +00:00
Jan Varga
d3df072168
Bug 1662087 - Replace explicit error handling involving `mozilla::Result::isErr` with IDB_TRY/IDB_TRY_VAR in ActorsChild.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88831
2020-09-07 15:52:52 +00:00
Kris Maglione
c2c6945169
Bug 1650257: Part 2 - Abort SetNewDocument() if ancestors are discarded/cached. r=nika,smaug,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D87486
2020-08-31 18:51:56 +00:00
Simon Giesecke
ed4841ca72
Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88144
2020-08-28 15:50:38 +00:00
Simon Giesecke
68059713d9
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 15:50:23 +00:00
Razvan Maries
1bebc65e70
Backed out 2 changesets (bug 1660800, bug 1660816) as per Simon's request. CLOSED TREE
...
Backed out changeset 55d2e05d2e0b (bug 1660800)
Backed out changeset 7b9687fb7d41 (bug 1660816)
2020-08-28 18:45:54 +03:00
Simon Giesecke
c169085c8e
Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88144
2020-08-28 10:02:33 +00:00
Simon Giesecke
881d526f83
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D88143
2020-08-28 14:43:51 +00:00
Simon Giesecke
b13b4d3deb
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 09:40:12 +00:00
Simon Giesecke
c49d17f0db
Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 09:39:24 +00:00
Cosmin Sabou
a40ede8ab7
Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE
...
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
2020-07-03 11:49:58 +03:00
Simon Giesecke
4c5ca225c9
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 08:08:27 +00:00
Simon Giesecke
b14f5d4a12
Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 08:08:05 +00:00
Simon Giesecke
85c8c0062e
Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D81078
2020-07-01 20:14:23 +00:00
Andrea Marchesini
5def6bbc8c
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 11:02:53 +00:00
Razvan Maries
f7cb24cc7e
Backed out 8 changesets (bug 1648141
) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE
...
Backed out changeset e9b4ca0ee700 (bug 1648141
)
Backed out changeset b9bb847cee47 (bug 1648141
)
Backed out changeset 11dfce46ec14 (bug 1648141
)
Backed out changeset d824d2f67f27 (bug 1648141
)
Backed out changeset e5b8292e7095 (bug 1648141
)
Backed out changeset c1a3d5fa0c61 (bug 1648141
)
Backed out changeset 24fdb83db3cd (bug 1648141
)
Backed out changeset 749d894dde52 (bug 1648141
)
2020-06-29 13:59:16 +03:00
Andrea Marchesini
82d0167e5e
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 10:25:08 +00:00
Jean-Yves Avenard
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Jean-Yves Avenard
ea34205395
Bug 1646054 - P1. Remove EventTargetWrapper class. r=froydnj
...
We also establish the intent of bug 1602167 on the TaskQueue object
Differential Revision: https://phabricator.services.mozilla.com/D80351
2020-06-22 13:55:21 +00:00
Simon Giesecke
d11275bd72
Bug 1632128 - Dissolve FileHandleResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D75053
2020-05-14 09:42:33 +00:00
Simon Giesecke
4fc4c0a9d9
Bug 1632128 - Dissolve ResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74890
2020-05-14 09:42:23 +00:00
Simon Giesecke
9ee13d3ec4
Bug 1632128 - De-virtualize IDBFileRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74875
2020-05-14 09:42:21 +00:00
Simon Giesecke
5f4d07aff0
Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74874
2020-05-14 09:42:18 +00:00
Simon Giesecke
ae0940c00a
Bug 1632128 - Use mozilla::Variant for FileHandleResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74870
2020-05-14 09:42:16 +00:00
Simon Giesecke
7a8f68d96f
Bug 1632128 - Use mozilla::Variant for ResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71936
2020-05-14 09:42:13 +00:00
Simon Giesecke
a892bc01f6
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
078debe589
Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
...
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
98b9d42815
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
ssengupta
cf852bbfb9
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
Andrew Sutherland
06937e8b14
Bug 1631970 - Delay converting uint64 results to JSVals. r=sg
...
The rooting hazard analysis is getting upset because of the usage where
a non-GCThing JSVal is declared on the stack and AcquireTransaction() is
called. The analysis doesn't know that it's guaranteed that the value is
NaN-boxed and can't be a GC thing. It also doesn't know that the SafeRefPtr
can't already have a value so a release is impossible.
Arguably the hazard analysis doesn't need to know these things though.
This fix delays the point at which we convert the uint64 into a JS::Value.
The [call to GetResult](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/dom/indexedDB/IDBRequest.cpp#300 )
already has a rooted result and the (Auto)JSAPI initialized, so this is
arguably cleaner and less scary in terms of holding raw pointers in the
ResultHelper that aren't necessary.
This fix doesn't correct the ResultTypeJSValHandle which is a similar
situation, except it's a reference to
[UndefinedHandleValue](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/js/src/vm/Value.cpp#23 )
which is I suppose more fine from a GC perspective. Still somewhat ugly
as used in ResultHelper, but I'm presuming we'll clean ResultHelper up
in the future to use a Variant, at which point we can explicitly indicate
we want `undefined`.
Differential Revision: https://phabricator.services.mozilla.com/D74800
2020-05-12 10:39:00 +00:00
Simon Giesecke
6d8be8c785
Bug 1623278 - Make transaction actors refcounted. r=dom-workers-and-storage-reviewers,nika,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71933
2020-05-06 12:20:32 +00:00
Simon Giesecke
ecfe1e0e4d
Bug 1618542 - Add use of new transformation algorithms in ActorsChild. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69044
2020-04-21 14:35:03 +00:00
Simon Giesecke
18c7f261c4
Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Simon Giesecke
da859a31b2
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:43 +00:00
Simon Giesecke
02753c9665
Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D65710
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:39 +00:00
André Bargull
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull
73a498ec0c
Bug 1625138 - Part 38: Replace mozilla::IsSame with std::is_same in dom/. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68557
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull
cae4e1fdbc
Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68401
--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
Simon Giesecke
393a8cb4a2
Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65167
--HG--
extra : moz-landing-system : lando
2020-03-19 11:35:03 +00:00
Mihai Alexandru Michis
2922453b6e
Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages.
...
CLOSED TREE
Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
2020-03-19 13:30:26 +02:00
Simon Giesecke
59bc885b82
Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D65710
--HG--
extra : moz-landing-system : lando
2020-03-19 09:34:40 +00:00
Simon Giesecke
f4b6d69804
Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65167
--HG--
extra : moz-landing-system : lando
2020-03-19 09:57:27 +00:00
Simon Giesecke
ad3730c81e
Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
...
Based on a patch supplied by janv@mozilla.com
Differential Revision: https://phabricator.services.mozilla.com/D67129
--HG--
extra : moz-landing-system : lando
2020-03-17 11:28:49 +00:00
Simon Giesecke
f28bafa279
Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D64131
--HG--
extra : moz-landing-system : lando
2020-03-11 17:30:33 +00:00
Simon Giesecke
1fabf7b51c
Bug 1617170 - Encapsulate StructuredCloneReadInfo members. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D64078
--HG--
extra : moz-landing-system : lando
2020-03-11 17:20:05 +00:00
Simon Giesecke
2c98fa92a7
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-07 09:31:48 +00:00
Andreea Pavel
110347c99a
Backed out 8 changesets (bug 1617170) for build bustages at nsTArray.h on a CLOSED TREE
...
Backed out changeset ed7eaba53757 (bug 1617170)
Backed out changeset 0021ab4bcf77 (bug 1617170)
Backed out changeset 92f4ef8809ec (bug 1617170)
Backed out changeset c9561cb90821 (bug 1617170)
Backed out changeset 739dafac70bc (bug 1617170)
Backed out changeset 51c699b06d04 (bug 1617170)
Backed out changeset 2ae6b424f492 (bug 1617170)
Backed out changeset 6acafdd56175 (bug 1617170)
2020-03-06 17:57:23 +02:00
Simon Giesecke
63db82d1eb
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-06 15:34:18 +00:00
shindli
ff75fdf21a
Backed out 5 changesets (bug 1617170) for toolchains bustages CLOSED TREE
...
Backed out changeset cc2aadaf5923 (bug 1617170)
Backed out changeset bda38a16aac3 (bug 1617170)
Backed out changeset 5d3ed69aca66 (bug 1617170)
Backed out changeset 90dfe1253fe4 (bug 1617170)
Backed out changeset f1a4f3952931 (bug 1617170)
2020-03-06 14:55:58 +02:00
Simon Giesecke
517784f1bc
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-06 12:30:35 +00:00
Simon Giesecke
efe737d7c3
Bug 1613340 - Remove const_cast relating to CursorResponse. r=jld,dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61672
--HG--
extra : moz-landing-system : lando
2020-03-03 13:51:18 +00:00
Simon Giesecke
20603da0aa
Bug 1613340 - Remove const_cast relating to SerializedStructuredCloneReadInfo. r=jld,dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61671
--HG--
extra : moz-landing-system : lando
2020-03-03 13:50:48 +00:00
Simon Giesecke
a27fa59c89
Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61670
--HG--
extra : moz-landing-system : lando
2020-03-03 13:45:26 +00:00
Simon Giesecke
e4bf6784c3
Bug 1613854 - Avoid copying non-trivial IPDL params. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D62023
--HG--
extra : moz-landing-system : lando
2020-02-18 16:37:49 +00:00
Simon Giesecke
e26d6083c0
Bug 1613854 - Pass nsresult/bool/int* by value instead of const &. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D61992
--HG--
extra : moz-landing-system : lando
2020-02-27 12:17:47 +00:00
Eric Rahm
124379887c
Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
...
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.
Differential Revision: https://phabricator.services.mozilla.com/D63745
--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
David Major
c4e3b2d209
Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
...
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.
Differential Revision: https://phabricator.services.mozilla.com/D62327
--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Boris Zbarsky
c9e8a8042b
Bug 1611509 part 3. Remove the Date type from Web IDL. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D61054
--HG--
extra : moz-landing-system : lando
2020-01-27 08:50:35 +00:00
Simon Giesecke
2181db6537
Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55673
--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:17 +00:00
Simon Giesecke
0bcde245c0
Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
...
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.
Differential Revision: https://phabricator.services.mozilla.com/D59713
--HG--
extra : moz-landing-system : lando
2020-01-17 10:11:58 +00:00
Andrea Marchesini
ce6465d9ea
Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D59140
--HG--
extra : moz-landing-system : lando
2020-01-15 12:02:21 +00:00
Mihai Alexandru Michis
4345a38d0d
Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
...
CLOSED TREE
Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
6c05c922e3
Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D59140
--HG--
extra : moz-landing-system : lando
2020-01-15 09:58:39 +00:00
Csoregi Natalia
8ee62c60e1
Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
...
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke
25cbe0ce57
Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55673
--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:29 +00:00
Simon Giesecke
378b2a112d
Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
...
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.
Differential Revision: https://phabricator.services.mozilla.com/D59713
--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:52 +00:00
Simon Giesecke
a5e45033f2
Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
...
This also simplifies delegating calls that are dependent on the cursor type.
Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h
Differential Revision: https://phabricator.services.mozilla.com/D57993
--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8c7b4f143a
Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
...
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
a48be584a9
Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
...
This also simplifies delegating calls that are dependent on the cursor type.
Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h
Differential Revision: https://phabricator.services.mozilla.com/D57993
--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke
0d5b4fd7af
Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
...
Depends on D57990
Differential Revision: https://phabricator.services.mozilla.com/D57991
--HG--
extra : moz-landing-system : lando
2020-01-06 14:19:39 +00:00
Simon Giesecke
e4ec4856f2
Bug 1600906 - Use std::move instead of swap, use const where then possible. r=dom-workers-and-storage-reviewers,ytausky
...
Depends on D57988
Differential Revision: https://phabricator.services.mozilla.com/D57989
--HG--
extra : moz-landing-system : lando
2020-01-09 14:43:57 +00:00
Simon Giesecke
db6caebec7
Bug 1600906 - Merge identical switch cases. r=dom-workers-and-storage-reviewers,ttung
...
Depends on D57986
Differential Revision: https://phabricator.services.mozilla.com/D57987
--HG--
extra : moz-landing-system : lando
2019-12-20 15:33:40 +00:00
Simon Giesecke
77ea686b98
Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55520
--HG--
extra : moz-landing-system : lando
2019-12-19 09:57:49 +00:00
Simon Giesecke
c1c7168eae
Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55485
--HG--
extra : moz-landing-system : lando
2019-12-16 13:18:26 +00:00
Simon Giesecke
f490322f81
Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55484
--HG--
extra : moz-landing-system : lando
2019-12-16 13:18:13 +00:00
Simon Giesecke
7e8ae185d6
Bug 1600283 - Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D55477
--HG--
extra : moz-landing-system : lando
2019-12-13 12:18:21 +00:00
Jeff Walden
62a130ba0a
Bug 1602882 - Move array operations to a new js/Array.h header. r=sfink,bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D56595
--HG--
extra : moz-landing-system : lando
2019-12-11 06:17:44 +00:00
Simon Giesecke
b727e2abc1
Bug 1598164 - Implement transaction inactive state according to spec. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55142
--HG--
extra : moz-landing-system : lando
2019-12-04 12:59:09 +00:00
Simon Giesecke
d174bc1285
Bug 1596129 - Removed redundant assertions after infallible EmplaceBack calls. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D53932
--HG--
extra : moz-landing-system : lando
2019-12-04 12:48:38 +00:00
Simon Giesecke
90427d7da3
Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D54322
--HG--
extra : moz-landing-system : lando
2019-11-28 16:00:29 +00:00
Simon Giesecke
0d86246c8c
Bug 1599420 - Ensure that strong references to newly created cursors are kept until the DOM Binding is created. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D54704
--HG--
extra : moz-landing-system : lando
2019-11-26 14:38:16 +00:00
ssengupta
70cc52ae23
Bug 1595085 - BackgroundCursorChild::SendContinueInternal discards cached responses conditionally also for ContinuePrimaryKey r=sg
...
Differential Revision: https://phabricator.services.mozilla.com/D54518
--HG--
extra : moz-landing-system : lando
2019-11-26 13:33:56 +00:00
Simon Giesecke
766fe5ebfe
Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=dom-workers-and-storage-reviewers,ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D52861
--HG--
extra : moz-landing-system : lando
2019-11-20 16:21:34 +00:00
Simon Giesecke
dd2dfbdb42
Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=dom-workers-and-storage-reviewers,ttung
...
Depends on D52859
Differential Revision: https://phabricator.services.mozilla.com/D52860
--HG--
extra : moz-landing-system : lando
2019-11-20 15:12:34 +00:00
Simon Giesecke
06d137dba8
Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D52859
--HG--
extra : moz-landing-system : lando
2019-11-21 16:46:08 +00:00
Simon Giesecke
9932ffacc7
Bug 1596129 - Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess. r=dom-workers-and-storage-reviewers,ttung
...
Depends on D52844
Differential Revision: https://phabricator.services.mozilla.com/D52858
--HG--
extra : moz-landing-system : lando
2019-11-20 13:19:39 +00:00
Simon Giesecke
a137d4ea5b
Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D52844
--HG--
extra : moz-landing-system : lando
2019-11-20 13:26:16 +00:00
Simon Giesecke
ffec9b2750
Bug 1168606 - Set flag to invalidate in-flight responses as well. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D52559
--HG--
extra : moz-landing-system : lando
2019-11-14 16:14:02 +00:00
Simon Giesecke
deb959c93c
Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D49274
--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:28 +00:00
Simon Giesecke
608f5bac34
Bug 1168606 - Replace pseudo-move constructor of StructuredCloneReadInfo by explicit DeserializeStructuredCloneReadInfo function. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46593
--HG--
extra : moz-landing-system : lando
2019-11-08 13:22:08 +00:00
Simon Giesecke
b6fc689caf
Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
...
Depends on D45674
Differential Revision: https://phabricator.services.mozilla.com/D45675
--HG--
extra : moz-landing-system : lando
2019-11-05 16:46:31 +00:00