This evolves restoreScratchpadSession into restoreDevToolsSession which can keep track
of more than just scratchpad windows. In this case we also restore the Browser Console.
MozReview-Commit-ID: D4vOGkpq8xH
--HG--
extra : rebase_source : 33f1a2183ee717c79f360a7dda688832a5c33566
Tests were failing because we did not pass the expected serviceContainer prop
to the EvaluationResult component.
MozReview-Commit-ID: F6xKoY6vggb
--HG--
extra : rebase_source : aedefde806b4751fd7ba1d35041ef08118190b28
A loose checking was causing 0 and undefined values to be rendered as Object.
We fix this by checking explicitely if the grip has a value property.
A test is added to make sure we handle those cases as expected.
MozReview-Commit-ID: 1wdBVs7bF61
--HG--
extra : rebase_source : 2a4304bc365174a9822732c13bad6aabb356721b
The Browser Console interacts with a ChromeActor instance, which as any TabActor inherited actor,
expects to be "attached" by calling its `attach` request. isTabActor set to true ensures that.
While chrome set to true allows client codebase to enable additional behavior for chrome debugging.
MozReview-Commit-ID: 1MVLBKnluhg
--HG--
extra : rebase_source : 09b9cce4f6053b78cf617abbe71d54cc1b842f4e
The Browser Console interacts with a ChromeActor instance, which as any TabActor inherited actor,
expects to be "attached" by calling its `attach` request. isTabActor set to true ensures that.
While chrome set to true allows client codebase to enable additional behavior for chrome debugging.
MozReview-Commit-ID: 1MVLBKnluhg
--HG--
extra : rebase_source : 7e5c976c6a9690ae730fd8c32a8909e24a277ace
This passes an openLink callback to the Reps which handles the output.
MozReview-Commit-ID: L6q9wAWmwrp
--HG--
rename : devtools/client/webconsole/test/browser_webconsole_clickable_urls.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_clickable_urls.js
extra : rebase_source : d439fe0596f0fdc2b3c529814bcd07c0c08c7200
This required some changes in the ConsoleTable component. Since
it uses GripMessageBody, we need to pass it props that it might
need.
MozReview-Commit-ID: DNeBsmJqCFI
--HG--
extra : rebase_source : 34f4b6acc34fdd79b4111f07162ede46b96ae363
A test needed to be fixed since we changed some things
in bucketing (proper ellipsis and bucket label fix).
MozReview-Commit-ID: HhfJcKOGO2H
--HG--
extra : rebase_source : 91163a226eaada796b884b6a8e7a0b4887b65e1d
In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm
as that's the only one feature that DOM Promise don't support.
PART3: Manual fixes
- Go manually fix: http://searchfox.org/mozilla-central/source/devtools/client/dom/dom-panel.js
which has duplicated import of defer symbol (it already used to import it)
- execute eslint, see all the places where we import of 'promise' is no longer use it
(there may be leftovers not covered by eslint that will be covered in bug 1387128)
devtools/server/tests/mochitest/inspector-helpers.js needs to keep importing promise as it is a shared test script.
- fix devtools/client/performance/panel.js and devtools/client/webconsole/console-output.js
which use loader.lazyRequireGetter(this, "promise") and miss the defer import
- fix devtools/server/worker.js to use 'worker.require(devtools/shared/defer")'
MozReview-Commit-ID: HIOB5Et87Wc
--HG--
extra : rebase_source : fe3bff8599807224fd51898e753589d4c7c1777f
In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm
as that's the only one feature that DOM Promise don't support.
PART2: Substitutes promise.defer usages with defer
$ sed -i 's/promise.defer/defer/gI' $(egrep -lir "promise.defer\(\)" devtools)
Reset modification to the following files as they are using deprecated syncable promises as we don't want to touch them.
http://searchfox.org/mozilla-central/search?q=deprecated-sync-thenables&case=true®exp=false&path=
$ git checkout devtools/client/debugger/test/mochitest/
$ git checkout devtools/shared/client/main.js
$ git checkout devtools/client/debugger/
$ git checkout devtools/server/main.js
MozReview-Commit-ID: DGN5ae68wtn
--HG--
extra : rebase_source : 57602d89b0bcc1c905bee7723e30f87fa434c6d9
In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm
as that's the only one feature that DOM Promise don't support.
PART1: Import devtools/shared/defer
$ sed -i '/require("promise")/a const defer = require("devtools/shared/defer");' $(egrep -lir "promise.defer\(\)" $(egrep -rl "require\(\"promise\"\)" devtools))
But ignore debugger as it still uses sync promises and would better be handled manually
$ git checkout devtools/client/debugger/
MozReview-Commit-ID: 7FvhNxULB2x
--HG--
extra : rebase_source : 7eacd673759d85ab88d69b6edc6dff4c7f245638
Brian Grinstead
Nicolas Chevobbe
Andrew Halberstadt
Phil Ringnalda
Wes Kocher
Julian Descottes
Sebastian Hengst
Masatoshi Kimura
Kris Maglione
Jan Odvarko
Xidorn Quan
Alexandre Poirot
Tim Nguyen
Luca Greco
Carsten "Tomcat" Book
Jason Laster
Gabor Krizsanits
Brad Werth
Tom Tromey