Граф коммитов

3898 Коммитов

Автор SHA1 Сообщение Дата
Hubert Boma Manilla 2f728bd220 Bug 1687205 - [devtools] Use the network event actor id when getting stacktraces r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102116
2021-01-18 12:50:14 +00:00
longsonr dd9e8bf312 Bug 1687136 - remove svg.transform-box.enabled pref r=emilio
It's been default true since Firefox 55 via bug 1208550

Differential Revision: https://phabricator.services.mozilla.com/D102093
2021-01-18 08:11:05 +00:00
Tim Nguyen 21aaf562ea Bug 1686350 - Remove defer() from devtools/shared/security/socket.js. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D101603
2021-01-13 15:39:57 +00:00
Nicolas Chevobbe 00c0475c5d Bug 1686417 - [devtools] Generate a list of deprecated DOM methods and attributes. r=ladybenko.
This patch modifies and renameGeneratePureDOMFunctions.py so it generates a new file
indicating all the deprecated properties and methods so we can retrieve those information
in DevTools, in order, for example, to not call those deprecated properties and avoid generating
warning messages.

Differential Revision: https://phabricator.services.mozilla.com/D80864
2021-01-13 13:03:10 +00:00
nchevobbe 41791c52d9 Bug 1682534 - [devtools] Format generated file from GeneratePureDOMFunctions.py . r=ladybenko.
We take the opportunity to remove the parser.out file that
is generated when parsing the webidl files.

Differential Revision: https://phabricator.services.mozilla.com/D99772
2021-01-13 12:59:41 +00:00
Hubert Boma Manilla c0cca06a13 Bug 1686440 - [devtools] Fix webconsole network events and stacktrace tests r=ochameau,nchevobbe
Fixes browser_webconsole_stubs_network_event.js
Fixes browser_webconsole_network_messages_stacktrace_console_initiated_request.js

Differential Revision: https://phabricator.services.mozilla.com/D99623
2021-01-13 12:37:21 +00:00
Julian Descottes 2d91e59e16 Bug 1682029 - [devtools] Remove unused screenshotToDataUrl in devtools/server/actors/device.js r=devtools-backward-compat-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D101347
2021-01-13 09:06:16 +00:00
Emilio Cobos Álvarez dae007dd80 Bug 1684909 - Update the devtools CSS database.
MANUAL PUSH: Orange in a CLOSED TREE
2021-01-11 23:31:49 +01:00
Nicolas Chevobbe 947d31a9ff Bug 1685667 - Move devtools/shared/screenshot files to client/server. r=jdescottes.
Since capture.js was only loaded by server files and
save.js by client files, there wasn't any reason to
have them in devtools/shared.
The files are moved and the references are updated.

Differential Revision: https://phabricator.services.mozilla.com/D101142
2021-01-08 17:36:36 +00:00
Emilio Cobos Álvarez c2f1413e6b Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:

  * Instead of manually managing the image request, use the CSS image
    loader, with the `REQUEST_REQUIRES_REFLOW` flag, to handle image
    loads correctly. This didn't exist when this code was initially
    implemented, but we can nicely use it now.

  * Instead of re-implementing another WebRender command-builder thing,
    we can just reuse the nsImageRenderer code.

Differential Revision: https://phabricator.services.mozilla.com/D100774
2021-01-08 09:44:24 +00:00
Daisuke Akatsuka ec8a8ac1ac Bug 1685647: Update MDN compat data. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D101105
2021-01-08 09:23:35 +00:00
Alexandre Poirot 31c22e4866 Bug 1682780 - [devtools] Remove special hack around ThreadActor.attach from protocol.js internals. r=nchevobbe,jdescottes
This is no longer necessary as attach is no longer entering in a nested event loop.
And so we can have attach to complete and return its value as any other request.

Differential Revision: https://phabricator.services.mozilla.com/D100045
2021-01-07 13:32:41 +00:00
Alexandre Poirot 6fbec57619 Bug 1682780 - [devtools] Adapt tests and doc now that ThreadActor.attach no longer pause the thread. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D100022
2021-01-07 13:33:40 +00:00
Nicolas Chevobbe d72cf4ca31 Bug 1684965 - [devtools] Manage a reference to the parent in Pool. r=ochameau.
At the moment, the `getParent` method was using the connection `poolFor` method
to retrieve the pool that was managing it. This is quite costly as `poolFor`
loops through all the pools of the connection.
This patch adds a `parentPool` property to the Pool that is set in `manage` and
reset in `unmanage`, and used in the `getParent` method.
This speeds up getParent as well as the methods that call it (`manage` when the
actor was already managed, and `destroy`).

Differential Revision: https://phabricator.services.mozilla.com/D100981
2021-01-07 15:35:50 +00:00
Kartik Gautam 7ae6aea145 Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
Hubert Boma Manilla bf8708542a Bug 1685262 - [devtools] Add blockRequest/unblockRequest commands support r=ochameau,devtools-backward-compat-reviewers,nchevobbe
Fixes browser_jsterm_block_commands.js test

Differential Revision: https://phabricator.services.mozilla.com/D99622
2021-01-06 09:46:43 +00:00
Mark Banner 14da69d10f Bug 1684905 - Fully enable globalThis for ESLint. r=Gijs,necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D100697
2021-01-04 20:32:57 +00:00
Julian Descottes d8c21acf2f Bug 1678550 - [devtools] Load damp.js using the main DevTools Loader r=perftest-reviewers,nchevobbe,ochameau
Depends on D97626

Differential Revision: https://phabricator.services.mozilla.com/D97727
2021-01-04 13:07:08 +00:00
Kaique da Silva 74dde45aea Bug 1681897 - [devtools] Implemented the defer on test r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D100588
2021-01-04 11:17:18 +00:00
bfmags 3584270b01 Bug 1681894 - Remove unused `defer` require from devtools/shared/protocol/tests/xpcshell/head.js. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D100500
2020-12-28 16:10:08 +00:00
Cosmin Sabou 2978aa00a3 Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD 2020-12-28 00:43:51 +02:00
Kartik Gautam 775cdec032 Bug 1684173 - Add newline character at end of files when missing r=sylvestre
Depends on D100443

Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
Sonia Singla 7ea3ae701b Bug 1681896 - Remove defer usage in devtools/shared/transport/tests/xpcshell/head_dbg.js. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D100473
2020-12-26 23:34:32 +00:00
Nicolas Chevobbe ac3a027268 Bug 1679043 - [devtools] Fix race condition in StyleEditor when editing style sheet. r=daisuke,ochameau,devtools-backward-compat-reviewers,bomsy.
When the user edits a stylesheet in the StyleEditor, an `_isUpdating` flag is toggled,
and a request is sent to the server to actually apply those changes to the stylesheet.
It then causes a style-applied event to be emitted (or the stylesheet resource
to be updated, if watcher support is enabled for stylesheet).
In the end, this triggers the onStyleApplied function in the StyleEditor, where
we check if the `_isUpdating` flag is true (to know if the event was caused
through editing in style editor), and if not, replace the stylesheet content.

Unfortunately there's a race condition when the user is typing (and sending
multiple requests to the server), as the state of the _isUpdating flag could
be wrong if a new request is sent before the first one is handled.
This is probably highlighted with the throttling we're doing in the Resource API.

To fix this issue, we add a new `cause` parameter to the StyleSheets.update method,
which we set to `styleeditor` when calling update within the StyleEditor.
This `cause` parameter is then sent back by the server to the client (via the
style-applied event, or the resource update if we have Watcher support for stylesheets).
This `cause` can be checked by the StyleEditor client, and replace the check
on `_isUpdating`.

However, we need to keep the `_isUpdating` property to handle backward compatibility.

Differential Revision: https://phabricator.services.mozilla.com/D99862
2020-12-18 06:07:32 +00:00
Hubert Boma Manilla 32735f86aa Bug 1683119 - [devtools] Stop setting the targetFront on _onResourcUpdated and _onResourceDestroyed r=ochameau
Fixes browser_preloaded_newtab.js test
Fixes browser_aboutdebugging_devtoolstoolbox_target_destroyed.js test

Differential Revision: https://phabricator.services.mozilla.com/D99624
2020-12-17 15:29:17 +00:00
Hubert Boma Manilla ae44ae4664 Bug 1683107 - [devtools] Query the nsIHttpChannel to make sure we get the sourceMapURL r=ochameau
This fixes browser_dbg-gc-sources.js test

Differential Revision: https://phabricator.services.mozilla.com/D99620
2020-12-17 14:55:54 +00:00
Nicolas Chevobbe 51d30788b3 Bug 1681055 - [devtools] Add test case to check pretty-printing works on async function in console editor. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D99321
2020-12-15 08:44:55 +00:00
Nicolas Chevobbe 36ec5c6448 Bug 1681055 - [devtools] Update beautify-js to 1.13.0. r=ochameau.
This fix pretty-printing of async functions in console. A test case is added
to make sure we don't regress.

We used to copy the library tests and run them in xpcshell. The tests changed
a lot, and I don't think we get much value running tests that are already ran on
the project CI (we do have a few tests that checks that we get the output we want)
, so this patch remove the xpcshell test and the associated files.

The upgrade documentation is updated to remove some unecessary steps:
- no need to rename the exported module for each file
- no need to replace the acorn module, since what's in the file is just a subset
  of the library (~100 lines)
- no need to update the test file, which doesn't seem to exist anymore

Differential Revision: https://phabricator.services.mozilla.com/D99320
2020-12-15 08:48:19 +00:00
Emilio Cobos Álvarez 93ac2de55b Bug 1682295 - Update property dbs.
Differential Revision: https://phabricator.services.mozilla.com/D99706
2020-12-14 18:27:54 +00:00
Alexandre Poirot 44062da776 Bug 1573327 - [devtools] Pass breakpoints via the Watcher actor. r=jdescottes,devtools-backward-compat-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88850
2020-12-14 08:54:25 +00:00
Hubert Boma Manilla ce646bb5ee Bug 1674653 - [devtools] Resend requests with fission r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95474
2020-12-12 16:01:44 +00:00
Nicolas Chevobbe 9cd6389ce8 Bug 1680440 - [devtools] Remove backward compatibility comments for descriptor watcher traits. r=jdescottes.
The watcher trait might not be set on other descriptors, so
we want to keep them until we can get rid of the generic client
code that is handling them. This can probably be done as part of Bug 1680280.

Differential Revision: https://phabricator.services.mozilla.com/D98737
2020-12-11 14:20:16 +00:00
Nicolas Chevobbe d384313a27 Bug 1680440 - [devtools] Remove backward compatibility code to handle older messages in legacy listeners. r=ladybenko.
Older message had a _type property and a different shape,
so we needed to transform them.
We shouldn't get those anymore since 78, so we can remove that code.

Differential Revision: https://phabricator.services.mozilla.com/D98729
2020-12-11 13:54:33 +00:00
Nicolas Chevobbe 0578684be5 Bug 1680440 - [devtools] Remove favicons parameter in listTabs call. r=ladybenko,devtools-backward-compat-reviewers,jdescottes.
The parameter was only used for older servers, so we
can remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D98726
2020-12-11 13:54:06 +00:00
Nicolas Chevobbe a2398fb444 Bug 1680440 - [devtools] Remove nullable on profiler-started activeBrowsingContextID property. r=ladybenko,devtools-backward-compat-reviewers.
The nullable attribute was only there to handle server
older than 72, so we can remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D98724
2020-12-11 13:53:45 +00:00
Nicolas Chevobbe 450824e09f Bug 1680440 - [devtools] Remove backward compatibility comment for getSupportedFeatures. r=ladybenko,devtools-backward-compat-reviewers.
The function is used, the comment was only mentioning when
the function was added, which doesn't bring us any value.

Differential Revision: https://phabricator.services.mozilla.com/D98722
2020-12-11 13:53:30 +00:00
Nicolas Chevobbe 48fff0a45c Bug 1680440 - [devtools] Remove backward compatibility code in getNodeFrontFromNodeGrip. r=ladybenko,devtools-backward-compat-reviewers.
Since we now always have a contentDomReference in grips, we
don't need to fallback on gripToNodeFront.
And since gripToNodeFront was only used from getNodeFrontFromNodeGrip,
we can remove it, as well as the walker actor method getNodeActorFromObjectActor.

We also had to get a content reference from a rendered Reps in the console, for
the "Reveal in inspector" context menu entry, so we stringigy it in a data attribute.

Differential Revision: https://phabricator.services.mozilla.com/D98720
2020-12-11 13:53:14 +00:00
Nicolas Chevobbe 3aff30e0c2 Bug 1681065 - [devtools] Update MDN compat data for release 85. r=Honza.
This patch updates the compat data json files, using the update script.

Differential Revision: https://phabricator.services.mozilla.com/D98913
2020-12-10 16:49:12 +00:00
Nicolas Chevobbe abc372fb68 Bug 1680218 - [devtools] Remove mentions of WorkerDescriptorActor#connect. r=ochameau,devtools-backward-compat-reviewers.
The function doesn't exist anymore on newer server, so
we can remove it from the spec file.

Differential Revision: https://phabricator.services.mozilla.com/D98496
2020-12-09 13:17:56 +00:00
Nicolas Chevobbe 67ae0a0120 Bug 1680218 - [devtools] Remove unused methods in StyleSheetActor spec. r=daisuke,devtools-backward-compat-reviewers,jdescottes.
Those methods were only kept for backward compatibility in the spec file, so we
can remove them from here.
`getText` is still used from the `StyleSheetFront#guessIndentation`, so we remove
the backward compat comment, and add more information on it.

The methods on the actor can't be removed as they're still called from the StyleSheetsActor
to support servers that don't use the resource watcher for stylesheets.
A test that was using those methods was updated.

Differential Revision: https://phabricator.services.mozilla.com/D98494
2020-12-09 13:34:04 +00:00
Nicolas Chevobbe 205f99ee89 Bug 1680218 - [devtools] Remove supportsIsTopLevelDocument trait. r=rcaliman.
The trait was introduced in Firefox 81, so it's
safe to remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D98489
2020-12-09 13:17:08 +00:00
Csoregi Natalia 0c82325a1d Backed out 11 changesets (bug 1680218) for causing devtools failures e.g. /browser_rules_add-rule-and-property.js. CLOSED TREE
Backed out changeset a17c7da1221c (bug 1680218)
Backed out changeset 2cbd9d935611 (bug 1680218)
Backed out changeset 58034e6bc337 (bug 1680218)
Backed out changeset 9e668aa17d1c (bug 1680218)
Backed out changeset 082988607e17 (bug 1680218)
Backed out changeset 63d5d5fb0feb (bug 1680218)
Backed out changeset d09c87a11d72 (bug 1680218)
Backed out changeset 37adf02276eb (bug 1680218)
Backed out changeset 5103a959e33d (bug 1680218)
Backed out changeset 34838b56270b (bug 1680218)
Backed out changeset 936c49ae59a4 (bug 1680218)
2020-12-09 10:01:41 +02:00
Nicolas Chevobbe b52e8b6f00 Bug 1680218 - [devtools] Remove mentions of WorkerDescriptorActor#connect. r=ochameau,devtools-backward-compat-reviewers.
The function doesn't exist anymore on newer server, so
we can remove it from the spec file.

Differential Revision: https://phabricator.services.mozilla.com/D98496
2020-12-09 06:25:10 +00:00
Nicolas Chevobbe 882badf682 Bug 1680218 - [devtools] Remove unused methods in StyleSheetActor spec. r=daisuke,devtools-backward-compat-reviewers,jdescottes
Those methods were only kept for backward compatibility in the spec file, so we
can remove them from here.
The methods on the actor can't be removed as they're still called from the StyleSheetsActor
to support servers that don't use the resource watcher for stylesheets.
A test that was using those methods was updated.

Differential Revision: https://phabricator.services.mozilla.com/D98494
2020-12-09 06:25:05 +00:00
Nicolas Chevobbe 63a91e4bfb Bug 1680218 - [devtools] Remove supportsIsTopLevelDocument trait. r=rcaliman.
The trait was introduced in Firefox 81, so it's
safe to remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D98489
2020-12-09 06:23:46 +00:00
Nicolas Chevobbe e1302ab436 Bug 1680684 - [devtools] Fix handling of escaped characters for console autocomplete. r=bomsy.
The analyzeInputString function tried to handle escape characters in strings,
by having a dedicated ESCAPE state.
Unfortunately, when in ESCAPE state, the code will always re-assign the NORMAL state.
So if at some point the string was terminated, the code would assume we were entering
a string state again.
In the end, this would cause the autocomplete to fail, because the JSPropertyProvider
would think that it was passed an unterminated string literal.
This is fixed by introducing quote-specific escape state, so we know which state to get
back in once the escape character is consumed.

A few test cases are added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D98754
2020-12-08 16:31:27 +00:00
Alexandre Poirot 1a154de122 Bug 1644188 - [devtools] Unregister service worker in all resourceWatcher/targetList tests. r=jdescottes
Not doing that, makes the browser_resources_sources.js test to fail because
of pending SW's target which comes with unexpected sources.

Differential Revision: https://phabricator.services.mozilla.com/D98460
2020-12-08 13:12:11 +00:00
Alexandre Poirot 53d3715f45 Bug 1644188 - [devtools] Test Service Worker JS sources watching. r=jdescottes
This helps cover the workaround put in ResourceWatcher in order to trigger
the SOURCE legacy listener for targets that we don't yet support in the Watcher actor.

Differential Revision: https://phabricator.services.mozilla.com/D98438
2020-12-08 13:12:09 +00:00
Alexandre Poirot cc447685d4 Bug 1644188 - [devtools] Prevents watching for resources we no longer watch on target switching. r=jdescottes
This code in ResourceWatcher was forcing to watch resources we stopped listening to
when the target was switching.

Differential Revision: https://phabricator.services.mozilla.com/D98437
2020-12-08 13:45:40 +00:00
Nicolas Chevobbe 1c4be694f6 Bug 1680202 - [devtools] Remove perfActorVersion trait on Root actor. r=julienw.
The trait wasn't used at all.

Differential Revision: https://phabricator.services.mozilla.com/D98446
2020-12-08 10:55:54 +00:00
Nicolas Chevobbe d384fc5d5d Bug 1680202 - [devtools] Remove bulk traits on Root actor. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D98445
2020-12-08 10:55:41 +00:00
Nicolas Chevobbe a8c3a9ef74 Bug 1681070 - [devtools] Add a script to update MDN compat data. r=daisuke.
This patch adds a script which is similar to the one that was written in the README.md file.
This goes along with a simple package.json that let's us have a simple command
to execute the update script.

The README file is updated as well to reflect this new script.

Differential Revision: https://phabricator.services.mozilla.com/D98912
2020-12-08 09:16:33 +00:00
Bogdan Tara ade4d82c59 Backed out changeset 98c3e6255c58 (bug 1597600) for browser_installssl.js failures CLOSED TREE 2020-12-07 21:01:50 +02:00
R. Martinho Fernandes c99fe51d2d Bug 1597600 - make certificate overrides depend on origin attributes r=keeler,geckoview-reviewers,smaug,agi
Differential Revision: https://phabricator.services.mozilla.com/D91962
2020-12-07 17:10:52 +00:00
Emilio Cobos Álvarez 96a85ab8c6 Bug 1680558 - Update cssparser to get ParserState in rule parser. r=heycam
The changes should be trivial.

The third_party changes are up for review in
https://github.com/servo/rust-cssparser/pull/277 (and of course I'll
land with a bump to 0.28 rather than the override after that gets r+'d).

The basic idea is that with this we have the actual start offset of the
rule, so we wouldn't include html comments or other invalid stuff we
discard during sanitization in bug 1680084. But that's a separate
change.

Differential Revision: https://phabricator.services.mozilla.com/D98677
2020-12-04 10:47:55 +00:00
Julian Descottes 0e4a1ef1aa Bug 1673897 - [devtools] Throw if a spec method defines an array return value r=ochameau
Depends on D96940

Differential Revision: https://phabricator.services.mozilla.com/D96941
2020-12-02 14:35:53 +00:00
Julian Descottes a0e3b72bea Bug 1673897 - [devtools] Stop using arrays as return values for rdp responses r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96940
2020-12-02 14:35:46 +00:00
Alexandre Poirot 350909e718 Bug 1678385 - [devtools] Enable legacy listener for targets that watcher actor doesn't support. r=jdescottes
This is useful for SOURCE resource, as that's one resource that we expect to
fetch from all targets, but Service Worker and Shared worker targets aren't supported
yet by the watcher. So we should be using legacy listener for these.

Differential Revision: https://phabricator.services.mozilla.com/D97631
2020-12-02 10:33:49 +00:00
Hubert Boma Manilla 0b6ab1ef69 Bug 1676177 - [devtools] Throtting requests in fission r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97965
2020-11-30 23:03:55 +00:00
Nicolas Chevobbe 32aaf870e6 Bug 1677942 - [devtools] Use new syntax for backward compatibility comments. r=jdescottes,devtools-backward-compat-reviewers.
This turns all existing backward compatibility comments (or
comments mentioning a specific Firefox version), into the new
syntax we agreed upon in Bug 1673535.

Differential Revision: https://phabricator.services.mozilla.com/D97395
2020-12-01 10:27:47 +00:00
Sunita Sen 663194d7fc Bug 1329241 - Add support for touch-action:pinch-zoom - Add pinch-zoom support to touchAction r=kats,emilio
Differential Revision: https://phabricator.services.mozilla.com/D97815
2020-11-24 13:33:51 +00:00
Simon Giesecke dd80614fa0 Bug 1678062 - Remove unnecessary includes. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D97467

Depends on D96561
2020-11-23 16:12:02 +00:00
Simon Giesecke 971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Emilio Cobos Álvarez 559823cc19 Bug 1617608 - Allow toggling :focus-visible from inspector. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D97164
2020-11-20 16:24:37 +00:00
Hubert Boma Manilla cee5bf40eb Bug 1662736 - [devtools] Simplify the network resource payload for the server watcher r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94720
2020-11-20 16:17:36 +00:00
Micah Tigley f9418e8f58 Bug 1677660 - Remove backwards-compat methods from Compatibility front. r=jdescottes,daisuke,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97248
2020-11-18 16:29:31 +00:00
Sylvestre Ledru bebb9f9181 Bug 1519636 - Reformat with clang-format-11 to the Google coding style r=andi,sg,geckoview-reviewers,snorp
It is bringing some minor changes

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D90795
2020-11-18 09:05:59 +00:00
Hubert Boma Manilla 6e19a79a32 Bug 1677546 - [devtools] Rename network actors to parent and content actors r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97239
2020-11-17 23:21:26 +00:00
Alexandre Poirot b6defeeb72 Bug 1676808 - [devtools] Rename all watcher to watcherFront. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D96859
2020-11-17 11:15:40 +00:00
Alexandre Poirot 03ce56bda3 Bug 1676808 - [devtools] Rename ResourceWatcher.hasWatcherSupport to hasResourceWatcherSupport. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D97148
2020-11-17 11:15:38 +00:00
Alexandre Poirot ee7d0f17ec Bug 1676808 - [devtools] Expose WatcherFront via the TargetList instead of ResourceWatcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D96804
2020-11-17 11:15:35 +00:00
Sylvestre Ledru c0f6fe8caf Bug 1562642 - Add missing license headers r=mhoye,marionette-reviewers,webdriver-reviewers,perftest-reviewers,tarek
Differential Revision: https://phabricator.services.mozilla.com/D97138
2020-11-17 02:06:54 +00:00
Oriol Brufau fddd41228d Bug 1552648 - Avoid too much recursion when inspecting nested promises. r=nchevobbe,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96317
2020-11-16 18:15:14 +00:00
Noemi Erli debd6a2710 Backed out 3 changesets (bug 1676808) for causing devtools failures CLOSED TREE
Backed out changeset bc9b1ba331c3 (bug 1676808)
Backed out changeset 9e26cb0f0bdf (bug 1676808)
Backed out changeset 03abab648794 (bug 1676808)
2020-11-17 01:23:53 +02:00
Alexandre Poirot 02c7de7954 Bug 1676808 - [devtools] Rename all watcher to watcherFront. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D96859
2020-11-16 21:08:24 +00:00
Alexandre Poirot 1b2d2414ad Bug 1676808 - [devtools] Rename ResourceWatcher.hasWatcherSupport to hasResourceWatcherSupport. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D97148
2020-11-16 21:08:21 +00:00
Alexandre Poirot b1bb3196f3 Bug 1676808 - [devtools] Expose WatcherFront via the TargetList instead of ResourceWatcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D96804
2020-11-16 21:08:19 +00:00
Nika Layzell 42028efc71 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Nicolas Chevobbe 68d3b8b92b Bug 1672980 - [devtools] Fix browser_browser_resources_console_messages failures on beta simulation. r=ochameau.
This is flipping the devtools.browsertoolbox.fission pref, which
is only enabled on Nightly at the moment.

Differential Revision: https://phabricator.services.mozilla.com/D96411
2020-11-11 09:05:01 +00:00
Hubert Boma Manilla a70ec38159 Bug 1662736 - [devtools] Simplify the network request payload r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94457
2020-11-13 15:17:48 +00:00
Julian Descottes e7ec1ff308 Bug 1676980 - [devtools] Remove unused protocol/utils describeTemplate() helper r=ochameau
Depends on D96935

Differential Revision: https://phabricator.services.mozilla.com/D96939
2020-11-13 10:21:36 +00:00
Julian Descottes 3ad6fe2ca8 Bug 1676974 - [devtools] Remove unused protocol/utils.js method() helper r=ochameau
Current implementation
```lang=javascript
exports.method = function(fn, spec = {}) {
  fn._methodSpec = Object.freeze(spec);
  if (spec.request) {
    Object.freeze(spec.request);
  }
  if (spec.response) {
    Object.freeze(spec.response);
  }
  return fn;
};
```
https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/utils.js#70-79

The helper method() in protocol/utils.js is only called from two methods:
- actorBridge (never used in the codebase)
- actorBridgeWithSpec (used by a few actors)

actorBridgeWithSpec doesn't pass the second argument, so in practice, this method could be reduced to:
```lang=javascript
exports.method = function(fn) {
  fn._methodSpec = Object.freeze({});
  return fn;
};
```

`_methodSpec` is only mentioned in one other spot: https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/Actor/generateActorSpec.js#27-40

But based on our coverage tooling, we never actually have a `_methodSpec` when we run this code: https://coverage.moz.tools/#view=file&revision=latest&path=devtools/shared/protocol/Actor/generateActorSpec.js

To hit it, we would have to call `generateActorSpec` directly with an actor where we used `actorBridgeWithSpec`. But we never do that, we only use it with plain JS objects in the devtools/shared/specs folder.

Consequently, this helper can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D96935
2020-11-13 09:49:53 +00:00
Andreea Pavel 51f16bb9d2 Backed out changeset 62af829812bd (bug 1662736) for permafailing bug 1676641 and bug 1655183 on a CLOSED TREE 2020-11-11 19:53:14 +02:00
Hubert Boma Manilla d4cec11d5a Bug 1662736 - [devtools] Simplify the network request payload r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94457
2020-11-11 10:51:28 +00:00
Kris Maglione cfebcd3fd2 Bug 1669961: Return null from `.contentWindow` when inner window is inactive. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D93853
2020-11-10 20:35:04 +00:00
Kris Maglione 7ae9faa46f Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D93858
2020-11-06 18:58:33 +00:00
Steven MacLeod 971103bdd5 Bug 1606061 - move TouchEventsOverride to BrowsingContext. r=farre,devtools-backward-compat-reviewers
This change removes docshell's `mTouchEventsOverride` and replaces it
with a new `BrowsingContext` field `TouchEventsOverrideInternal`.
All uses of the old field have been replaced and an override should
now work under fission when there are cross-origin descendent frames.

Differential Revision: https://phabricator.services.mozilla.com/D96414
2020-11-10 15:57:30 +00:00
smolnar ec58e559fc Backed out changeset 1780d41127e8 (bug 1662736) for causing devtools failure. CLOSED TREE 2020-11-10 15:07:27 +02:00
Andrey Bienkowski e5944c6972 Bug 1674841 - [devtools] Clean up devtools/shared/protocol/tests/xpcshell/test_protocol_async.js r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D95553
2020-11-10 12:55:29 +00:00
Hubert Boma Manilla 5c91d1f55c Bug 1662736 - [devtools] Simplify the network request payload r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94457
2020-11-10 12:44:23 +00:00
Alexandre Poirot efdfcfb399 Bug 1672826 - [devtools] Unmanage fronts when we purge a whole prefix. r=nchevobbe
Previous `purgeRequestForDestroy` method was only rejecting all pending requests.
The new `syncFrontDestroy` allows to fully destroy the front, including
unregistering it/unmanage it. So that if we receive a packet from a brand new
actor, with the same prefix and actor ID, DevToolsClient.getFront doesn't return
the old destroyed front.
This issue was making pending requests that were never resolved.

Differential Revision: https://phabricator.services.mozilla.com/D94718
2020-11-09 12:29:53 +00:00
Nicolas Chevobbe 220bf52237 Bug 1675450 - [devtools] Remove unused ObjectActor.definitionSite. r=ochameau,devtools-backward-compat-reviewers.
The function wasn't used, except in a test that this patch removes.
Since it was also the only use of the getSourcesManager hook, we're able to
remove it as well.

Differential Revision: https://phabricator.services.mozilla.com/D95989
2020-11-09 09:50:26 +00:00
Julian Descottes d6d8ea296d Bug 1654763 - [devtools] Remove implementation, tests and documentation for actorHasMethod r=rcaliman,ochameau,devtools-backward-compat-reviewers
actorhasMethod had several technical limitations making it hard to use consistently. We now removed all the call sites for this method. This changeset removes the method and all its dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D95861
2020-11-06 13:50:52 +00:00
Nicolas Chevobbe 4bad3995de Bug 1592584 - [devtools] Accept worker targets in console. r=ochameau.
The `dom.worker.console.dispatch_events_to_main_thread` pref is used by platform
code to check if console API messages in the worker thread should be dispatched
to the main thread. If so, the message parameters are cloned, or stringified if
they can't be. This is currently the default behavior.

The pref is checked on the server side and added as a trait to the root actor.
On the client, if the pref isn't true, then we accept messages coming from
worker targets in the console. We can't accept them without condition, otherwise
we would get duplicated message (from the main thread AND the worker thread).

The browser_webconsole_console_logging_workers_api.js test is repurposed for
worker logging since it was disabled on e10s anyway. We add a few test case
to check we can get cached and live message, and that non-clonable object, like
worker scope, are displayed like regular objects when the pref is false.

Differential Revision: https://phabricator.services.mozilla.com/D85397
2020-11-05 10:17:36 +00:00
Julian Descottes d8f70bb25f Bug 1675020 - [devtools] Disable frequent intermittents / permafail DevTools tests on Fission platforms r=Honza
Temporarily add skip-if=fission in order to move devtools tests on Fission platforms to Tier1

Differential Revision: https://phabricator.services.mozilla.com/D95746
2020-11-04 18:39:57 +00:00
Julian Descottes e65f71419f Bug 1674977 - [devtools] Remove gDevTools::isFissionContentToolboxEnabled r=ochameau
Depends on D95686

Finally, remove the method itself.

Differential Revision: https://phabricator.services.mozilla.com/D95687
2020-11-04 18:32:37 +00:00
Julian Descottes 4952a99950 Bug 1674977 - [devtools] Always return true from gDevTools::isFissionContentToolboxEnabled r=ochameau
Depends on D95685

Keep the isFissionContentToolboxEnabled method but always return true to effectively enable all fission related behavior for all content toolboxes.

Differential Revision: https://phabricator.services.mozilla.com/D95686
2020-11-04 14:33:37 +00:00
Julian Descottes d17e35eb23 Bug 1674977 - [devtools] Enable Frame watching for all content toolboxes r=ochameau
This changeset only starts the FrameWatcher for any content toolbox.
The stack will progressively phase out the devtools.contenttoolbox.fission preference.

Differential Revision: https://phabricator.services.mozilla.com/D95685
2020-11-04 14:26:06 +00:00
Alexandre Poirot 613fcbb932 Bug 1675256 - [devtools] Remove discardRequestBody and discardResponseBody attributes of NETWORK_EVENT resource. r=bomsy,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D95846
2020-11-04 17:14:03 +00:00
Alexandre Poirot 2de72821eb Bug 1675237 - [devtools] Set NETWORK_EVENT resource's `isRacing` attribute early, on securityInfo update. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D95836
2020-11-04 17:14:03 +00:00
Yura Zenevich c7aaa8e041 Bug 1654956 - add UI for displaying tabbing order overlay in the accessibility panel. r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94926
2020-11-03 15:33:16 +00:00
Yura Zenevich ba825c5746 Bug 1654956 - add AccessibleWalker functionality to show/hide tabbing order overlay. r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94925
2020-11-03 15:33:09 +00:00
Razvan Maries 10425eddfc Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell 5f9c85da95 Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-04 00:55:36 +00:00
Julian Descottes ea163d7b6b Bug 1674357 - [devtools] Remove lifetime from DevTools protocol r=ochameau,devtools-backward-compat-reviewers
Depends on D95299

The lifetime feature seems unused in DevTools. Removing it should have no impact.

Differential Revision: https://phabricator.services.mozilla.com/D95302
2020-11-03 16:43:52 +00:00
Julian Descottes 9168a9f524 Bug 1674405 - [devtools] Extract StyleSheet, StyleSheets and MediaRule fronts to individual files r=daisuke,devtools-backward-compat-reviewers
Depends on D95329

Differential Revision: https://phabricator.services.mozilla.com/D95330
2020-11-03 16:35:51 +00:00
Julian Descottes 3ad5aa0547 Bug 1674405 - [devtools] Extract StyleSheet, StyleSheets and MediaRule specs to individual files r=daisuke,devtools-backward-compat-reviewers
Depends on D95328

Differential Revision: https://phabricator.services.mozilla.com/D95329
2020-11-03 15:56:12 +00:00
Julian Descottes 3def563fd2 Bug 1674371 - [devtools] Move ELEMENT_STYLE constant to a single file r=rcaliman,devtools-backward-compat-reviewers
Depends on D95299

Differential Revision: https://phabricator.services.mozilla.com/D95307
2020-11-02 18:45:03 +00:00
Julian Descottes 7021e9145e Bug 1674362 - [devtools] Extract PageStyle and StyleRule fronts to individual files r=rcaliman,devtools-backward-compat-reviewers
Depends on D95298

Also extract the corresponding fronts in individual files.

Differential Revision: https://phabricator.services.mozilla.com/D95299
2020-11-02 18:36:09 +00:00
Julian Descottes 6094cf8dcb Bug 1674362 - [devtools] Extract PageStyle and StyleRule specs to individual files r=rcaliman,devtools-backward-compat-reviewers
Depends on D95297

After moving actors to individual files, we should also do the same with specs.
Both actors are using shared types, which are moved to a shared types file.

Differential Revision: https://phabricator.services.mozilla.com/D95298
2020-11-02 18:35:28 +00:00
Belén Albeza 65ade5bf66 Bug 1669509 - [devtools] Hide internal indexedDB's when we are not in the browser toolbox r=ochameau
In https://phabricator.services.mozilla.com/D91122#C3084925OL296 we transferred the filtering of indexedDB dbs to a transformer, but it was not being applied since the `hosts` getter was still used by the client. Since we discussed this filtering should be done in the server, this patch moves the filtering to the storage actor instead.

Differential Revision: https://phabricator.services.mozilla.com/D95020
2020-11-02 13:28:56 +00:00
Belén Albeza 6ce63ec0cd Bug 1666528 - [devtools] Add session storage resource + test r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D94728
2020-10-30 16:12:58 +00:00
Csoregi Natalia c9031b88f2 Backed out changeset 5a4c2dc63d04 (bug 1669509) for causing leaks. CLOSED TREE 2020-10-30 18:50:11 +02:00
Belén Albeza a2eed98a2c Bug 1669509 - [devtools] Hide internal indexedDB's when we are not in the browser toolbox r=ochameau
In https://phabricator.services.mozilla.com/D91122#C3084925OL296 we transferred the filtering of indexedDB dbs to a transformer, but it was not being applied since the `hosts` getter was still used by the client. Since we discussed this filtering should be done in the server, this patch moves the filtering to the storage actor instead.

Differential Revision: https://phabricator.services.mozilla.com/D95020
2020-10-30 13:33:47 +00:00
Alexandre Poirot 1cca051c93 Bug 1673328 - [devtools] Stop using requestTypes in ThreadActor. r=nchevobbe
This was hacking the internals of RDP/protocol.js in order to provide
different names to the actor prototype.
I had to rename existing `skipBreakpoints` getter in order to avoid
name collision with the RDP method of the same name.
I also had to tweak a few method arguments as they weren't following protocol.js spec.
They were called without protocol.js automatic marshalling of values.
Finally, hack something in protocol.js in order to avoid duplicated response for ThreadActor.attach.

Differential Revision: https://phabricator.services.mozilla.com/D94958
2020-10-29 18:58:33 +00:00
Alexandre Poirot fdb8f8c40d Bug 1673328 - [devtools] Drop unused ThreadActor.detach method. r=nchevobbe,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94956
2020-10-29 19:00:39 +00:00
Ben Delevingne 8f836b4a1e Bug 1673872 - [devtools] Remove defer usage in devtools/shared/security/cert.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94994
2020-10-29 13:02:59 +00:00
Hubert Boma Manilla f2eff26a41 Bug 1667370 - [devtools] Implement network request blocking in fission r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94449
2020-10-28 22:32:14 +00:00
Daisuke Akatsuka 473676fda0 Bug 1664941: Connect style actor and stylesheet watcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90651
2020-10-29 06:26:20 +00:00
Cosmin Sabou 7a1d8770ac Backed out changeset 3b72cf9476d8 (bug 1667370) for xpc failures on test_protocol_index.js. CLOSED TREE 2020-10-28 23:35:36 +02:00
Hubert Boma Manilla 3d18cd113c Bug 1667370 - [devtools] Implement network request blocking in fission r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94449
2020-10-28 20:46:13 +00:00
Ben Delevingne 30a007f78c Bug 1673873 - [devtools] Remove defer usage in devtools/shared/security/auth.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94995
2020-10-28 15:41:22 +00:00
Ben Delevingne 44743fea0a Bug 1673724 - Remove defer usage in devtools/shared/qrcode/index.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94891
2020-10-28 11:33:21 +00:00
Nicolas Chevobbe 8eb8c85437 Bug 1672930 - [devtools] Handle Node environment in l10n module. r=ladybenko.
In most of our node tests (jest and mocha), we need to rely on fixtures for the
l10n modules because in its current shape, the module couldn't load the properties
files properly.
This patch fixes that by detecting if we're in a Node environment, and in such
case load the file using `readFileSync`.
We are also able to remove the specific code we had for webpack as it doesn't
seem to be used anymore.

The Spectrum.js file needed to be updated to fix the paths it was using.

Differential Revision: https://phabricator.services.mozilla.com/D94568
2020-10-26 17:11:17 +00:00
Hubert Boma Manilla 66158e4209 Bug 1671869 - [devtools] Fix intermittent failures for stacktraces test r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94707
2020-10-27 15:26:06 +00:00
Markus Stange af68ac4a30 Bug 1673132 - Use the -moz-default-appearance values "scrollbar-horizontal" and "scrollbar-vertical" on macOS and remove the now-unused value "scrollbar". r=emilio
Other platforms were already converted to scrollbar-horizontal and scrollbar-vertical in bug 1205643.

Differential Revision: https://phabricator.services.mozilla.com/D94674
2020-10-27 12:37:44 +00:00
Markus Stange cb8968058f Bug 1673132 - Remove "scrollbar-small" -moz-default-appearance value and replace its single use with scrollbar-width: thin. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D94673
2020-10-27 12:37:44 +00:00
Ben Delevingne c9aa53a1ec Bug 1673386 - remove defer from devtools/shared/tests/xpcshell/test_executeSoon.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94739
2020-10-27 15:23:22 +00:00
Ricky Stewart 02a7b4ebdf Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Nicolas Chevobbe d40666da1d Bug 1633712 - [devtools] Add a console message resource test for worker targets. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D88770
2020-10-26 12:55:06 +00:00
Nicolas Chevobbe 8470542b39 Bug 1633712 - [devtools] Add test cases to browser_target_list_tab_workers and remove the fission fail-if. r=jdescottes.
Check that when removing iframes, we're notified about the worker unregistration,
and check that the target list works as expected when we have multiple iframes
on same origin (both remote and same-origin as main document).

The test documents are modified so we can avoid spawning shared and/or service
workers (in the case of this test, this seems to prevent some memory leaks/crashes).

Differential Revision: https://phabricator.services.mozilla.com/D88769
2020-10-26 12:54:14 +00:00
Nicolas Chevobbe edca74234a Bug 1633712 - [devtools] Create WorkerTargets as soon as possible. r=ochameau,devtools-backward-compat-reviewers.
This patch adds support for dedicated worker targets in the Watcher actor.
Shared and Service workers are not handled yet.

In a similar manner to what we already have for frame targets, we add a worker-helper
file that will communicate with a JsWindowActor pair spawned on each document,
that will  manage workers (DevToolsWorkerParent/DevToolsWorkerChild).

For a given document, the DevToolsWorkerChild will enumerate the existing workers
related to it, as well as add an event listener to be notified when workers are
being registered and unregistered, and communicate that back to the DevToolsWorkerParent
on the main thread, so worker targets creation and destruction are notified by
the Watcher actor (via target-available-form and target-destroyed-form events).

When a worker is created, the DevToolsWorkerChild for the document the worker
was spawned from will create a WorkerTargetActor, that will live in the worker
thread (using worker-connector.js), passing it resources the Watcher is currently
listening for. It will also handle communication between the main thread and the
worker thread, when the watcher listen to new resources (or stop watching resources).

A WorkerTargetFront is created so the client can be notified about available
resources (via the resource-available-form event, emitted from the worker target).

Tests are added in the next patches of this queue.

Differential Revision: https://phabricator.services.mozilla.com/D85399
2020-10-26 12:53:43 +00:00
Ted Campbell e1d1f04395 Bug 1672172 - Make source notes relative to initial line/column. r=jandem
Update the SetLine / ColSpan source-notes to be relative to the script's
initial line and column number. This allows for more bytecode sharing.

Differential Revision: https://phabricator.services.mozilla.com/D94116
2020-10-24 01:12:57 +00:00
Bogdan Tara 7e2f80a26c Backed out changeset 0b27951e02d6 (bug 1672172) for browser_resources_* devtools failures CLOSED TREE 2020-10-24 04:10:13 +03:00
Bogdan Tara da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ted Campbell 2189239f96 Bug 1672172 - Make source notes relative to initial line/column. r=jandem
Update the SetLine / ColSpan source-notes to be relative to the script's
initial line and column number. This allows for more bytecode sharing.

Differential Revision: https://phabricator.services.mozilla.com/D94116
2020-10-23 22:48:52 +00:00
Ricky Stewart c0cea3b0fa Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Mats Palmgren 0d4b979717 Bug 1672807 - [css-grid-3] Enable masonry layout by default in Nightly. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D94522
2020-10-23 09:10:56 +00:00
Belén Albeza e6d07a37fa Bug 1666519 - Part 1: [devtools] Add localStorage resource r=ochameau
Tests are added in the next revision of the stack: D93808

Differential Revision: https://phabricator.services.mozilla.com/D92634
2020-10-23 11:58:45 +00:00
Ben Delevingne f3e01fb112 Bug 1672339 - remove defer from test_discovery.js. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94276
2020-10-23 11:00:02 +00:00
Razvan Caliman 8dacfff4f6 Bug 1623667 - [devtools] Remove HighlighterActor r=ochameau,devtools-backward-compat-reviewers
This patch completely removes the `HighlighterActor` and its accessors.

The rest of the patches in this commit series update the consumers and tests to use the new highlighter manager added to `HighlightersOverlay` in D81526. [Bug 1646028](https://bugzilla.mozilla.org/show_bug.cgi?id=1646028) updated all consumers within the **Inspector** panel to use this approach. Now, we're updating the rest of the consumers outside the Inspector.

### Why remove HighlighterActor?

The changes introduced in D81526 for [Bug 1646028](https://bugzilla.mozilla.org/show_bug.cgi?id=1646028) make it possible to  highlight nodes using the `CustomHighligtherActor` with the **Box Model Highlighter** implementation.

The `HighlighterActor` was itself a wrapper around **Box Model Highlighter** and Simple Outline Highlighter, and exposed node picking functionality. Simple Outline Highlighter was removed with [Bug 1650094](https://bugzilla.mozilla.org/show_bug.cgi?id=1650094). The node picking functionality was decoupled from `HighlighterActor`in [Bug 1607756](https://bugzilla.mozilla.org/show_bug.cgi?id=1607756).

After those changes, `HighlighterActor` is no longer special. It can be removed in favor of a single generic actor, `CustomHighligtherActor`, with the Box Model Highlighter implementation.

Differential Revision: https://phabricator.services.mozilla.com/D92220
2020-10-20 14:43:23 +00:00
Csoregi Natalia 22aaaaef5c Backed out changeset 77c34aa0aaf3 (bug 1669961) for causing crashtests. CLOSED TREE 2020-10-22 23:13:31 +03:00
Kris Maglione 3cf334a80a Bug 1669961: Return null from `.contentWindow` when inner window is inactive. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D93853
2020-10-22 19:05:04 +00:00
Alexandre Poirot 01c64de783 Bug 1620248 - [devtools] Test content process console messages in a resource watcher test. r=nchevobbe
For now, resource watcher tests were only testing resources from a single tab.
This test targets the main process, like the browser toolbox and so will listen to all targets,
including content process targets.

Differential Revision: https://phabricator.services.mozilla.com/D93734
2020-10-22 10:02:44 +00:00
Alexandre Poirot 8cfdbef9f5 Bug 1620248 - [devtools] Create ContentProcessTarget from the server side via the Watcher Actor. r=nchevobbe,jdescottes
Before, targets were created on-demand, from the frontend, by calling ProcessDescriptor.getTarget
when the root actor informed the frontend of a creation of a content process via processListChanged event
and the notification of a new ProcessDescriptor.
This previous behavior was making so that the target actor was created very late and did not allow
recording for resources (console messages for ex), nor setting breakpoints very early during the process startup.

With this new implementation, the watcher actor allows knowing if the frontend cares about content process target or not.
We should only create these targets if the browser toolbox is opened, and typically not if we are only debugging a tab via a regular web toolbox.
We do that via WatcherActor.watchTarget and sharedData object.
content-process-script.js is loaded in all processes. Process script are loaded quite early during process startup.
Soonish after `sharedData` is passed to the content process.
So that it is hopefully executed before most privileged javascript runs.
Javascript code where we possibly want to debug/observe/set a breakpoint on.
This setup allows us to create the Content Process Target actor much earlier than the previous setup.
When created, the target actor immediately start listening for resources (console message and others) via its `addWatcherDataEntry` method.
In a near future, breakpoints will also be set via this method.

We should also followup to use something else than Process Script and sharedData
in order to create the target earlier, before any JS runs.

Differential Revision: https://phabricator.services.mozilla.com/D65529
2020-10-22 10:02:42 +00:00
Alexandre Poirot 23e54f0836 Bug 1620248 - [devtools] Make hooks.onClosed optional for all Transport classes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D93193
2020-10-22 10:02:34 +00:00
Dorel Luca 1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 50762dacab Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Boris Chiou 8b4bc86a78 Bug 1672078 - Enable aspect-ratio on nightly. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D94061
2020-10-21 07:42:56 +00:00
Bogdan Tara 3f38cbb0f8 Backed out 2 changesets (bug 1666519) for devtools leaks and failures CLOSED TREE
Backed out changeset 94c066ab05dc (bug 1666519)
Backed out changeset 990b312b5abe (bug 1666519)
2020-10-21 18:42:25 +03:00
Belén Albeza 223b34efcf Bug 1666519 - Part 1: [devtools] Add localStorage resource r=ochameau
Tests are added in the next revision of the stack: D93808

Differential Revision: https://phabricator.services.mozilla.com/D92634
2020-10-21 14:05:14 +00:00
Ben Hearsum 2167d1b284 Bug 1638957: run 'mach devtools-css-db' under python 3. r=releng-reviewers,aki DONTBUILD
It's not 100% clear how long this command will live, but it doesn't look
immediately removable, and it was easy to add python3 support.

Differential Revision: https://phabricator.services.mozilla.com/D94179
2020-10-21 14:04:17 +00:00
Ben Delevingne 2dd4dbb9c9 Bug 1672347 - remove defer from devtools/shared/discovery/tests/xpcshell. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D94283
2020-10-21 10:59:32 +00:00
Julian Descottes 1ba86569a5 Bug 1671609 - [devtools] Remove swapBrowser methods from DevTools transports r=ochameau
Depends on D93819

Differential Revision: https://phabricator.services.mozilla.com/D93820
2020-10-20 17:02:31 +00:00
Razvan Maries 3954e7eb5a Backed out 5 changesets (bug 1671676, bug 1671609) for Lint failure on frame.js. CLOSED TREE
Backed out changeset aba7c7caae10 (bug 1671676)
Backed out changeset 68449199cb9a (bug 1671676)
Backed out changeset 107e0c2f141a (bug 1671609)
Backed out changeset 02bc34c28501 (bug 1671609)
Backed out changeset 5efd9f6968ed (bug 1671609)
2020-10-20 19:59:11 +03:00
Julian Descottes 998b2a78f6 Bug 1671609 - [devtools] Remove swapBrowser methods from DevTools transports r=ochameau
Depends on D93819

Differential Revision: https://phabricator.services.mozilla.com/D93820
2020-10-19 09:54:17 +00:00
Csoregi Natalia f9e58cacd1 Backed out 9 changesets (bug 1623667) for failures on devtools/client/*. CLOSED TREE
Backed out changeset 54ca4d13f54f (bug 1623667)
Backed out changeset ce62de8733f1 (bug 1623667)
Backed out changeset 4877c0c5ba2c (bug 1623667)
Backed out changeset d32decff7ea8 (bug 1623667)
Backed out changeset 53a2c44f955b (bug 1623667)
Backed out changeset 0addf3282b72 (bug 1623667)
Backed out changeset feeb0f0b3bb3 (bug 1623667)
Backed out changeset f90ccc4f5210 (bug 1623667)
Backed out changeset e18376ee942f (bug 1623667)
2020-10-20 17:39:28 +03:00
Razvan Caliman e7d88cfad5 Bug 1623667 - [devtools] Remove HighlighterActor r=ochameau,devtools-backward-compat-reviewers
This patch completely removes the `HighlighterActor` and its accessors.

The rest of the patches in this commit series update the consumers and tests to use the new highlighter manager added to `HighlightersOverlay` in D81526. [Bug 1646028](https://bugzilla.mozilla.org/show_bug.cgi?id=1646028) updated all consumers within the **Inspector** panel to use this approach. Now, we're updating the rest of the consumers outside the Inspector.

### Why remove HighlighterActor?

The changes introduced in D81526 for [Bug 1646028](https://bugzilla.mozilla.org/show_bug.cgi?id=1646028) make it possible to  highlight nodes using the `CustomHighligtherActor` with the **Box Model Highlighter** implementation.

The `HighlighterActor` was itself a wrapper around **Box Model Highlighter** and Simple Outline Highlighter, and exposed node picking functionality. Simple Outline Highlighter was removed with [Bug 1650094](https://bugzilla.mozilla.org/show_bug.cgi?id=1650094). The node picking functionality was decoupled from `HighlighterActor`in [Bug 1607756](https://bugzilla.mozilla.org/show_bug.cgi?id=1607756).

After those changes, `HighlighterActor` is no longer special. It can be removed in favor of a single generic actor, `CustomHighligtherActor`, with the Box Model Highlighter implementation.

Differential Revision: https://phabricator.services.mozilla.com/D92220
2020-10-13 15:40:13 +00:00
Hubert Boma Manilla 3d1f26e2cd Bug 1663523 - [devtools] Add the network event stacktrace watcher r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86809
2020-10-19 01:19:39 +00:00
Bogdan Tara 61728de827 Backed out changeset de71a00c6f68 (bug 1663523) for devtools/shared/ failures CLOSED TREE 2020-10-18 20:53:17 +03:00
Hubert Boma Manilla 403ec0015b Bug 1663523 - [devtools] Add the network event stacktrace watcher r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86809
2020-10-18 17:11:36 +00:00
Csoregi Natalia e0eb861a18 Backed out 4 changesets (bug 1633712) for leaks. CLOSED TREE
Backed out changeset 03553b300b86 (bug 1633712)
Backed out changeset 19c8ea0b43df (bug 1633712)
Backed out changeset 6eaa4d12b58c (bug 1633712)
Backed out changeset 10f97f47c883 (bug 1633712)
2020-10-15 09:36:36 +03:00
Nicolas Chevobbe 4c0fda2660 Bug 1633712 - [devtools] Add a console message resource test for worker targets. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D88770
2020-10-15 05:18:58 +00:00
Nicolas Chevobbe 12e26edc41 Bug 1633712 - [devtools] Add test cases to browser_target_list_tab_workers and remove the fission fail-if. r=jdescottes.
Check that when removing iframes, we're notified about the worker unregistration,
and check that the target list works as expected when we have multiple iframes
on same origin (both remote and same-origin as main document).

Differential Revision: https://phabricator.services.mozilla.com/D88769
2020-10-15 05:19:23 +00:00
Nicolas Chevobbe 1e17daf388 Bug 1633712 - [devtools] Create WorkerTargets as soon as possible. r=ochameau,devtools-backward-compat-reviewers.
This patch adds support for dedicated worker targets in the Watcher actor.
Shared and Service workers are not handled yet.

In a similar manner to what we already have for frame targets, we add a worker-helper
file that will communicate with a JsWindowActor pair spawned on each document,
that will  manage workers (DevToolsWorkerParent/DevToolsWorkerChild).

For a given document, the DevToolsWorkerChild will enumerate the existing workers
related to it, as well as add an event listener to be notified when workers are
being registered and unregistered, and communicate that back to the DevToolsWorkerParent
on the main thread, so worker targets creation and destruction are notified by
the Watcher actor (via target-available-form and target-destroyed-form events).

When a worker is created, the DevToolsWorkerChild for the document the worker
was spawned from will create a WorkerTargetActor, that will live in the worker
thread (using worker-connector.js), passing it resources the Watcher is currently
listening for. It will also handle communication between the main thread and the
worker thread, when the watcher listen to new resources (or stop watching resources).

A WorkerTargetFront is created so the client can be notified about available
resources (via the resource-available-form event, emitted from the worker target).

Tests are added in the next patches of this queue.

Differential Revision: https://phabricator.services.mozilla.com/D85399
2020-10-15 05:17:52 +00:00
Alexandre Poirot b5d324284b Bug 1667282 - [devtools] Fix browser_resources_network_events.js intermittent. r=bomsy
We should only assert `updates` attribute on resource-updated,
as we aren't guaranteed how many updates we will have in resource-available.
That's because of resource throttling. Updates may be coalesced into available,
but we can't predict how many.

Differential Revision: https://phabricator.services.mozilla.com/D93337
2020-10-14 13:03:31 +00:00
Jan Odvarko da6a32c342 Bug 1662653: [devtools] Update MDN compat data r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D93070
2020-10-13 15:14:38 +00:00
Narcis Beleuzu 0cc97d7a9e Backed out changeset f71a318e2dfc (bug 1662653) for dt failures on browser_rules_css-compatibility-check-add-fix.js CLOSED TREE 2020-10-13 18:07:04 +03:00
Jan Odvarko d0ecf61755 Bug 1662653 - [devtools] Update MDN compat data r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D93070
2020-10-13 01:05:37 +00:00
Julian Descottes e1074b5ab6 Bug 1669681 - [devtools] Send tabDetached event before the forwardingCancelled event in content-process-connector r=ochameau
Depends on D93029

Emitting "forwardingCancelled" will result in purging requests on the target front, which almost equates to destroying the front.
We should emit the "tabDetached" event before that to avoid emitting events on already destroyed fronts.

Differential Revision: https://phabricator.services.mozilla.com/D93030
2020-10-12 08:13:19 +00:00
Julian Descottes a9480f8030 Bug 1669681 - [devtools] Send tabDetached event before the forwardingCancelled event in frame-connector r=ochameau
Emitting "forwardingCancelled" will result in purging requests on the target front, which almost equates to destroying the front.
We should emit the "tabDetached" event before that to avoid emitting events on already destroyed fronts.

Differential Revision: https://phabricator.services.mozilla.com/D93029
2020-10-12 08:13:29 +00:00
Tim Nguyen 4dd07cd7c4 Bug 1632351 - Enable CSS conic-gradient by default and let it ride the trains. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D93024
2020-10-10 19:46:42 +00:00
Csoregi Natalia 3459200163 Backed out changeset 7576a306cce4 (bug 1632351) for failures on layout/style/test/test_value_cloning.html. CLOSED TREE 2020-10-10 17:37:40 +03:00
Tim Nguyen 25127ffb85 Bug 1632351 - Enable CSS conic-gradient by default and let it ride the trains. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D93024
2020-10-10 13:19:56 +00:00
Sylvestre Ledru cad53f4804 Bug 1588458 - Replace dxr links by searchfox in the code/test r=kats,sparky
Differential Revision: https://phabricator.services.mozilla.com/D92792
2020-10-08 14:02:40 +00:00
Christoph Kerschbaumer faf05f7d19 Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D92087
2020-10-08 16:55:25 +00:00
Alexandre Poirot 1d2c3f612c Bug 1667839 - Test console message resources against remoted iframes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D91970
2020-10-05 20:52:00 +00:00
Alexandre Poirot 2c3d8677f9 Bug 1667839 - Pass watchedData to already existing targets. r=nchevobbe
The previous code was all wrong and we weren't correctly listening to resource
for already existing additional targets. Top level target was still working fine
thanks to WatcherActor.watchResources calling watchTargetResource directly.

Differential Revision: https://phabricator.services.mozilla.com/D91969
2020-10-05 20:52:23 +00:00
Gabriel Luong 18a75c17f7 Bug 1660973 - [devtools] Return a disconnectedNodeArray for getOverflowCausingElements. r=jdescottes,devtools-backward-compat-reviewers
The problem with `getOverflowCausingElement`s seems to be that it returned an array
of nodes that weren't properly attached to their parents.

To mitigate this, we call `attachElements` on the entire list of nodes and
return a `disconnectedNodeArray` which ensures that the returned nodes
are properly attached and therefore has all their parent node information
when calling `showNode`.

Differential Revision: https://phabricator.services.mozilla.com/D92360
2020-10-05 15:58:21 +00:00
Alexandre Poirot 9e8ae4bdea Bug 1620280 - [devtools] Workaround browser_ext_devtools_inspectedWindow_targetSwitch.js intermittent failure. r=jdescottes
browser_ext_devtools_inspectedWindow_targetSwitch.js has top level targets that are destroyed while
the test runs. This makes the `sources` request to fail with an exception because when a target
is destroyed, we "purge" any pending request and make them throw/reject them.

This isn't super elegant, but the idea is that the server side implementation won't have this issue.

Differential Revision: https://phabricator.services.mozilla.com/D92371
2020-10-05 13:22:30 +00:00
Alexandre Poirot 4bcdeb0c48 Bug 1620280 - [devtools] Convert SourceMapService to use SOURCE resource. r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D88298
2020-10-05 08:28:48 +00:00
Alexandre Poirot 280c0d17aa Bug 1620280 - [devtools] Implement and use a SOURCE resource. r=jdescottes,bomsy,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D86916
2020-10-05 08:28:46 +00:00
Julian Descottes 94e1fdd036 Bug 1668117 - [devtools] do not load prefsHelper from devtools-modules in debugger r=nchevobbe
Depends on D91858

Differential Revision: https://phabricator.services.mozilla.com/D91859
2020-10-02 15:39:44 +00:00
Julian Descottes be2fc1e55c Bug 1668117 - [devtools] fix typo in plural-form.js r=nchevobbe
Depends on D91853

Differential Revision: https://phabricator.services.mozilla.com/D91854
2020-10-02 15:38:32 +00:00
David Walsh 9dab095b52 Bug 1625935 - [devtools] Implement ResourceWatcher with legacy listeners for Storage panel r=ochameau
This is D86050, rebased on top of current central. I kept it a separate commit, so the new stuff can be reviewed separately in a different revision.

Differential Revision: https://phabricator.services.mozilla.com/D91122
2020-10-02 09:31:03 +00:00
Butkovits Atila d89b519adc Backed out 9 changesets (bug 1620280) for failure at browser_ext_devtools_inspectedWindow_targetSwitch.js. CLOSED TREE
Backed out changeset 8dda1f048067 (bug 1620280)
Backed out changeset 309c0be48745 (bug 1620280)
Backed out changeset 78a06cd336c6 (bug 1620280)
Backed out changeset 74aba83895ce (bug 1620280)
Backed out changeset 6a8126ded6ec (bug 1620280)
Backed out changeset 47a2d6b77270 (bug 1620280)
Backed out changeset 526c067da0c1 (bug 1620280)
Backed out changeset 488f645884ba (bug 1620280)
Backed out changeset 9cffe1c5fb6d (bug 1620280)
2020-10-01 23:32:57 +03:00
Alexandre Poirot 2cf7b7a8e4 Bug 1620280 - [devtools] Convert SourceMapService to use SOURCE resource. r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D88298
2020-10-01 14:22:23 +00:00
Alexandre Poirot 4367d1b79f Bug 1620280 - [devtools] Implement and use a SOURCE resource. r=jdescottes,bomsy,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D86916
2020-10-01 14:22:21 +00:00
Nicolas Chevobbe 6e140506a1 Bug 1662734 - [devtools] Create an actual WorkerTargetActor and use it in startup/worker.js . r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This patch adds a simple WorkerTargetActor, which is similar to the mock target
actor we had in startup/worker.js.

Its spec file is empty at the moment, and it does not have an associated front,
but that might change with Bug 1633712 where we will at least have events for
resources available/destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D91128
2020-09-29 14:47:34 +00:00
Nicolas Chevobbe f315ff58cd Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-29 14:30:24 +00:00
Dorel Luca f826d52619 Backed out 3 changesets (bug 1573779, bug 1662734) for Geckoview failures. CLOSED TREE
Backed out changeset 0adff4f08b28 (bug 1662734)
Backed out changeset c6bb84f2a032 (bug 1573779)
Backed out changeset 0c605800aa6b (bug 1573779)
2020-09-29 12:59:39 +03:00
Tom Schuster 002deb9621 Bug 1645284 - When taking a fullscreen screenshot accept any DPR, but try again when too large. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D91508
2020-09-29 06:13:54 +00:00
Nicolas Chevobbe 68ba8f3d46 Bug 1662734 - [devtools] Create an actual WorkerTargetActor and use it in startup/worker.js . r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This patch adds a simple WorkerTargetActor, which is similar to the mock target
actor we had in startup/worker.js.

Its spec file is empty at the moment, and it does not have an associated front,
but that might change with Bug 1633712 where we will at least have events for
resources available/destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D91128
2020-09-28 12:29:11 +00:00
Nicolas Chevobbe 4914f8c614 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-28 12:27:22 +00:00
Frederic Wang 0eebca3c33 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-26 03:04:56 +00:00
Narcis Beleuzu 679469fad8 Backed out changeset 239f29a99c4f (bug 1667118) for bc failure on browser_parsable_css.js . CLOSED TREE 2020-09-25 23:39:15 +03:00
Frederic Wang 5461921d85 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-25 18:37:39 +00:00
Julian Descottes 4fd39a83f2 Bug 1618693 - [devtools] Remove LocalTabTargetFront and move localtab logic to TabDescriptorFront r=ochameau
The goal of this revision is to unify the various tab & frame target fronts on the client side so that they are all simple instances of BrowsingContextTargetFront.
This will simplify https://bugzilla.mozilla.org/show_bug.cgi?id=1644397 . At the moment all targets emitted by the watcher are turned into BrowsingContextTargetFront by target list (https://searchfox.org/mozilla-central/rev/35d927df97900a57ecb562ad13909e392440b0fb/devtools/client/fronts/watcher.js#37). Removing `LocalTabTargetFront` means we don't have to introduce this concept to TargetList.

The first top target of a content toolbox will be a BrowsingContextTargetFront, same as all the future ones, even if they are provided by the watcher.

Differential Revision: https://phabricator.services.mozilla.com/D91106
2020-09-25 09:55:14 +00:00
Alexandre Poirot a326ee8f09 Bug 1663614 - Throttle resources on the client side from ResourceWatcher. r=jdescottes,bomsy
Because of this, in netmonitor stubs tests, the resource objects ends up loosing
"intermediate" state and now contains all information that we gathered by the time
we emit throttled resources.
The only way to address that would be to do an archived copy of each resource state,
but I don't think we want to do that...

Differential Revision: https://phabricator.services.mozilla.com/D89628
2020-09-24 11:04:57 +00:00
Alexandre Poirot 5406b6049d Bug 1663614 - Do not use EventEmitter API in ResourceWatcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90259
2020-09-24 07:11:18 +00:00