Aliased commands have not loaded the virtualenv associated with a
command/subcommand since bug 1695312. It has been defaulting to the
`common` virtualenv, which worked most of the time since most commands
use `common` and it also contains a large share of our dependencies.
Differential Revision: https://phabricator.services.mozilla.com/D192376
This is 20% faster on my setup, and according to llvm-mca, the IPC for
the false branch (which is the hottest one) goes from 3 to 5.7, thanks
to unrolling and conditional moves.
Basically, most of the bits of `bits` are generally set, so it's ok to do a
few more extra operations as we do them faster.
Differential Revision: https://phabricator.services.mozilla.com/D193366
This is 20% faster on my setup, and according to llvm-mca, the IPC for
the false branch (which is the hottest one) goes from 3 to 5.7, thanks
to unrolling and conditional moves.
Basically, most of the bits of `bits` are generally set, so it's ok to do a
few more extra operations as we do them faster.
Differential Revision: https://phabricator.services.mozilla.com/D193366
This is 20% faster on my setup, and according to llvm-mca, the IPC for
the false branch (which is the hottest one) goes from 3 to 5.7, thanks
to unrolling and conditional moves.
Basically, most of the bits of `bits` are generally set, so it's ok to do a
few more extra operations as we do them faster.
Differential Revision: https://phabricator.services.mozilla.com/D193366
When the injected code is used by elfhack, the debug info is thrown away
because elfhack doesn't know what to do with it, but in the case of
relrhack, the normal linker can handle it, so there's no reason not to
include the debug info anymore.
Differential Revision: https://phabricator.services.mozilla.com/D192904
When .rel.plt and .relr.dyn are the same size, after the section header
for .relr.dyn has been updated, it matches the condition for .rel.plt,
and we ended up undoing the change.
Differential Revision: https://phabricator.services.mozilla.com/D192981
Aliased commands have not loaded the virtualenv associated with a
command/subcommand since bug 1695312. It has been defaulting to the
`common` virtualenv, which worked most of the time since most commands
use `common` and it also contains a large share of our dependencies.
Differential Revision: https://phabricator.services.mozilla.com/D192376
`--enable-phc` builds firefox with PHC support. It's not enabled unless the
`phc` pref is also set. So this change will cause PHC support to ride the
trains, but in a disabled state.
Differential Revision: https://phabricator.services.mozilla.com/D188821
Some more recent fixes upstream unbroke cross-compiling the windows
compiler-rt, so we don't need the reversal patch anymore. We also don't
need it on clang 14 either because we don't build the windows
compiler-rt there.
Differential Revision: https://phabricator.services.mozilla.com/D189881
On ARM, lld places the .ARM.exidx section between .rel.dyn/.relr.dyn and
.rel.plt. This means we can't swap .relr.dyn and .rel.plt (well, we
could, if we also moved and rewrote the .ARM.exidx section, but that's
more work than we ought to do).
But we only need to swap the sections when we want the binary to be
compatible with older versions of glibc, which we don't care about on
desktop ARM Linux (we don't ship such builds), and don't need at all
on ARM Android. Ultimately, this is a bug in lld
(https://github.com/llvm/llvm-project/issues/68178).
Differential Revision: https://phabricator.services.mozilla.com/D190006
Setting them before the first call to check_compiler can fail when the
compiler doesn't recognize the flag for its default target and actively
errors out.
Differential Revision: https://phabricator.services.mozilla.com/D189861
Sprinter::jsprintf is nowadays the same as GenericPrinter::printf which Sprinter
inherit from. This patch removes all calls to Sprinter::jsprintf and replaces
them by Sprinter::printf.
The advantage of using GenericPrinter::printf is that this reduce the dependency
on Sprinter-specific interface and moves us toward being able to move more
consumers over to the GenericPrinter.
Differential Revision: https://phabricator.services.mozilla.com/D181500
The patch it reverted was causing problems while running tests with
ASan, but, from a try push, it seems those are not happening anymore.
Presumably, the issue was either fixed on the workers (whatever that
might have been), or in newer versions of clang.
Either way, we're not using clang 14 for ASan builds either, so we can
remove the patch from clang 14 too.
Differential Revision: https://phabricator.services.mozilla.com/D189908
The patch it reverted was causing problems while running tests with
ASan, but, from a try push, it seems those are not happening anymore.
Presumably, the issue was either fixed on the workers (whatever that
might have been), or in newer versions of clang.
Either way, we're not using clang 14 for ASan builds either, so we can
remove the patch from clang 14 too.
Differential Revision: https://phabricator.services.mozilla.com/D189908
Some more recent fixes upstream unbroke cross-compiling the windows
compiler-rt, so we don't need the reversal patch anymore. We also don't
need it on clang 14 either because we don't build the windows
compiler-rt there.
Differential Revision: https://phabricator.services.mozilla.com/D189881
Sprinter::jsprintf is nowadays the same as GenericPrinter::printf which Sprinter
inherit from. This patch removes all calls to Sprinter::jsprintf and replaces
them by Sprinter::printf.
The advantage of using GenericPrinter::printf is that this reduce the dependency
on Sprinter-specific interface and moves us toward being able to move more
consumers over to the GenericPrinter.
Differential Revision: https://phabricator.services.mozilla.com/D181500
We currently are using a fake bitflags 2, derived from bitflags 1. More
and more crates are using it, and we're at a sweet spot where flipping
things around makes sense: using a fake bitflags 1, derived from
bitflags 2.
Differential Revision: https://phabricator.services.mozilla.com/D189316
Old versions of llvm-readelf didn't have parens in its output for `-d`.
So instead of looking for parens, look for word boundaries.
Differential Revision: https://phabricator.services.mozilla.com/D188897
- D146664 is not needed anymore (something equivalent now landed upstream)
- One patch needs a small context adjustment
- Other patches need to be reverted because we already revert things
they depend on.
- We also disable a new warning about unversioned android target
fallback because it currently causes problems we'll fix later.
Differential Revision: https://phabricator.services.mozilla.com/D188669
Sprinter::jsprintf is nowadays the same as GenericPrinter::printf which Sprinter
inherit from. This patch removes all calls to Sprinter::jsprintf and replaces
them by Sprinter::printf.
The advantage of using GenericPrinter::printf is that this reduce the dependency
on Sprinter-specific interface and moves us toward being able to move more
consumers over to the GenericPrinter.
Differential Revision: https://phabricator.services.mozilla.com/D181500
Except when bootstrap is explicitly disabled. This means that on
--enable-release builds, we would now prefer previously bootstrapped
toolchains (but wouldn't bootstrap by default if they aren't there)
Differential Revision: https://phabricator.services.mozilla.com/D188315
Actually, Fenix's minimum is 21 even if 32-bit and Google Play Service has
discontinued 4.4 support. We would like to increase Lite's minimum API to 21
even if 32-bit.
Differential Revision: https://phabricator.services.mozilla.com/D187861
By attaching the #[link] to the function instead of the extern block,
rustc avoids adding libs that aren't used to the linker command line.
Differential Revision: https://phabricator.services.mozilla.com/D188312
Elfhack is the main reason we're not using lld on Linux/Android
shippable builds, because the way it works doesn't go well with how lld
lays out ELF binaries. By leveraging the linker itself (BFD and lld both
having recently gained the ability to generate the compact relocation
info themselves), we can achieve a similar result to what elfhack is
doing, while allowing to use lld.
See more in-depth background on https://glandium.org/blog/?p=4297
Differential Revision: https://phabricator.services.mozilla.com/D187089
Elfhack acts as a linker, and it uses the `elf_header` symbol to point
at the ELF header in the injected code that applies relocations.
Both GNU ld and lld expose a `__ehdr_start` symbol with the same meaning,
so rename the `elf_header` symbol for compatibility. This will allow to
reuse the code in the upcoming replacement for elfhack.
Differential Revision: https://phabricator.services.mozilla.com/D187088
Andreas Pehrson
Mike Hommey
ahochheiden
Cristian Tuns
serge-sans-paille
Natalia Csoregi
Mark Banner
Butkovits Atila
Norisz Fay
Sylvestre Ledru
Dennis Jackson
Sandor Molnar
Malte Juergens
Gregory Pappas
Rob Lemley
Sergey Galich
Paul Bone
Ray Kraesig
Emilio Cobos Álvarez
Nicolas B. Pierron
Cosmin Sabou
Narcis Beleuzu
Joel Maher
Iulian Moraru
Landry Breuil
Makoto Kato