This patch does remove the pageActionExtras experimental API, which is what started triggering
those errors after the pageAction manifest property was removed from the manifest in Bug 1690573:
- The pageActionExtras API was internally retrieving the pageAction API class
(see https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/extensions/report-site-issue/experimentalAPIs/pageActionExtras.js#12-16)
which is a bit of an hack and it used to work because there was a pageAction property in the
manifest.json file (and that was what used to guarantee that the ext-pageAction.js API module
was always loaded before the background page of the extension did have a chance to run)
- In Bug 1690573 we removed the pageAction property from the manifest and as a side-effect the
ext-pageAction.js module wouldn't be loaded anymore, which did break the assumption in
the pageActionExtras API (and the extension background page script as a side effect of that)
I assume that if we removed the pageAction from the manifest, then we don't need the pageActionExtras
experimental API neither (it seems that its purpose was to localize the pageAction and to set a custom
telemetry label for it) and so to fix the regression I opted to remove the remaining traces of the
pageActionExtras experimental API.
NOTE: there are some more traces left in head.js, which are used for the test cases.
All the tests are currently disabled and it seems that they are meant to be re-enabled
as part or as a follow up of Bug 1693119 and so I think that for those parts we can
wait to get there.
Differential Revision: https://phabricator.services.mozilla.com/D107326
We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it _is_ the right spot, we'll
probably do something a little more self-contained, and less hacky.
I'm leaving the old .properties file just in case we change our mind here.
Yes, we'll want to port to Fluent anyways, but our ultimate choice of where
we put this thing is probably going to dictate where the string lives.
Differential Revision: https://phabricator.services.mozilla.com/D104832
This also removes the queue loop at the end, because as far as I can tell that code was never run.
The loop was only entered if gaQueue was falsy (check in the first line), and if gaQueue was a
function (check just before the loop), which is unlikely to be true at the same time.
The uBlock Origin loop does have that loop, but it doesn't call the original function; the loop
calls the shim function, because uBlock Origin replaces window.ga with its shim function even
if window.ga is already defined.
Differential Revision: https://phabricator.services.mozilla.com/D101496
We will create the image using the selected position, and the canvas
will use the image coordinates, which have not been adjusted
for scrolling
Differential Revision: https://phabricator.services.mozilla.com/D100291
Remove calls to old heuristics, which are duplicated, improved, expanded, and balanced in the Fathom model. We'll come along in the next release and delete the dead code. We're leaving it in for now to keep it from bitrotting, in case we have to revert to it.
Differential Revision: https://phabricator.services.mozilla.com/D100141
We need it from both FormAutofillHeuristics and CreditCardRuleset, and it would make a circular import otherwise: FormAutofillHeuristics -> CreditCardRuleset -> FormAutofillHeuristics.
Differential Revision: https://phabricator.services.mozilla.com/D100140
This patch removes the code that saves screenshots, as that is no longer supported.
We remove the drawing canvas work in shooter.js to make this fission compatible.
This work is repeated in the background, so we should instead rely on that to handle
downloading and copying a screenshot, as well as previewing full page and the visible
parts of the page.
Differential Revision: https://phabricator.services.mozilla.com/D98285
This patch removes the code that saves screenshots, as that is no longer supported.
We remove the drawing canvas work in shooter.js to make this fission compatible.
This work is repeated in the background, so we should instead rely on that to handle
downloading and copying a screenshot, as well as previewing full page and the visible
parts of the page.
Differential Revision: https://phabricator.services.mozilla.com/D98285
This patch moves the following SVGs from browser to toolkit so that a subsequent
patch can load panel-icon-folder.svg and connection-mixed-active-loaded.svg from
toolkit. The other two SVGs are moved to minimize a change in CSS and JS.
- panel-icon-folder.svg
- panel-icon-magnifier.svg
- connection-mixed-active-loaded.svg
- connection-mixed-passive-loaded.svg
Differential Revision: https://phabricator.services.mozilla.com/D98699
This patch moves the following SVGs from browser to toolkit so that a subsequent
patch can load panel-icon-folder.svg and connection-mixed-active-loaded.svg from
toolkit. The other two SVGs are moved to minimize a change in CSS and JS.
- panel-icon-folder.svg
- panel-icon-magnifier.svg
- connection-mixed-active-loaded.svg
- connection-mixed-passive-loaded.svg
Differential Revision: https://phabricator.services.mozilla.com/D98699
This also adds the first threshold of 0.9 for YouTube, which allows us to avoid
hittest false positives on the PiP toggle when the user has one of the YouTube
player menus open.
Differential Revision: https://phabricator.services.mozilla.com/D93124
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.
This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.
Differential Revision: https://phabricator.services.mozilla.com/D94641
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.
This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.
Differential Revision: https://phabricator.services.mozilla.com/D94641
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Agi Sferro
Emma Malysz
Luca Greco
Oliver Pope
Mike Conley
Thomas Wisniewski
Dennis Schubert
Mark Banner
Brindusan Cristian
Markus Stange
Itiel
Razvan Maries
Erik Rose
Jim Mathies
Emilio Cobos Álvarez
Dorel Luca
Kartik Gautam
Butkovits Atila
Toshihito Kikuchi
Narcis Beleuzu
Ksenia Berezina
Gijs Kruitbosch
Nika Layzell
Zibi Braniecki
Karl Dubost
Ricky Stewart
Bogdan Tara