This patch does remove the pageActionExtras experimental API, which is what started triggering
those errors after the pageAction manifest property was removed from the manifest in Bug 1690573:
- The pageActionExtras API was internally retrieving the pageAction API class
(see https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/extensions/report-site-issue/experimentalAPIs/pageActionExtras.js#12-16)
which is a bit of an hack and it used to work because there was a pageAction property in the
manifest.json file (and that was what used to guarantee that the ext-pageAction.js API module
was always loaded before the background page of the extension did have a chance to run)
- In Bug 1690573 we removed the pageAction property from the manifest and as a side-effect the
ext-pageAction.js module wouldn't be loaded anymore, which did break the assumption in
the pageActionExtras API (and the extension background page script as a side effect of that)
I assume that if we removed the pageAction from the manifest, then we don't need the pageActionExtras
experimental API neither (it seems that its purpose was to localize the pageAction and to set a custom
telemetry label for it) and so to fix the regression I opted to remove the remaining traces of the
pageActionExtras experimental API.
NOTE: there are some more traces left in head.js, which are used for the test cases.
All the tests are currently disabled and it seems that they are meant to be re-enabled
as part or as a follow up of Bug 1693119 and so I think that for those parts we can
wait to get there.
Differential Revision: https://phabricator.services.mozilla.com/D107326
We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it _is_ the right spot, we'll
probably do something a little more self-contained, and less hacky.
I'm leaving the old .properties file just in case we change our mind here.
Yes, we'll want to port to Fluent anyways, but our ultimate choice of where
we put this thing is probably going to dictate where the string lives.
Differential Revision: https://phabricator.services.mozilla.com/D104832
Luca Greco
Mike Conley
Thomas Wisniewski