nasm doesn't like compiling x86_abi_support.asm
(https://bugzilla.nasm.us/show_bug.cgi?id=3392738), which is actually an
include file, rather than a source file, so it shouldn't have been in
the list of sources in the first place (libvpx has a similar file that
is excluded already, for instance).
I was considering updating the vendoring script, but it turns out it
doesn't produce the current contents in-tree (which even breaks the
build), and aom is set to be removed (bug 1635296)...
Differential Revision: https://phabricator.services.mozilla.com/D105430
Back when it was added, it was added to libvpx, and the clang base
version was older. Either newer version of clang fixed the issues or
the libvpx source fixed it, but we don't need the flag anymore for
libvpx.
The flag for libaom was cargo culted from libvpx, but may not have been
necessary in the first place. Or maybe it was, but things fixed
themselves in a similar manner. Either way, the flag is not necessary.
Differential Revision: https://phabricator.services.mozilla.com/D102262
Consequently, this removes:
- MOZ_LIBPRIO, which is now always enabled.
- non_msvc_compiler, which is now always true.
- The cl.py wrapper, since it's not used anymore.
- CL_INCLUDES_PREFIX, which was only used for the cl.py wrapper.
- NONASCII, which was only there to ensure CL_INCLUDES_PREFIX still
worked in non-ASCII cases.
This however keeps a large part of detecting and configuring for MSVC,
because we still do need it for at least headers, libraries, and midl.
Depends on D19614
Differential Revision: https://phabricator.services.mozilla.com/D19615
--HG--
extra : moz-landing-system : lando
There aren't any, and the code to actually convert them from .asm to gas
that is expected by the moz.build is not even there, so if there were
assembly sources, it would fail to build.
Depends on D14946
Differential Revision: https://phabricator.services.mozilla.com/D14947
--HG--
extra : moz-landing-system : lando
Includes changes to support nasm's stricter include paths.
Supports falling back to yasm if nasm is missing.
Differential Revision: https://phabricator.services.mozilla.com/D9972
--HG--
extra : moz-landing-system : lando
Recent changes made this a public header, so it needs to be
available to callers like AOMDecoder.
MozReview-Commit-ID: KKXcv8bdVYj
--HG--
extra : rebase_source : 87d509a40f3b305e414067af5ed433eef8489fbc
The configuration object is spelled with capitals. We didn't
try to build this code on Windows previously, so short-circuit
evaluation saved us from hitting the mistake.
MozReview-Commit-ID: FCGtHW8Dzlw
--HG--
extra : rebase_source : 70676bd436211aa65c7ea447b4aab4bbab61c27a
Propagate the libvpx AVX flag changes from bug 1279593.
This flag tells the compiler to generate AVX code
in these modules intead of using normal SSE instructions
which can trigger expensive state-switching.
NB: This should only be set for AVX-specific implementation
files; setting this flag for general code will invalidate
our runtime simd support checks.
MozReview-Commit-ID: 5BVeCTsNlup
--HG--
extra : rebase_source : 219b5912a220e960e45ec43a532f407fe18eb41b
Propagate the libvpx AVX flag changes from bug 1279593.
This flag tells the compiler to generate AVX code
in these modules intead of using normal SSE instructions
which can trigger expensive state-switching.
NB: This should only be set for AVX-specific implementation
files; setting this flag for general code will invalidate
our runtime simd support checks.
MozReview-Commit-ID: 5BVeCTsNlup
--HG--
extra : rebase_source : 219b5912a220e960e45ec43a532f407fe18eb41b
I had removed the USE_YASM define in porting the libvpx
moz.build to libaom, to avoid depending on VPX_USE_ASM.
Turns out USE_YASM is a magic context define, without which
the build won't compile libaom's yasm-format .asm files,
so we need to define it for the two intel architecture
source sets.
Restore the define unconditionally for intel targets.
We require yasm in the default build for those targets,
and want to fail if it isn't available to block performance
regressions.
MozReview-Commit-ID: CqGtY8RNLNf
--HG--
extra : rebase_source : ccc7f9dfc467642d9e4c623c55e54e769fb38f2f
We no longer support 32-bit x86 macOS, and
these flags point to configurations we
don't generate.
MozReview-Commit-ID: 3mIfHCf6aUj
--HG--
extra : rebase_source : 35b5089ade7f9d5d03e5f4d3f0760cc969b4b8c7
This is a port of the libvpx scripts, themselves a port of
Chromium's scripts to generate an external build description
using hooks in the upstream configure and make scripts.
The libaom library is a fork of libvpx so we can use a similar
approach.
I've put the upstream source in $(topsrc_dir)/third_party/aom
but the build description and any patches are under the media
directory with the other codecs, similar to how zlib works.
Config files and headers generated by the upstream build system
are also under $(topsrc_dir)/media/libaom/.
MozReview-Commit-ID: ATLgOTPD2i1
--HG--
extra : rebase_source : c0fdcdb41a5bac5fdf64f773458cb62937fc9dd8
Mike Hommey
Matthew Finkel
Tom Ritter
Thomas Daede
Christian Holler
Nathan Froyd
Dan Minor
David Major
Sylvestre Ledru
Chris Manchester
Ted Mielczarek
Ralph Giles
Carsten "Tomcat" Book