Nika Layzell
461b98ded0
Bug 1711090 - Part 3: Add some missing nsITimerCallback queryinterface targets, r=KrisWright,necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D115108
2021-05-18 20:45:17 +00:00
Alexandru Michis
08e0f3cf36
Backed out 4 changesets (bug 1711090) for causing bustages in nsTimerImpl.cpp
...
CLOSED TREE
Backed out changeset 5c6f0950714d (bug 1711090)
Backed out changeset 0b6a886eea8a (bug 1711090)
Backed out changeset fc9c788ff41d (bug 1711090)
Backed out changeset ecc51d9ad027 (bug 1711090)
2021-05-18 20:25:56 +03:00
Nika Layzell
2eead824d8
Bug 1711090 - Part 3: Add some missing nsITimerCallback queryinterface targets, r=KrisWright,necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D115108
2021-05-18 16:24:48 +00:00
Paul Bone
6191ca4916
Bug 1709526 - Fix all the lint errors for .ini files in dom/ r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D114321
2021-05-06 01:29:31 +00:00
Emilio Cobos Álvarez
5e03d6a488
Bug 1704651 - Wait for the right load in ClientOpenWindow. r=asuth
...
With fission+BFCache, we get a notification for the initial document,
and that fails the same-origin check (because about:blank isn't
same-origin with the opener) so we resolve the promise with null
rather than returning a client.
Instead, wait for the right load to arrive if the top level window
global is the initial document.
Differential Revision: https://phabricator.services.mozilla.com/D112072
2021-04-16 23:38:42 +00:00
Butkovits Atila
a8051422a4
Backed out changeset b099dbba4587 (bug 1704651) for causing leackcheck failures. CLOSED TREE
2021-04-15 18:49:25 +03:00
Emilio Cobos Álvarez
0677a9ec85
Bug 1704651 - Wait for the right load in ClientOpenWindow. r=asuth
...
With fission+BFCache, we get a notification for the initial document,
and that fails the same-origin check (because about:blank isn't
same-origin with the opener) so we resolve the promise with null
rather than returning a client.
Instead, wait for the right load to arrive if the top level window
global is the initial document.
Differential Revision: https://phabricator.services.mozilla.com/D112072
2021-04-15 12:11:02 +00:00
Tim Huang
45630a2d30
Bug 1695050 - Part 4: Update the call-sites of CookieJarSettings::Create() for ServiceWorker and Worker. r=asuth
...
This patch updates all call-sites of CookieJarSettings::Create() to pass
the principal for ServiceWorker and Worker.
Differential Revision: https://phabricator.services.mozilla.com/D109047
2021-03-29 11:01:52 +00:00
Doug Thayer
ec23c3ca31
Bug 1693133 - Fix resetProfile.xhtml tests r=Gijs
...
BrowserTestUtils.promiseAlertDialog and friends account for commonDialog.xhtml,
but not other dialogs which go through gDialogBox. This fixes that by adding a
inWindowDialog option to promiseAlertDialog. I don't like this solution very
much - it requires all of these dialogs to fire the event themselves. An
alternative might be putting this code in some file which these all include,
but given how small the code is that feels like overkill. Alternatives welcome.
Differential Revision: https://phabricator.services.mozilla.com/D109674
2021-03-25 17:28:56 +00:00
Simon Giesecke
613e20d136
Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
Simon Giesecke
022093b8c4
Bug 708901 - Migrate to nsTHashSet in dom/serviceworkers. r=dom-worker-reviewers,janv
...
Depends on D109323
Differential Revision: https://phabricator.services.mozilla.com/D109324
2021-03-23 10:36:38 +00:00
Simon Giesecke
4ff9d15889
Bug 1634281
- Use nsBaseHashtable::GetOrInsertNew where possible. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D106491
2021-03-03 08:58:52 +00:00
Simon Giesecke
0b443059fd
Bug 1693306 - Simplify some uses of LookupOrInsertWith by GetOrInsertNew. r=xpcom-reviewers,necko-reviewers,dragana,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D105479
2021-02-26 09:22:54 +00:00
Simon Giesecke
9af107a839
Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.
Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Simon Giesecke
4f75368dcb
Bug 1691913 - Rename nsBaseHashtable::GetOrInsert(With) to LookupOrInsert(With). r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
...
The functions should be called "Lookup" rather than "Get" because they return
a DataType& (rather than UserDataType).
Differential Revision: https://phabricator.services.mozilla.com/D105472
2021-02-26 09:11:45 +00:00
Kris Maglione
f508b30e41
Bug 1403348: Follow-up: Remove crash annotations for AsyncShutdown load failures. r=mccr8
...
They've done their job. It's clear at this point that these failures are
happening because of omni.ja corruption.
Differential Revision: https://phabricator.services.mozilla.com/D105834
2021-02-23 20:18:13 +00:00
smolnar
c245e071f7
Backed out changeset 7c67e3cb1ded (bug 1403348) for causing xpc failures in AsyncShutdown. CLOSED TREE
2021-02-23 02:17:08 +02:00
Kris Maglione
9e57d6f966
Bug 1403348: Follow-up: Remove crash annotations for AsyncShutdown load failures. r=mccr8
...
They've done their job. It's clear at this point that these failures are
happening because of omni.ja corruption.
Differential Revision: https://phabricator.services.mozilla.com/D105834
2021-02-22 21:37:28 +00:00
Simon Giesecke
d2caea36fa
Bug 1691894 - Simplify uses of WithEntryHandle that only use OrInsert(With) by using GetOrInsertWith. r=xpcom-reviewers,necko-reviewers,jgilbert,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D104676
2021-02-22 12:07:46 +00:00
Alexis Beingessner
719dd81cbb
Bug 1686616 - make ServiceWorkerManager use Components instead of Services. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D105527
2021-02-18 13:26:31 +00:00
Simon Giesecke
661e25bf09
Bug 1692880 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-16 15:53:33 +00:00
Simon Giesecke
330a65a7de
Bug 1692996 - Remove redundant nullptr checks of return value of infallible new in dom/serviceworkers. r=dom-worker-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D105289
2021-02-16 15:52:09 +00:00
smolnar
1afbbe67e1
Backed out 5 changesets (bug 1691894) for causing hazard failures in nsXULPrototypeCache. CLOSED TREE
...
Backed out changeset 22dc870ee609 (bug 1691894)
Backed out changeset 58c31e9d6ae3 (bug 1691894)
Backed out changeset 7483e84149d8 (bug 1691894)
Backed out changeset f977d6cfa973 (bug 1691894)
Backed out changeset db4503476f34 (bug 1691894)
2021-02-15 16:43:23 +02:00
Simon Giesecke
3c29a68440
Bug 1691894 - Make Put accept DataType instead of wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D104850
2021-02-15 10:04:46 +00:00
Simon Giesecke
d092a59dcd
Bug 1691894 - Replace use of GetOrInsert by WithEntryHandle. r=dom-worker-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D104675
2021-02-12 15:25:40 +00:00
Simon Giesecke
f701c44a5c
Bug 1691894 - Fix EntryHandle to only work with DataType rather than wrapping UserDataType. r=xpcom-reviewers,necko-reviewers,nika,jonco,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D104810
2021-02-12 15:25:40 +00:00
Simon Giesecke
fbfee61619
Bug 1688833 - Change remaining references to LookupForAdd to WithEntryHandle and remove LookupForAdd. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D104400
2021-02-09 18:19:47 +00:00
Simon Giesecke
815d5d72c3
Bug 1688833 - Migrate LookupForAdd to WithEntryHandle in dom/serviceworkers. r=dom-worker-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D104192
2021-02-09 18:19:46 +00:00
Nika Layzell
86a03e6701
Bug 1689147 - Part 5: Change comparable to an extended attribute, r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D103370
2021-02-09 16:50:23 +00:00
Andrew Sutherland
12ecea23a3
Bug 1558486
- remove abandoned, archaic test_client_focus.html test r=dom-worker-reviewers,sg
...
Per Perry's analysis in
https://bugzilla.mozilla.org/show_bug.cgi?id=1558486#c3 and my
independent rediscovery of Bug 1144660 having disabled/broken it when
:julienw raised the issue of the test appearing broken, the test file
which is not covered by any mochitest.ini and is missing its support
files should be removed.
Differential Revision: https://phabricator.services.mozilla.com/D103964
2021-02-04 11:16:51 +00:00
Emilio Cobos Álvarez
635e3580e3
Bug 1655967 - Move serviceWorkersTestingEnabled to BrowsingContext. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D103757
2021-02-03 10:38:43 +00:00
Luca Greco
3ba66d4d86
Bug 1678927 - Expect non http channel in ServiceWorkerScriptCache CompareNetwork::OnStreamComplete. r=asuth,mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D100343
2021-01-19 15:27:46 +00:00
Aaron Klotz
48a50615fb
Bug 1682987: Unconditionally return true from ServiceWorkerParentInterceptEnabled; r=dom-workers-and-storage-reviewers,asuth
...
The [current implementation](https://searchfox.org/mozilla-central/rev/c7cf087b6e1384608ca3989f042f12f7cabd0a5f/dom/serviceworkers/ServiceWorkerUtils.cpp#25 )
of `ServiceWorkerParentInterceptEnabled` uses two atomics to load the
`dom.serviceWorkers.parent_intercept` pref.
As-is, there is a slight chance that this function could return a false-negative,
given that `sInitialized` is set to `true` before `sEnabled` is set.
Per asuth, we now unconditionally return `true`.
Differential Revision: https://phabricator.services.mozilla.com/D99957
2021-01-12 23:12:53 +00:00
Kartik Gautam
7ae6aea145
Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
Cosmin Sabou
2978aa00a3
Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD
2020-12-28 00:43:51 +02:00
Kartik Gautam
775cdec032
Bug 1684173 - Add newline character at end of files when missing r=sylvestre
...
Depends on D100443
Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
Kartik Gautam
f7ffcd09fb
Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-15 10:34:54 +00:00
Simon Giesecke
b9d6edb0d7
Bug 1673424 - Fix includes in RefMessageBodyService.h and PromiseWorkerProxy.h. r=kmag
...
Specifically, remove the include of StructuredCloneHolder.h from
RefMessageBodyService.h, and that of WorkerRunnable.h from PromiseWorkerProxy.h
and add other required includes instead.
Differential Revision: https://phabricator.services.mozilla.com/D94764
2020-12-14 15:59:56 +00:00
Dorel Luca
7320ae982a
Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE
2020-12-13 16:38:21 +02:00
Kartik Gautam
caf549c200
Bug 1679758 - Remove trailing empty lines r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-13 13:28:30 +00:00
Simon Giesecke
4cab6ac723
Bug 1677466 - Move ParamTraits specializations with extra dependencies out of IPCMessageUtils.h. r=mccr8
...
This moves parts of IPCMessageUtils.h to two new header files and adapts
the include directives as necessary. The new header files are:
- EnumSerializer.h, which defines the templates for enum serializers
- IPCMessageUtilsSpecializations.h, which defines template specializations
of ParamTraits with extra dependencies (building upon both IPCMessageUtils.h
and EnumSerializer.h)
This should minimize the dependencies pulled in by every consumer of
IPCMessageUtils.h
Differential Revision: https://phabricator.services.mozilla.com/D94459
2020-12-10 11:09:21 +00:00
Simon Giesecke
8c2c2388e6
Bug 1679273 - Fix bustage when building without MOZ_GECKO_PROFILER. r=gerald
...
Differential Revision: https://phabricator.services.mozilla.com/D97966
2020-12-07 14:21:28 +00:00
Simon Giesecke
1c53236b70
Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
Simon Giesecke
5bfbb2a572
Bug 1673931
- Avoid including Document.h from header files. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D95046
Depends on D95045
2020-11-23 16:07:43 +00:00
Simon Giesecke
6f7b6986d5
Bug 1673424 - Fix includes around StructuredCloneData.h.
...
Differential Revision: https://phabricator.services.mozilla.com/D94763
Depends on D94762
2020-11-23 16:07:01 +00:00
Simon Giesecke
fb7f3afbc4
Bug 1660470 - Avoid including ServiceWorkerIPCUtils.h from header files. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D93555
Depends on D93552
2020-11-23 16:05:38 +00:00
Simon Giesecke
252f99be51
Bug 1660470 - Avoid including ErrorIPCUtils.h from header files. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D93243
Depends on D93242
2020-11-23 16:04:28 +00:00
Simon Giesecke
971b645fe3
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Nika Layzell
43b599baf6
Bug 1603340 - Disable browser_force_refresh.js under verify, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D95892
2020-11-12 18:01:08 +00:00
Nika Layzell
42028efc71
Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
...
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.
This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.
Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00