Граф коммитов

29 Коммитов

Автор SHA1 Сообщение Дата
Geoff Brown 8eb29268ad Bug 1146690 - Enable layout/reftests/margin-collapsing/block-float-1b.html on Android 4.3; r=me 2016-02-26 14:01:11 -07:00
L. David Baron bb57d7d42e Bug 451791 patch 2 - Report block non-empty to its parent block during margin collapsing if we encounter clearance. r=roc
The goal of ComputeCollapsedBStartMargin is to collapse all of the
margins that collapse with a block's top margin.  It does this by
scanning forward through the child list until it finds something that
blocks collapsing; it descends into children through recursion.  When we
find a non-empty block or line, we stop collapsing and report to the
parent that the child is non-empty so that it stops collapsing as well.

This patch changes our behavior when we have clearance to do the same
thing that we do for non-empty lines or blocks (which makes both
occurrences of |goto done| be preceded by the same code).  Without the
patch we would fail to report being non-empty to the parent (and instead
report emptiness based on the IsEmpty() method).  This meant that,
without the patch, if a block has a child with clearance but also has
IsEmpty() true, we would stop scanning margins in that block after the
clearance, but start searching again for margins in the block's parent,
starting with the block's bottom margin.  This patch sets *aBlockIsEmpty
to true in that case so that we do not pick up again in the block's
parent (or, potentially, grandparent, etc.).

--HG--
extra : commitid : LCMTvXvZT3G
2015-08-05 21:04:38 -07:00
Geoff Brown 24b2cd5f48 Bug 1140148 - Update reftest manifests for Android 4.3 emulator; r=dminor 2015-03-24 06:51:45 -06:00
Alexandre Lissy e8b4f395c0 Bug 1138442 - Disable reftests on Mulet in parity with B2G/B2G Desktop. r=ahal 2015-03-10 02:43:00 +01:00
CJKu 9691cf3136 Bug 1000722 - Rollback close reftest in bug 981477. r=ahal 2014-06-24 10:20:00 -04:00
Vincent Chen c53b5f77a8 Bug 981477 - Disable B2G emulator reftests that fail oop, r=ahal 2014-05-23 15:56:15 -04:00
Daniel Schattenkirchner 9788bb556c Bug 921761 - margin-collapsing test suite, wave 8; dynamic and additional cases for margins of a BFC; Multi-column margins; margins given in percent and em; r=dholbert
--HG--
rename : layout/reftests/margin-collapsing/block-abs-pos-1.html => layout/reftests/margin-collapsing/block-abs-pos-1-dyn.html
rename : layout/reftests/margin-collapsing/block-abs-pos-2.html => layout/reftests/margin-collapsing/block-abs-pos-2-dyn.html
rename : layout/reftests/margin-collapsing/block-float-1a.html => layout/reftests/margin-collapsing/block-float-1a-dyn.html
rename : layout/reftests/margin-collapsing/block-float-1b.html => layout/reftests/margin-collapsing/block-float-1b-dyn.html
rename : layout/reftests/margin-collapsing/block-float-2a.html => layout/reftests/margin-collapsing/block-float-2a-dyn.html
rename : layout/reftests/margin-collapsing/block-float-2b.html => layout/reftests/margin-collapsing/block-float-2b-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-1a.html => layout/reftests/margin-collapsing/block-no-content-1a-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-1b.html => layout/reftests/margin-collapsing/block-no-content-1b-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-1c.html => layout/reftests/margin-collapsing/block-no-content-1c-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-2a.html => layout/reftests/margin-collapsing/block-no-content-2a-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-2b.html => layout/reftests/margin-collapsing/block-no-content-2b-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-2c.html => layout/reftests/margin-collapsing/block-no-content-2c-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-2d.html => layout/reftests/margin-collapsing/block-no-content-2d-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-3.html => layout/reftests/margin-collapsing/block-no-content-3a-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-3.html => layout/reftests/margin-collapsing/block-no-content-3a.html
rename : layout/reftests/margin-collapsing/block-no-content-4.html => layout/reftests/margin-collapsing/block-no-content-4a-dyn.html
rename : layout/reftests/margin-collapsing/block-no-content-4.html => layout/reftests/margin-collapsing/block-no-content-4a.html
rename : layout/reftests/margin-collapsing/block-overflow-1.html => layout/reftests/margin-collapsing/block-overflow-1-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-2.html => layout/reftests/margin-collapsing/block-overflow-2-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-3.html => layout/reftests/margin-collapsing/block-overflow-3-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-4.html => layout/reftests/margin-collapsing/block-overflow-4-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-5a.html => layout/reftests/margin-collapsing/block-overflow-5a-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-5b.html => layout/reftests/margin-collapsing/block-overflow-5b-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-5c.html => layout/reftests/margin-collapsing/block-overflow-5c-dyn.html
rename : layout/reftests/margin-collapsing/block-overflow-5d.html => layout/reftests/margin-collapsing/block-overflow-5d-dyn.html
rename : layout/reftests/margin-collapsing/block-percent-1.html => layout/reftests/margin-collapsing/block-percent-1-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-child-1.html => layout/reftests/margin-collapsing/fieldset-child-1-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-1a.html => layout/reftests/margin-collapsing/fieldset-sibling-1a-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-1b.html => layout/reftests/margin-collapsing/fieldset-sibling-1b-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-1c.html => layout/reftests/margin-collapsing/fieldset-sibling-1c-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-2a.html => layout/reftests/margin-collapsing/fieldset-sibling-2a-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-2b.html => layout/reftests/margin-collapsing/fieldset-sibling-2b-dyn.html
rename : layout/reftests/margin-collapsing/fieldset-sibling-2c.html => layout/reftests/margin-collapsing/fieldset-sibling-2c-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-child-1.html => layout/reftests/margin-collapsing/inline-block-child-1-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-child-2.html => layout/reftests/margin-collapsing/inline-block-child-2-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-sibling-1a.html => layout/reftests/margin-collapsing/inline-block-sibling-1a-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-sibling-1b.html => layout/reftests/margin-collapsing/inline-block-sibling-1b-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-sibling-1c.html => layout/reftests/margin-collapsing/inline-block-sibling-1c-dyn.html
rename : layout/reftests/margin-collapsing/inline-block-sibling-2.html => layout/reftests/margin-collapsing/inline-block-sibling-2-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-1a.html => layout/reftests/margin-collapsing/table-caption-1a-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-1b.html => layout/reftests/margin-collapsing/table-caption-1b-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-2a.html => layout/reftests/margin-collapsing/table-caption-2a-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-2b.html => layout/reftests/margin-collapsing/table-caption-2b-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-2c.html => layout/reftests/margin-collapsing/table-caption-2c-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-bottom-1.html => layout/reftests/margin-collapsing/table-caption-bottom-1-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-bottom-2.html => layout/reftests/margin-collapsing/table-caption-bottom-2-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-top-1.html => layout/reftests/margin-collapsing/table-caption-top-1-dyn.html
rename : layout/reftests/margin-collapsing/table-caption-top-2.html => layout/reftests/margin-collapsing/table-caption-top-2-dyn.html
2014-03-04 14:09:37 -08:00
Daniel Schattenkirchner 1adfb86364 Bug 921761 part 2 - margin-collapsing test suite; rearrange tests in reftest.list and add comments; r=dholbert 2013-10-15 17:37:11 -07:00
Daniel Schattenkirchner d66537afa0 Bug 921761 part 1 - margin-collapsing test suite, wave 7; improving tests by adding readable IDs, rearranging styles, changing colors; r=dholbert 2013-10-15 17:37:03 -07:00
Daniel Schattenkirchner 06df61b3db Bug 477462 - margin-collapsing test suite, wave 6; parent's and last-child's bottom margin with min-/max-/height. r=dholbert 2013-09-14 22:16:53 -04:00
Daniel Schattenkirchner cfc22cc223 Bug 477462 - margin-collapsing test suite, wave 5b; root, html, body margins and non-sibling margins; r=dholbert 2013-08-26 21:27:49 -10:00
Andrew Halberstadt 221179f50b Bug 811779 - Enable larger set of reftests on B2G emulators, r=jgriffin 2013-01-03 15:35:01 -05:00
Daniel.S a90b66c464 Bug 477462 - margin-collapsing test suite, wave 5a; dynamic and != tests for negative sibling margins; r=dbaron 2012-11-20 15:15:42 -08:00
Mats Palmgren c3fee3748b Bug 750293 - Don't include a block's margins in its scrollable overflow for now. r=roc 2012-05-17 01:04:38 +02:00
Mats Palmgren c101f77175 Bug 724352 - Don't add vertical margin to scrollable overflow here, it's already done during reflow and we don't need it for UpdateOverflow yet (and we need to account for margin-collapsing when we do). r=roc 2012-04-05 16:30:21 +02:00
Mats Palmgren bea763f11f Bug 665597 - Fix some reftests assumptions about margins and scrollable overflow. part=5/5 r=dbaron,roc 2012-01-17 00:38:10 +01:00
Benoit Girard 3805b3cd62 Bug 691354 - Enable test fix by changes. r=jmuizelaar 2011-10-17 13:09:03 -07:00
Ehsan Akhgari 4b84fe41d5 Bug 659828 - Part 1: Apply table margins to the outer table frame instead of the inner table frame (also fixes bug 87277); r=dbaron
Outer table frames act as CSS2.1 table wrapper boxes.  We used to lay them out
without taking their margins into the account, which meant that their width was
always equal to the available width.  This breaks horizontal positioning of
absolutely positioned kids of a table frame.

The main purpose of this patch is to apply the margins of tables to their outer
frame, instead of the inner frame.  This means that the inner table frame will
always have a zero margin, which means that a lot of the stuff which used to
rely on the fact that table margins are applied to the inner frame need to
change.

In particular, in order to get the computed margins of a table, we used to query
the inner table frame, and this patch corrects that.  Also, when shrink wrapping
tables, we used to not take the margins of the inner table frame into account,
which is fixed by this patch too.  nsBlockReflowState::
ComputeReplacedBlockOffsetsForFloats also needed to be changed to read the
margin values from the outer frame too.

Also, as part of this patch, we start to respect the CSS2.1 margin model for
captions on all sides.  This means that in particular, the top/bottom margins on
the top-outside and bottom-outside captions will not be collapsed with the
top/bottom margins of the table, and that the margins of the caption element
contribute to the width and height of the outer table frame.  The
427129-table-caption reftest has been modified to match this new behavior.

Another side effect of this bug is fixing bug 87277, and the reftests for that
bug are marked as passing in this patch.
2011-05-31 19:02:56 -04:00
Benoit Girard 55511ee95e Bug 676831 - Mark Android OpenGL Reftest failures for regression testing. r=joe
--HG--
extra : rebase_source : b5458fa13fc6277560eb0ebc3e4e31f6c04b4e6c
2011-09-19 13:05:15 -07:00
Jonathan Kew 69863cb1b2 Bug 661471. Part 5: Fix reftests. r=roc 2011-06-03 16:31:08 +12:00
Daniel.S 695f80cd69 Bug 477462 - margin-collapsing test suite, wave 4: dynamic horizontal, block, table, caption sibling margins. r=dbaron
--HG--
extra : rebase_source : 2768fbfd11770d9f72edd70d7828b4f4f5ac9ae0
2011-05-21 22:05:43 +02:00
Jesse Ruderman d1b6c0a0f6 Add reftest for bug 467321 2009-10-15 12:18:37 -07:00
Jonathan Kew 27a7a54dc2 Bug 518357, make reftests less sensitive to default font size settings. r=roc
--HG--
extra : rebase_source : 1914dd5f2998a2f45e10ccf3574d854ba9240f52
2009-09-23 15:55:55 +01:00
Daniel.S 7bb22adca4 Bug 477462: Create tests for margin collapsing, phase 3. r=dbaron 2009-08-14 14:59:45 -07:00
Bernd d0faab8b9c adopt caption vertical margins to latest CSS2.1 revision, bug 478614, r/sr=dbaron 2009-06-28 15:51:46 +02:00
Daniel.S 72a33e18d3 Bug 477462 - Add margin-collapsing tests (part 2): horizontal margins, tables, captions, fieldsets and some suggested tests. r+sr=dbaron 2009-05-26 20:24:25 +02:00
Robert O'Callahan c2948e945e Fix bustage #3 2009-04-25 21:38:35 +12:00
Daniel.S a0e84ca6c3 Bug 477462. Add many margin-collapsing reftests. r+sr=dbaron
--HG--
extra : rebase_source : 7ae1e9d247225b11cf6468bd0334ccd80f86db8c
2009-04-25 20:50:57 +12:00
Daniel.S 9d890d53c0 Bug 477462 - create an extensive reftest suite for margin(-collapsing); create basic infrastructure, for checkin; r=dbaron 2009-02-16 16:27:11 +01:00