c50a2c3b1f
Bug 497495 (frame poisoning) part 2: Introduce nsIPresShell::AllocateMisc/FreeMisc functions; add an as-yet-unused "code" parameter to AllocateFrame/FreeFrame; fix up nsFrame to match; use AllocateMisc/FreeMisc for all non-frame pres arena objects; move clearing of frame objects from nsFrame::operator new to AllocateFrame. r=roc sr=dbaron
2009-08-17 20:21:06 -07:00
08e90a1a5b
Make lines with only a bullet take up height. (Bug 179596 / Bug 507187) r=roc
2009-08-10 19:48:42 -07:00
1816bcdd46
Bug 499377 - Store float region on frame r+sr=roc
2009-07-14 22:19:31 -07:00
2f713cb3b1
Bug 491415. Need to initialize this member so we don't report bogus ascents. r+sr=roc
2009-05-05 01:01:47 -04:00
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
f6824a9fa5
Replace space manager with a more limited float manager. (Bug 191448) r+sr=roc
...
--HG--
rename : layout/generic/nsSpaceManager.cpp => layout/generic/nsFloatManager.cpp
rename : layout/generic/nsSpaceManager.h => layout/generic/nsFloatManager.h
2009-01-04 19:39:54 -05:00
ae14b3d6aa
Relanding bug 461410 - nsILineIterator is never used outside of layout - set nsresults to replicate the existing code more correctly, which fixes the mochitest failures, r+sr=roc with nits noted by Mats Palmgren
2008-10-30 12:17:59 -07:00
292d44b1a8
Backed out changeset d4c9a0776667 (deCOM nsILineEnumerator) due to regression from it or bug 461212
2008-10-28 02:49:14 -04:00
87c2e7ef23
Bug 461410 - nsILineIterator is never used outside of layout, and doesn't need to be refcounted: the callers can just destroy it when they're done with it. We can't do this with a virtual destructor, however, because nsTableRowGroupFrame implements the interface directly, while nsLineIterator is a separately-allocated class. So clients are expected to call DisposeLineIterator when they're done with it.
...
Instead of accessing nsILineIterator using QueryInterface, we add a nsIFrame::GetLineIterator API, which is cleaner and more efficient all at the same time!
r+sr=roc
2008-10-28 00:47:19 -04:00
5338360abe
Bug 411870. nsBidiPresUtils needs to track the current line across block continuation boundaries. r=smontagu
2008-01-29 15:39:39 -08:00
72c72d1d33
Bug 411870 backout again
2008-01-28 11:10:26 -08:00
ef12785f4c
Bug 411870. Bidi resolution needs to scan through block continuations when tracking the current line for frames. r=smontagu
2008-01-28 10:16:22 -08:00
cc8a28fdd6
backing out 411870
2008-01-27 22:28:31 -08:00
fbf20e6e5d
Bug 411870. Make bidi resolution track lines across block continuation boundaries. r=smontagu
2008-01-27 21:07:14 -08:00
a2e1cce21c
[DEBUG-only] Print a warning if we find a null float in the float cache. b=387651 r+sr=roc
2007-07-22 06:37:36 -07:00
fdc82745ab
Fix printf format-specifier and args mismatch to prevent potential DEBUG-only crashes. bug 388358, r+sr=roc
2007-07-16 15:26:53 -07:00
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
5fe6149b7e
Bug 383551. Clean up IsInlineFrame, nsStyleDisplay::IsBlockLevel and related methods. r+sr=dbaron
2007-06-26 19:31:35 -07:00
2c2399e327
Bug 381385: get rid of unneeded members of nsFloatCache (saves about 50 bytes footprint per float). r+sr=roc.
2007-06-16 13:27:46 -07:00
eeaa1a101b
Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc.
2007-03-30 14:11:41 -07:00
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
ed6210be3f
Leave the placeholder's pointer to the out-of-flow intact because the float cache depends on it later on. b=348688 r=bzbarsky sr=roc
2006-08-17 13:15:26 +00:00
8c0e3dd5b7
Handle returning nulls from CheckLineOrder correctly. bug=345616 r=smotagu sr=roc
2006-08-04 05:40:57 +00:00
c19fb04fdf
Bug 342479: fix compiler warning @ nsFloatCacheList::RemoveAndReturnPrev in nsLineBox.cpp, patch by Ryan VanderMeulen <ryanvm@gmail.com>, r+sr=roc
2006-07-24 18:57:42 +00:00
3a9a287253
Bug 344050: Kill nsITextContent and move the methods to nsIContent. r/sr=jst
2006-07-19 04:36:36 +00:00
672343880e
Bug 342322. It's OK for mNext to be non-null when we remove an element. r+sr=dbaron
2006-07-13 08:15:31 +00:00
6f21109f82
Always use the visual iterator when moving visually in a bidi page, even if the current line or adjacent lines are LTR. bug=309432 r=smontagu sr=roc
2006-07-12 11:22:18 +00:00
a42c58298b
relanding fix for bug 317278 :-(
2006-06-29 01:19:48 +00:00
1621ac24bd
Bug 237085. Move string subdivision code to gfx so we can efficiently make it metrics-dependent. r=smontagu,sr=rbs
2006-06-26 22:18:23 +00:00
ab87d3edb5
Bug 317278. Reland patch that reflows lines again if we detect some already-placed floats need to move to the next line. This time, with changes to nsSpaceManager's PushState/PopState infrastructure so that dynamic allocations are never required; the saved state is always stack-allocated by callers. r+sr=dbaron
2006-06-19 23:06:59 +00:00
ed0bc93ff0
Backing out patch for 317278 due to Tp regression
2006-06-19 01:29:07 +00:00
cc52ece1a1
Bug 317278. In some cases we push float placeholders from one line to the next after we have already placed their floats on the line. In such situations, reset the space manager and force the line to reflow again so those floats don't get placed. r+sr=dbaron
2006-06-19 00:02:49 +00:00
6e1f1e3dfc
Allow searching a line for a frame starting from a given point, to improve performance of forward-moving searches. Used in bidi resolution. bug=339935, r+sr=roc
2006-06-08 08:41:51 +00:00
678511471c
Bustage fix (bug 337883)
2006-05-25 01:48:00 +00:00
a5a64a9fb9
Clear the float cache from placeholders that are descendants of the frame we remove. b=337883 r+sr=roc
2006-05-25 01:30:34 +00:00
44d201a532
Don't mess with empty float cache lists. Bug 334105, r+sr+branch181=dbaron
2006-04-17 01:47:11 +00:00
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
04b8c33eda
Remove uses of MOZ_DECL_CTOR_COUNTER, which is always defined to nothing. b=332745 rs=roc,bzbarsky
2006-04-05 00:00:44 +00:00
0e88f73bc6
Single line comments to describe files (helpful in LXR)
2006-03-29 18:29:03 +00:00
a52c79e7ad
Bug 330881: Crash when double-clicking in empty area inside isindex with position:absolute;direction:rtl;. r+sr=roc
2006-03-20 09:20:49 +00:00
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
1003ca6dd4
Do away with geometry in nsFrameList::GetPrev[Next]VisualFor() and nsLineIterator::CheckLineOrder(). Instead use new helper methods in nsBidiPresUtils for determining visual order of the top level of frames in a line. bug=303884 r=smontagu sr=roc
2006-03-12 09:49:48 +00:00
f132edee94
Bug 256311. Improve block reflow performance in the presence of many empty lines, by being more aggressive about caching block and line emptiness state, and by stashing a reference to a line that we know has nothing but empty lines above it. Relanding because I accidentally backed it out. r+sr=dbaron
2006-02-27 04:15:05 +00:00
bde356f1f5
Backing out changes for bug 326944.
2006-02-27 03:22:03 +00:00
e344f390f8
Bug 256311. Improve block reflow performance in the presence of many empty lines, by being more aggressive about caching block and line emptiness state, and by stashing a reference to a line that we know has nothing but empty lines above it. r+sr=dbaron
2006-02-27 02:51:57 +00:00
c2d981f764
bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
...
r+sr=darin
2006-02-03 14:18:39 +00:00
41432ddbee
Caret skips blank line using down-arrow key in preformatted text (e.g. View Source). Bug 298690, patch by Uri Bernstein <uriber@gmail.com>, r+sr=roc
2005-10-30 13:05:45 +00:00
04153159a6
Fix some nsFloatCache leaks. Bug 302438, r+sr=dbaron
2005-10-21 22:23:28 +00:00
f246fa2bbd
Bug 280987. Remove aPresContext from nsIFrameDebug::List. r+sr=roc, patch by Vidar Braut Harr.
2005-09-06 21:34:50 +00:00
b4d01d069d
Bug 277553 clicking on Textarea with a RTL direction doesnt work
...
patch by uriber@gmail.com r=bz sr=bz a=bsmedberg
2005-08-02 21:55:55 +00:00
87c224f2cb
Bug 263825. Make paginated floats work, and other fixes. r+sr=dbaron
2005-03-23 03:35:08 +00:00
13a6502805
Bug 209694. Major rework of margin-collapsing and clearance to match CSS 2.1 rules. Also includes major incremental reflow fixes for those situations. See the bug for details. rubber-stamp r+sr=dbaron
2004-11-25 14:51:00 +00:00
917ba5cead
Bug 269905. Remember emptiness state on line boxes, but be selective about to to minimize the invalidation burden. r+sr=dbaron
2004-11-24 13:22:10 +00:00
c9f4947a85
Bug 257612. Fix dynamic margin changes by 1) Propagate IsPreviousMarginDirty through empty lines 2) Reflow any line whose previous margin is dirty. 3) If a reflowed line could have been tested in a subsequent line's ShouldApplyTopMargin both before and after reflow, and might have been empty before or after reflow, then make the next line's previous margin dirty. 4) If reflowing a block changes its carried-out margin, then mark the next line's previous margin dirty. r+sr=dbaron
2004-09-18 14:39:07 +00:00
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
0af1a79c51
More nsIPresContext deCOMtamination (bug 229371). r+sr=roc.
2004-04-13 00:28:44 +00:00
3eef6608c2
Bug 231372
...
GetCombinedArea could be faster/better
make it return an nsRect as return value instead of out parameter.
r=dbaron sr=bzbarsky
2004-01-22 15:06:25 +00:00
dfe3513814
Change all callers of nsIPresContext::GetShell() to use the non-refcounting versions. Most callers now use PresShell(), a few that were checking for null conditions are using GetPresShell() -- this will be remedied once we can ensure that a prescontext never has a null pres shell. Bug 227690, r+sr=bzbarsky.
2003-12-21 05:36:36 +00:00
8856db0238
Clean up nsIFrame::IsEmpty signature and move towards making 'white-space' work on inlines. b=191699 r+sr=roc
2003-11-10 23:36:06 +00:00
3de4dc91e0
Use the correct term "float" instead of "floater". b=218654 r+sr=bzbarsky
2003-10-13 21:51:02 +00:00
5d55c4535e
Ongoing deCOMtamination. r+sr=dbaron
2003-06-30 10:46:59 +00:00
b0318bfe51
195080 fix regression. sr=sfrasier r=danm. fix logic for moving caret around 0 width frames
2003-04-30 21:37:05 +00:00
0bc89daad7
202834 r=danm sr=kin fixes regression in line clicking and navigation.
2003-04-22 22:40:58 +00:00
4dfd694d28
fix for 195080 and other caret jumping problems. r=kaie sr=fraser
2003-04-17 20:22:17 +00:00
db88d9b75b
b=192320 Cannot down arrow in file
...
r=mjudge sr=kin
2003-04-02 12:05:43 +00:00
6dd68f3c64
Remove nsISizeOfHandler and associated SizeOf methods. b=106792 r=bzbarsky sr=jst
2003-02-22 15:34:38 +00:00
7f0488eb18
Phase 1 of style context deCOMtamination (bug 114713). Remove all dependencies on nsIStyleContext from outside of content and layout. Make nsIFrame::GetStyleData be a non-inline virtual function when called from outside of layout, since the nsStyleContext implementation won't be available to those callers. r=dbaron, sr=bzbarsky.
2003-01-09 06:49:07 +00:00
14c5b6b776
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
2003-01-08 21:19:10 +00:00
a34c46af22
Change my email address from dbaron@fas.harvard.edu to dbaron@dbaron.org. Comment changes only.
2003-01-01 23:53:20 +00:00
180b2268fb
Remove nsLineBox::RemoveFloatersFromSpaceManager, and use nsSpaceManager::PushState and nsSpaceManager::PopState instead. b=177342 r=roc sr=kin
2002-11-17 15:51:25 +00:00
68faeb5241
166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
2002-09-07 17:13:19 +00:00
03ace271f0
Add CPP_THROW_NEW macro to the build system. This macro should be used when defining a local |operator new| function. It will be set to an empty throw function by default on all platforms except mac CW builds. This will allow us to not crash on systems that expect |operator new| to throw an exception by default and will suppress compiler warnings about how |operator new| should throw an exception instead of returning NULL.
...
Bug 149032 r=timeless sr=scc
2002-07-02 20:25:30 +00:00
e63a11c0e8
Split strict mode into almost-standards and full-standards mode, where the only quirk in almost standards mode is the quirky inline box model. Remove previous fix for bug 151620. Tweak mode detection to use almost-standards for XHTML Transitional, HTML 4.01 transitional with system ID, and for IBM system DOCTYPE. b=153032 r=karnaze, bzbarsky, harishd sr=waterson
2002-06-25 21:16:17 +00:00
599b320791
Add some NOISY_SPACEMANAGER debugging code.
2002-05-07 14:08:54 +00:00
b878ea3fae
Fix leak (within the pres shell arena) of lines from nsLineBox::DeleteLineList. b=136764 r=attinasi sr=waterson
2002-04-13 18:54:40 +00:00
a0fc3640fa
Print the rest of the linebox flags when debugging reflow. Debug-only change.
2002-01-09 03:04:29 +00:00
854831c91c
Bug 115113. Eliminate nsIReflowCommand, and just use nsHTMLReflowCommand directly. r=karnaze, sr=attinasi.
2001-12-17 22:39:59 +00:00
6e86902faa
Remove unnecessary XPCOM interface around nsSpaceManager. b=102453 r=jag sr=waterson
2001-10-26 05:06:07 +00:00
157c017816
Bug 86947:
...
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow). Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed. Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs sr=waterson
2001-10-25 01:08:40 +00:00
ed869c764e
Replace uses of overloaded |fputs| and most uses of |ns[C]String::ToCString|. b=104763 r=jag rs=scc
2001-10-16 03:53:44 +00:00
4e12e44b2f
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2001-09-28 20:14:13 +00:00
fc01a17366
Make the width of floats with |width: auto| depend only on the width of the containing block and the contents of the float and not on the available space. Remove the loop calling ReflowFloater at different positions that is no longer needed, and remove the caching of the max element size for that loop that was not being invalidated correctly between reflows. Fix handling of margin, border, and padding for computation of available width for |width: auto| floaters. r=attinasi sr=waterson b= 85876, 82314, 82315, 85216, 85874, 86746
2001-07-19 02:33:43 +00:00
b55568be36
Bug 59200. Merge floater reflow and placement into FlowAndPlaceFloater() to deal with the fact that a floater may need to be reflowed as its 'pushed' to a new location. For auto-width floaters, ensure that the floater is not flowed at a width less than its max-element-size. Enforce CSS2 section 9.5.1 rule [2] by maintaining mLastFloaterY in the reflow state. r=rbs, sr=attinasi.
2001-05-21 23:03:46 +00:00
6bbe0d4deb
bug 74587; author=simon@softel.co.il; r=attinasi; sr=erik; fix for a
...
crasher in IBMBIDI-ifdeffed code for bidi documents
2001-05-02 22:13:29 +00:00
b9c0d17102
fixing build bustage in IBMBIDI ifdef on Mac
2001-04-16 21:32:19 +00:00
06d55ad850
bug 71370; author=simon@softel.co.il; r=attinasi; sr=erik; implement bidi
...
(bidirectional text) for languages such as Arabic and Hebrew; from IBM bidi
project; not part of build yet (due to #ifdef IBMBIDI)
2001-03-09 03:29:00 +00:00
6a1cef6f9a
Remove trailing semicolons after all uses of MOZ_DECL_CTOR_COUNTER to quiet build warnings on Mac. b=60415 a=brendan@mozilla.org
2001-01-27 23:06:33 +00:00
edb0c6270c
removing most all NS_DEFINE_IID and replacing them with NS_GET_IID macros
...
Bug 61274, r=buster sr=waterson
2001-01-04 20:44:42 +00:00
277d3af41f
Make destructors that exist only for MOZ_COUNT_DTOR be #ifdef NS_BUILD_REFCNT_LOGGING instead of #ifdef DEBUG so the leak stats on optimized builds are correct. r=waterson@netscape.com sr=brendan@mozilla.org b=62421
2000-12-16 18:56:06 +00:00
cd56c0575b
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2000-10-28 22:17:53 +00:00
9a6d92a433
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2000-10-27 22:43:51 +00:00
2ba178903c
warning fixes for linux. r: mjudge a: beppe
2000-06-16 22:28:10 +00:00
7ab436fd88
avoiding confusion between line iterator between layout and navigation.
...
if you want a line iterator for navigation you must explicitly ask for one.
2000-05-16 08:11:14 +00:00
e8ceb8ee1b
r:mjudge
...
fix for bug# 29785, keyboard navigation of tables in editor
not completely fixed, tables with row|column span do not navigate correctly
2000-05-11 01:04:39 +00:00
1c6eca645a
bug 29595 (and others)
...
fixes layout of pages where a single line is impacted by 2 or more floaters
r=troy
2000-03-22 23:19:10 +00:00
Zack Weinberg
L. David Baron
fantasai
Boris Zbarsky
Benjamin Smedberg
roc+@cs.cmu.edu
mats.palmgren@bredband.net
mrbkap@gmail.com
jwalden@mit.edu
sharparrow1@yahoo.com
cvshook%sicking.cc
dbaron%dbaron.org
mats.palmgren%bredband.net
uriber%gmail.com
gavin%gavinsharp.com
roc+%cs.cmu.edu
bzbarsky%mit.edu
pavlov%pavlov.net
cbiesinger%web.de
smontagu%smontagu.org
timeless%mozdev.org
bryner%brianryner.com
gerv%gerv.net
mjudge%netscape.com
kaie%netscape.com
bryner%netscape.com
dbaron%fas.harvard.edu
dougt%netscape.com
seawood%netscape.com
waterson%netscape.com
erik%netscape.com
rods%netscape.com
warren%netscape.com
anthonyd%netscape.com
buster%netscape.com