On elementNodeRep, we have different outputs for tiny and short modes, and
short and long modes are the same.
Since the current long mode of textNodeRep aren't used anywhere, we can do the
same, i.e. have a really small representation for tiny mode, and then the same
rendering for short and long modes.
Modify tests to adapt them to the new rendering.
MozReview-Commit-ID: BRA7iADkn1C
--HG--
extra : rebase_source : 1e33216239ebdcde47a0f7e80e3c138a8d3335f2
In the MessageBody component, we already have the "mode" props we use
to pass it to the Reps. We only default it to "long" so most of the
message will use it.
We only need to specify to use "short" mode in ConsoleTable cells.
MozReview-Commit-ID: 6KyZkN86bHJ
--HG--
extra : rebase_source : 39fcc8ff5cb3386663fb5f0821cecd78abae00b3
Adapt tests that relied on an other length for long mode.
MozReview-Commit-ID: J00UmOa2AwJ
--HG--
extra : rebase_source : a7ff746662f006e1a132ce1e21cac3a0cbbea0e2
This patch removes support for mozapp iframes, leaving support for
mozbrowser iframes intact. Some of the code has been rewritten in order
to phrase things in terms of mozbrowser only, as opposed to mozbrowser
or app. In some places, code that was only useful with apps has been
completely removed, so that the APIs consumed can also be removed. In
some places where the notion of appId was bleeding out of this API, now
we use NO_APP_ID. Other notions of appId which were restricted to this
API have been removed.
The `destroy` method in some actors would throw errors or was incomplete,
leading to various issues closing the toolbox after the previous patch.
This cleans up all such cases noticed through manual testing of the toolbox.
MozReview-Commit-ID: 6EZYFwjSri
--HG--
extra : rebase_source : b9db68be857285de4269f7354f6ecbf703c82e29
Ever since protocol.js was added as a way to create DevTools actors, we've had
lots of confusion about the correct way to implement actor destruction. If your
actor's _parent_ was the legacy kind, you had to use `disconnect`. If it was
protocol.js, you had to use `destroy`.
There is no reason for this madness, which makes reasoning about destruction
quite hard. Here we rename `disconnect` to `destroy` so there is only one name
for every destruction path.
MozReview-Commit-ID: C1Yw9NfUUR2
--HG--
extra : rebase_source : 4d018622b7547d404510e0b563c6324c0127aafc
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.
MozReview-Commit-ID: AzVbApxFGZ0
Add in serviceContainer highlight and unhighlight utils function so they can
be accessible in components.
Fix EvaluationResult component to pass the serviceContainer to the MessageBody.
Modify ElementNodeRep and TextNodeRep to allow passing them function properties
`onDOMNodeMouseOver` and `onDOMNodeMouseOut` that will be called respectively
on mouseOver and mouseOut.
Add a mochitest in the webconsole to make sure we indeed highlight and unhighlight
node as expected, and add tests in Reps to make sure the passed functions get called
as expected.
MozReview-Commit-ID: 8o8WM7vBfMM
--HG--
extra : rebase_source : 445f02a72b1c9859c0b034ca9e941a7f3df9f4e0
Update the test to avoid closing / reopening the toolbox each time a new color
is tested. An element is created upfront for each color to test, and the test
simply selects a different node when switching to a different color.
MozReview-Commit-ID: Atz70fwoMN2
--HG--
extra : rebase_source : aba56bef09c05e94b55ce2153d48b502f586e3c5
Ricky Chien
Carsten "Tomcat" Book
Gabriel Luong
Phil Ringnalda
Sebastian Hengst
Helen V. Holmes
Nicolas Chevobbe
Dalimil Hajek
Julian Descottes
Bob Owen
Jarda Snajdr
Wes Kocher
Brian Grinstead
Tooru Fujisawa
Ehsan Akhgari
Alexandre Poirot
J. Ryan Stinnett
Tim Nguyen
Kan-Ru Chen
Daisuke Akatsuka
Fred Lin
Luca Greco