mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
592 380 коммитов 615 Ветки 98 Теги 5,7 GiB
Граф коммитов

1528 Коммитов

Автор SHA1 Сообщение Дата
Robert Helmer c8714b1c7d Bug 1348981 - only load system add-ons from a built-in list r=kmag 
MozReview-Commit-ID: A6c5kaLmNPP

--HG--
extra : rebase_source : 058e6011c8ce953059e674eea032ba79c19f8eb8
 2017-10-02 18:41:20 -07:00
Thom Chiovoloni d39e820403 Bug 1403052 - Limit tab sync max_record_payload_size to 512k. r=markh 
Also fixes an issue where we wouldn't encode to utf8 when comparing the actual
size to the limit after the first time.

MozReview-Commit-ID: Cf3byjI1FTZ

--HG--
extra : rebase_source : 272ec3b3ad85f8b44c4d69950be83419054abdab
 2017-10-02 19:27:54 -04:00
Thom Chiovoloni 9f708fd861 Bug 1400467 - Ensure services/common/logmanager.js awaits it's cleanup function r=markh 
MozReview-Commit-ID: thQph1UUA0

--HG--
extra : rebase_source : 705cdd9d07a1a26b568554e07638c0415789b404
 2017-09-22 11:57:13 -04:00
Thom Chiovoloni 76a3991796 Bug 1400467 - Make WeaveCrypto use promises instead of spinning event loops r=eoger,markh 
MozReview-Commit-ID: 64dewKKaAOJ

--HG--
extra : rebase_source : e8d48e05ad8dac214358b0a9979b011a65ed07a8
 2017-09-15 19:21:31 -07:00
Edouard Oger 1df9d06245 Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc 
MozReview-Commit-ID: 3oUBqLuHpoG

--HG--
extra : rebase_source : 303c40b6fc5a41a7b2f2e9edc9f275228ccbbe47
 2017-09-22 15:19:44 -04:00
Sebastian Hengst e08e4f2f41 Backed out changeset d86f2704b27a (bug 1395427) 2017-09-27 17:10:15 +02:00
Edouard Oger 7d0ecfa428 Bug 1395427 p4 - Add form history items deletions to TPS tests. r=markh,tcsc 
MozReview-Commit-ID: 3oUBqLuHpoG

--HG--
extra : rebase_source : 19f4c4c21c35d9d604e17d3e1df862bc700773bd
 2017-09-22 15:19:44 -04:00
Phil Ringnalda 216b709c48 Backed out 4 changesets (bug 1348981) for Linux debug timeouts in test_system_update.js 
Backed out changeset b1fe39ea6d5c (bug 1348981)
Backed out changeset 47866f942752 (bug 1348981)
Backed out changeset 5e93d8760487 (bug 1348981)
Backed out changeset 58431e2c37d7 (bug 1348981)

MozReview-Commit-ID: 2WjZKztxyVs
 2017-09-23 06:20:56 -07:00
Robert Helmer 70071e128b Bug 1348981 - only load system add-ons from a built-in list r=kmag 
MozReview-Commit-ID: A6c5kaLmNPP

--HG--
extra : rebase_source : 8a98ba4a36f2717c1b733b661e9d8621a9bbfec0
 2017-09-14 00:36:04 -07:00
Thom Chiovoloni 6348cd2190 Bug 1393659 - Fix inconsistent handling of max_post_bytes and max_request_bytes r=markh 
MozReview-Commit-ID: 4jwpAYNuoQj

--HG--
extra : rebase_source : f32ecbd9740f7d8647fdf37ad6bbb53e332320ac
 2017-09-13 18:02:41 -07:00
Edouard Oger daf87f8b3b Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh 
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.

MozReview-Commit-ID: FuCMewhO20z

--HG--
extra : rebase_source : cbeb2b30a425020e2379d3f5d21affabe610a20b
 2017-08-21 17:06:06 -04:00
Phil Ringnalda e6c038d6ee Backed out 3 changesets (bug 1383663) for timeouts in browser_aboutAccounts.js and failures in test_web_channel.js 
Backed out changeset f384a524cac6 (bug 1383663)
Backed out changeset 9d26a627e2f8 (bug 1383663)
Backed out changeset c7d46e2e8ddc (bug 1383663)

MozReview-Commit-ID: 88xbdeVJtK2
 2017-09-16 10:40:00 -07:00
Edouard Oger 11875727be Bug 1383663 part 1 - Revert bug 1385191 changes. r=markh 
This reverts commit 3f279247b875becd0c617fa6dc31cdf9f1349374.

MozReview-Commit-ID: FuCMewhO20z

--HG--
extra : rebase_source : f071fe7d8b67d84a0b2836b7dae3883e8c85c46a
 2017-08-21 17:06:06 -04:00
Kit Cambridge 95856672f4 Bug 1400394 - Remove `TestingUtils.deepCopy`. r=markh 
MozReview-Commit-ID: 3ZZpA3inWSF

--HG--
extra : rebase_source : 506d1bb5bba484e65bcd5abed196c3ecc751fb1b
 2017-09-15 13:46:21 -07:00
Kris Maglione f829523282 Bug 1371065: Part 0 - Fix unit tests that use the SDK loader :/ r=Mossop 
MozReview-Commit-ID: 4ewrbY0FS09

--HG--
extra : rebase_source : 390256a9eb0d303d8582c24d69fff189b0e0ab4d
 2017-09-08 18:16:50 -07:00
Kit Cambridge d6cced9ca1 Bug 1394525 - Reset tracker scores before syncing. r=markh 
MozReview-Commit-ID: 1wHdOeiZOyl

--HG--
extra : rebase_source : 765094feecdbe79cfa30f5c5a2886f8113890077
 2017-08-28 11:24:26 -07:00
Kit Cambridge 0d29ca233e Bug 1393904 - Ensure `insertTree` removes Sync tombstones for restored bookmarks. r=mak 
MozReview-Commit-ID: EbGybRbhWKJ

--HG--
extra : rebase_source : 596389e1ffc111f26cc10f014da6d74202f988eb
 2017-08-25 12:04:22 -07:00
Mark Hammond 5317324bec Bug 1397537 - check FxA has a session token and enter a needs-reauth state even when the user is unverified. r=eoger 
MozReview-Commit-ID: KuldXySDvt4

--HG--
extra : rebase_source : 9b33265b341e7fcd5be9dc6e3b01d218ce1aabca
 2017-09-07 11:13:53 +10:00
Mark Hammond 27afdd11e1 Bug 1396544 - don't schedule syncs when Sync isn't configured. r=rnewman 
MozReview-Commit-ID: AM0G43vFyty

--HG--
extra : rebase_source : 9888cfd079f4761debb710d1bbe064956aec1093
 2017-09-05 12:40:53 +10:00
Mark Hammond 2dad858a21 Bug 1375635 - Add telemetry for how often and long users are in bad authentication states. r=Dexter,rweiss+418169,tcsc 
MozReview-Commit-ID: BW8ixM3wmxJ

--HG--
extra : rebase_source : 6872e86fbd6ff00c4ab65ef4bf8c6195e06de54b
 2017-07-27 11:59:24 +10:00
Geoff Brown e16b402acf Bug 1395148 - Run some services/sync xpcshell tests sequentially; r=markh 
These tests normally pass when run sequentially but often timeout when run
in parallel, especially on debug builds.
 2017-08-31 07:50:25 -06:00
Nicolas Ouellet-Payeur 5a0bb50ea8 Bug 1392148 - Remove aliases to CommonUtils in util.js r=markh 
MozReview-Commit-ID: 1fv6AN0TMNW

--HG--
extra : rebase_source : 083c73e50bfdb2dd121aa483e5aa53ae0e35768d
 2017-08-24 22:41:44 -07:00
Mark Hammond c204098ad4 Bug 1392409 - set engine.lastModified to avoid intermittent orange. r=tcsc 
MozReview-Commit-ID: 4kPzk9nSWxw

--HG--
extra : rebase_source : 6f4ef917001e2565dd00eefa12876fc897705ca1
 2017-08-23 13:59:16 +10:00
Mark Banner a53020d022 Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop 
MozReview-Commit-ID: 35MaseieNUk

--HG--
extra : rebase_source : 98eaec6a67fd3b30ea6b0be641f26c3911012fab
 2017-08-20 18:52:05 +01:00
Mark Hammond 34e7a1eb17 Bug 1355766 - don't treat a 412 response as a sync error. r=kitcambridge 
MozReview-Commit-ID: 4IL6RJcP9PC

--HG--
extra : rebase_source : 2e0c3143da1f01eaeb5a30efab2becd367ded36c
 2017-08-08 12:02:28 +10:00
Mark Hammond fa4625acc7 Bug 1368951 - add x-if-unmodified-since support to the sync test server. r=tcsc 
MozReview-Commit-ID: FF7smwdeQ0k

--HG--
extra : rebase_source : 82f8706d6a27f1bf93b95b93572a2fa37b268b3d
 2017-05-31 18:42:45 +10:00
Nicolas Ouellet-Payeur b242392e7d Bug 1353217 - importing bookmarks from html doesn't need to reset the bookmarks engine. r=markh 
MozReview-Commit-ID: 4F7KF5ZkNuX

--HG--
extra : rebase_source : 521510fe074fa0f84f28212fa8a230a74dfd2ce8
 2017-08-11 00:19:01 +00:00
Thom Chiovoloni 3e1366bdf6 Bug 1388149 - Make PlacesUtils.history.insertMany respect provided GUIDs r=markh 
MozReview-Commit-ID: 7g6uABtHKg2

--HG--
extra : rebase_source : 0b43e026ad3de514d2ffbc56568bf3f4e3e17126
 2017-08-07 16:01:10 -04:00
Masatoshi Kimura 8b713b2b0f Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj 
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC

--HG--
extra : rebase_source : 412880ea27766118c38498d021331a3df6bccc70
 2017-08-04 17:49:22 +09:00
Mark Hammond 4f08809c1f Bug 1387303 - fix test_places_guid_downgrade.js to work correctly in the new async-sync world. r=eoger 
MozReview-Commit-ID: 4bmu45qUmFA
 2017-08-04 15:00:51 +10:00
Edouard Oger 2b42c50319 Bug 1385440 - Serialize client commands additions. r=markh 
MozReview-Commit-ID: 3qGcHVhOCeL

--HG--
extra : rebase_source : 3d71a5af631d2dd9be59ce0b1495959552f8c640
 2017-08-02 11:33:24 -04:00
Rajesh Kathiriya 48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
 2017-07-25 23:45:41 +05:30
Mark Hammond 6b5f784403 Bug 1384818 - flush sync log files on sync reset. r=eoger 
MozReview-Commit-ID: H6CkvHGxAmx

--HG--
extra : rebase_source : 53bede19ec7766c91c30324668dcca8d11f64197
 2017-07-27 14:57:47 +10:00
Thom Chiovoloni 5368b04624 Bug 1374722 - Expand the set of ids requested during the initial repair process r=markh 
MozReview-Commit-ID: 92SGMd9fJgX

--HG--
extra : rebase_source : 0b6ca2379a03adc4488bf3f679a3f81b18de83b1
 2017-06-20 13:40:17 -04:00
Sebastian Hengst 804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya 22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
 2017-07-25 23:45:41 +05:30
tiago 7a9b4d8b79 Bug 1336518 - Move Sync history queries into PlacesSyncUtils. r=kitcambridge 
MozReview-Commit-ID: Lood8ivLeJf

--HG--
extra : rebase_source : dcb8207378afc6ce2995acfe4f235f3ed728a188
 2017-07-30 17:46:56 -03:00
Kit Cambridge 5c9899d993 Bug 1383621 - Use the async bookmarks API to insert the mobile query. r=markh 
MozReview-Commit-ID: KaeXwFHEg7K

--HG--
extra : rebase_source : b67f8662e221614041aad391d71bdf381ce4e8b0
 2017-07-24 16:45:17 -07:00
Mark Hammond 8d2320d13f Bug 1385191 - Prefer email address from the FxA profile over that from the account. r=eoger 
MozReview-Commit-ID: 78U2RZQ5xfB

--HG--
extra : rebase_source : b79b18ea8c545003998692cd97c7ad5d6606c7f7
 2017-07-28 16:35:40 +10:00
Nicolas Ouellet-Payeur 250eef68d6 Bug 1375212 - Wrap thrown strings in Error objects r=eoger,markh 
MozReview-Commit-ID: KquBcbNhBEN

--HG--
extra : rebase_source : 172bcad2eb178092bc7d49940db61e8cb5ad6572
 2017-07-22 18:55:43 -07:00
Kit Cambridge 932f724512 Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh 
The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.

I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.

MozReview-Commit-ID: Gq16sNm7K2e

--HG--
extra : rebase_source : e597233dae23d7582f34faeb83365896b6c22a75
 2017-07-25 11:53:45 -07:00
Wes Kocher 65bbd0525a Merge inbound to central, a=merge 
MozReview-Commit-ID: E4oXfAM1mtd
 2017-07-25 19:04:37 -07:00
Rob Cutmore 061209972d Bug 1368568 - Remove legacy SyncKeyBundle. r=eoger 
MozReview-Commit-ID: JYiTeQnduto
 2017-07-25 11:40:14 -04:00
Mark Hammond 1e3bdd598f Bug 1382913 - throw an error when a non existing observer is removed from observers.js. r=kitcambridge 
MozReview-Commit-ID: AR2IPDH0Rpw

--HG--
extra : rebase_source : c533d5a5e086fc43c9c847297c3fba97ed9e25d7
 2017-07-25 13:59:44 +10:00
Thom Chiovoloni 23b85ab316 Bug 1337978 - Unify the multiple notions of 'weak upload' in sync. r=kitcambridge,markh 
MozReview-Commit-ID: 5vTCAhUfMzm

--HG--
extra : rebase_source : fea6783352868e15481a751923aac2a166ad5506
 2017-07-18 14:18:04 -04:00
Thom Chiovoloni 9a475a45bf Bug 1382044 - Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js. r=markh 
MozReview-Commit-ID: 112UJWjF7R4

--HG--
extra : rebase_source : d398e93deb2d5bd7cc43d96eb37580552b8e2d72
 2017-07-18 19:56:50 -04:00
Kit Cambridge 8893010bae Bug 1380835 - Don't check queries with `excludeQueries` for cycles in the bookmark validator. r=tcsc 
MozReview-Commit-ID: DsPzrCxWWMG

--HG--
extra : rebase_source : 25281ab8f8d53901d960a738212361831b12fc55
 2017-07-13 19:52:57 -07:00
Kit Cambridge 8fc0f2d795 Bug 1377183 - Manually follow folder queries when validating bookmarks. r=tcsc 
MozReview-Commit-ID: K3nl5GcilMz

--HG--
extra : rebase_source : 3704f00919170e12652e4d977c50604d6f94ce49
 2017-07-05 17:00:50 -07:00
Mark Banner 35f3666937 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop 
MozReview-Commit-ID: EnhSBHMjurr

--HG--
extra : rebase_source : 74ba4c10e369067629af95bf705a9acd0df1089b
 2017-07-11 22:49:55 +01:00
Thom Chiovoloni 764f64b2d5 Bug 1380094 - services/sync changes to support formautofill r=markh 
MozReview-Commit-ID: BdsrrFOU5ec

--HG--
extra : rebase_source : b7bc64fd510c9db60c6788cda94a07b1a53d0594
 2017-07-11 15:15:37 -04:00
Edouard Oger 314ef330a0 Bug 1210296 part 2 - Update tests. r=kitcambridge,markh,tcsc 
MozReview-Commit-ID: 41dnyvdlNJv

--HG--
extra : rebase_source : 4c6e3cc63d4861d176ba053a1cff872c04f0f3b3
 2017-06-05 18:49:43 -04:00
Edouard Oger f4f4832d9e Bug 1369539 - Sync UI startup performance improvements. r=florian,markh 
MozReview-Commit-ID: 7ibJokJttLh

--HG--
extra : rebase_source : 7eac08de35da72744ce4b101d4f52229fe0e0688
 2017-07-04 14:23:33 -04:00
Rajesh Kathiriya 881bce09ea Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8 
MozReview-Commit-ID: RT5QTipaOW

--HG--
extra : rebase_source : 84bccaeba083bc430316d3c80d5c8f56494f1950
 2017-07-04 21:30:18 +05:30
Kit Cambridge 0c16f513c9 Bug 1378551 - Separate `pullNewChanges` and `markChangesAsSyncing`. r=markh 
MozReview-Commit-ID: FcysoHJtG60

--HG--
extra : rebase_source : 902460b486ef230c939608ee9bede93374069776
 2017-07-05 13:49:48 -07:00
Kit Cambridge a4f06209c9 Bug 1378545 - Ensure `test_misreconciled_root` waits for the test server to start. r=markh 
MozReview-Commit-ID: AyjdR5hfSOf

--HG--
extra : rebase_source : 9483f7f2d0c0437da1a3e97d9477ea8eae243843
 2017-07-05 15:19:17 -07:00
Edouard Oger 03c81660b0 Bug 1377200 - Ensure Sync can recover after a profile refresh. r=markh 
MozReview-Commit-ID: FeId4ANTNX9

--HG--
extra : rebase_source : 5c3f69ee524584617635375d9bc416fc57e9a67e
 2017-07-04 15:03:43 -04:00
Kit Cambridge 31ccf3dc94 Bug 1360872 - Return empty strings for `null` bookmark titles. r=mak 
MozReview-Commit-ID: Dd2sEfYvnBt

--HG--
extra : rebase_source : 963b09955610d099b1acb508472a2a3c24202d73
 2017-06-06 14:37:22 -07:00
Benjamin Smedberg 53c93f8449 Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss 
MozReview-Commit-ID: FD5npJlB24W

--HG--
extra : rebase_source : d30bac5044ecb8d86253e8bca3e8d47371fb9d1f
extra : source : 4f0ee0f75a307095e4a04afe4413e5bb6ea8e502
 2017-06-21 15:26:10 -04:00
Mark Hammond 7e61aa8e97 Bug 1373093 - Add operating system information to the desktop Sync ping. r=tcsc 
MozReview-Commit-ID: 9ypnosSawxu

--HG--
extra : rebase_source : 8a0192c70917c952431693c6864f96f7fd9b278e
 2017-06-21 12:28:25 +10:00
Phil Ringnalda c636da88e0 Backed out changeset 4f0ee0f75a30 (bug 1367813) for Windows opt permaorange in test_worker_basic.html 
MozReview-Commit-ID: 2k693yFa28r
 2017-06-22 20:43:11 -07:00
Benjamin Smedberg 5cf8c34a94 Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss 
MozReview-Commit-ID: FD5npJlB24W

--HG--
extra : rebase_source : 049275836880f0aa4d19a9af2de9ec4101432b44
 2017-06-21 15:26:10 -04:00
Florian Quèze 66f6d259bc Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Mark Hammond a1b09f054d Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges. r=standard8 
MozReview-Commit-ID: Ihun5yu3hit

--HG--
extra : rebase_source : 9448411e072d144456e7672b92699cdf288a13fc
 2017-06-21 14:53:07 +10:00
Mark Banner d030707609 Bug 1095426 - Convert JSON backups code to the new async Bookmarks.jsm API. r=mak 
MozReview-Commit-ID: FNZZGwWVSI2

--HG--
extra : rebase_source : dacb3c5ddb439d074c66e0baaa7e73044c5dcd46
 2017-05-12 08:04:51 +01:00
Thom Chiovoloni a208081e56 Bug 1357798 - Ensure URLs don't end up in sync error telemetry. r=markh 
MozReview-Commit-ID: AxFzysv0ks3

--HG--
extra : rebase_source : 6b2aa9354ed9540c5cdb8f537eaca7080c97a4eb
 2017-06-12 13:38:39 -04:00
Thom Chiovoloni c3972efec6 Bug 1368393 - Handle already synced commands in clients collection duplicate checking r=eoger,markh 
MozReview-Commit-ID: Hs0Jh8mMlOp

--HG--
extra : rebase_source : 8a8bae7330210547d128c322abed773cb73895e5
 2017-06-09 12:07:43 -04:00
Edouard Oger b599411285 Bug 1369119 - Refresh known stale devices list on FxA device disconnect. r=markh 
MozReview-Commit-ID: A2iqas0kP20

--HG--
extra : rebase_source : 15db886e4751885e173a55c561df7ea1a3b2871b
 2017-06-06 14:28:00 -04:00
Masatoshi Kimura 3231cb3535 Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen 
MozReview-Commit-ID: GliLHLsUWjt

--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
 2017-06-17 19:30:09 +09:00
Edouard Oger a1f2f47f82 Bug 1363412 - Notify other clients when uploading the local clients record for the first time. r=markh 
MozReview-Commit-ID: Ldc3Jrj8RhV

--HG--
extra : rebase_source : 44bdeaa962ddbcb748f9e5a01871fd2ff7d6a676
 2017-06-12 14:51:17 -04:00
Edouard Oger 1826fefb4c Bug 1370985 - Change getBatched() to return records directly instead of using a callback. r=markh,tcsc 
MozReview-Commit-ID: HfwPe8jSH66

--HG--
extra : rebase_source : 12c8800f1fcc090589c2a94a0fc1608b36c54181
 2017-05-30 13:23:57 -04:00
Edouard Oger adde19d4f4 Bug 1369855 - Update sinon.js to version 2.3.2. r=markh 
MozReview-Commit-ID: FPB4HebP3g7

--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
 2017-06-02 15:50:30 -04:00
tiago 19362d0bfa Bug 1354016 - Forms validator ignore clientMissing. r=tcsc 
MozReview-Commit-ID: C2FD58C9HzS

--HG--
extra : rebase_source : f5b627342e7fa4915914cbfd3e54003fe6d94c1e
 2017-06-01 22:32:23 -03:00
Mark Hammond dc01c77702 Bug 1369285 - update how we build the default sync device name. r=tcsc 
MozReview-Commit-ID: 6eY8IzKg9kd

--HG--
extra : rebase_source : ae321d48de0144c29fa4f40fd16a02c44539d795
 2017-06-01 16:57:02 +10:00
Edouard Oger 9d1dc7c4a7 Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh 
MozReview-Commit-ID: 74IFsVjZSgz

--HG--
extra : rebase_source : 00f77b7a24a509d5e9fabb8ee7793a59b38f639f
 2017-05-29 13:24:01 -04:00
Edouard Oger 2c61cf7eb4 Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh 
MozReview-Commit-ID: JbzweOMFLpR

--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
 2017-05-29 17:27:13 -04:00
Edouard Oger 0c6026b415 Bug 1369092 - Listen to onverified events in UIState. r=markh 
MozReview-Commit-ID: 8nfmpaz9obF

--HG--
extra : rebase_source : 736673d0c1245b81ea9f419f08b943c3ce26a8e6
 2017-05-31 12:02:28 -04:00
Sebastian Hengst 9768267be1 Backed out changeset bf392a1d0c5a (bug 1368560) for failing xpcshell's test_ext_storage_sync.js and test_ext_storage_sync_crypto.js on Linux. r=backout on a CLOSED TREE 2017-05-31 22:53:16 +02:00
Sebastian Hengst a9f8675d96 Backed out changeset c2d00a8b897b (bug 1368560) 2017-05-31 22:52:14 +02:00
Edouard Oger 275b48a53e Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh 
MozReview-Commit-ID: 74IFsVjZSgz

--HG--
extra : rebase_source : 29833856a9cca178a2b508b6401cdb6bd8ca1bb9
 2017-05-29 13:24:01 -04:00
Edouard Oger 198e8ab1d1 Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh 
MozReview-Commit-ID: JbzweOMFLpR

--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
 2017-05-29 17:27:13 -04:00
Mark Hammond 71a24b858a Bug 1366994 - prevent appDisabled addons from hanging sync. r=tcsc 
MozReview-Commit-ID: 4RRCPlwUZrG

--HG--
extra : rebase_source : 8ab03af402dc15432252b74a120da286b810302f
 2017-05-26 12:42:10 +10:00
tiago 7386600327 Bug 1366081 - Excise 'mobileGUIDFetchBatchSize' and other mobile sync-related constants. r=kitcambridge 
MozReview-Commit-ID: 6JTtpWFFyvD

--HG--
extra : rebase_source : f6ca75e91ca38d0d1ba18ff79a0872d96a878954
 2017-05-24 03:28:22 -03:00
milindl fc8d285e3d Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak 
This includes 2 things:
1. Replacing the parts which test the logs for the presence of prefixes by testing
the returned map for `suceeded`.
2. We don't need to wait to observe the topic anymore, we can simply await methods
from `PlacesDBUtils` to know when they are done.

MozReview-Commit-ID: Ct9l9pzUW5x

--HG--
extra : rebase_source : 657e4ac53f8b3785740a5b732d483fad9600f73d
 2017-05-24 11:00:47 +05:30
Edouard Oger 99947c9c38 Bug 1353307 - Add main process start time to sync ping. r=gfritzsche,markh 
MozReview-Commit-ID: DbSZUmO0tuf

--HG--
extra : rebase_source : e13afbd5829b86b7bee5c82a7a1ff09263e9dc3f
 2017-05-16 17:43:49 -04:00
Kit Cambridge df2d03a198 Bug 973166 - Only track passwords with changes to synced fields. r=eoger 
MozReview-Commit-ID: 8ZOyVCaZIi8

--HG--
extra : rebase_source : 8252c5a9ad718594872d5bda38e04528cd227f44
 2017-05-22 17:21:20 -07:00
Kit Cambridge d2833635e1 Bug 1352233 - Try to preserve synced folder child order in case of conflicts. r=tcsc 
For folders, we resolve conflicts by taking the chronologically newer
list, then appending any missing items from the older list. This
preserves the order of those missing items relative to each other, but
not relative to those appearing in the newer list.

MozReview-Commit-ID: 6rimXpV7vLg

--HG--
extra : rebase_source : 10cda7f529cec3f71d9d45d253285d35788cb0b5
 2017-04-28 14:08:11 -07:00
tiago 45fdbb5730 Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger 
MozReview-Commit-ID: AciCTECtXJc

--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
 2017-05-12 20:54:54 -03:00
Florian Quèze 4e937e42a2 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Kit Cambridge 103b72ff2f Bug 1335891 - Ensure and test that Sync changes don't bump the score. r=markh 
MozReview-Commit-ID: 4dP5oZS3pm

--HG--
extra : rebase_source : ebada671d4aa5feba290f118e370fd7def093c4a
 2017-05-09 13:04:50 -07:00
Frederik Braun cd1cbcef0f Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8 
MozReview-Commit-ID: 4nYlX4sSdbF

--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
 2017-05-08 14:50:50 +02:00
Edouard Oger b3b3ff9cc5 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh 
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
 2017-04-18 14:15:43 -04:00
Edouard Oger 1df337c9ce Bug 1361572 - Remove Task.jsm/Promise.jsm from services/. r=kitcambridge 
MozReview-Commit-ID: BBIkpIkWIYc

--HG--
extra : rebase_source : a0f10b07bad20789e2d1c2c2bca133b32bf671aa
 2017-05-02 19:29:33 -04:00
Sebastian Hengst 18253e3fa2 Backed out changeset 0a0138825fb5 (bug 1353571) 
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
 2017-05-03 21:56:44 +02:00
Edouard Oger c11e66021d Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh 
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
 2017-04-18 14:15:43 -04:00
Edouard Oger abba8c5b31 Bug 1358648 part 2 - Remove util.js Svc.{DefaultPrefs,Session,Idle, FormHistory} and Str. r=markh 
MozReview-Commit-ID: Jc1th8Snvhv

--HG--
extra : rebase_source : dd950a5d7bb0f2cb2ea4f32c7b61eb2a15ae327d
 2017-05-02 18:30:23 -04:00
Dan Banner f2a6a685fe Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh 
MozReview-Commit-ID: D6qH5XtEtHO

--HG--
extra : rebase_source : 8e4c319c7fb8b727ac0193e5dd78411e1ec2785c
 2017-04-27 17:24:18 +01:00
Carsten "Tomcat" Book 8cb9279791 Backed out changeset e6177d883f37 (bug 1359540) for eslint failures 2017-05-02 09:25:45 +02:00
Dan Banner 0c2aa823c9 Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh 
MozReview-Commit-ID: D6qH5XtEtHO

--HG--
extra : rebase_source : 3d8d878810c60dc339e196eaac0215f9f72cc829
 2017-04-27 17:24:18 +01:00
Kit Cambridge dcce7ae769 Bug 1348699 - Add test to ensure we don't track left pane queries. r=mak,markh 
MozReview-Commit-ID: LFoCpvz2rAn

--HG--
extra : rebase_source : c2e927100899b5856d0fc2350efdf0e1ffb52e77
 2017-03-20 19:22:15 -07:00
Kit Cambridge 5b32e800fa Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc 
MozReview-Commit-ID: 3D1xwv9k76m

--HG--
extra : rebase_source : a27836cea6100fd90e15ed95b08c9f02e6c79605
 2017-03-30 18:01:19 -07:00
Mark Banner 29c680ad80 Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic). r=markh 
This fixes various errors raised in services for the rules: key-spacing, quotes, no-else-return, no-extra-semi, comma-spacing, object-shorthand.

MozReview-Commit-ID: IClwG5rfXfW

--HG--
extra : rebase_source : 81c059dacfc39b5cf8bc85b9b746dcdd494a3629
 2017-04-24 18:52:57 +01:00
Mark Hammond 00431016d0 Bug 1355677 - Make all Sync network requests promise based. r=kitcambridge,rnewman,tcsc 
MozReview-Commit-ID: JSwAS4Xd1uy

--HG--
extra : rebase_source : 95724c3b59576d40cafd2f380ff42acb4fc3d553
 2017-04-11 23:40:53 +10:00
Thom Chiovoloni 0bb64306d4 Bug 1346175 - Record AsyncResource.serverTime in sync telemetry events. r=bsmedberg,markh 
MozReview-Commit-ID: DG43B9zEHaO

--HG--
extra : rebase_source : 9b16fe1dff50574036fb2e10224d8056fe415ecd
 2017-04-04 13:51:16 -04:00
Marco Bonardo 12dcd10d01 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge 
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj

--HG--
extra : rebase_source : 55120252e7ea8abb91f21ca2486deddc43795142
 2017-04-14 20:34:27 +02:00
Carsten "Tomcat" Book 16969b40e2 Backed out changeset eb94759f0fcf (bug 1356567) for test failures in own test 2017-04-18 12:58:09 +02:00
Marco Bonardo 5238755b71 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge 
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj

--HG--
extra : rebase_source : e36ba1ab41649927f92fee053c10bf43474a0bcf
 2017-04-14 20:34:27 +02:00
Edouard Oger c8bcf1e705 Bug 1351915 - Fire onItemChanged when deduping sync bookmarks. r=kitcambridge 
MozReview-Commit-ID: JHaCz42aRwx

--HG--
extra : rebase_source : 38361447a7900c55dc56cc5b528be5045181fee2
 2017-04-08 19:57:39 -04:00
Florian Queze 37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze 95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Thom Chiovoloni daf505ef20 Bug 595314 - Add TPS test ensuring that new changes to existing bookmarks are respected by sync r=markh 
MozReview-Commit-ID: B2A60B3ufYb

--HG--
extra : rebase_source : bc30afdc09497f9bcdda85493f02faa8fe8afb17
 2017-04-05 12:39:00 -04:00
Thom Chiovoloni 3c9fc16ebc Bug 1345744 - Ensure an error log is written when sync (newly) fails to apply records. r=markh 
MozReview-Commit-ID: 586faUBtX6n

--HG--
extra : rebase_source : 7e1d0eab656838f3718260a11ef8cd2d9b501d17
 2017-04-04 14:18:09 -04:00
Edouard Oger 557fa7b36a Bug 1350665 - Disable sync repair tests on beta and release. r=kitcambridge 
MozReview-Commit-ID: 6anD2FJ2aQ2

--HG--
extra : rebase_source : 708b1c52d0ecbad5407d3d27db0c5d14c8bfa73e
 2017-03-29 15:27:25 -04:00
Thom Chiovoloni f189ba9211 Bug 1349703 - (part 3) Delete a test from TPS that was testing that we made the wrong decision during reconciliation r=kitcambridge 
MozReview-Commit-ID: KVRcVNJAKfg

--HG--
extra : rebase_source : c37b394f0a97488f783db0b751ea2f5f9c454f8d
 2017-03-23 17:18:32 -04:00
Edouard Oger 2f0a83abc1 Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc 
MozReview-Commit-ID: 9Wxq2wfUnkb

--HG--
extra : rebase_source : 133133eb765a403a77ca3bbd0d8302c0a0be49a0
 2017-03-24 11:12:48 -04:00
Sebastian Hengst 7ebbcc1624 Backed out changeset 16d562074791 (bug 1339340) for failing xpcshell test services/sync/tests/unit/test_doctor.js. r=backout 2017-03-24 00:52:29 +01:00
Edouard Oger 125d3015c3 Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc 
MozReview-Commit-ID: 9Wxq2wfUnkb

--HG--
extra : rebase_source : 8dfe36e5c2d75291e07d61341648dec95b5dd213
 2017-03-14 18:02:20 -04:00
Kit Cambridge 55c8025ae4 Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc 
This was a regression from bug 1317223. This commit also adds a
password engine sync test to catch future regressions.

MozReview-Commit-ID: 9dq8K39jLwB

--HG--
extra : rebase_source : 346c4abaf639f7781426f4e06e988c76cf552422
 2017-03-22 19:21:08 -07:00
Kit Cambridge c4565c993a Bug 1343093 - Add integration test for bookmark repair. r=markh 
This test replaces the clients engine to simulate two different
clients, and uses `SOURCE_SYNC` to bypass change tracking.

MozReview-Commit-ID: IF3b3WZtain

--HG--
extra : rebase_source : deff5eb74dcbc29d7e7556b4ce6e15590ee4d4a0
 2017-03-21 11:54:06 -07:00
Mark Banner bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws 
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
 2017-03-20 12:36:37 +01:00
Thom Chiovoloni 130ff3a299 Bug 1345754 - Skip sync bookmark repair and validation if we have pending changes r=markh 
MozReview-Commit-ID: ClQRXGZGV9p

--HG--
extra : rebase_source : 4ae8ead7a9121dc383fcfc5ebf757f44e46f5679
 2017-03-14 14:26:20 -04:00
Edouard Oger e4ec1eb1d3 Bug 1343735 - Respect max_record_payload_bytes limit. r=markh 
MozReview-Commit-ID: 1aDwl1cq2Hh

--HG--
extra : rebase_source : a29abc5c1f3b9eefea26fe93b5ee82f4b3d12924
 2017-03-15 17:12:17 -04:00
Mark Hammond dfa642bc63 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc 
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : f13d7ef61b343820347579b76352cd65a322c8eb
 2017-03-20 19:13:42 +11:00
Wes Kocher 1a61788cb8 Backed out changeset a2ec162fa051 (bug 1348743) for eslint failures a=backout 
MozReview-Commit-ID: 2rfgqYueacf
 2017-03-20 16:32:06 -07:00
Mark Hammond 10c7be4d14 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc 
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : e68d0050fb3b6b48e5c61abed98827dbbf449923
 2017-03-20 19:13:42 +11:00
Thom Chiovoloni 4f8d16041f Bug 1342320 - Use PlacesUtils and not PlacesSyncUtils in sync bookmark decline/undecline test r=markh 
MozReview-Commit-ID: DgbCeKgSxoE

--HG--
extra : rebase_source : d7a73f871436a3c557e3ea921439da3e6f55e13c
 2017-03-14 13:01:10 -04:00
Mark Hammond f13f9ed085 Bug 1347373 - better handling of requests that have only non-existing items and of errors. r=kitcambridge 
MozReview-Commit-ID: 7kcky3wJb4j

--HG--
extra : rebase_source : 108dde9145e323410e8799053581dc9bb4b80e42
 2017-03-16 20:53:06 +11:00
Joseph Cameron 4ad85c5308 Bug 1345023 - Changed SYNC_API_VERSION to 1.5 and updated SUPPORTED_PROTOCOL_VERSIONS to reflect this change. r=markh 
MozReview-Commit-ID: 98knOLicr9E

--HG--
extra : rebase_source : 1acbb125c0512842abdfab068094cc744ce2d329
 2017-03-15 22:18:43 -04:00
David Rajchenbach-Teller 2508d8532a Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r=markh 
MozReview-Commit-ID: 3dZljFrvJUA

--HG--
extra : rebase_source : 355265e0dbdc169df308ba15212997373f781ea3
 2014-10-24 14:57:02 +02:00
Edouard Oger fe217294a0 Bug 1346136 - Add more leeway in backoff testing. r=markh 
MozReview-Commit-ID: 4M86B9BVbq9

--HG--
extra : rebase_source : 726bf645306864410f18bac78c3484e347e9ff7d
 2017-03-10 15:39:41 -05:00
Edouard Oger 036a984325 Bug 745410 - Remove microsummary support from Sync. r=kitcambridge 
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 1049da5ecc1a61ef6a042f67ab37b619118eb45a
 2017-03-10 15:03:07 -05:00
Wes Kocher 0cca2c83d5 Backed out changeset 9c8eac7852f6 (bug 745410) for build failures a=backout 
MozReview-Commit-ID: JY6fS63iCwJ
 2017-03-10 13:19:34 -08:00
Edouard Oger 5e9bd0d28b Bug 745410 - Remove microsummary support from Sync. r=kitcambridge 
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 184b254f3299209f98cfc50f6630050a2ca29ab1
 2017-03-10 15:03:07 -05:00
Thom Chiovoloni 577f26289e Bug 676563 - Add dateAdded field to synced bookmarks r=markh,rnewman 
MozReview-Commit-ID: 5dxoTGrypqm

--HG--
extra : rebase_source : 94af07afc4c0ae2faccc33247fa8f2df91683cce
 2017-01-17 14:45:08 -05:00
Edouard Oger 682b54d712 Bug 1339861 - Mark Sync clients as stale if not in the FxA device list. r=markh 
MozReview-Commit-ID: 84Tl3QTHInO

--HG--
extra : rebase_source : c05a5462be71b9eb0bc1bddc6a6a74f1b13088b7
 2017-02-28 16:35:01 -05:00
BharatR123 56b41b115e Bug 1345009 - remove _migratePrefs() function and related test and references in xpcshell.ini r=markh 
MozReview-Commit-ID: CbXXPLNXUet

--HG--
extra : rebase_source : 81ace434bc1ecdff3a84b9c8a978343d052ad1ea
 2017-03-07 14:41:46 +05:30
Kit Cambridge 35e400d22b Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc 
Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.

MozReview-Commit-ID: 7a0wR8nuJeW

--HG--
extra : rebase_source : 18ff025671c9dd5e2e30d441940f5c2fb804cae3
 2017-03-06 11:29:19 -08:00
Zibi Braniecki 100766fec4 Bug 1335877 - Remove resource://services-common/stringbundle.js from gecko. r=gandalf 
MozReview-Commit-ID: FNoj7XH71E4

--HG--
extra : rebase_source : 294d3e425ca60e2aac6149998da7f39f62864ae5
 2017-03-06 09:39:52 -08:00
Carsten "Tomcat" Book 1bc7720a43 Backed out changeset 0bd17b868a31 (bug 1335877) for causing regression bug 1344760 2017-03-06 17:03:11 +01:00
Edouard Oger 69b317e280 Bug 1321119 - Allow to Sync more tabs and reduce tabs history to 5. r=markh 
MozReview-Commit-ID: 7kRg4XQeT4C

--HG--
extra : rebase_source : 7558c92cc3fefe1ade2359008df9102f5ba72322
 2017-03-01 13:47:20 -05:00
Zibi Braniecki 4b7b3d4092 Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman 
MozReview-Commit-ID: M7V6JS5myy

--HG--
extra : rebase_source : a47d739d3dd67ce563088aaf9fab5421de376cd7
 2017-03-02 15:26:53 -08:00
Mark Hammond b86ff30666 Bug 1317223 (part 7) - disable tests on ASAN due to bug 1344085. r=kitcambridge 
MozReview-Commit-ID: 6L72ACMcDBq
 2017-03-03 10:54:45 +11:00
Mark Hammond 5712360194 Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r=tcsc 
A poor start, but at least it's something.

MozReview-Commit-ID: 8us4v6Y21oM
 2017-03-01 23:17:05 +11:00
Mark Hammond 9b6693b8ee Bug 1317223 (part 5) - a bookmark repair responder. r=kitcambridge 
This is the "repair responder" - it handles a "repairRequest" command sent
by another client and attempts to take the list of IDs that client lists as
missing and upload whatever records are necessary such that the requesting
client would then be likely to find a complete and valid tree on the server.

MozReview-Commit-ID: 4xw19nH6EfL
 2017-02-28 15:34:37 +11:00
Kit Cambridge 46e87ef366 Bug 1317223 (part 4) - formalize weak tracking in `BookmarksChangeset`. r=markh 
MozReview-Commit-ID: C6otrtSuhZH
 2017-02-06 10:19:27 -08:00
Mark Hammond 8c4e55d022 Bug 1317223 (part 3) - a bookmark repair requestor. r=markh,tcsc 
The bookmark repair requestor takes the validation results and possibly
initiates a bookmark repair.

MozReview-Commit-ID: 7rRNbBx8Vo3
 2017-03-02 19:21:53 +11:00
Mark Hammond de20e8f357 Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r=tcsc 
This patch defines the concept of a "doctor" for collections. The doctor is
responsible for running all validators and deciding whether or not to initiate
a repair request based on the validation results.

MozReview-Commit-ID: 6NLRE6L0OpA
 2017-03-02 17:14:31 +11:00
Mark Hammond 79d7981ee8 Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman 
MozReview-Commit-ID: 2jtCsl3sy3X

--HG--
extra : rebase_source : f0d24ca1a990abd8499f7f07eb7561840441dd1a
 2017-02-27 12:44:12 +11:00
Edouard Oger baba07044d Bug 1317667 - Use dates further in the future in test_bookmark_duping. r=kitcambridge 
MozReview-Commit-ID: 3R3tbbzio2I

--HG--
extra : rebase_source : f87d2261859ff7195e795e2e2ba4c5285536e6cf
 2017-02-27 11:44:22 -05:00
Gijs Kruitbosch b0f2da2a20 Bug 1341097 - part 3: don't dispatch oodles of titlechanged notifications for new history entries, r=mak 
MozReview-Commit-ID: 7jHOcCQ5ZBb

--HG--
extra : rebase_source : 6dff335e78857e7c860ebe7ec6ea415fe0f9e3f6
 2017-02-27 18:26:21 +00:00
Kit Cambridge ffd9158f97 Bug 1335752 - Disable persistence and clean up after `RotaryEngine` in tests. r=markh 
MozReview-Commit-ID: 8feE9O6Dv3W

--HG--
extra : rebase_source : c01eed08e72fd4ff654b3afed0472cb5185aec4e
 2017-02-13 13:48:08 -08:00
Thom Chiovoloni c396116b69 Bug 1337993 - Ensure we mark all current bookmarks for reupload when bookmark engine enabled state changes. r=kitcambridge 
MozReview-Commit-ID: 4gOmqrzUr77

--HG--
extra : rebase_source : ee645449c2bb08cc13a6b9040a0bbdd506d5c0a3
 2017-02-13 14:28:06 -05:00
Mark Hammond cd73a70071 Bug 1340357 - remove all special eslint rules in services/. r=eoger 
MozReview-Commit-ID: 6zMOBoWLOhJ

--HG--
extra : rebase_source : cf546abd9a52230746c0c05f7bb716cae42815bf
 2017-02-17 12:34:45 +11:00
Ethan Glasser-Camp b228d5b47d Bug 1321570 - use dependency injection for fxAccounts, r=kmag 
Get rid of the ugly hack where test code monkeypatches a singleton to
convince the rest of the ExtensionStorageSync code that a fake user is
logged in. Instead, take a handle to the fxAccounts service at
construction time. Test code can provide any kind of fxAccounts it
wants, including one that has a hard-coded user.

This provokes a bunch of changes:

- ExtensionStorageSync is now no longer a singleton, but a class. You
  have to instantiate it in order to do anything with it. A global
  instance extensionStorageSync is provided for use by Sync code as
  well as WebExtension code.

- CryptoCollection is now also a class, and each ExtensionStorageSync
  instance has its own CryptoCollection. This dependency should maybe
  also be injected, but for the time being it doesn't provide us any
  value to do so.

- Converting singletons with asynchronous methods to classes is a pain
  in the neck. We convert async method foo from `foo:
  Task.async(....)` to `async foo() { .... }`. While we're here,
  convert KeyRingEncryptionRemoteTransformer#decode to async/await to
  eliminate a need for `let self = this`.

- Update Sync code and WebExtension code to use extensionStorageSync.

- There's a cyclic dependency where CryptoCollection#sync depends on
  ExtensionStorageSync#_syncCollection which depends on
  CryptoCollection#getKeyRing. As a short-term hack, we now require an
  ExtensionStorageSync argument to CryptoCollection#sync.

- KeyRingEncryptionRemoteTransformer now takes a handle to fxAccounts
  on construction time as well. Because this is the only
  EncryptionRemoteTransformer subclass that accesses fxAccounts, we
  can get rid of the hack where the tests monkeypatch something in the
  EncryptionRemoteTransformer prototype.

- CollectionKeyEncryptionRemoteTransformer now takes a handle to a
  CryptoCollection, rather than relying on a global one.

- A bunch of methods that previously assumed access to fxAccounts now
  check if fxAccounts is present (i.e. if we're on Android). Strictly
  speaking, this isn't required by this change, but it helps make
  certain kinds of failure a little easier to diagnose.

- Update tests, including extracting a domain-specific helper method
  to hide the use of CollectionKeyEncryptionRemoteTransformer. We now
  no longer monkeypatch in our mock fxaService, but pass it to the
  test so that it can do whatever it wants with it. We also provide an
  ExtensionStorageSync instance for convenience. Access to the global
  cryptoCollection is now done through an ExtensionStorageSync
  instance.

To summarize, we've gone from a situation where a bunch of singletons
had implicit dependencies on other singletons in a shared global
namespace, to a situation where dependencies are provided explicitly
using method/constructor arguments. This highlights some of the
dependencies present:

- ExtensionStorageSync depends on CryptoCollection and fxAccounts if
  it needs to sync

- Every collection created via openCollection needs a handle to
  CryptoCollection so it can correctly create its remote transformers

- CryptoCollection needs a handle to fxAccounts so it can create its
  own remote transformer for its special collection

Most of this is only possible, or at least much easier, because we no
longer try to juggle Sqlite connections but just keep one around
forever.

However, please note:

- CryptoCollection needs a handle to ExtensionStorageSync to actually
  perform syncing logic because that's where we foolishly put the
  logic to make requests

- There's still a backing Sqlite store which is shared by everything

- There's still a singleton tracking contexts that opened extensions
  which we manage to try to clean contexts up correctly

MozReview-Commit-ID: DGIzyRTdYZ1

--HG--
extra : rebase_source : 305a98b8e1ece3ae7a5e8a2fdb5c58d8e7c496d9
 2017-01-10 16:44:01 -05:00
Ethan Glasser-Camp 4f7afb05a6 Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag 
Since services/sync doesn't ship on Android, this meant
conditionally-defining some variables such as `cryptoCollection` and
`CollectionKeyEncryptionRemoteTransformer` depending on whether or not
we were on Android. However, none of these definitions really rely on
functionality that isn't present on Android (although you can't really
use them yet either). Move the dependency together with the dependant
code so we can simplify a bit. This lets us remove conditional uses of
`cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer`.

Because the WebExtensions source directory has more stringent eslint
rules, we end up reformatting and commenting a bit in addition to
moving.

MozReview-Commit-ID: 2ddDeymYFNi

--HG--
rename : services/sync/tests/unit/test_extension_storage_crypto.js => toolkit/components/extensions/test/xpcshell/test_ext_storage_sync_crypto.js
extra : rebase_source : f84c0810b6a447f2104f96c9dc9d6139743f269c
 2017-02-13 15:06:02 -05:00
Phil Ringnalda aa72959f4e Bug 1338439 followup, placate eslint 2017-02-12 20:50:46 -08:00
Mark Hammond e23f30ffed Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc 
MozReview-Commit-ID: 7a6qjRUswGL

--HG--
extra : rebase_source : a6112f4fb8762f3cde4a85aaa5ef4a8d11b15947
 2017-02-10 16:49:33 +11:00
Kit Cambridge e73b9cdef7 Bug 1338668 - Ignore tag query folder IDs when comparing client and server bookmark records. r=tcsc 
MozReview-Commit-ID: 2Mz9fTsTou5

--HG--
extra : rebase_source : e2030c91a20356d61677a212fa57f88d680bfb90
 2017-02-10 15:03:34 -08:00
Phil Ringnalda 3063243dfc Bug 1323867 followup, placate eslint 2017-02-07 16:20:31 -08:00
Kit Cambridge 1e92ba873d Bug 1323867 - Bump bookmark validation threshold to 1k. r=tcsc 
This patch also refactors `compareServerWithClient` and
`inspectServerRecords` to periodically yield back to the main thread,
since validating a large number of bookmarks in a tight loop causes
jank. Yielding every 50 records for 50ms is somewhat arbitrary, but
keeps things snappy for my profile (2947 records).

MozReview-Commit-ID: 99DJtNvNeHI

--HG--
extra : rebase_source : cc0991106c17ce906b8779afbe9eced0e27cc4b4
 2017-01-12 14:02:45 -07:00
Kit Cambridge 912d625cf7 Bug 1325523 - Persist tracked IDs on finalization, and don't persist IDs in Sync tests. r=markh 
MozReview-Commit-ID: CpQP2aM1DO

--HG--
extra : rebase_source : 02fa555cc44bd9d94a6c3beedf00fa1746f0c637
 2017-02-07 11:51:06 -08:00
Mark Hammond f02fca824e Bug 1310065 - use more reliable preferences for calculating the client count in the sync scheduler. r=eoger 
This patch switches to using preferences written by the clients engine to
determine the number of clients so it's correct before the first sync for
a browser session.

It also fixes another bug I discovered - if a mobile device dropped from the
client list, the preference for the number of mobile devices would remain at
1 rather than resetting to zero.

MozReview-Commit-ID: IPythSQcorx

--HG--
extra : rebase_source : 4ce465e3958d037f90312553a0c353cdc161c0fe
 2017-01-25 18:11:05 +11:00
Edouard Oger cfc8f37c1b Bug 1317667 - Use async bookmark methods in test_bookmark_duping. r=kitcambridge 
MozReview-Commit-ID: CpvcDXKkfcl

--HG--
extra : rebase_source : 4d143bdf9af7727933a74a9f05c7a56baa5c321b
 2017-02-03 13:52:39 -05:00
Edouard Oger f7e895d911 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh 
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : 71c2a627bd0291fa2b9448710e6b0eb1fae36719
 2017-01-24 17:05:12 -05:00
Sebastian Hengst 573326d526 Backed out changeset 20863de3b8f4 (bug 1329850) for eslint failure: redeclaration of collection in deeper scope in test_syncengine_sync.js. r=backout 2017-01-31 18:46:39 +01:00
Edouard Oger ecdeb55693 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh 
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : bce1d12bf1fdb7867ac0f290fdfe4e6b5d761bcc
 2017-01-24 17:05:12 -05:00
Mark Banner 8cf0d4744c Bug 1333044 - Enable no-undef eslint rule for services/. r=markh 
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 72df6ddc457431ae77f953a00712462e4902b5f1
 2017-01-23 15:15:05 +00:00
Mark Banner df3fdf012f Bug 1333044 - Fix no-shadow issues in services/. r=markh 
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : b93a673073045ddfec6e4b4b347b4e8494425310
 2017-01-23 14:07:55 +00:00
Mark Banner 2ecc79b536 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws 
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : c4b19fe3714b19b445011ae1c413ca0e624cb46e
 2017-01-17 12:25:43 +00:00
Edouard Oger 1d38375171 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh 
MozReview-Commit-ID: E4S5xYTNDIH
 2017-01-27 13:31:58 -05:00
Edouard Oger ad36606986 Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh 
MozReview-Commit-ID: Kmsxn10sA2X
 2017-01-27 13:31:58 -05:00
Edouard Oger f5eb6dc494 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh 
MozReview-Commit-ID: LK9akz4chd1
 2017-01-27 13:31:57 -05:00
Edouard Oger ea99e4442d Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh 
MozReview-Commit-ID: 7YDYTCRiKZa
 2017-01-27 13:30:48 -05:00
Edouard Oger cdce850c10 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh 
MozReview-Commit-ID: 12pP01IHRyp
 2017-01-27 13:30:48 -05:00
Edouard Oger df80e282e9 Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh 
MozReview-Commit-ID: AFRyZFW6xZU
 2017-01-27 13:30:48 -05:00
Edouard Oger bf4dae4e25 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh 
MozReview-Commit-ID: IC7kRjgtPp8
 2017-01-27 13:30:47 -05:00
Edouard Oger c94655827a Bug 1296767 part 2 - Remove Sync UserApi. r=markh 
MozReview-Commit-ID: CdgLxCN52Os
 2017-01-27 13:30:47 -05:00
Edouard Oger bb525e4654 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh 
MozReview-Commit-ID: iD4OJv436i
 2017-01-27 13:30:47 -05:00
Wes Kocher c3cc3b6407 Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE 
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL

--HG--
extra : amend_source : 1afafaa8127fcebac31ce1d7743dc16872fa0522
 2017-01-26 11:16:12 -08:00
Edouard Oger 1595b78c75 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh 
MozReview-Commit-ID: E4S5xYTNDIH

--HG--
extra : rebase_source : 6a98b9503183bbf679622b00073d162fd3e4f5e4
 2017-01-23 15:19:04 -05:00
Edouard Oger f49ecb465d Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh 
MozReview-Commit-ID: Kmsxn10sA2X

--HG--
extra : rebase_source : 87bebd2abc19a6b62647d4bcb48193765a3622e2
 2017-01-19 13:19:33 -05:00
Edouard Oger b41402ea7b Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh 
MozReview-Commit-ID: LK9akz4chd1

--HG--
extra : rebase_source : b7113c37a486f88ae1138c54e314bb0ff07ef1af
 2017-01-18 17:39:11 -05:00
Edouard Oger 17b83cde16 Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh 
MozReview-Commit-ID: 7YDYTCRiKZa

--HG--
extra : rebase_source : 41574e70bd92ee2abe6f92a799c57e1f5910f8b4
 2017-01-18 16:30:38 -05:00
Edouard Oger 9050cab070 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh 
MozReview-Commit-ID: 12pP01IHRyp

--HG--
extra : rebase_source : 2c5af253df77ed08dd8bdf0c7645ed98e6a96c9a
 2017-01-18 15:52:47 -05:00
Edouard Oger cfef81983f Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh 
MozReview-Commit-ID: AFRyZFW6xZU

--HG--
extra : rebase_source : 6110e19a51d6d3375b47f785c8f644ee879fb924
 2017-01-13 15:59:32 -05:00
Edouard Oger 49552f7919 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh 
MozReview-Commit-ID: IC7kRjgtPp8

--HG--
extra : rebase_source : ec10c24400afa4b1c1fd3840f31a9d57d498ec8a
 2017-01-13 15:02:21 -05:00
Edouard Oger eb0c42bf7a Bug 1296767 part 2 - Remove Sync UserApi. r=markh 
MozReview-Commit-ID: CdgLxCN52Os

--HG--
extra : rebase_source : c270d7dfbaf621c1eb8f440009b361212969a8bc
 2017-01-13 15:54:46 -05:00
Edouard Oger 0c915a6f46 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh 
MozReview-Commit-ID: iD4OJv436i

--HG--
extra : rebase_source : 1653284a3b2e014719a7eb37588f99df868e2060
 2017-01-10 13:47:24 -05:00
Kit Cambridge 009412ee92 Bug 1332024 - Finalize tracker storage and consolidate cleanup logic in engine tests. r=markh 
MozReview-Commit-ID: 8t9bXFrLA1Z

--HG--
extra : rebase_source : 51e15f6cc8fd44947f42cc59be413df6775291b0
 2017-01-24 09:59:09 -08:00
Carsten "Tomcat" Book aaafcb0f0a Backed out changeset f8b29e24280b (bug 1333044) for perma failures in test_load_modules.js 
--HG--
extra : rebase_source : ef649da0bb1acaabcb55a42e5df4164f1cf8b6d4
 2017-01-25 15:29:53 +01:00
Carsten "Tomcat" Book f868542f9b Backed out changeset 06a658a93aab (bug 1333044) 
--HG--
extra : rebase_source : 554fed79a1c36ce418ab95952cde9669a3297cb6
 2017-01-25 15:29:35 +01:00
Carsten "Tomcat" Book a6178c3af9 Backed out changeset 9c6b98edac72 (bug 1333044) 
--HG--
extra : rebase_source : e81a05f7fa7ffca19ced3e0aca62ada7bde935b2
 2017-01-25 15:29:33 +01:00
Mark Banner eb102a103e Bug 1333044 - Enable no-undef eslint rule for services/. r=markh 
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 19e5895756579ecf88d5be70e8aaaf8c3166ada1
 2017-01-23 15:15:05 +00:00
Mark Banner caa2f51ce1 Bug 1333044 - Fix no-shadow issues in services/. r=markh 
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : 32511d0a015fe57f0b8262b0faa28dbd4bd7a623
 2017-01-23 14:07:55 +00:00
Mark Banner 33c00194c2 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws 
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : 9b5edc75897af35754433b6fccfcecf83293c62b
 2017-01-17 12:25:43 +00:00
Jared Wein a1b9179389 Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh 
MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 4dc9dddaa26d1c10f859dc7a08b64168a1d0fdd5
 2017-01-12 18:28:48 -05:00
Jared Wein 516a926c6e Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh 
MozReview-Commit-ID: 7ADLmPB4eSu

--HG--
extra : rebase_source : 94a966d6cbc5c2b6b6097355fc3aa84dd50e27f5
 2017-01-12 18:19:47 -05:00
Jared Wein ac53e1b8be Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors. r=markh 
MozReview-Commit-ID: 7Os4uZQCDox

--HG--
extra : rebase_source : 2a1d9ef6fb6510f7f3b02b6c727bc706e56637b0
 2017-01-12 18:14:54 -05:00
Jared Wein d019dbcaa8 Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh 
MozReview-Commit-ID: Ixd7jk5G5CB

--HG--
extra : rebase_source : 0f5817cb03f26c28d401706069ba9aa23f6acce3
 2017-01-12 18:08:10 -05:00
Jared Wein 7cb8b041fe Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh 
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : c6abc288124c1c47480cc73db8294195d8832fa2
 2017-01-12 18:02:08 -05:00
Mark Banner 16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps 
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
 2017-01-18 10:30:39 +00:00
Kit Cambridge 14b98b514b Bug 1317579 - Don't send a sync ping for self-hosters. r=tcsc 
MozReview-Commit-ID: 601nfXW0gT6

--HG--
extra : rebase_source : e0f96250cb101c3de020fadd856f28f0d8a4bfa8
 2016-12-22 19:00:34 -07:00
Wes Kocher 20dc006d88 Backed out 14 changesets (bug 1330791) for various android failures a=backout 
Backed out changeset eada8de7256f (bug 1330791)
Backed out changeset a3c656a9f3ca (bug 1330791)
Backed out changeset e0cbc754e841 (bug 1330791)
Backed out changeset 49d8016fab12 (bug 1330791)
Backed out changeset 53d4b83ccd22 (bug 1330791)
Backed out changeset b35cbfcd801f (bug 1330791)
Backed out changeset 25a6356de622 (bug 1330791)
Backed out changeset 46f9c247550d (bug 1330791)
Backed out changeset ef7356099bd3 (bug 1330791)
Backed out changeset a5fe483288db (bug 1330791)
Backed out changeset 4902107b7568 (bug 1330791)
Backed out changeset 5b2b2be2e389 (bug 1330791)
Backed out changeset 610ec89e98bb (bug 1330791)
Backed out changeset 631adda26a21 (bug 1330791)

MozReview-Commit-ID: GGUFW29U3TL
 2017-01-17 17:06:36 -08:00
Jared Wein 4bca295e61 Bug 1330791 - Enable the no-native-reassign rule for eslint in /services and fix the associated error. r=markh 
MozReview-Commit-ID: 65EsZGCJPMD

--HG--
extra : rebase_source : 716697450e8506240a50a29508bf4943c37f48ef
 2017-01-12 18:28:48 -05:00
Jared Wein 16f3cc90b4 Bug 1330791 - Enable the no-redeclare rule for eslint in /services and fix the associated errors. r=markh 
MozReview-Commit-ID: 7ADLmPB4eSu

--HG--
extra : rebase_source : 2305e778e5a37a6c32753b021789c3a8c0077c69
 2017-01-12 18:19:47 -05:00
Jared Wein d3dba448bd Bug 1330791 - Enable no-else-return rule for eslint in /services and fix associated errors. r=markh 
MozReview-Commit-ID: 7Os4uZQCDox

--HG--
extra : rebase_source : 8d14b02c97b8024268b5625a633393e75efed117
 2017-01-12 18:14:54 -05:00
Jared Wein e1a3fb1d47 Bug 1330791 - Enable the no-useless-call eslint rule for /services and fix associated errors. r=markh 
MozReview-Commit-ID: Ixd7jk5G5CB

--HG--
extra : rebase_source : a4c226744a30df49d408a8c904fefa27b1439388
 2017-01-12 18:08:10 -05:00
Jared Wein 42349d27b4 Bug 1330791 - Enable the no-unused-vars rule for eslint in /services and fix associated errors. r=markh 
MozReview-Commit-ID: DFcvEllwGSb

--HG--
extra : rebase_source : 24dc56342d6b1a95df64c0c7c5a1819344cfe603
 2017-01-12 18:02:08 -05:00
Jared Wein 43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
 2017-01-17 09:48:17 -06:00
Wes Kocher f8a62a9ce6 Merge m-c to inbound, a=merge 
MozReview-Commit-ID: ASajzspkOe1
 2017-01-13 15:48:34 -08:00
Florian Quèze 1e42cad36c Bug 1330464 - script-generated removal of additional parameters that don't exist in the interface, r=jaws. 2017-01-13 20:21:53 +01:00
Jared Wein 65605f286e Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8 
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : cbfc8d4474b6c3d46eb21374e33fd3341403444f
 2017-01-10 12:09:02 -05:00
Iris Hsiao 55313b4bc9 Backed out changeset 7e0a0bd74199 (bug 1330014) 2017-01-13 11:06:43 +08:00
Jared Wein 81cb5e57b9 Bug 1330014 - Add .eslintrc.js file to /services and run eslint --fix to automatically fix most of the errors. --fix brings the error count down from 4083 to 321 errors. r=markh,standard8 
MozReview-Commit-ID: EjyAssqiQk8

--HG--
extra : rebase_source : d783829bc7fced3044d0d076c4786a6957d29bb6
 2017-01-10 12:09:02 -05:00
Kit Cambridge 08ec8494fb No bug - Log tracker contents in test_telemetry.js to diagnose intermittent failures. a=testonly 
MozReview-Commit-ID: 2qUNV7Cz7pd

--HG--
extra : rebase_source : b9c6e4c6adc506f05ef7ec5982444aebdba32fc4
 2017-01-11 15:30:25 -07:00
Mark Banner 582fcb8090 Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws 
MozReview-Commit-ID: 5NKHHb70YA6

--HG--
extra : rebase_source : 4551e56f56065349fb9ddc8d90e67f9dc84c1701
 2017-01-09 10:12:26 +00:00
Florian Quèze fc6379e827 Bug 1329182 - remove trailing newURI null parameters in the rest of the tree, r=jaws. 2017-01-09 20:27:26 +01:00
Mark Hammond 5f7905c8f3 Bug 1289536 (part 2) - Add a unique flowID GUID to each command sent via the clients collection. r=rnewman 
MozReview-Commit-ID: 4eTFDq4Yr7S

--HG--
extra : rebase_source : faa5cb3ddd41e107b898412b0c9c5899df91c335
 2016-11-04 12:46:57 +11:00
Mark Hammond 85c80336b8 Bug 1289536 (part 1) - Add events to Sync ping. r=gfritzsche 
MozReview-Commit-ID: 184fIhelOa6

--HG--
extra : rebase_source : bf7c96a473b92a42411fe5c94ac6802d42ff57d5
 2016-11-04 17:57:09 +11:00
Thom Chiovoloni 1330224f6a Bug 1301389 - Only include the uid and device ID once in the sync ping. r=markh 
Previously this was included for each sync. In addition to being less efficient,
this makes certain info that's planned to be added in the future more difficult.

MozReview-Commit-ID: fjOvAJJVI6

--HG--
extra : rebase_source : edb9a60a101c1110560c1ceb61a927248bed06e9
 2016-11-21 16:34:46 -05:00
Kit Cambridge 1897a70d72 Bug 1325523 - Clean up after tests that modify tracker contents. r=markh 
MozReview-Commit-ID: 45g4n4UipTW

--HG--
extra : rebase_source : 1be78706cab9b42d0c6c949243b9a835351486fa
 2016-12-29 18:18:38 -07:00
Kit Cambridge 4797a3b6cd Bug 1319175 - Switch to `JSONFile` for tracker persistence. r=markh 
MozReview-Commit-ID: 6nhGe9aHSk3

--HG--
extra : rebase_source : 43449f689a47287e034b80d3cbdd2fd5fbba44ab
 2016-12-20 12:25:27 -07:00
Wes Kocher b5de71ec44 Merge m-c to autoland, a=merge 2016-12-01 15:46:49 -08:00
Kit Cambridge 666a52df0a Bug 1319037 - Disable trace logging and increase timeout factor for test_bookmark_tracker.js. a=testonly 
MozReview-Commit-ID: EmSdy92cYzc

--HG--
extra : rebase_source : 8e15718c657cbd7fd1ecae0bf4a4c86c51a70b8c
 2016-11-29 13:21:56 -07:00
Kit Cambridge 52ddf2d3d0 Bug 1319328 - Wait for pending statements before checking annos in test_mobile_query. a=testonly 
MozReview-Commit-ID: BW5b0FgvwMD

--HG--
extra : rebase_source : 6af0f95c3aca4e434533bc496f1b695b8c74100d
 2016-11-29 13:13:20 -07:00
André Bargull 82ed270fce Bug 1319937 - Remove String generics uses in services/sync. r=markh 2016-11-24 13:17:08 -08:00
Thom Chiovoloni 39c3163cf7 Bug 1321396 - Skip oversized records without aborting the sync by default in sync engines. r=markh 
MozReview-Commit-ID: 7hgzyKb2UxY

--HG--
extra : rebase_source : 7c7f238a8e46b0776afe83798061d1539b07f76c
 2016-11-30 17:28:52 -05:00
Mark Hammond 632c46235a Bug 1317216 - consistently use the Sync client GUID as the basis for the device ID in the sync ping. r=tcsc 
MozReview-Commit-ID: BDTqnM7de6n

--HG--
extra : rebase_source : 169b3ad54dd19b5ef319d1e09684c0fd474e695b
 2016-11-10 19:12:55 +11:00
Mark Hammond 40140fc9de Bug 1319323 (part 2) - improve sync unit tests; SyncTestingInfrastructure now uses the FxA identity provider. r=tcsc 
MozReview-Commit-ID: 2zpZMpvbAy

--HG--
extra : rebase_source : a33b15a3ef8acf39a7a423694093a690ca519c88
 2016-11-22 15:03:47 +11:00
Mark Hammond f3312b9b72 Bug 1319323 (part 1) - improve sync unit tests; remove many ensureLegacyIdentityManager calls. r=tcsc 
MozReview-Commit-ID: CV6cpo2Tp5O

--HG--
extra : rebase_source : 03f8fb39e69065bf7263b8bc20e4b2641a247b01
 2016-11-21 12:22:24 +11:00
Kit Cambridge 73fba410f4 Bug 1173359 - Exclude hidden pages and framed links from syncing. r=markh 
MozReview-Commit-ID: 8I4Sulyr0H7

--HG--
extra : rebase_source : 55fb1ff567c0a2916bc0153a09c41b03d396cfeb
 2016-11-22 12:52:09 -07:00
Kit Cambridge ce8909d3fb Bug 1173359 - Convert the history tracker tests to use async functions. r=markh 
MozReview-Commit-ID: CFNLQkRa7Qb

--HG--
extra : rebase_source : 086dbe074f6979428e826aa1faa7ab75100a0dad
 2016-11-22 12:34:02 -07:00
Mark Hammond 682d81fa5d Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc 
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 2b16f697902736ef39cded96c1bd98b547136263
 2016-11-10 14:34:38 +11:00
Thom Chiovoloni 15acd98009 Bug 1273342 - Don't retry skippable records that fail to sync due to being too large. r=markh 
MozReview-Commit-ID: HjzL1crTVDB

--HG--
extra : rebase_source : 887c3364bf0dec05353c2ea7e7c23d6393158fa3
 2016-11-21 15:37:35 -05:00
Kit Cambridge 8c2abe0611 Bug 1318414 - Default to empty strings for titles and parent titles if not set. r=rnewman,tcsc 
MozReview-Commit-ID: DppxJuVrbAM

--HG--
extra : rebase_source : a214d54fda7d25798039fc9844c34cabd3165a27
 2016-11-19 08:29:26 -08:00
Kit Cambridge ccee4d37f5 Bug 1258127 - Add migration logic for old synced bookmarks. r=markh,rnewman 
MozReview-Commit-ID: Gye30bYZejy

--HG--
extra : rebase_source : 882c4769d28ad4b56829e5b6037f74c04028f03a
 2016-11-18 14:00:56 -08:00
Kit Cambridge 4c26a7b758 Bug 1258127 - Move bookmark deletion logic into `PlacesSyncUtils.bookmarks.remove`. r=tcsc 
This patch moves most of `BookmarksStore::deletePending` and
`BookmarksStore::_shouldReviveRemotelyDeletedRecord` into
`PlacesSyncUtils.bookmarks.remove` and `touch`, respectively. Both
methods use the same approach as `PlacesSyncUtils.bookmarks.dedupe` to
amend the `_modified` changeset with new change records.

We use the new `SYNC_REPARENT_REMOVED_FOLDER_CHILDREN` change source to
bump the change counters for the reparented items and their new
parents, without bumping the score and triggering extra syncs.

MozReview-Commit-ID: 1SZvygWNkgL

--HG--
extra : rebase_source : 97fdac6ccb0d0326a3da7e42259dc6a961994ac3
 2016-11-17 15:07:14 -08:00
Kit Cambridge 69350f8b7b Bug 1258127 - Move bookmark de-duping logic into `PlacesSyncUtils.bookmarks.dedupe`. r=markh 
This patch moves the logic from `BookmarksEngine::_switchItemToDupe`
into `PlacesSyncUtils.bookmarks.dedupe`, and updates it to work with
the new tracker. `dedupe` returns an object containing new change
records, which the bookmarks engine merges into the initial changeset
from `PlacesSyncUtils.bookmarks.pullChanges`.

This patch also removes `changeItemID` and
`PlacesSyncUtils.bookmarks.changeGuid`, since `dedupe` subsumes them.

MozReview-Commit-ID: Iw3YRxWuZnK

--HG--
extra : rebase_source : 6fd80c64b160103e1090b87a300ed74b8ef85eed
 2016-11-17 15:04:19 -08:00
Kit Cambridge ccf45973d0 Bug 1258127 - Update the bookmarks engine to pull changes from Places. r=markh 
MozReview-Commit-ID: 4YESuxP2rRf

--HG--
extra : rebase_source : 9c2f5830d10ba280e45c30076f19f498e6913fd0
 2016-11-17 15:39:15 -08:00
Phil Ringnalda 1583627c71 Backed out changeset ca02f30bc3a0 (bug 1316500) for eslint failures 2016-11-16 19:32:10 -08:00
Mark Hammond e35c5ab29f Bug 1316500 - remove use of tasks and promise.jsm promises from Sync tests. r=tcsc 
MozReview-Commit-ID: 5itPSLBKguc

--HG--
extra : rebase_source : 9c0ee4387d4b3d7df56c1e9ccda0ec39cd5b11e2
 2016-11-10 14:34:38 +11:00
Kit Cambridge 6cd5db91d6 Bug 1303679 - Remove Places roots, reading list items, and pinned sites from the Sync server. r=markh 
MozReview-Commit-ID: AhOBOnXsTYi

--HG--
extra : rebase_source : 1f39b406b1a9215ca04ff4602cc8fac54163916f
 2016-11-09 14:23:54 -08:00
Ethan Glasser-Camp 2ee9c896d5 Bug 1253740 - Add crypto, including tests, r=rnewman 
MozReview-Commit-ID: Jq8QRoNtPwb

--HG--
extra : rebase_source : 3524b723c3bf14263b54a97e4b21256d9abd180f
extra : source : 66877faacf75cd4de31ae868ce034d254ec8a080
 2016-09-08 14:21:18 -04:00
Ethan Glasser-Camp ff10caa15d Bug 1253740 - Introduce extension-storage engine with a sanity test, r=markh 
Note that this "enables" the engine using a pref, even though it might
not be ready yet, so that the tests can pass.

MozReview-Commit-ID: AZ0TVERiQDU

--HG--
extra : rebase_source : 8ca202c1ec79e068fb9395207792942a228d4433
extra : intermediate-source : 93f41b72d8e7023b5f22c727436e836de87c9ca7
extra : source : 183547f4dbbedc9ee3399b6a474016d0e89a12e8
 2016-09-08 14:23:12 -04:00
Wes Kocher 57c08b3b40 Backed out 9 changesets (bug 1253740) for xpcshell failures a=backout 
Backed out changeset 903890f218dd (bug 1253740)
Backed out changeset 1b13fe394b66 (bug 1253740)
Backed out changeset e1312ab53299 (bug 1253740)
Backed out changeset 5b5338a2baeb (bug 1253740)
Backed out changeset d3d89d4e2d87 (bug 1253740)
Backed out changeset 96da5e6944b8 (bug 1253740)
Backed out changeset 4fbff333994f (bug 1253740)
Backed out changeset 653788e146f2 (bug 1253740)
Backed out changeset b98fa03d8c15 (bug 1253740)
 2016-11-11 18:59:24 -08:00
Ethan Glasser-Camp 8be871dd00 Bug 1253740 - Add crypto, including tests, r=rnewman 
MozReview-Commit-ID: Jq8QRoNtPwb

--HG--
extra : rebase_source : f00b8108330a244229cf8b409bc59a4c5f331e2c
extra : source : 66877faacf75cd4de31ae868ce034d254ec8a080
 2016-09-08 14:21:18 -04:00
Ethan Glasser-Camp 138ba0ff0a Bug 1253740 - Introduce extension-storage engine with a sanity test, r=markh 
Note that this "enables" the engine using a pref, even though it might
not be ready yet, so that the tests can pass.

MozReview-Commit-ID: AZ0TVERiQDU

--HG--
extra : rebase_source : 3078b86c4255afd66a9c4faf895dc2b6fc43a152
extra : intermediate-source : 93f41b72d8e7023b5f22c727436e836de87c9ca7
extra : source : 183547f4dbbedc9ee3399b6a474016d0e89a12e8
 2016-09-08 14:23:12 -04:00
Thom Chiovoloni 8363f8b9c7 Bug 1313573 - Validate the sync ping during TPS test runs r=markh 
MozReview-Commit-ID: Jy7VpAvhbPf

--HG--
extra : rebase_source : 36dce5d68a7236d90af50756ac58dbe021d35f4f
 2016-11-02 14:25:07 -04:00
Sebastian Hengst 0dc4492dd2 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: services. r=RyanVM 
MozReview-Commit-ID: DuzsFEaAeYr

--HG--
extra : rebase_source : b6c4cb95bf0563b0abd48949d50d2c156c86602b
 2016-11-05 11:29:21 +01:00
Thom Chiovoloni b9e92c7821 Bug 1309774 - Part 2. Add version number to validation data in sync ping. r=markh 
MozReview-Commit-ID: FlDSEsT1ah9

--HG--
extra : rebase_source : 327bcac18dba5c685092e311e2be880b6d616e07
 2016-10-20 15:20:07 -04:00