We should preserve e.g. the `-fcrash-diagnostics-dir` that is included indirectly via the sourcing of `mozconfig.asan` at line 14.
Differential Revision: https://phabricator.services.mozilla.com/D89952
This test requires search mode, but it doesn't enable update2, so it fails on
non-Nightly. It only needs to enable update2 like other search-mode tests do.
Differential Revision: https://phabricator.services.mozilla.com/D89850
The "Search in a Private Window" result is included only in Nightly builds, so
this test needs to either enable the corresponding pref, or disable the pref and
remove that result from the expected results. This patch does the latter.
Differential Revision: https://phabricator.services.mozilla.com/D89849
The _shortName variable is basically redundant, and we can transfer the remaining 'identifier' handling across to the telemetry Id as they were virtually the same.
Differential Revision: https://phabricator.services.mozilla.com/D88623
This also moves gInitialised into SearchService, as it no longer needs to be separate, and it makes changing it for tests easier.
Depends on D88462
Differential Revision: https://phabricator.services.mozilla.com/D88622
This patch adds support for key modifiers on the refreshed one-offs. They work the same as the old key modifiers, with one exception: Shift+Click and Shift+Enter both execute a search immediately in the current tab, replicating the behaviour of the old one-offs. For empty searches, Shift+Click and Shift+Enter just enter search mode. To support these Shift modifiers, we dropped support for opening a one-off search in a new window. Users can still search in a new window with a non-default engine by typing a search string, selecting a one-off with the keyboard, then Shift+Clicking the heuristic result or the Go button.
Other key modifiers worth pointing out include Accel+Click to search in a new background tab and Alt+Enter to search in a new foreground tab. If these modifiers are used on the local one offs or with an empty query, we open search mode in the new tab.
Differential Revision: https://phabricator.services.mozilla.com/D89504
This is ultimately less build magic and makes for more meaningful URIs.
This patch paves the way for the second patch in this stack which fixes bug 1655456.
Differential Revision: https://phabricator.services.mozilla.com/D89130
See bug for justification. This patch aims to display a blank window prior to
loading/prefetching xul.dll. It also has a placeholder for drawing a
skeleton UI into that window. Note that this is disabled by default based on
a registry value, as there are still kinks to work out (for instance, what
happens if we aren't actually going to display a window, because, say, Firefox
is already running.) This just gives a basic implementation to dogfood, and
facilitates distributing work across multiple contributors.
Onto the details. The patch achieves its goal by creating a window and
assigning its handle to a static variable, which will be consumed inside
nsWindow::Create by the first toplevel window we want to make. nsWindow::Create
will take ownership of the window handle, restyle it to its own liking, and
then proceed as if everything is normal and it had created the window itself.
Differential Revision: https://phabricator.services.mozilla.com/D86263
This introduces the enrollment ping (really the existing 'ping-study'
ping with a different schema name) that is sent both when user joins
Pioneer and when they join a new study.
The one sent when joining pioneer has a different namespace, because
we want this data to flow in a separate dataset. The one sent when
joining the study behaves like the deletion-request, has an empty
payload and is properly routed to the study table due to the rules
on the pioneer ingestion pipeline.
This additionally lands documentation required for data-review.
Differential Revision: https://phabricator.services.mozilla.com/D89718
This introduces the enrollment ping (really the existing 'ping-study'
ping with a different schema name) that is sent both when user joins
Pioneer and when they join a new study.
The one sent when joining pioneer has a different namespace, because
we want this data to flow in a separate dataset. The one sent when
joining the study behaves like the deletion-request, has an empty
payload and is properly routed to the study table due to the rules
on the pioneer ingestion pipeline.
This additionally lands documentation required for data-review.
Differential Revision: https://phabricator.services.mozilla.com/D89718
James Teh
Gijs Kruitbosch
Chris Jackson
Razvan Maries
Mark Banner
Marco Bonardo
David Major
Mike Conley
Drew Willcoxon
Thomas Wisniewski
Harry Twyford
Robert Helmer
Scott
Jim Mathies
Dorel Luca
Artem Polivanchuk
Edouard Oger
Nihanth Subramanya
Denis Palmeiro
Punam Dahiya
Andrei Oprea
Doug Thayer
Dan Mosedale
Alessio Placitelli
Dão Gottwald
Tarek Ziadé
Cosmin Sabou
Narcis Beleuzu
Agi Sferro
Tomislav Jovanovic