dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
af20a470c6
Bug 1545120: Simplify this callback management stuff a little. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D27914
--HG--
extra : moz-landing-system : lando
2019-04-18 14:53:18 +00:00
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
6d7cf47871
Bug 1498651 - make initial timer target setting more efficient; r=erahm
...
The NS_NewTimer* family of functions, when using a custom event target,
currently go through a path that looks something like:
auto timer = createTimer()
timer->SetTarget(target);
// call the requisite Init* function
return timer;
This setup is inefficient, because SetTarget requires the timer mutex to
be acquired. The mutex acquisition here is completely unnecessary,
because the timer hasn't yet been shared out to the wider world; we can
set the timer target without acquiring the mutex at all because we know
that no sharing is possible at this point.
This patch reworks things somewhat to make that possible.
2018-10-17 19:57:36 -04:00
6b3da0609f
Bug 1383019: Move more logic under the protection of nsTimerImpl::mMutex, and simplify. r=froydnj, a=abillings
...
MozReview-Commit-ID: JjYScKwyika
--HG--
extra : rebase_source : a5a8a17f86459ace51d9250454bd4cf1433130b0
2017-09-14 12:19:24 -05:00
1467938d67
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
9f887e9104
Backed out changeset 37c9e9d07aac (bug 1351148)
2017-08-11 15:19:51 +08:00
64a5f2d51c
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
c24a288e9a
Backed out changeset 420d9e53c959 (bug 1351148) for causing regressions / on request from stone
2017-07-28 09:20:54 +02:00
afa6a2e045
Bug 1351148 Part1: Add include header to TimerThread.h to fix compile errors. r=smaug.
...
MozReview-Commit-ID: 65UfFMwmSrm
2017-05-29 17:19:17 +08:00
be1903d4a8
Bug 1363829 P12 Expose nsITimer::InitHighResolutionWithCallback() method. r=froydnj
2017-05-31 17:13:19 -07:00
8e2322bcce
Bug 1311425 - Make idle callbacks aware of nsITimers, r=froydnj
...
--HG--
extra : rebase_source : 3baa3054c1ca08783fd0d04dab91d3f97d2e65f1
2017-05-24 21:12:55 -04:00
85231bad6e
Bug 1361100: Perform all timer init after removal from TimerThread. r=froydnj
2017-05-01 14:50:37 -05:00
a2eeb6e4f1
Bug 1325254 P5 Make nsITimer::Cancel() O(c). r=froydnj
2017-04-20 17:56:07 -04:00
f3a2ca7fb5
Bug 1339588 - Part 3: Don't break the nsTimer/nsTimerImpl cycle during Fire. r=froydnj, a=dveditz
...
MozReview-Commit-ID: J6TNJqGsBv4
--HG--
extra : rebase_source : 363923520a2527911c9b82aaf28d3d3291e95a71
2017-04-06 12:29:57 -05:00
d7372e37d9
Bug 1338374 - Use alignas/alignof to define Variant's internal raw storage. r=froydnj
...
--HG--
extra : rebase_source : a75613ba7c17ceccf20e6f096a118bfedfa1eb15
2017-01-30 15:56:05 -08:00
276d12bcef
Bug 1328643: Add some locking to prevent races caused by Cancel/Init from threads other than the target. r=froydnj
...
MozReview-Commit-ID: FdAPTGDNKup
--HG--
extra : rebase_source : f0b04c73f0867708750fb9022e07f929ec221e84
2017-01-11 13:59:19 -06:00
6df682a091
Bug 1320753 - Adding nsINamed naming to nsITimer (r=ehsan)
...
MozReview-Commit-ID: AbyLcMhRvbx
2016-11-30 18:01:59 -08:00
60820e4a14
Bug 1157323 - Part 6: Some comment improvements. r=froydnj
...
MozReview-Commit-ID: GDLuJS0Wlgh
--HG--
extra : rebase_source : 6156b6ab99aa7b429bec55b0e32500074d59f7a6
extra : source : 32ed23f6341788882a076134a62ae5717c2fbf02
2016-08-05 13:46:07 -05:00
1a6b8f0e4e
Bug 1157323 - Part 5: Remove some unnecessary members. r=froydnj
...
MozReview-Commit-ID: Fhkq0CZoqQP
--HG--
extra : rebase_source : fb0624ad264173656de1c28ebbafcc509533ebb2
2016-08-05 13:39:34 -05:00
0f00611fff
Bug 1157323 - Part 4: Stop modifying mTimeout/mDelay from the TimerThread, plus some simplification. r=froydnj
...
MozReview-Commit-ID: 1pMCKLi9DLZ
--HG--
extra : rebase_source : 03eabab8f39865bdb2489a96c809abb99b1fb7d9
2016-08-05 12:50:00 -05:00
0cf5031cd7
Bug 1157323 - Part 2: Factor nsTimerImpl into two classes, so we don't need to do racy stuff in nsTimerImpl::Release. r=froydnj
...
MozReview-Commit-ID: DAe4TpMqBpA
--HG--
extra : rebase_source : 4caeb1ffc41b0704e5c1c111ef869d8edfb6d30c
2016-07-20 15:16:40 -05:00
5b38c55967
Bug 1174785 - Part 2: Convert xpcom over to LogModule. r=froydnj
...
--HG--
extra : rebase_source : 58d3b32bd0174f2540512cef810cafdd3556ef6b
2015-10-19 12:50:14 -07:00
f429eae6a5
Bug 1203427 (part 5) - Add logging of timer firings. r=froydnj.
2015-09-10 00:50:51 -07:00
886074f2e3
Bug 1203427 (part 3) - Change order of InitCommon() arguments. r=froydnj.
...
This makes the order of |aDelay| and |aType| match those of the InitWith*()
functions.
I've made this change because the inconsistency tripped me up during the
development of part 4.
--HG--
extra : rebase_source : 7d49f3f643e76955ea3de57e0954deb22cda3ddf
2015-09-14 15:57:17 -07:00
e145322168
Bug 1059572 - Part 1: Move PostTimerEvent to TimerThread to allow TimerThread's monitor to protect it. r=nfroyd
...
--HG--
extra : rebase_source : ec9623818cd1a5f3a2665a1c4af4be7869c0dec3
2015-07-22 12:39:34 -05:00
4d01d51096
Bug 1178363 - make nsTimerImpl::GetGeneration a private method; r=poiru
...
Since GetGeneration() is only called by nsTimerEvent, it doesn't need to
be public.
2015-06-29 13:09:11 -04:00
ed7e987ecb
Bug 1178363 - make nsTimerImpl::PostTimerEvent a private method; r=poiru
...
PostTimerEvent is only called by the timer thread, which is already able
to access private members of nsTimerImpl; there's no reason for
PostTimerEvent to be public.
2015-06-29 10:33:30 -04:00
889fc1ad61
Bug 1178363 - make MOZ_TASK_TRACER-dependent bits of nsTimerImpl private; r=poiru
...
GetTracedTask() is only called from nsTimerImpl itself, so it doesn't
need to be public. GetTLSTraceInfo() is called from the timer thread,
which has access to our private members already.
2015-06-18 12:02:23 -04:00
4fea06a3a3
Bug 1178363 - make nsTimerImpl::Fire a private method; r=poiru
...
This method is only called by nsTimerEvent, which is an implementation
detail of nsTimerImpl.
2015-06-18 12:00:56 -04:00
22b75ae28f
Bug 1178363 - make nsTimerImpl::SetDelayInternal a private method; r=poiru
...
Nothing outside nsTimerImpl uses it, and with a name like
"SetDelayInternal", nothing should.
2015-06-17 21:40:18 -04:00
4eff0a1842
Bug 1113562 - Expected delay time of tasks should not be the latency of those kind. r=sinker
...
--HG--
extra : rebase_source : b5e012fb6570e87270a0924fbe395dc56e6242ec
2015-06-16 10:57:19 +08:00
ab4019ac55
Bug 1168170 - Mark reference counted members of nsTimerImpl::mCallback as MOZ_OWNING_REF. r=froydnj
2015-05-28 10:14:00 -04:00
4879ae86f4
Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj
2015-05-19 11:15:34 -07:00
6417f13e09
Bug 1162242 - Part 2: Remove DEBUG_TIMERS. r=froydnj
...
Now that PR_LOGGING is always defined DEBUG_TIMERS will always be set. It can
now be removed.
2015-05-07 09:43:36 -07:00
645b42df1f
Bug 1162242 - Part 1: Remove instances of #ifdef PR_LOGGING. r=froydnj
...
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-07 09:43:35 -07:00
7fbbaf9fde
Bug 1156407 - part 3 - get rid of NS_NewTimer; r=mccr8
...
It's never called. We could replace a few do_CreateInstance/InitWithFuncCallback
pairs with NS_NewTimer, but I don't think it's worth doing that ahead of a "stop
using do_CreateInstance for all timer instances" effort.
2015-04-20 14:21:01 -04:00
8af565d0f7
Bug 1156407 - part 2 - make CALLBACK_TYPE enum a private implementation detail of nsTimerImpl; r=mccr8
...
The CALLBACK_TYPE enum doesn't need to be exposed outside of
nsTimerImpl, so move it inside the class definition. While we're doing
this, let's C++-ify the enum definition and give the members
non-shouting names.
2015-04-20 14:08:57 -04:00
880dd42a14
Bug 1156407 - part 1 - use static_assert instead of PR_STATIC_ASSERT; r=mccr8
...
We have better, C++-ier ways of doing compile-time assertions now. Fold in the
nsTSubstring.cpp change in passing, since mccr8 suggested it in his review.
2015-04-20 13:56:46 -04:00
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
f32bb086bc
Bug 1117035 - Mark virtual overridden functions as MOZ_OVERRIDE in XPCOM; r=froydnj
2015-01-05 11:25:41 -05:00
d33f31e6be
Bug 1089514, Patch 1: Some traced tasks/runnables have record of dispatch, but no records of execution, r=thinker.
...
---
tools/profiler/TracedTaskCommon.cpp | 19 +++++--------------
tools/profiler/TracedTaskCommon.h | 12 ++++++++----
xpcom/threads/TimerThread.cpp | 2 ++
xpcom/threads/nsTimerImpl.cpp | 3 +++
xpcom/threads/nsTimerImpl.h | 2 +-
5 files changed, 19 insertions(+), 19 deletions(-)
2014-11-04 17:42:03 +08:00
8d715a7fe4
Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan
2014-10-08 13:17:32 -07:00
445e1466e9
Backed out 5 changesets (bug 806819) for WinXP test failures on a CLOSED TREE
...
Backed out changeset 009ae35b0c67 (bug 806819)
Backed out changeset 5a57f87f5061 (bug 806819)
Backed out changeset f06cd735b5b3 (bug 806819)
Backed out changeset e25a2a8d4af4 (bug 806819)
Backed out changeset 70a167982c3f (bug 806819)
2014-10-06 16:32:50 -07:00
80d2b8bba6
Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan
...
--HG--
extra : rebase_source : c96eea1c12ea8c19314393f0e8b4b57a4316a61d
2014-10-06 13:08:20 -07:00
16471161bb
Bug 1046841 - Fix more style violations in previously touched .h files in xpcom/. r=froydnj
2014-08-25 12:17:24 -07:00
c9fb2c0d48
Bug 1022456 - Fix modelines in xpcom/{base,glue,io,string,threads}/. r=froydnj
2014-06-30 08:39:45 -07:00
123de17a5e
Bug 1024765 - Part 2: Make refcounting logic around PostTimerEvent more explicit. r=bz
2014-06-16 14:13:04 -07:00
b73bc43c94
Bug 1016680, part 5 - Report the memory used by PresShell::mCaret. r=dbaron
2014-06-22 23:02:59 +01:00
Simon Giesecke
Byron Campen [:bwc]
Ehsan Akhgari
Sylvestre Ledru
Nathan Froyd
Stone Shih
Carsten "Tomcat" Book
Ben Kelly
Andreas Farre
Jeff Walden
Bill McCloskey
Eric Rahm
Nicholas Nethercote
Shelly Lin
Michael Layzell
Gina Yeh
Wes Kocher
Birunthan Mohanathas
Jonathan Watt