This should be less confusing. This is not supported outside of chrome:// or
user-agent stylesheets so we can name this however we want.
Differential Revision: https://phabricator.services.mozilla.com/D65605
--HG--
extra : moz-landing-system : lando
Reuse the AddXULMinSize logic which already deals with all the widget stuff,
non-themed scrollbars, etc.
Remove some useless margin declarations and such in GeckoView scrollbars code
now that AddXULMinSize does look at the min-width/height properties.
Differential Revision: https://phabricator.services.mozilla.com/D65129
--HG--
extra : moz-landing-system : lando
The regular Android theme doesn't support it, so it does nothing.
With the non-native theme, which supports scrollbars, it'd look like windows
scrollbars, which we don't want.
Differential Revision: https://phabricator.services.mozilla.com/D65138
--HG--
extra : moz-landing-system : lando
Reuse the AddXULMinSize logic which already deals with all the widget stuff,
non-themed scrollbars, etc.
Remove some useless margin declarations and such in GeckoView scrollbars code
now that AddXULMinSize does look at the min-width/height properties.
Differential Revision: https://phabricator.services.mozilla.com/D65129
--HG--
extra : moz-landing-system : lando
The :not() clause unhelpfully influences the specificity of the selector for menulists in general.
However, it is not necessary anyway, because xul.css overrides the min-height to 0 for [popuponly]
menulists using !important.
Differential Revision: https://phabricator.services.mozilla.com/D64922
--HG--
extra : moz-landing-system : lando
I think during the All Hands in Berlin you might have suggested to do this in nsPresContext::DefaultBackgroundColor,
but this seems a bit more targeted and not a header.
I haven't try tested this yet, so this more of a feedback?
Differential Revision: https://phabricator.services.mozilla.com/D63801
--HG--
extra : moz-landing-system : lando
The text track list should not exceed the size of the video controls. Because it is positioned
absolutely, and because the height of the video is not known in the CSS, the only way to
ensure the list's height does not exceed the video's height is to set a 'top' value as well as
a 'bottom' one.
Unfortunately, that then means that if the list is quite small and the video quite tall, the
popup becomes way too large.
To avoid this, I've added another level of nesting, and used flexbox to align the actual list
to the bottom of the container for the list.
Differential Revision: https://phabricator.services.mozilla.com/D62452
--HG--
extra : moz-landing-system : lando
The text track list should not exceed the size of the video controls. Because it is positioned
absolutely, and because the height of the video is not known in the CSS, the only way to
ensure the list's height does not exceed the video's height is to set a 'top' value as well as
a 'bottom' one.
Unfortunately, that then means that if the list is quite small and the video quite tall, the
popup becomes way too large.
To avoid this, I've added another level of nesting, and used flexbox to align the actual list
to the bottom of the container for the list.
Differential Revision: https://phabricator.services.mozilla.com/D62452
--HG--
extra : moz-landing-system : lando
The light theme sets both visited and non-visited links to the same color
(`--blue-60`) by default, while the dark theme sets non-visited links to
`--blue-40` but did not specify a color for visited links, displaying them as
`--blue-60`. This resulted in inconsistent styling of pages written in XHTML
versus HTML, e.g. `about:protections` versus `about:newtab`. epang confirmed
that the desired behavior is to display links as `--blue-40`, visited or not.
Differential Revision: https://phabricator.services.mozilla.com/D60748
--HG--
extra : moz-landing-system : lando
We want them to always appear on one line to avoid covering the toolbarbuttono,
even when there are multiple words in the badge.
Differential Revision: https://phabricator.services.mozilla.com/D60287
--HG--
extra : moz-landing-system : lando
This both allows proper CSS sizing (it respects max-width), and allows for hidden overflow for long badges.
Using xul:label with textContent fixes the former but doesn't support the latter, so an html:label is used instead.
Differential Revision: https://phabricator.services.mozilla.com/D57652
--HG--
extra : moz-landing-system : lando
Instead, subclass nsTextControlFrame. This simplifies the code and avoids
correctness issues.
I kept the localization functionality though it is not spec compliant. But I
filed a bug to remove it in a followup.
Differential Revision: https://phabricator.services.mozilla.com/D57193
--HG--
extra : moz-landing-system : lando
Instead, subclass nsTextControlFrame. This simplifies the code and avoids
correctness issues.
I kept the localization functionality though it is not spec compliant. But I
filed a bug to remove it in a followup.
Differential Revision: https://phabricator.services.mozilla.com/D57193
--HG--
extra : moz-landing-system : lando
https://hg.mozilla.org/mozilla-central/rev/234701139a2a61d1262e609c9d8ac42384ecafda
Removed the following CSS rule:
#iconContainer {
-moz-box-pack: center;
min-height: 55px; /* maximum icon height + icon margin */
min-width: 58px; /* maximum icon width + icon margin */
}
Which enforced the size of the icon row.
The icon loads asynchronously, so by the first time we fire DOMContentLoaded it
may not have loaded yet. This means that sizeToContent() will size the window to
an smaller size and stuff will wrap around when it loads.
<image> doesn't block onload so even delaying this wouldn't work.
Restore the wrapper to ensure loading the icon or not doesn't affect layout of
the dialog.
Differential Revision: https://phabricator.services.mozilla.com/D58705
--HG--
extra : moz-landing-system : lando
I went with "policy" rather than "position" since "hidden" isn't really a position.
Differential Revision: https://phabricator.services.mozilla.com/D57177
--HG--
extra : moz-landing-system : lando
Also fix the styling of containers to have their separators centered vertically, and make them stretch to the end.
Differential Revision: https://phabricator.services.mozilla.com/D55839
--HG--
extra : moz-landing-system : lando
This makes use of display: contents; in order to preserve the row-based markup that is needed by JS to hide certain rows.
Differential Revision: https://phabricator.services.mozilla.com/D54243
--HG--
extra : moz-landing-system : lando
The selectors that changed number inputs when they were used in a XUL
root document no longer make sense now that we're using an html root.
Convert the selector to a class instead. Also, add flex attribute so
the toolbar fills the whole width of the wrapping box.
Differential Revision: https://phabricator.services.mozilla.com/D53241
--HG--
extra : moz-landing-system : lando
The display property appears to do nothing here and the appearance closely
matches that of a fieldset so switching to that seems to work fine.
Differential Revision: https://phabricator.services.mozilla.com/D50292
--HG--
extra : moz-landing-system : lando
Emilio Cobos Álvarez
shindli
Gijs Kruitbosch
Tom Schuster
Tim Nguyen
Jonathan Michalon
Dorel Luca
Itiel
Brent Schroeter
Brian Grinstead
Mihai Alexandru Michis
Connor Brewster
Mike Conley
Mark Striemer
Sylvestre Ledru
Brendan Dahl
Noemi Erli
Gabriel Luong
Marco Bonardo
Dave Townsend