This bug was introduced with the Proton tab design. Since we no longer draw a background behind inactive tabs, tabs are not legible against some accent colors. This problem is especially bad in brighttext themes. This patch also fixes 1714507, since the tabs are now legible against the light gray inactive window color.
Differential Revision: https://phabricator.services.mozilla.com/D125213
* Position each "frame" in the svg filmstrip animation at 16px increments, which allows space for the scaled path without intruding on the subsequent frame.
* Update CSS widths and animation details
Differential Revision: https://phabricator.services.mozilla.com/D125138
* Use the new path from check.svg in each frame
* Use clip-paths rather than the mask & stroke-width properties to do the clipping in each frame
* Pick up the fill (white) color from CSS using currentColor rather than hardcoding in the SVG
Differential Revision: https://phabricator.services.mozilla.com/D124410
Summary of changes:
* Remove the Sponsored action text for Firefox Suggest sponsored results
* Instead show Sponsored below their titles
* Remove the Firefox Suggest action text for non-sponsored results
This uses the action text for "Sponsored" as we do now, but it wraps it below
the title.
The Figma spec (link in Jira ticket) shows URLs in Firefox Suggest results, the
same as history results. I asked Natalie about it, and that's not correct, or at
least we shouldn't implement that now. If we do need to show URLs, then this
approach is probably worse than D124519 because wrapping the action would also
force the URL on a new line since the URL comes after it.
Differential Revision: https://phabricator.services.mozilla.com/D124563
This addresses a few things:
- it doesn't really make sense to have 2 different badge implementations
for the library and the panel. Just use the panel one for the library.
- remove the old badge itself
- remove a bunch of old CSS to do with the old badge
- rename the 'new' badge now it isn't new anymore
- share the badge styling between the 'all downloads' view (about:downloads
and the library) and the downloads panel
- use the downloadMainArea for hover styling of the non-button bit, and
update the JS to set the downloadHoveringButton class appropriately for
this new reality.
- tighten up hover styles so we don't get a weird double hover for the
blocked download case
- tighten up margins of the button, badge and progress meter (see also
https://bugzilla.mozilla.org/show_bug.cgi?id=1725837). This is also
helped by the fact that the renaming means we now properly hide the
badge image when the download isn't blocked; the CSS at
https://searchfox.org/mozilla-central/rev/a1ab92e0b16631465a946b300493e75be0eacc37/browser/components/downloads/content/downloads.css#44-47
didn't apply to this badge pre-patch.
Differential Revision: https://phabricator.services.mozilla.com/D123169
* Refactor to call a toggle function in the various places we want to show or hide the debug info
* Add a href to the error link and preventDefault() on it to get proper link keyboard a11y
* Show/hide the debug info with the hidden property
Differential Revision: https://phabricator.services.mozilla.com/D122884
* Resize progress bar to 4px to match spec, rounding the ends of the bar and its tray
* Define and use a set of CSS variables for the progressbar tray color, bar fill and paused fill
* Use the theme's icon attention color for the main progressbar color - when defined - to match the download indicator in the toolbar
* Use a --download-progress-flare-color variable for the highlight color in the indeterminate download animation, which lets us invert the colors in a selected item.
* Remove exceptions/overrides for windows and osx
* Match colors where possible in Places and about:downloads, ensuring we always have contrast in selected download richlistitems
Differential Revision: https://phabricator.services.mozilla.com/D122543
* Resize progress bar to 4px to match spec, rounding the ends of the bar and its tray
* Define and use a set of CSS variables for the progressbar tray color, bar fill and paused fill
* Use the theme's icon attention color for the main progressbar color - when defined - to match the download indicator in the toolbar
* Use a --download-progress-flare-color variable for the highlight color in the indeterminate download animation, which lets us invert the colors in a selected item.
* Remove exceptions/overrides for windows and osx
* Match colors where possible in Places and about:downloads, ensuring we always have contrast in selected download richlistitems
Differential Revision: https://phabricator.services.mozilla.com/D122543
This bug was originally about changing the size of this text, but we aren't
really able to do that. We are however able to improve its legibility by giving
it some additional contrast against the background.
Based on the specs (and also on intuition, to be honest), I believe only the
"normal" download status text should be getting any reduced opacity, and the
error message states should not. So this patch undoes the opacity reduction in
the error states.
Differential Revision: https://phabricator.services.mozilla.com/D123659
This patch addresses two points where the badge on the download status toolbar
button's badge was not quite meeting the MR1 design spec:
1) The badge for the "uncommon download" safe browsing verdict should be "info"
(currently a blue circle) and not "warning" (a yellow triangle).
2) The badge (regardless of its type) should not appear while the "finished"
animation is playing, only after it completes.
Differential Revision: https://phabricator.services.mozilla.com/D123818
pestanoah
Harry Twyford
Itiel
Sam Foster
Sebastian Hengst
Drew Willcoxon
Dan Mosedale
Mike Conley
Emilio Cobos Álvarez
Gijs Kruitbosch
Narcis Beleuzu
Dão Gottwald
criss
Molly Howell
Sandor Molnar
Michael Kohler
Emma Malysz
Bernard Igiri
Asif Youssuff
Andrei Oprea
Emily McMinn
Johann Hofmann