Because we use an older version of Python than the one generally used on
the host system, this implied enforcing a few package requirements.
Differential Revision: https://phabricator.services.mozilla.com/D180057
Most of this patch is ripping `command-context` out from Gecko. The other parts are the fairly straightforward conversions from `command-context` to `task-context`.
Differential Revision: https://phabricator.services.mozilla.com/D186822
Most of this patch is ripping `command-context` out from Gecko. The other parts are the fairly straightforward conversions from `command-context` to `task-context`.
Differential Revision: https://phabricator.services.mozilla.com/D186822
While we're here, add the missing pkgconf dependency that leads to
unrelated error messages in the task log when other problems happen
(like in bug 1813506).
Differential Revision: https://phabricator.services.mozilla.com/D185240
jgraham confirmed there is nothing related in this directory, and any update
to wpt test expectations scheduled the task.
Differential Revision: https://phabricator.services.mozilla.com/D181475
Currently dot files (e.g. .eslintrc.js) are not checked in the full run on CI.
Also ignores .gradle/ directory as that it a cache.
Differential Revision: https://phabricator.services.mozilla.com/D177261
This notification will help Thunderbird developers who are tasked with pushing
multiple bugs to comm-central after a mozilla-central push.
Taskgraph tests adjusted to verify the notification is only sent for pushes
to mozilla-central, and to run the tests when .taskcluster.yml is updated.
Differential Revision: https://phabricator.services.mozilla.com/D175290
This is enabling the PLE and PLC rules across a much larger swatch of the code
base. The PLR and PLW are additionally enabled at the warning level (introduces
~2500 new warnings).
To avoid extraneous changes in people's patches, rules at the warning level are
excluded from --fix.
Differential Revision: https://phabricator.services.mozilla.com/D172358
This results in some changes from our current `isort` configuration. I'm
unclear if it's because ruff isn't at 100% parity with isort, they choose
different defaults or if I missed some configuration.
Either way, the changes all look reasonable to me (see child commit), so I'm
inclined to just accept the new import format it imposes.
Differential Revision: https://phabricator.services.mozilla.com/D172348
Ruff is a very fast linter implemented in Rust and it can act as a drop-in
replacement for flake8. When running the same set of rules across all files
in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff
takes 0.9 seconds.
Ruff also implements rules from other popular Python linters such as pylint,
isort and pyupgrade. There are even plans to implement feature parity with
black in the future. Ultimately, it can become our one stop shop for all Python
linting and formatting.
This stack will swap out all our Python lint tools for ruff (excluding black
for now).
Differential Revision: https://phabricator.services.mozilla.com/D172313
This is enabling the PLE and PLC rules across a much larger swatch of the code
base. The PLR and PLW are additionally enabled at the warning level (introduces
~2500 new warnings).
To avoid extraneous changes in people's patches, rules at the warning level are
excluded from --fix.
Differential Revision: https://phabricator.services.mozilla.com/D172358
This results in some changes from our current `isort` configuration. I'm
unclear if it's because ruff isn't at 100% parity with isort, they choose
different defaults or if I missed some configuration.
Either way, the changes all look reasonable to me (see child commit), so I'm
inclined to just accept the new import format it imposes.
Differential Revision: https://phabricator.services.mozilla.com/D172348
Ruff is a very fast linter implemented in Rust and it can act as a drop-in
replacement for flake8. When running the same set of rules across all files
in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff
takes 0.9 seconds.
Ruff also implements rules from other popular Python linters such as pylint,
isort and pyupgrade. There are even plans to implement feature parity with
black in the future. Ultimately, it can become our one stop shop for all Python
linting and formatting.
This stack will swap out all our Python lint tools for ruff (excluding black
for now).
Differential Revision: https://phabricator.services.mozilla.com/D172313
serge-sans-paille
Ben Hearsum
Sandor Molnar
Norisz Fay
Mike Hommey
Natalia Csoregi
Andi-Bogdan Postelnicu
Sebastian Hengst
Noemi Erli
Katherine Patenio
Gijs Kruitbosch
Mark Banner
Joel Maher
Rob Lemley
Andrew Halberstadt
Cristian Tuns
Nicolas Chevobbe
Bastien Abadie
ogiorgis
Stanca Serban
Mike Conley
Julien Cristau
Alexandra Borovova
Sylvestre Ledru