3ad920307d
Backed out 6 changesets (bug 939294) for B2G bustage on a CLOSED TREE.
...
Backed out changeset 8c3aa9973da0 (bug 939294)
Backed out changeset 37098c13e59e (bug 939294)
Backed out changeset 7c9ade6c871c (bug 939294)
Backed out changeset fed59539afc1 (bug 939294)
Backed out changeset 89e9d3fa16fc (bug 939294)
Backed out changeset c97e58ebc5f4 (bug 939294)
2014-01-09 14:17:39 -05:00
de26c13547
Bug 939294 - Handlify all the rest. r=terrence
2014-01-09 18:39:37 +01:00
b31a6b57fb
Bug 952192 - getObjectPrincipal should be script callable. r=bholley
2014-01-09 15:28:46 +01:00
89b0750843
Backed out changeset 18eeafedd180 (bug 952192) XPC Shell Bustage on a CLOSED TREE
2014-01-09 12:53:22 +01:00
421ebe4af8
Bug 952192 - getObjectPrincipal should be script callable. r=bholley
2014-01-09 11:31:33 +01:00
1b83407ce9
Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc
...
This patch was automatically generated by the following script:
#!/bin/bash
# Command to convert PRUnichar to char16_t
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*modules/libmar*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name prtypes.h \
! -name Char16.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRUnichar char16_t
2014-01-04 10:02:17 -05:00
2e804616e4
Bug 924905 - Do a subsumes check inside the stack iterator. r=jandem
...
--HG--
extra : rebase_source : ff8407c4f79fd3e2264470379470c526a751e45f
2014-01-03 10:32:56 -06:00
d43c55ca0e
bug 949821 - use MOZ_UTF16 more and NS_LITERAL_STRING less r=froydnj
2013-12-12 20:50:01 -05:00
ea86682111
Bug 913734 - Remove namespace mozilla::hotness. r=mrbkap
2013-12-13 19:15:44 -08:00
ebe6344137
Bug 913734 - Remove EnabledID() machinery. r=mrbkap
2013-12-13 19:15:44 -08:00
041e66aa0e
Bug 913734 - Remove now-unused policy machinery. r=mrbkap
2013-12-13 19:15:43 -08:00
d99e6b8d97
Bug 913734 - Stop consulting domain policies in CAPS. r=mrbkap
...
The whole LookupPolicy juggernaut is basically a mechanism for setting custom
per-(protocol, origin, property, action) access control in the preferences
service.
There are two sets of preferences currently in all.js. One of them is set up
for mailnews, for the mailbox:, imap:, and news: protocols. According to jst,
this was designed as a whack-a-mole security mechanism for javascript running
in HTML email. IIUC, we no longer allow JS to run at all in mailnews, so this
is obsolete.
The other mechanism appears to be our old-fashioned implementation of the
same-origin policy, which has been obsoleted by the new compartment
architecture.
In addition, most of this stuff was obsoleted by the new dom bindings, since
these DOM classes no longer go through XPCWrappedNativeJSOps, and thus no
longer trigger these security checks at all.
We stop using the infrastructure in this patch, and rip it out in the next one.
2013-12-13 19:15:43 -08:00
bdd70cb368
Bug 913734 - Stop storing security policies on XPCWrappedNativeProtos. r=mrbkap
...
This is just a cache, so we can safely remove it without impacting correctness.
The rest of this mechanism goes away in subsequent patches.
2013-12-13 19:15:43 -08:00
3440613a39
Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
...
--HG--
rename : mfbt/Util.h => mfbt/ArrayUtils.h
2013-12-08 21:52:54 -05:00
62578248db
Bug 932906 - Exempt Remote XUL from CanCreateWrapper checks. r=bz
2013-12-04 19:15:40 -08:00
ae71929347
Bug 884676 - Convert JSPrincipals::refcount to Atomic<int32_t> in JS_THREADSAFE builds, and remove JS_ATOMIC_*. r=Waldo
2013-11-27 09:37:10 -06:00
3f9a418ee1
Bug 886164 - Enforce CSP in sandboxed iframe, r=grobinson
2013-11-22 15:12:00 -08:00
26c0110ca6
Bug 941332 - Build caps/src in unified mode. r=ehsan
2013-11-21 09:22:26 -05:00
2812d11fce
Bug 939632 - Remove LIBRARY_NAME for leaf libraries. r=gps
...
Landing on a CLOSED TREE.
2013-11-19 11:50:54 +09:00
e06d795c71
Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps
2013-11-19 11:48:10 +09:00
26bc04d200
Bug 939044 - Rename remaining MODULE definitions to XPIDL_MODULE. r=mshal
2013-11-19 11:47:43 +09:00
e80e877ab7
Bug 939044 - Remove most definitions of MODULE. r=mshal
2013-11-19 11:47:39 +09:00
ffe0380912
Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps
2013-11-19 11:47:14 +09:00
4478f5b384
Bug 933834 - Rename and handlify JS_ValueToString. r=terrence,bz
2013-11-16 13:31:36 +01:00
cca4d45da6
Backout changesets ded0d64f6786:03f041d03f24 and 30cbd1abde1a (bug 935696, bug 933834 and bug 939194) for build bustage.
2013-11-17 16:39:25 +01:00
bc757ef965
Bug 933834 - Rename and handlify JS_ValueToString. r=terrence,bz
2013-11-16 13:31:36 +01:00
2f55900502
Bug 840488 - Tests. r=bz
2013-11-12 16:43:35 -08:00
93808be553
Bug 840488 - New domain policy API. r=bz
...
Note that this patch changes the semantics of javascript.enabled so that changes
to the pref do not apply to compartments that have already been created. This is
a significant change, but is necessary to support the new domain policy API.
After one cycle or so, we'll rip out the old API.
2013-11-12 16:43:35 -08:00
95ac2b3227
Bug 840488 - Compute immunity from caps checks exactly once, and kill nsScriptSecurityManager::CanExecuteScripts. r=bz
2013-11-12 16:43:35 -08:00
8e73b817c0
Bug 840488 - Remove per-JSContext script toggling. r=bz
...
Note that the checks in nsJSEnvironment::EvaluateString and EvalInWindow
can safely go away, because we call ssm->ScriptAllowed() in
nsJSUtils::EvaluateString.
2013-11-12 16:43:35 -08:00
5e788f9565
Bug 840488 - Directly mark compartments whose docshells disable script execution. r=bz
2013-11-12 16:43:33 -08:00
358692053b
Bug 840488 - Introduce a mechanism to temporarily or permanently block script for a given scope, and use it for unsafe channels. r=bz
2013-11-12 16:43:33 -08:00
a17328e5cc
Bug 840488 - Remove CheckFunctionAccess. r=bz
...
\o/
Aside from checking whether script is enabled, all the other work this function
does is silly.
2013-11-12 16:43:32 -08:00
63af01c6e2
Bug 840488 - Get rid of aAllowIfNoScriptContext. r=bz
...
The old code seemed to feel that the lack of a script context was some sort of
showdown that required either unconditional allow or deny. Instead, let's just
make the scriptcontext-relevant checks conditional on there being a script
context, which lets us switch CheckFunctionAccess over to ScriptAllowed.
2013-11-12 16:43:32 -08:00
074ccfec30
Bug 840488 - Refactor Gecko to provide a more direct API to ask whether script is allowed for a given global. r=bz
2013-11-12 16:43:31 -08:00
1da990368c
Bug 855326 - CSP 1.1 nonce-source for scripts and styles r=mrbkap r=dholbert r=geekboy
2013-11-08 15:44:39 -08:00
9a3437dd77
backout 57213b64023b (bug 855326) for build bustage in debug builds
...
CLOSED TREE
2013-11-08 11:22:36 -08:00
5add685cdd
Bug 855326 - CSP 1.1 nonce-source for scripts and styles. r=mrbkap r=dholbert r=geekboy
2013-11-08 09:20:43 -08:00
3b80765894
Bug 925584 - Remove some unnecessary jsapi.h inclusions from .cpp files. r=Ms2ger.
...
--HG--
extra : rebase_source : 41fcb0e922a519ef679c1c1b6293c2b638e83a48
2013-10-10 15:22:35 -07:00
b000a846c2
Bug 929905 - Consolidate sources in moz.build. r=gps
2013-10-25 08:23:05 +09:00
6fb588efa7
merge b2g-inbound to mozilla-central
2013-10-09 10:13:52 +02:00
31f8c782f2
b=923591 don't warn when checkLoadURIStrWithPrincipal() returns NS_ERROR_DOM_BAD_URI r=bz
...
--HG--
extra : transplant_source : J%09t%A3Z%B4%8C%B9%99%E0O%CE3%7Ex%93vu%9BA
2013-10-09 15:32:38 +13:00
628b85da4f
Bug 918658 - Don't pretend that mozIApplication inherits from mozIDOMApplication r=bent
2013-10-08 15:52:26 -07:00
a8eb623c18
Bug 897516 - Implement a separate cookie jar for safebrowsing - cookie separation part. r=mmc
2013-08-19 12:31:24 -07:00
6e22b00095
bug 920754 - rm more makefiles r=mshal
2013-09-25 16:39:06 -04:00
1cff342d15
Bug 920223 - Part 1: Mass convert MOCHITEST_FILES to manifests; rs=Ms2ger
2013-09-30 09:51:57 +02:00
18a411a55c
Backed out changeset 77bff106b704 (bug 920223)
2013-09-30 12:50:12 +01:00
6ed63cb064
Bug 920223 - Part 1: Mass convert MOCHITEST_FILES to manifests; rs=Ms2ger
2013-09-30 09:51:57 +02:00
8b1e734ef4
Backed out changeset a73ffb0d0c97 because of build bustage
2013-09-29 17:20:07 -04:00
f3d364af5a
Remove a number of unused variables, no bug
2013-09-29 16:42:12 -04:00
fba1ba6542
Backed out changeset 0cc959e28407 (bug 897516) failed XPC Shell tests CLOSED TREE
2013-09-27 15:45:31 +02:00
72cca452f5
Bug 897516 - Implement a separate cookie jar for safebrowsing - cookie separation part. r=mmc
2013-08-19 12:31:24 -07:00
b7e0804666
Backout bug 886164 for B2G regressions.
2013-09-23 21:26:05 -04:00
7f7a4918ef
Bug 918373 - GC: Handlify various public APIs r=sfink r=bholley r=smaug
2013-09-20 10:22:59 +01:00
c36df6710c
Bug 886164 - Enforce CSP in sandboxed iframe. r=grobinson
2013-06-23 14:31:52 -07:00
c4c9f9e982
Bug 917009 - Remove old-style object principal calculation. r=bz
2013-09-17 15:29:11 -07:00
d4b22fae39
Bug 908750 - Fix a rooting hazard in nsScriptSecurityManger::LookupPolicy; r=bholley
...
--HG--
extra : rebase_source : 27bf6ef6bce3bed136921df15ea00ae86bd73f89
2013-08-23 08:51:40 -07:00
22e23fe60d
Bug 909107 - Replace use of (obsolete) strres.js in test_bug292789.html. r=dveditz
2013-09-12 10:47:55 -04:00
ed0259103b
Merge fx-team to m-c.
2013-09-11 21:48:20 -04:00
3c5aa5b67c
Bug 914940 - Remove some enablePrivilige calls. r=jgriffin
2013-09-11 10:51:09 +02:00
a50084b38d
Bug 910823 - Constify static js::Class/JSClass instances. r=waldo
2013-09-11 05:49:05 -07:00
e9492bcd36
Bug 785884 - Implement support for temporary storage (aka shared pool). r=ehsan, r=bent
...
--HG--
rename : caps/tests/mochitest/test_principal_extendedorigin_appid_appstatus.html => caps/tests/mochitest/test_principal_jarprefix_origin_appid_appstatus.html
rename : dom/quota/UsageRunnable.h => dom/quota/UsageInfo.h
2013-09-11 06:18:36 +02:00
30d81ff017
Bug 905364 - Stop using the SafeJSContext in nsScriptSecurityManager::Init. r=mrbkap
...
With this patch, I've confirmed that we instantiate the SafeJSContext much later
in startup, during nsAppStartupNotifier::Observe (which ends up invoking an
XPCWrappedJS). As such, this should solve a number of our startup ordering woes.
2013-09-06 11:35:12 -07:00
f8bc7fa754
Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps
2013-09-05 09:01:46 +09:00
83c76ab760
Bug 899367 - Make GetNativeGlobal consumers call GetWindowProxy and rm the former. r=mccr8
...
Some of the uses of this are a bit nonsensical now, but that's a problem for
another day.
2013-09-04 14:06:57 -07:00
e06d8f88fa
Bug 911573 - Mochitest fixup to prepare removing Components-in-content with UniversalXPConnect. r=bholley
2013-09-05 01:02:34 +09:00
01c70c8c97
Bug 911020 - Introduce js/TypeDecls.h, which holds very commonly used type declarations from the JS engine. r=luke.
...
--HG--
extra : rebase_source : 008ef689989f93b46627b8be8608bdbc544ca3a2
2013-08-27 19:59:14 -07:00
3c5b0c6b29
Bug 909597 (part 2) - Rename jsdbgapi.{h,cpp} as {js,vm}OldDebugAPI.{h,cpp}. r=luke.
...
--HG--
rename : js/src/jsdbgapi.h => js/public/OldDebugAPI.h
rename : js/src/jsdbgapi.cpp => js/src/vm/OldDebugAPI.cpp
extra : rebase_source : 9cd65a698e726c43d88d650f40823367bf98feae
2013-08-26 19:05:20 -07:00
6f0d3838c9
Backed out 12 changesets (bug 899367) for Windows and OSX mochitest failures on a CLOSED TREE.
...
Backed out changeset 46cf4c3eb447 (bug 899367)
Backed out changeset d8a876219fc7 (bug 899367)
Backed out changeset d930333f95a7 (bug 899367)
Backed out changeset efae8cc0fff8 (bug 899367)
Backed out changeset 1dd262d146a6 (bug 899367)
Backed out changeset 4c396b8a51d0 (bug 899367)
Backed out changeset c8c30176639a (bug 899367)
Backed out changeset aaa8fbcf9aaf (bug 899367)
Backed out changeset d1a782044a4b (bug 899367)
Backed out changeset b2672ab55046 (bug 899367)
Backed out changeset fc4deb0b06fa (bug 899367)
Backed out changeset b9f1018a609c (bug 899367)
2013-08-27 21:14:54 -04:00
3ef78b339d
Bug 899367 - Make GetNativeGlobal consumers call GetWindowProxy and rm the former. r=mccr8
...
Some of the uses of this are a bit nonsensical now, but that's a problem for
another day.
2013-08-27 15:21:40 -07:00
f805d8d6eb
Merge m-c to inbound
2013-08-22 10:38:48 +02:00
bdfaa84f5b
Bug 904831 - Part b: Move unconditional MSVC_ENABLE_PGO definitions into moz.build; r=gps
2013-08-22 08:56:01 +02:00
6d473220dc
Bug 883284 - Part b: Move LIBXUL_LIBRARY into moz.build (a-c); r=joey
2013-08-22 08:55:59 +02:00
2585de9a07
Bug 905017 (part 1) - Minimize inclusions of JS engine headers in .h and .idl files. r=billm.
...
--HG--
extra : rebase_source : 984c61ab12f46be0509b1ce0d458d9a6e5841c64
2013-08-17 15:50:18 -07:00
72c8f5969c
Back out c39d60483813 (bug 905364) for xpcshell and b2g desktop bustage
2013-08-16 22:38:48 -07:00
363bb61e01
Bug 905364 - Stop using the SafeJSContext in nsScriptSecurityManager::Init. r=mrbkap
...
With this patch, I've confirmed that we instantiate the SafeJSContext much later
in startup, during nsAppStartupNotifier::Observe (which ends up invoking an
XPCWrappedJS). As such, this should solve a number of our startup ordering woes.
2013-08-16 20:28:17 -07:00
1a5ae526d9
Bug 901323 - Don't include nsContentUtils.h unnecessarily; r=jlebar
2013-08-14 08:56:21 +02:00
d8f824e34e
Bug 898914 (part 1) - Remove JSBool.
...
--HG--
extra : rebase_source : 2d202e0e5005a7f54724b1540481c15cde3ad52e
2013-08-08 15:53:04 -07:00
443795d1eb
Bug 897913 part 1. Don't assert that app id exists when asked for app status; just claim not installed if there is no app id. r=sicking
2013-08-07 17:40:00 -04:00
8ce53f9ffd
Bug 902332 - Replace JS_{FALSE,TRUE} with {false,true} almost everywhere. r=luke,bz.
...
--HG--
extra : rebase_source : 25f4de1bfae830b0af6407d260a70b787ab1dc9b
2013-08-06 23:59:54 -07:00
9624be5713
Bug 901750 - Change return type of |JSNative| from |JSBool| to |bool|. code=nnethercote,jandem. r=luke,bz.
...
--HG--
extra : rebase_source : 5b3d7cc339af6d93bde078322e25c6e740d1b617
2013-08-02 00:41:57 -07:00
dc4bd05cb5
Bug 884410 - Handlify JS_GetPrototype. r=terrence
2013-07-31 12:20:33 -04:00
2824b29025
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
ef4b479714
Bug 872127 - Part 2: Replace mozilla/StandardInteger.h with stdint.h; r=Waldo,ted
2013-07-30 10:25:31 -04:00
20fb51afdd
Bug 897484 - GC: Convert JS_GetProperty APIs to take MutableHandleValue r=terrence r=bholley r=smaug
2013-07-26 10:00:38 +01:00
ce93df92db
Backed out changeset ae8d72538dee (bug 897484) for b2g bustage
2013-07-26 12:34:25 +02:00
9709d43d76
Bug 897484 - GC: Convert JS_GetProperty APIs to take MutableHandleValue r=terrence r=bholley r=smaug
2013-07-26 10:00:38 +01:00
b82a7849fb
Bug 884061 - Part 4: Remove nsAtomicRefcnt.h, r=jlebar
...
--HG--
extra : rebase_source : ce24ab345baa48104328e3c101b7266a31e81870
2013-07-11 15:21:45 -05:00
55a7eb9289
Bug 884061 - Part 3b: Use NS_DECL_THREADSAFE_ISUPPORTS in caps/, r=bz
...
--HG--
extra : rebase_source : bc7beb6f567c2bf0c4a5c528648198f7619d0e72
2013-07-16 22:51:48 -05:00
d5d84f0dff
Bug 885668 - Removed specialized function object principal machinery from CAPS. r=bz
2013-07-15 11:22:10 -07:00
f33ade0d68
bug 887483 - remove a bunch of useless assignments to FORCE_STATIC_LIB implied by LIBXUL_LIBRARY=1 r=mshal
2013-07-11 11:06:34 -04:00
b002b30b2a
bug 789919, (snow-white) make addref/release of CCable objects faster by removing indirect refcnt increase/decrease, r=mccr8, test changes r=ehsan
...
--HG--
extra : rebase_source : 2a3b22425c14d6daedc91d62a652c34431acd2fb
2013-07-09 13:30:58 -04:00
115f9ae25d
Bug 406541 - Split NS_CheckStrictFileOriginPolicy out of nsPrincipal::CheckMayLoad. r=bs
2013-07-02 16:40:39 -07:00
9b129014be
Bug 874080 - Add an early return to nsExternalHelperAppService::GetTypeFromExtension when called with an empty extension parameter. r=paolo
2013-07-02 15:49:06 -04:00
8f3a2a0c69
Bug 798914 (part 6) - Followup: move MemoryReporting.h include after the cpp's own header include. r=njn.
2013-06-30 18:26:39 +02:00
3e059c7221
Bug 820686 - Remove code after MOZ_CRASH or MOZ_ASSUME_NOT_REACHED. r=(see below)
...
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=waldo for js
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
2013-06-28 18:38:32 -07:00
051c5b560a
Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below)
...
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
This is a mechanical change made with sed. Later patches in this queue
clean up the whitespace errors and so on.
2013-06-28 18:38:30 -07:00
6f4758d23e
Bug 798914 (part 5) - Use newly introduced mozilla::MallocSizeOf instead of nsMallocSizeOfFun. r=njn.
...
--HG--
extra : rebase_source : fc472490dd978d165f02f77ed37f07aed6e5bb61
2013-06-23 14:03:39 +02:00
ef8bb39711
Bug 885310 - 1 Rename JSHandleFoo in the browser r=bz
2013-06-21 14:12:46 +01:00
435d36ff71
Bug 880041 (part 22) - Use JSObject::{is,as} for JSFunction. r=sfink.
...
--HG--
extra : rebase_source : 43c8c65c7d00edffde12c5b1ec8a1aff42acc7fe
2013-06-17 23:53:49 -07:00
Ryan VanderMeulen
Tom Schuster
Gabor Krizsanits
Carsten "Tomcat" Book
Ehsan Akhgari
Luke Wagner
Trevor Saunders
Bobby Holley
Birunthan Mohanathas
Joshua Cranmer
Deian Stefan
Michael Shuen
Mike Hommey
Ms2ger
Garrett Robinson
Daniel Holbert
Nicholas Nethercote
Karl Tomlinson
Fabrice Desré
Christoph Kerschbaumer
Gregory Szorc
Ed Morley
Jon Coppeard
Terrence Cole
Cykesiopka
Martijn Wargers
Dan Gohman
Jan Varga
Masatoshi Kimura
Phil Ringnalda
Boris Zbarsky
Olli Pettay
John Schoenick
Catalin Iacob
Justin Lebar