This is motivated by three separate but related problems:
1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).
2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).
3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.
The solve this, this patch does the following:
1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
We were being overly cautious, and returning NS_ERROR_FAILURE if the printer name passed
up from the content process didn't map to an existing system printer.
The problem with that is that sometimes there are no registered printers. In that case,
we just need to not set the printer in the NSPrintInfo.
So in the event that we cannot find a printer with the name that the child sent up, we
just leave the printer and printer name fields on the NSPrintInfo blank.
--HG--
extra : commitid : 6N6PJq4K50q
extra : rebase_source : 733c9fac76747bc2a0b177d7b1688e4b673b0e4d
extra : amend_source : 3acf505a51930a5ab951028edeadb12352d024cb
We assume that when an NSURL has been serialized to PrintData, that it has already
been percent encoded. This means that we don't need to re-percent encode it when
we deserialize.
--HG--
extra : commitid : 7Xx00BDxmFk
extra : rebase_source : 03a016ea5f40484c6e357cf940577d4d975d3d3b
extra : amend_source : 2d276f22c295fca2a1a60ce5085f1d71d24ba13a
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
This patch implements the code which is shared by all platforms for
fullscreen transition.
It adds two prefs for the duration of fullscreen transition. They can
also be used to completely suppress the transition.
In addition, this patch uses the newly added prefs to suppress the
transition in all tests which use the DOM fullscreen.
--HG--
extra : source : 54a8b3b7351af89049825598891fd3a1f98d18af
The old code was just flat-out wrong. The IPDL for getting the LookAndFeel
cache from the parent during child process initialization was passing an
array it wanted to be populated as an argument, rather than using a return
value.
--HG--
extra : commitid : 2baQu56XHdn
extra : rebase_source : 7c45ecafa2ef6adb05bc753e87e354b136030958
extra : amend_source : 7b72c17d964e8b60c7c75a09ae38a28f60985583
This patch implements the code which is shared by all platforms for
fullscreen transition.
It adds two prefs for the duration of fullscreen transition. They can
also be used to completely suppress the transition.
In addition, this patch uses the newly added prefs to suppress the
transition in all tests which use the DOM fullscreen.
--HG--
extra : source : a64f71ea9ceb37acbbfc4e4023880fb244daa738
This conversion was done with the script:
find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
-e 's/TemporaryRef</already_AddRefed</g'
Manual fixups were performed in the following instances:
- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
into already_AddRefed.
- The following files had explicit Move() calls added to make up for the lack
of a copy constructor on already_AddRefed:
dom/base/ImageEncoder.cpp
dom/media/MediaTaskQueue.{h,cpp}
dom/media/webaudio/PannerNode.cpp
- A redundant overload for MediaTaskQueue::Dispatch was deleted.
- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.
- Comments, using declarations, and forward declarations relating to
TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
already_AddRefed.
Matt Woodrow
Nick Robson
Kyle Huey
Xidorn Quan
Robert O'Callahan
Carsten "Tomcat" Book
Steven Michaud
Ryan VanderMeulen
Mike Conley
Masayuki Nakano
Wes Kocher
Makoto Kato
David Anderson
Birunthan Mohanathas
Nicolas Silva
Nigel Babu
Josh Aas
Joel Maher
Markus Stange
Dragana Damjanovic
Juan Gomez
Andrew McCreight
Nathan Froyd
Chris Peterson