4d059b2890
Bug 1446225 - Ensure client id's are consistently {}-less UUIDs. r=catalinb
...
Our Client.id values were being normalized from "{uuid}" to "uuid", but not
our FetchEvent.clientId values. Because nsID::Parse accepts both forms,
this was not being caught by any tests.
Although there are ServiceWorker WPT tests that verify consistency of
returned Client.id values across multiple matchAll invocations (ex:
client-id.https.html), there are no tests that compare Client.id with
FetchEvent.clientId. All the tests largely use Clients.get() to verify
correctness/round-tripping. I looked into adding WPT tests, but we
quickly run into the test logistics problem where it's preferable to
avoid adding tests that involve effectively global state.
So, this patch:
- Changes Clients::Get() to explicitly treat client id's that start with a
"{" as invalid. This causes existing FetchEvent.clientId-related WPT
tests to fail, as we would hope.
- Duplicates the client id normalization logic that strips {} for the
FetchEvent.clientId to its point of origin in
ContinueDispatchFetchEventRunnable::Run.
- Augments our dom/serviceworkers/test/test_match_all_client_properties.html
test, which has been enforcing {}-less UUIDs for a while, to also test
FetchEvent.clientId to verify it conforms. I added some comments to the
test files too.
--HG--
extra : rebase_source : dd6d07ea880eb2c3115d8810ea246b4469ad5f96
2018-03-22 11:33:13 -04:00
c7543d428d
Bug 1441133 P1 Don't assert storage permission on windows that inherit the service worker. r=asuth
2018-03-01 08:13:56 -08:00
3eb3941bc5
Backed out 2 changesets (bug 1441133) for build bustage in beta simulations at dom/clients/manager/ClientSource.cpp:402: unused variable 'wp'. a=backout
...
Backed out changeset 275855621865 (bug 1441133)
Backed out changeset 7a4546e25adc (bug 1441133)
--HG--
extra : histedit_source : d38746923972091f05ad8f435c39e7fe38e57a18
2018-03-01 11:55:28 +02:00
8c55bc6898
Bug 1440705 P3 Assert that a client and its controlling service worker have a matching principal. r=asuth
2018-02-28 10:32:50 -08:00
0dd1174a39
Bug 1440705 P2 Separate ClientMatchPrincipalInfo() into a separate method and header. r=asuth
2018-02-28 10:32:50 -08:00
c6a37e4357
Bug 1441133 P1 Don't assert storage permission on windows that inherit the service worker. r=asuth
2018-02-28 10:31:29 -08:00
e67b89fe1c
Bug 1439099 P2 Remove ServiceWorkerRegistrationInfo::GetByID(). r=asuth
2018-02-19 12:06:19 -08:00
8cdf705535
Bug 1435174 - Remove the renaming 'using namespace workers', r=bkelly
2018-02-05 19:55:07 +01:00
478687c2e8
Bug 1434686 part 4. Use IgnoreErrors() in dom/. r=mystor
...
MozReview-Commit-ID: GwVDrTLPTOb
2018-02-01 14:21:14 -05:00
785a14270e
Bug 1431867 - Part 2: Add move constructors and assignment operators to IPDL unions, r=mccr8
...
MozReview-Commit-ID: IQVODEfMGi9
2018-02-01 11:30:50 -05:00
af73b55e78
Bug 1434342 P7 Use the global to GetOrCreate the ServiceWorker DOM instance. r=asuth
2018-01-31 09:10:27 -08:00
26352bfee1
Bug 1432963 - Fixing workers headers - part 17 - no LIBS=[workers] in moz.build files, r=smaug
2018-01-31 08:25:30 +01:00
a5bed23bd8
Bug 1432963 - Fixing workers headers - part 15 - static function in a workers namespace, r=smaug
2018-01-31 08:24:30 +01:00
2c7c69af24
Bug 1432963 - Fixing workers headers - part 14 - WorkerPrivate without workers namespace, r=smaug
2018-01-31 08:24:08 +01:00
063723a1f0
Bug 1432963 - Fixing workers headers - part 13 - WorkerHolder without workers namespace, r=smaug
2018-01-31 08:23:44 +01:00
528066218f
Bug 1432963 - Fixing workers headers - part 8 - WorkerTargetHolder without workers namespace, r=smaug
2018-01-31 08:21:27 +01:00
9774cec092
Bug 1413112 - Fixing includes in dom/workers, r=bkelly
2018-01-30 10:14:00 +01:00
e71d8db226
Bug 1430139 P3 Remove workers namespace from service worker code. r=asuth
2018-01-26 13:08:59 -08:00
9225189e3a
Bug 1231211 P3 Serialize LoadInfo's mClientInfo, mReservedClientInfo, and mReservedClientInfo members across IPC. r=valentin
2018-01-23 10:38:52 -05:00
16c84b6c1b
Bug 1431846 part 2. Rename nsPIDOMWindowInner::GetNavigator() to Navigator(), since it never returns null. r=mystor
...
Also have it return a dom::Navigator.
MozReview-Commit-ID: 5thGopGWIk9
2018-01-22 12:59:15 -05:00
83aecd3510
Bug 1431079 - Ensure we don't attempt to launch content processes during shutdown. r=smaug
2018-01-22 06:11:46 -06:00
7ec737b816
Bug 1431295 - Drop 'undef None' macro in dom/. r=baku
...
MozReview-Commit-ID: Fmd4A2c7yUu
--HG--
extra : rebase_source : fdad8ac6276efa1a3612eb1c9a2a9478270d426d
2018-01-18 14:12:51 +09:00
37efe4d0e6
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
...
MozReview-Commit-ID: DCPTnyBooIe
--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
b7d9339122
Bug 1425975 P14 Assert that storage is allowed when a ClientSource is both execution ready and controlled. r=asuth
2018-01-05 12:10:22 -05:00
423f2202f9
Bug 1425975 P13 Check for a different final document principal and reset the ClientSource when it happens. r=asuth
2018-01-05 12:10:22 -05:00
ed3bd4b27a
Bug 1425975 P1 Add ClientHandle::OnDetach() which returns a MozPromise that resolves on actor destruction. r=asuth
2018-01-05 12:10:20 -05:00
0bf10c4d4e
Backed out 14 changesets (bug 1425975) for M(5) permafails mochitest/test_ext_webrequest_filter.html. r=backout a=backout
...
Backed out changeset e6f4a2d1df9a (bug 1425975)
Backed out changeset 1e657fa97b71 (bug 1425975)
Backed out changeset 9e1544ec814d (bug 1425975)
Backed out changeset 0e50d9d1d069 (bug 1425975)
Backed out changeset fb89dbd922ba (bug 1425975)
Backed out changeset f2b451ce55d4 (bug 1425975)
Backed out changeset 4ce186c6d8f5 (bug 1425975)
Backed out changeset 6f520ab76d6a (bug 1425975)
Backed out changeset f091f5e182c4 (bug 1425975)
Backed out changeset 82d39ed8c831 (bug 1425975)
Backed out changeset df13eba47970 (bug 1425975)
Backed out changeset 553628a56e6a (bug 1425975)
Backed out changeset acf4d61babab (bug 1425975)
Backed out changeset b7ae11b5bce8 (bug 1425975)
2017-12-24 00:23:57 +02:00
e6fd22c374
Bug 1425975 P14 Assert that storage is allowed when a ClientSource is both execution ready and controlled. r=asuth
2017-12-22 21:09:20 -05:00
8a4820ecbd
Bug 1425975 P13 Check for a different final document principal and reset the ClientSource when it happens. r=asuth
2017-12-22 21:09:20 -05:00
8e2abf779f
Bug 1425975 P1 Add ClientHandle::OnDetach() which returns a MozPromise that resolves on actor destruction. r=asuth
2017-12-22 21:09:17 -05:00
0c4c26f91f
Bug 1426253 P4 Assert that ClientSource::SetController() is never called on a client in private browsing mode. r=asuth
2017-12-20 10:53:19 -05:00
7c2e00408e
Bug 1426253 P2 Use nsIDocument::GetClientInfo() where possible. r=asuth
2017-12-20 10:53:18 -05:00
36ae9f5253
Bug 1425316 P4 Note that a ClientSource has called register() for a SW scope and use it to match window console reports. r=asuth
2017-12-19 10:04:48 -05:00
13b91bfce7
Bug 1425614 P2 Make ClientManager and ClientHandle operation promises reject if called on a worker thread already shutting down. r=asuth
2017-12-18 16:42:10 -05:00
90251dcbd7
Bug 1425614 P1 Make ClientThing::MaybeExecute() call an optional failure callback. r=asuth
2017-12-18 16:42:10 -05:00
41971c4dc5
Bug 1425704 Fix nullptr deref in android-only Clients.openWindow() when browser is not running. r=asuth
2017-12-18 11:55:18 -05:00
63c97930f1
Bug 1293277 P7 Make ServiceWorkerManager use ClientHandle::Control() for claiming and ClientSource::SetController() fire the controller change event. r=baku
2017-12-12 15:44:48 -05:00
cfb0e62f7b
Bug 1293277 P5 Switch bindings over to new Client and Clients classes. r=baku
2017-12-12 15:44:47 -05:00
4bede347d6
Bug 1293277 P4 Add Client and Clients DOM classes, but don't hook them into bindings yet. r=baku
2017-12-12 15:44:47 -05:00
64d85c2b66
Bug 1293277 P1 Capture StorageAccess when snapshoting ClientSource state. r=baku
2017-12-12 15:44:46 -05:00
3816f9801c
Bug 1424338 P7 Remove the ClientEndPoint union type for now. r=baku
2017-12-08 14:46:43 -05:00
32b65c1d6c
Bug 1424338 P6 Implement ClientHandle::PostMessage() r=baku
2017-12-08 14:46:43 -05:00
daf4ea918b
Bug 1424338 P5 Implement ClientHandle::Focus(). r=baku
2017-12-08 14:46:43 -05:00
280fdf002f
Bug 1424338 P4 Implement ClientManager::OpenWindow(). r=baku
2017-12-08 14:46:43 -05:00
80571616a2
Bug 1424338 P3 Add ClientManager::Navigate() method. r=baku
2017-12-08 14:46:42 -05:00
c911e0c6bb
Bug 1424338 P2 Add ClientManager::Claim() message to matching ClientSource objects. r=baku
2017-12-08 14:46:42 -05:00
783e26e13e
Bug 1424338 P1 Implement ClientManager::MatchAll() to support clients.matchAll() WebAPI. r=baku
2017-12-08 14:46:42 -05:00
4e2dc7e51f
Bug 1423913 P3 Don't register more shutdown handle if we create more than one ClientManagerService instance. r=baku
2017-12-08 11:52:07 -05:00
65e9628fa6
Bug 1423913 P2 Make callers expect infallble CreateSource() and CreateHandle(). r=baku
2017-12-08 11:52:07 -05:00
10e891e2d2
Bug 1423913 P1 Make ClientManager::CreateSource() and CreateHandle() infallible. Errors result in a detached object instead of nullptr. r=baku
2017-12-08 11:52:06 -05:00
Andrew Sutherland
Ben Kelly
Sebastian Hengst
Andrea Marchesini
Boris Zbarsky
Nika Layzell
Andrew Osmond
Hiroyuki Ikezoe
Chris Peterson
Csoregi Natalia