This clarifies why the flavors are added in a certain order and why
retrieving the first available one is the best one.
Moreover, this enables previously, accidentally disabled
`NS_WARNING_ASSERTIONS`.
Differential Revision: https://phabricator.services.mozilla.com/D90883
This clarifies why the flavors are added in a certain order and why
retrieving the first available one is the best one.
Moreover, this enables previously, accidentally disabled
`NS_WARNING_ASSERTIONS`.
Differential Revision: https://phabricator.services.mozilla.com/D90883
If an XPIDL interface has a method or attribute that is [notxpcom],
then it is implicitly treated as [builtinclass], even if it is not
marked as such. For clarity, this patch goes through and marks every
place that relies on this behavior (aside from some test code).
Differential Revision: https://phabricator.services.mozilla.com/D30714
--HG--
extra : moz-landing-system : lando
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.
Overall it's not a very interesting patch I think.
nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.
I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
On Mac, when dragging an image, add the image request's MIME type to
the transfer so that the MIME-extension check can be done in the
parent process to avoid content sandboxing issues.
MozReview-Commit-ID: 3cb4fCr6GnL
--HG--
extra : rebase_source : 43720237b467765401b5504c57bbc1b43d4dfdc0
When dragging an image, add the image request's MIME type to the transfer
so that the MIME-extension check can be done in the parent process.
Move the MIME-extension check to the parent process to avoid
issues caused by content process sandboxing.
MozReview-Commit-ID: 3cb4fCr6GnL
--HG--
extra : rebase_source : ec49b8c83613be844fe4cd88a5024ac41a845199
When dragging a `draggable=true` HTML DOM node, if no data is added to the
DataTransfer during the DragStart event, we currently cancel the drag. This is
inconsistent with Chrome's behaviour.
This patch adds a chrome-only (hidden from content) item to the DataTransfer:
application/x-moz-dummy-data. This data is added only when no other data has
been added to the DataTransfer, and the target of the dragstart event was a
draggable=true HTML DOM node.
This hidden node allows for the drag event to complete successfully, while
appearing the same as Chrome's behavior to content scripts.
MozReview-Commit-ID: HVqEr7aR6DD
This converts |nsITransferable.flavorsTransferableCanExport| and
|nsITransferable.flavorsTransferableCanImport| to return a |nsIArray|.
|nsIFormatConverter.getInputDataFlavors| and
|nsIFormatConverter.getOutputDataFlavors| are updated as well.
This patch does the following:
* It adds nsITransferable::Init(nsILoadContext*). The load context
might be null, which means that the transferable is non-private, but
if it's non-null, we extract the boolean value for the privacy mode
and store it in the transferable.
* It adds checks in debug builds to make sure that Init is always
called, in form of fatal assertions.
* It adds nsIDOMDocument* agruments to nsIClipboardHelper methods which
represent the document that the string is coming from.
nsIClipboardHelper implementation internally gets the nsILoadContext
from that and passes it on to the transferable upon creation. The
reason that I did this was that nsIClipboardHelper is supposed to be a
high-level helper, and in most of its call sites, we have easy access
to a document object.
* It modifies all of the call sites of the above interfaces according to
this change.
* It adds a GetLoadContext helper to nsIDocument to help with changing
the call sites.
Tom Schuster
Tim Huang
Mihai Alexandru Michis
Mirko Brodesser
Dorel Luca
Sylvestre Ledru
Andrew McCreight
Emilio Cobos Álvarez
Andreea Pavel
Csoregi Natalia
Boris Zbarsky
Haik Aftandilian
Coroiu Cristina
Masatoshi Kimura
Sebastian Hengst
Michael Layzell
Makoto Kato
Eric Rahm
Hector Zhao
Jonathan Kingston
Randell Jesup
Neil Deakin
Jorg K
Christoph Kerschbaumer
Ehsan Akhgari
Eric Wong
Ed Morley
Ryan VanderMeulen