Remove the now obsolete event handling code including `new Funcition`. Remove dialog.xml from eval() whitelist.
Differential Revision: https://phabricator.services.mozilla.com/D25742
--HG--
extra : moz-landing-system : lando
`nsIControllerCommandTable` isn't implemented with JS even in comm-central nor
BlueGriffon. Therefore, we can make it a builtinclass.
Additionally, it's inherited only by nsControllerCommandTable. So, all users
in C++ can treat the concrete class directly.
Differential Revision: https://phabricator.services.mozilla.com/D25727
--HG--
extra : moz-landing-system : lando
`nsICommandManager` isn't implemented by JS even in comm-central nor
BlueGriffon. Therefore, we can make it a builtinclass.
Additionally, this patch makes all users in C++ use `nsCommandManager` which is
the only implementation of `nsICommandManager`. This avoids QI from
`nsICommandManager` to `nsPICommandUpdater`.
Differential Revision: https://phabricator.services.mozilla.com/D25726
--HG--
extra : moz-landing-system : lando
`nsPresContext` should use `mozilla::PresShell` directly instead of
`nsIPresShell`. This patch makes it.
Unfortunately, `nsPresContext` and `nsIFrame` have `PresShell()`. Therefore,
we cannot use `PresShell*` in its methods so that this patch uses `mozilla::`
namespace prefix.
It might be better to rename them as `PresShellPtr()` in another bug.
Differential Revision: https://phabricator.services.mozilla.com/D25721
--HG--
extra : moz-landing-system : lando
`nsChildView::GetEditorView()` is called by `TextInputHandlerBase::GetWindowLevel()`
which is called when Cocoa requests window level of focused widget.
It currently gets widget including focused element (e.g., it may be in a XUL
`<panel>`) with `eQueryTextContent` event. However, it requires only the widget
(i.e., when a XUL `<panel>` has focused element, the widget for the panel).
Therefore, it does not require to flush the layout.
However, on macOS, `ContentEventHandler` always flushes layout even with
`eQueryContentState` which does not require any layout information. Whether
it requires flushing layout or not is considered with
`WidgetQueryContentEvent::mNeedsToFlushLayout` but this is set to false only
when `IMEContentObserver` notifies widget (and IME) of focus set. At this
time, only on macOS, IME caches the layout information, for example, the
character coordinates, but we don't have a way to update it. This is the reason
why we always flush layout on macOS.
Unfortunately, when a menu popup frame is created, widget for the popup is
created synchronously. Then, Cocoa retrieves window level of the widget including
focused element. But this is unsafe to flush the layout. So, we need to stop
flushing layout in this case.
Therefore, this patch moves the `#ifdef` from `TextEvents.h` to
`IMEContentObserver.cpp`, then, makes `nsChildView::GetEditorView()` use
`eQueryContentState` which is the simplest query content event, and finally,
sets `mNeedsToFlushLayout` to `false`.
Differential Revision: https://phabricator.services.mozilla.com/D25912
--HG--
extra : moz-landing-system : lando
When remote/JSONHandler.jsm intercepts errors thrown during the
handling of an HTTP request, it is without except the underlying
cause of the problem you wish RemoteAgentError#notify() to give you.
Under no circumstances are you interested in where the error is re-thrown.
Differential Revision: https://phabricator.services.mozilla.com/D25617
--HG--
extra : moz-landing-system : lando
In Bug 1533312, we supported the category-based list for tracking annotation.
We can update the preference now to enable the feature:
base-track-digest256 will be replaced with:
1.ads-track-digest256
2.social-track-digest256
3.analytics-track-digest256
Differential Revision: https://phabricator.services.mozilla.com/D24002
--HG--
extra : moz-landing-system : lando
Disable early sandbox init for the RDD Mac process until the 10.11 crash is resolved.
Differential Revision: https://phabricator.services.mozilla.com/D25690
--HG--
extra : moz-landing-system : lando
Mechanical change from Matcher::match(...) to Matcher::operator()(...).
This will now permit the use of generic lambdas, and facilitate the
implementation of multi-lambda match.
Differential Revision: https://phabricator.services.mozilla.com/D24889
--HG--
extra : moz-landing-system : lando
Navigating with Alt + arrow keys on OSX when the autocomplete popup
was open wasn't closing the popup, which could lead to weird behavior.
The test asserting arrow keys behavior is modified to ensure
this works as expected on all the different platforms.
Differential Revision: https://phabricator.services.mozilla.com/D25378
--HG--
extra : moz-landing-system : lando
I also updated the logic to properly cycle through the visible search engines list
and added a unit test that was missing, somehow.
Differential Revision: https://phabricator.services.mozilla.com/D25368
--HG--
extra : moz-landing-system : lando
To correctly present IPv6 URL, we need to add the brackets for the host obtained from nsIURI
Differential Revision: https://phabricator.services.mozilla.com/D21828
--HG--
extra : moz-landing-system : lando
Paul Adenot
Matthew Gaudet
Luke Wagner
Anthony Aillerie
Kartikaya Gupta
Thomas Wisniewski
Suriyaa Sundararuban
Khyati Agarwal
Ian Moody
Jonas Allmann
Robin Templeton
Ryan VanderMeulen
Alex Gaynor
Hector Zhao
Masayuki Nakano
Dhyey Thakore
Jan de Mooij
Marco Bonardo
Sebastian Hengst
Emilio Cobos Álvarez
Andreas Tolfsen
Dimi Lee
Matt Woodrow
Andi-Bogdan Postelnicu
Brindusan Cristian
Haik Aftandilian
Gerald Squelart
Gian-Carlo Pascutto
Nicolas Chevobbe
Dão Gottwald
Patrick Brosset
Mike de Boer
violet