When a page navigation happens, we update the state of the toolbox toolbar buttons
as some of them need to disable themselves then (rulers and measurement tool).
In bug 1500142 the logic to do this was changed to retrieve the right inspector front
instead of always the top-level one, stored at toolbox level.
This is good. However a tiny mistake made its way into the code.
Instead of calling getCachedFront("inspector") the code called
getCachedFront("inspectorFront")
This made it return null, and therefore prevented the rest of the button update logic
to run.
Differential Revision: https://phabricator.services.mozilla.com/D57997
--HG--
extra : moz-landing-system : lando
Styled the Outline pane filter to be consistent with the Event Breakpoint filter
Differential Revision: https://phabricator.services.mozilla.com/D50977
--HG--
extra : moz-landing-system : lando
The function was moved during Bug 1582870 and
we lost the return statement somehow.
Differential Revision: https://phabricator.services.mozilla.com/D58798
--HG--
extra : moz-landing-system : lando
Since the name can be an undefined grip, there
could be case where the name would be an object
and not a React element, making the rendering fail.
This patch fixes that and adds a test to ensure
this does not regress.
Differential Revision: https://phabricator.services.mozilla.com/D58747
--HG--
extra : moz-landing-system : lando
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.
Differential Revision: https://phabricator.services.mozilla.com/D58313
--HG--
extra : moz-landing-system : lando
For test browser_net_prefs-reload.js, I am not sure about this change firstValue/currentValue seems to be different types numbers, strings, objects.
toString is maybe not the best way to compare those values.
Differential Revision: https://phabricator.services.mozilla.com/D58313
--HG--
extra : moz-landing-system : lando
We then convert that to `#aarrggbb` in GeckoView for convenient use
with `android.graphics.Color`.
Differential Revision: https://phabricator.services.mozilla.com/D57689
--HG--
extra : moz-landing-system : lando
Setting the values for the pref explicitly will make the test run in the same way regardless of the channel
(this pref is true on Nightly only at the moment)
Differential Revision: https://phabricator.services.mozilla.com/D57966
--HG--
extra : moz-landing-system : lando
We were breaking twice in the browser toolbox because we were attaching to
all the content process targets as well as all frame targets.
But as frames (i.e. web pages) are running within the content processes,
we were having two thread actor attached to the same thread.
This is a stopgap solution for the browser toolbox and we would need
to do something better for the content toolboxes.
Differential Revision: https://phabricator.services.mozilla.com/D57505
--HG--
extra : moz-landing-system : lando
The ReflowTracker was based on the assumption that there was only ever going to
be one target to be observed.
With Fission, this is no longer true.
Turning the ReflowTracker into something that is multi-target aware seemed more
complex than really worth it. After all, all it was doing is getting a ReflowFront
and listening for events on it.
The only 3 things that needed it are the grid inspector, flex inspector and box
model widget. They all needed it for the same reason: updating the data displayed
in the UI when the size/geometry/box-model regions of the selected node changed.
So, it seems simpler to let the inspector instantiate the right ReflowFront when
it needs it (upon a new node selection).
There's only one node selected at any given time in the inspector, so it's simple
to just listen for reflow in that node's target, and dispatch events to the grid,
flex and box-model tools so they can update themselves.
Note that once a new node is selected, we do the `getFront("Reflow")` again
since that node can be in a different target than the previous one. If it is,
however, in the same target, then `getFront` will return the same instance which
is nice.
Differential Revision: https://phabricator.services.mozilla.com/D55987
--HG--
extra : moz-landing-system : lando
Belén Albeza
Patrick Brosset
Arthur Iakab
Krishnal Ciccolella
Micah Tigley
Brian Hackett
Jason Laster
Nicolas Chevobbe
Yura Zenevich
Jan Odvarko
Harald Kirschner
Dorel Luca
Tom Schuster
Michael Hoffmann
Gurzau Raul
wartmanm
Oriol Brufau
Greg Tatum
Brad Werth
Julian Descottes
Razvan Maries
Zibi Braniecki
Ciure Andrei
James Willcox
Alexandre Poirot