This patch adds localization to the WDBA in a somewhat unusual manner. It's very difficult to localize toast notifications because the button text tends to overflow, which the localizers won't realize. Therefore, we are making a simpler version of the toast notification that only uses "Yes" and "No" as the button text. In English, we will not use this version and will continue using the version we have been using.
This means that the localized toast notifications will not have an "Ask me later" button, so the behavior will differ a bit from the English version. Specifically, there is no "followup" for the localized notification since there is no button that ought to cause it to be shown.
We've considered and rejected using localizer comments to keep these button strings short. We are limited by the amount of space the text takes up, not the number of characters. We just don't have a good way to convey this information to localizers in an actionable way.
Differential Revision: https://phabricator.services.mozilla.com/D90608
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.
Differential Revision: https://phabricator.services.mozilla.com/D89222
`AppUpdater` just needs to declare that it implements `nsIProgressEventSink`.
`nsIProgressEventSink.onProgress` is the method that's called whenever download
progress is made, and `AppUpdater` implements it, but the caller doesn't call it
because it checks that consumers are `instanceof nsIProgressEventSink`:
https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/UpdateService.jsm#5014
The legacy aboutDialog updater (which I removed in bug 1600864) has this exact
`generateQI` call, I just forgot to port it over to `AppUpdater`. It also
includes `nsIRequestObserver` since AppUpdater (and the legacy aboutDialog
updater) implements it too.
I've updated all the updater tests (via their head.js) so that they check the
download progress text. This applies to aboutDialog and about:preferences tests.
Differential Revision: https://phabricator.services.mozilla.com/D90632
We need to specifiy the partition key for correctly clean-up HSTS data
if network partition is enabled. Without this, some tests could be
affected by HSTS.
Differential Revision: https://phabricator.services.mozilla.com/D90420
If the browser window is minimized, it's unlikely that a preloaded browser will
be useful in the near future. This change skips creating one in such a case.
This avoids an issue in the graphics layer where about:newtab content marks
itself as `renderLayers = true`, and will try to composite content in windows
which are not compositing (because they are hidden).
As an additional level of safety, we also check the preloaded browser's owner
window's minimized state just before setting `renderLayers`, in case it may have
changed after the preloaded browser was created.
Differential Revision: https://phabricator.services.mozilla.com/D85955
There are two things wrong with captureVisibleTab on mobile:
* ownerGlobal is not available on nativeTab, this patch uses
this.browser.ownerGlobal instead.
* ZoomManager is not available on mobile, this patch moves that code to
browser/../ext-tabs.
Differential Revision: https://phabricator.services.mozilla.com/D90009
When the user chooses to print using the system dialog, we should hide the print
UI. We are choosing to hide the dialog stack instead of closing the dialog because
the print preview browser still needs to be available if the user tries to print.
We close the window if the user cancels the system dialog or once we receive the
promise from PrintUtils.printWindow.
Differential Revision: https://phabricator.services.mozilla.com/D88096
Many instances of the launcher failure ping indicate hooking NtMapViewOfSection
or LdrLoadDll failed. This is most likely caused by a third-party application
applying a hook onto the same target earlier than we do.
This patch is to add a new field "detour_orig_bytes" in the laucnher failure ping
to collect the first sixteen bytes of a detour target function. With this,
we can know whether those detour failures were caused by a third-party hook or not,
and if yes, what was the actual binary pattern.
Differential Revision: https://phabricator.services.mozilla.com/D89836
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
Itiel
Kris Maglione
Mike Conley
Mihai Alexandru Michis
Dorel Luca
Mozilla Releng Treescript
Narcis Beleuzu
Kirk Steuber
Harry Twyford
Nihanth Subramanya
Jared Wein
pbz
Neil Deakin
Drew Willcoxon
Bogdan Tara
Punam Dahiya
Marco Bonardo
Cosmin Sabou
Dennis Schubert
Tim Huang
J. Ryan Stinnett
Erica Wright
Dão Gottwald
Christoph Kerschbaumer
Agi Sferro
emcminn
Scott
Toshihito Kikuchi
Emma Malysz
Shane Caraveo
Sean Feng