For now, the two cases were using the same flag 'insideDebuggerEvaluationWithOnNativeCallHook',
but it would be benefitial to distinguish the two features:
1) have a debugger to have exclusive observation of its own evaluation and calls (exlusiveDebuggerOnEval),
2) observe native call and requires to disable JIT and enable slow path related to this observation (onNativeCall/observesNativeCall).
The previous patch addressed 2), but now it would be nice to have an explicit flag to say
that a given Debugger evaluation should avoid trigerring any other Debugger's hooks.
Differential Revision: https://phabricator.services.mozilla.com/D195178
Instead of limiting Debugger onNativeCall hook to the debugger evaluation,
allow observing any code running, especially including the page executions.
Differential Revision: https://phabricator.services.mozilla.com/D195177
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.
As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.
Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.
Differential Revision: https://phabricator.services.mozilla.com/D194510
I forgot to use a reference when doing the refactoring. We should use a
reference to a pointer because we rely on the information from the previous
iteration, in the private function, `AddImplicitNamedAreasInternal()`.
Note: I don't have a test for this. This bug is from a real website:
https://www.oddbird.net/tools/, and it's not easy to reduce the
testcase, so we may need a QA to verify this by the real website.
Differential Revision: https://phabricator.services.mozilla.com/D195388
Other browsers seem to follow the spec to the letter, so do the same.
The list-styles.html test is marked as failing, but that's because it
hasn't been synced yet.
Differential Revision: https://phabricator.services.mozilla.com/D195406
Though there's no open bugs corresponding to these test cases, there were no
test cases to make sure `touch-action:manipulation` prevents double-tap-to-zoom
on __touchscreen__ and doesn't prevent it on __touchpad__.
I've confirmed both Chrome and Safari have the same behavior on touchpad.
Differential Revision: https://phabricator.services.mozilla.com/D186321
Since ICU4C 74 is backed out in tree, we don't land bug Bug 1806348 yet.
ICU4X 1.4 uses Unicode License V3, so we have to update license text.
Differential Revision: https://phabricator.services.mozilla.com/D195107
Although since `icu_capi` uses weak dependency syntax, cargo vendor doesn't
recognize it. So this command will copy unnecessary crates. To avoid it, I
would like to use modified version of icu_capi.
And this has another issue. `icu_capi`'s C++ headers isn't compatible with
clang [*1]. So we need the workaround for it.
ICU4X 1.3 has another change for data provider with `icu_capi`.
From ICU4X 1.3, there are new `icu_*_data` crates to custom data file, instead
of `icu_testdata`. So we have to add each data crate if using `icu_capi`.
*1 https://github.com/llvm/llvm-project/issues/70162
Differential Revision: https://phabricator.services.mozilla.com/D192902
When a grid item is set to align itself to the baseline (first or last)
then it should participate in baseline alignment if the item's size is
not dependent on the size of the track and vice versa.
Also added a test to check for last baseline alignment in addition to
first baseline alignment on empty blocks.
Differential Revision: https://phabricator.services.mozilla.com/D157345
Automatic update from web-platform-tests
HTML pseudo-classes: :checked:indeterminate
Primarily for https://github.com/WebKit/WebKit/pull/21157.
--
wpt-commits: e0e0f5b2721bf22568309f71a56ba7926348b0ef
wpt-pr: 43482
Automatic update from web-platform-tests
[GridNG] Update grid-auto-repeat-max-size-001.html and mark tentative
Updating per discussion in CSSWG
(https://github.com/w3c/csswg-drafts/issues/8963) and marking as
tentative.
Bug: 1506789
Change-Id: Ib639db1d2c01870aae2a14be97e63788e5d955b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5077105
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232260}
--
wpt-commits: 766176388fc4bb331c012525b85b2e482577c1c0
wpt-pr: 43461
Automatic update from web-platform-tests
Reland "Check if math expression has percentages deep inside"
This is a reland of commit fc365dddd74a2c9ba22036fd5563dbea8ff34c7c
Original change's description:
> Check if math expression has percentages deep inside
>
> Currently, only the top level category is checked to have a percentage
> dependency, check all the nodes inside the expression as well,
> as it can be the case like:
> NumberProducingFunction(Percentage) * Pixels.
> The top level category is Length in such case and we try to resolve it
> with ComputeLength, where percentages are not allowed.
>
> Note: the added test would crash before the CL, as it would try to
> GetDouble() of percentage which is not allowed in that context.
>
> Bug: 1505817
> Change-Id: Iefd13c0d190c3b8adf463ea244f81331635e14fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064155
> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1230671}
Bug: 1505817
Change-Id: I19b1ce50ffd50bdbf7aa4dc919fb7525b0b02db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076966
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232219}
--
wpt-commits: 274238953d7f9c74b6c77f3e91081a6ec50c4ab1
wpt-pr: 43468
Automatic update from web-platform-tests
Shared Storage: Add tests for SSW imgs controlled by service workers
We add some web tests to show that image requests, with the
`sharedStorageWritable` attribute set to true, that are intercepted
by service workers but fallback to network can write to shared storage
via response headers.
Bug: 1434529,1218540
Change-Id: I5b3b56286788f8f25042d5b02e1e10e4824f3c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5073616
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231656}
--
wpt-commits: f0b8f3951fa09e59b26a6cf15a1f287c499c2e3e
wpt-pr: 43438
Automatic update from web-platform-tests
LoAF: Be specific about source locations and CORS
- For CORS-ok scripts, expose base URL
- For opaque module scripts, expose source URL
- For callbacks/events in opaque scripts, don't expose URL
The proposed spec is a bit open about this as long as opaque script locations
are not exposed, so the WPT allows a few options and rejects only
on violations.
Bug: 1506096
Change-Id: If3b3a86a9ab396f189b188f4b5b7a8e0064b05ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5077466
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232040}
--
wpt-commits: 3aff5f1e12d6dc20e333b3f8ae589d86c1ddaedb
wpt-pr: 43467
Automatic update from web-platform-tests
Fix NOTREACHED in layoutTheme::DefaultSystemColor
CSS transitions and animations did not support unresolved color-mix.
With this patch, transitions work with unresolved-color-mix, and CSS
animations work with unresolved-color-mix in a neutral keyframe. Still
need to support unresolved-color-mix with a string keyframe for a CSS
animation.
Bug: 1493430, 1500708, 1464035
Change-Id: I7aa71ae8af4a8908f49bb41c5378f00c9a748c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014009
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232024}
--
wpt-commits: 6b504502305706640be6b33b5710dc47e568d260
wpt-pr: 43031
Automatic update from web-platform-tests
[Private Network Access] Add location update WPTs
Similar to window-open and anchor tests but navigating via
window.location updates. The "top.location" tests update
the window.location of its top window.
Bug: 1431155
Change-Id: I0894d798d40cd20bc4bc66042132feeb98a6beab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5062770
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232002}
--
wpt-commits: 52dabc90de44f528b8fc79aa5bfe4df11914f2b6
wpt-pr: 43367
Automatic update from web-platform-tests
[Private Network Access] Add anchor navigation wpts
This is very similar to the window-open tests but they open new windows
via an anchor link click.
Bug: 1291252
Change-Id: I93108369d7fc9e9cc5dae10ec06a009bd84064a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5053884
Commit-Queue: Jonathan Hao <phao@chromium.org>
Reviewed-by: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231997}
--
wpt-commits: 866a3036c79d1e8b651ae1d1375eace93b9ea920
wpt-pr: 43476
Automatic update from web-platform-tests
[Grid] Remove usage of Ahem font in grid-minimum-size-grid-items-021
The font is causing the WPT to fail due to minor artifacts that result
in the contribution size of the text not being *exactly* `100px`.
Refactoring the test to use an inline item of `width: 100px`.
Results for other browser vendors remain unaffected by this change.
Bug: 1506877
Change-Id: Ia019048d4f401ad8ccd3926eaff32f2547d6dfdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5078473
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231967}
--
wpt-commits: 12ddd2531567d7a7c41c211e60f5fe41518e6b72
wpt-pr: 43464
Automatic update from web-platform-tests
[Private Network Access] Extend iframe navigation check to main frames
This applies PNA to top level navigations. It also extends the original
feature flag to cover the top level case.
Adjustment to tests:
1. We can't expect window.open to return null. It has to return
something when it navigates to the initial empty document, and PNA
checks happen later.
2. Use subsetTestByKey like the iframe test because running evenything
together tends to time out.
3. Use `PreflightBehavior.navigation()` so the test server replies
headers necessary for navigation requests.
4. Make the test return "no preflight received" when that's the reason
the test fails, to distinguish from failures.
Bug: 1431155
Change-Id: I3fcf212139eebb59384e4247776d562bcbe67c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5019405
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231939}
--
wpt-commits: 3e5b556b8a60dc444d7b7a0c422145d467ae0a2b
wpt-pr: 43081
Alexandre Poirot
Eemeli Aro
Noemi Erli
Boris Chiou
Jonathan Watt
Emilio Cobos Álvarez
Issam Mani
Sarah Clements
Olli Pettay
Sylvestre Ledru
aaoblivion
Hiroyuki Ikezoe
Cristian Tuns
Makoto Kato
Tiaan Louw
moz-wptsync-bot
Anne van Kesteren
Kurt Catti-Schmidt
Daniil Sakhapov
Camillia Smith Barnes
Keren Zhu
Noam Rosenthal
Antoine Quint
Kevin Ellis
Jonathan Hao
Ethan Jimenez (from Dev Box)