The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
This conversion was done with the script:
find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
-e 's/TemporaryRef</already_AddRefed</g'
Manual fixups were performed in the following instances:
- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
into already_AddRefed.
- The following files had explicit Move() calls added to make up for the lack
of a copy constructor on already_AddRefed:
dom/base/ImageEncoder.cpp
dom/media/MediaTaskQueue.{h,cpp}
dom/media/webaudio/PannerNode.cpp
- A redundant overload for MediaTaskQueue::Dispatch was deleted.
- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.
- Comments, using declarations, and forward declarations relating to
TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
already_AddRefed.
Using GLTextureSource gives us better performance because we don't need to call
CGLTexImageIOSurface2D everytime we draw.
This will eventually let us drop MacIOSurfaceTextureSourceOGL once WebGL on OS
X is using MacIOSurfaceTextureHostOGL.
--HG--
extra : rebase_source : 95a9b0888d7ddfeae520141e7f932f8555fa58d5
Birunthan Mohanathas
Nathan Froyd
Nicolas Silva
Ehsan Akhgari
Jeff Muizelaar
Sotaro Ikeda
Jeff Gilbert
James Willcox
Matt Woodrow
Daniel Holbert
Dan Glastonbury
Nicolas Silva
Ryan VanderMeulen
Andreas Pehrson
Benoit Jacob