Steve Fink
e4b6669027
Bug 1762537 - Omit some annotations when compiling under sixgill to avoid incompatibilities between what clang and gcc allow for lambda annotations r=firefox-static-analysis-reviewers,andi
...
Differential Revision: https://phabricator.services.mozilla.com/D142714
2022-04-15 15:43:10 +00:00
Emilio Cobos Álvarez
a9a85f3eca
Bug 1763741 - Make gfx types take the right amount of space in MSVC. r=jrmuizel,glandium
...
This is an attribute that could be useful elsewhere so seems worth
putting in mfbt.
Differential Revision: https://phabricator.services.mozilla.com/D143249
2022-04-08 13:27:28 +00:00
Randell Jesup
da67253143
Bug 1207753 - minor cleanup of a comment r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D142084
2022-03-25 19:44:26 +00:00
Randell Jesup
fcaf70841e
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
2390d257e6
Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE
2022-03-16 18:32:51 +02:00
Randell Jesup
4b033a5256
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
927ad62c6a
Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE
2022-03-16 14:38:14 +02:00
Randell Jesup
7d4b5fae04
Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Kagami Sascha Rosylight
901a35ec10
Bug 1748874 - Part 5: Require CAN_RUN_SCRIPT to be at the first declaration r=andi
...
Depends on D135404
Differential Revision: https://phabricator.services.mozilla.com/D135405
2022-01-11 11:52:27 +00:00
Chris Peterson
339c7d8961
Bug 1729598
- Remove now-unused MustUseChecker and MOZ_MUST_USE_TYPE attribute. r=static-analysis-reviewers,andi
...
Depends on D125504
Differential Revision: https://phabricator.services.mozilla.com/D125505
2021-09-15 05:10:51 +00:00
Andi-Bogdan Postelnicu
eab549fd19
Bug 1519636 - Initial reformat of C/C++ code with clang-format version 12.0.0. r=sylvestre
...
clang-format version 12.0.0 (taskcluster-KEgO7qdgQ8uaewA6NkRnRA)
Differential Revision: https://phabricator.services.mozilla.com/D114211
2021-05-10 07:15:07 +00:00
Chris Peterson
7cba58e66d
Bug 1571631 - Remove MOZ_MUST_USE definition. r=sg
...
Depends on D108345
Differential Revision: https://phabricator.services.mozilla.com/D108346
2021-03-17 03:01:21 +00:00
Kagami Sascha Rosylight
a2323b59a0
Bug 1691515 - Add MOZ_KNOWN_LIVE member annotation r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D107321
2021-03-05 23:23:03 +00:00
Simon Giesecke
4fa1e97bce
Bug 1651323 - Add MOZ_LIFETIME_BOUND attribute. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D82681
2020-07-10 12:16:13 +00:00
june wilde
99fcac8838
Bug 1649967 - Add missing annotation attributes to builds with clang-plugin enabled; r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D81958
2020-07-06 17:03:23 +00:00
Simon Giesecke
79b5dc835f
Bug 1625143 - Add returns_nonnull attributes to moz_x allocation routines. r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D68367
--HG--
extra : moz-landing-system : lando
2020-03-27 07:33:28 +00:00
Boris Zbarsky
8303e25004
Improve documentation for MOZ_CAN_RUN_SCRIPT_BOUNDARY. No bug. r=mbrodesser,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D62955
--HG--
extra : moz-landing-system : lando
2020-02-19 02:50:58 +00:00
Chris Peterson
00129c9a09
Bug 1570499 - Part 3: Remove MOZ_FALLTHROUGH macro definition. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D56442
--HG--
extra : moz-landing-system : lando
2019-12-20 07:03:27 +00:00
Sylvestre Ledru
f12b9fa5c3
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D47737
--HG--
extra : moz-landing-system : lando
2019-10-06 18:29:55 +00:00
Boris Zbarsky
fa0ce4b209
Bug 1581315 part 1. Adjust MOZ_MUST_RETURN_FROM_CALLER to only apply to method calls on arguments. r=nika
...
It doesn't really make sense to enforce this behavior for calls on stack
variables (which presumably we then want to do something with) and doesn't
necessarily make sense to enforce it for member variables either.
Differential Revision: https://phabricator.services.mozilla.com/D46105
--HG--
extra : moz-landing-system : lando
2019-09-20 02:17:01 +00:00
Aaron Klotz
db8a55f024
Bug 1569681: Part 3 - Update mfbt/Attributes.h with new MOZ_STATIC_LOCAL_CLASS macro; r=Ehsan
...
I did not add a separate macro for `MOZ_TRIVIAL_DTOR` as I could not really
think of a use case for it. Let me know if you prefer that I add it as a
distinct macro.
Differential Revision: https://phabricator.services.mozilla.com/D39719
--HG--
extra : moz-landing-system : lando
2019-07-30 18:51:11 +00:00
Mihai Alexandru Michis
fbddadbfab
Backed out 3 changesets (bug 1569681) for causing build bustages. CLOSED TREE
...
Backed out changeset 292cc6853e82 (bug 1569681)
Backed out changeset 4d0a7b968eb0 (bug 1569681)
Backed out changeset be9e5f8f00d0 (bug 1569681)
2019-07-29 23:21:01 +03:00
Aaron Klotz
dd7121c289
Bug 1569681: Part 3 - Update mfbt/Attributes.h with new MOZ_STATIC_LOCAL_CLASS macro; r=Ehsan
...
I did not add a separate macro for `MOZ_TRIVIAL_DTOR` as I could not really
think of a use case for it. Let me know if you prefer that I add it as a
distinct macro.
Differential Revision: https://phabricator.services.mozilla.com/D39719
--HG--
extra : moz-landing-system : lando
2019-07-29 20:10:39 +00:00
Mihai Alexandru Michis
ab5f499ef3
Backed out 3 changesets (bug 1569681) for causing build bustages. CLOSED TREE
...
Backed out changeset 075b818a46fe (bug 1569681)
Backed out changeset 2c543b239808 (bug 1569681)
Backed out changeset 21ea6fea046e (bug 1569681)
2019-07-29 22:53:13 +03:00
Aaron Klotz
567add1b38
Bug 1569681: Part 3 - Update mfbt/Attributes.h with new MOZ_STATIC_LOCAL_CLASS macro; r=Ehsan
...
I did not add a separate macro for `MOZ_TRIVIAL_DTOR` as I could not really
think of a use case for it. Let me know if you prefer that I add it as a
distinct macro.
Differential Revision: https://phabricator.services.mozilla.com/D39719
--HG--
extra : moz-landing-system : lando
2019-07-29 19:38:37 +00:00
Kyle Huey
17b36a1a90
Bug 1563046: Move operator LogModule* out of line in debug builds. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D36675
--HG--
extra : moz-landing-system : lando
2019-07-02 23:58:18 +00:00
Boris Zbarsky
e348ad0b6c
Improve the documentation around the MOZ_CAN_RUN_SCRIPT analysis. No bug. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D23762
--HG--
extra : moz-landing-system : lando
2019-03-16 12:52:33 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Ehsan Akhgari
ca162bee20
Bug 1508472 - Part 4: Fourth batch of comment fix-ups in preparation for the tree reformat r=sylvestre
...
This is a best effort attempt at ensuring that the adverse impact of
reformatting the entire tree over the comments would be minimal. I've used a
combination of strategies including disabling of formatting, some manual
formatting and some changes to formatting to work around some clang-format
limitations.
Differential Revision: https://phabricator.services.mozilla.com/D13193
--HG--
extra : moz-landing-system : lando
2018-11-28 09:16:55 +00:00
Jeff Walden
f2196f8c8f
Bug 1503086 - Initialize all SourceBufferHolders with a fallible function that in all cases assumes ownership of given-ownership data. r=tcampbell, r=bz, r=mrbkap on some finicky worker code lightly touched here
...
--HG--
extra : rebase_source : 94b1a13dc03a7f1a5d07a2c665fdc0cde162d411
2018-10-23 12:27:16 -07:00
Steve Fink
b5b78d5525
Bug 1321014 - Respect MOZ_INHERIT_TYPE_ANNOTATIONS_FROM_TEMPLATE_ARGS for the purpose of identifying GC types and pointers, r=jonco
...
--HG--
extra : topic : hazard
extra : rebase_source : bdaf0ae60a6b45c9d44294aa9c2bc31a8811bdbd
extra : source : c7b32ffa822e353b5479b6224194e3cdfd135e65
2018-07-20 18:36:20 -07:00
Mike Hommey
b487ebbc58
Bug 1493093 - Allow to relax MOZ_NON_TEMPORARY_CLASS for some specific constructors r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D6566
--HG--
extra : moz-landing-system : lando
2018-09-24 22:47:12 +00:00
Mike Hommey
88314c2170
Bug 1488631 - Remove annotations that the clang plugin doesn't handle. r=andi
...
As per bug 1487622, annotations have side effects on codegen, one of
which changes a leak signature that the wpt harness doesn't match
against its whitelist anymore.
Interestingly, while looking at the issue, I found multiple moz_*
annotations that weren't actually looked for by the clang plugin,
making them useless. Even more interestingly, removing them changes
codegen in such a way that the leak signature mentioned above is not
altered anymore.
Differential Revision: https://phabricator.services.mozilla.com/D5000
2018-09-08 06:49:48 +09:00
Jeff Walden
04d21ccac0
Bug 1451248. r=jorendorff, r=bz
...
--HG--
extra : rebase_source : e26439a5954162bdaf332fbd63d623a3810e19e0
2018-04-25 19:40:09 -07:00
Nicholas Nethercote
374e333b76
Bug 1451658 - Add MOZ_STATIC_CLASS. r=mystor
...
MozReview-Commit-ID: HlbfoQypMcI
--HG--
extra : rebase_source : 3f91229f7190f04a9f512a6ac594674e05829039
2018-04-10 17:31:31 +10:00
Sylvestre Ledru
78c25c6d82
Bug 1437482 - gcc 8 has no-sanitize but not the {un,}signed-integer-overflow option r=Waldo
...
MozReview-Commit-ID: EfRYhaISZfL
--HG--
extra : rebase_source : 2a5f32a71be4688d260786f6f762183f38b682a8
2018-02-12 12:07:52 +01:00
Jeff Walden
0e77ce073b
Bug 1435484
- Split the integer-overflow blacklist into two blacklists, one for signed integer overflow and one for unsigned integer overflow, and rename both configure flags to be clearer. r=decoder, r=froydnj
...
--HG--
rename : build/sanitizers/ubsan_blacklist_int.txt => build/sanitizers/ubsan_signed_overflow_blacklist.txt
rename : build/sanitizers/ubsan_blacklist_int.txt => build/sanitizers/ubsan_unsigned_overflow_blacklist.txt
2018-02-02 21:25:31 -08:00
Eric Rahm
61c1f85e41
Bug 1434689 - Part 2: Add MOZ_TEMPORARY_CLASS attribute. r=mystor
...
This adds the MOZ_TEMPORARY_CLASS attribute to Attributes.h.
--HG--
extra : rebase_source : aea2ac53705863a839bcf11245b67a9fc1da08bf
2018-01-31 15:22:42 -08:00
Nika Layzell
a124bfae77
Bug 1418465 - Add an opt-out to the MOZ_CAN_RUN_SCRIPT analysis, r=andi
...
MozReview-Commit-ID: 2YKncUdrT5p
2017-11-24 11:15:17 -05:00
Nicholas Nethercote
d225f7151b
Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
...
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
--HG--
rename : xpcom/ds/nsIAtom.h => xpcom/ds/nsAtom.h
extra : rebase_source : ac3e904a21b8b48e74534fff964f1623ee937c67
2017-10-03 09:05:19 +11:00
Tom Ritter
92ff663a31
Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r=dmajor,froydnj
...
/home/worker/workspace/build/src/mozglue/build/WindowsDllBlocklist.cpp:816:1: error: 'noreturn' function does return [-Werror]
MozReview-Commit-ID: SYgPDW0sMV
--HG--
extra : rebase_source : 27b1dda404b3fc5fab95dd524677387bad921751
2017-08-24 22:49:09 -05:00
Tristan Bourvon
ba0998ae31
Bug 1380423 - Add static-analysis to enforce strict rules on functions which can run scripts. r=mystor
...
MozReview-Commit-ID: GGSyq0z5msB
2017-08-08 19:48:53 +03:00
Luke Wagner
e59ff0294c
Bug 1351488 - Add MOZ_XPCOM_ABI to mfbt (r=froydnj)
...
MozReview-Commit-ID: Hw3zDX3TOhs
--HG--
extra : rebase_source : 96d93215f9d79e376df25108d0f4d82a178bda28
2017-08-23 10:16:56 -05:00
Tristan Bourvon
2e77c99160
Bug 1374024 - add checker to prevent dangling pointers returned by method calls on temporaries. r=mystor
...
MozReview-Commit-ID: 9khNt59ONF
2017-07-05 16:14:21 +02:00
Cykesiopka
ec8581113b
Bug 1355692 - Add MOZ_FALLTHROUGH macro definition for gcc 7 to suppress -Wimplicit-fallthrough warnings. r=glandium
...
The generic fallback MOZ_FALLTHROUGH definition is insufficient for GCC 7 and
above, resulting in --enable-warnings-as-errors builds failing.
The check for clang support is changed to use the __has_cpp_attribute macro,
which is more robust than checking the __cplusplus version.
Also, MOZ_FALLTHROUGH is now only defined in C++ code, since GCC errors out if
it encounters a scoped attribute being used with __has_cpp_attribute in C code.
No C code uses MOZ_FALLTHROUGH or derivatives at the moment.
MozReview-Commit-ID: 4nKFBRD5jSF
--HG--
extra : rebase_source : 0c37ae39c806ca24a3271d3ec19531dd16e05daf
2017-07-28 00:11:28 +08:00
Carsten "Tomcat" Book
6f930b42b1
Backed out changeset 1a0693cc418b (bug 1374024) for bustage
2017-07-13 15:14:51 +02:00
Tristan Bourvon
473b245885
Bug 1374024 - add checker to prevent dangling pointers returned by method calls on temporaries. r=mystor
...
MozReview-Commit-ID: 9khNt59ONFE
2017-07-05 16:14:21 +02:00
Carsten "Tomcat" Book
2332473008
Backed out changeset 1a49d403a9a4 (bug 1374024) for bustage
2017-07-13 11:10:31 +02:00
Tristan Bourvon
20068f7ba3
Bug 1374024 - add checker to prevent dangling pointers returned by method calls
...
on temporaries. r=mystor
MozReview-Commit-ID: 9khNt59ONFE
2017-07-05 16:14:21 +02:00