Jon Coppeard
7cf55278e0
Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8
...
So that we can update the holders table correctly we will need to remove the wrapper from its original vector and add it to the one associated with the new zone.
I tried to make SetPreservingWrapper private but there's still a use in layout/style/Rule.cpp that I couldn't see an obvious fix for.
Differential Revision: https://phabricator.services.mozilla.com/D68521
2020-04-20 17:08:14 +00:00
Andrew McCreight
ca427d70af
Bug 1425450 - Pass zone information through when preserving wrappers r=mccr8
...
This is bascially the same as your original patch.
Differential Revision: https://phabricator.services.mozilla.com/D68520
2020-04-20 17:07:58 +00:00
Bogdan Tara
eddea671e7
Backed out 6 changesets (bug 1425450) for hazard failure complaining about nsWrapperCacheInlines CLOSED TREE
...
Backed out changeset c57ac2e125e8 (bug 1425450)
Backed out changeset 4238c59af7bb (bug 1425450)
Backed out changeset 2a00272e72ba (bug 1425450)
Backed out changeset 3e4a52d596bb (bug 1425450)
Backed out changeset 5da68de67491 (bug 1425450)
Backed out changeset efac091a3ba4 (bug 1425450)
2020-04-06 21:22:51 +03:00
Jon Coppeard
eff4a09dd5
Bug 1425450 - Ensure that we call Drop/HoldJSObjects when a preserved wrapper is changed for one in a different zone r=mccr8
...
So that we can update the holders table correctly we will need to remove the wrapper from its original vector and add it to the one associated with the new zone.
I tried to make SetPreservingWrapper private but there's still a use in layout/style/Rule.cpp that I couldn't see an obvious fix for.
Differential Revision: https://phabricator.services.mozilla.com/D68521
--HG--
extra : moz-landing-system : lando
2020-04-06 16:13:51 +00:00
Andrew McCreight
081d4ec773
Bug 1425450 - Pass zone information through when preserving wrappers r=mccr8
...
This is bascially the same as your original patch.
Differential Revision: https://phabricator.services.mozilla.com/D68520
--HG--
extra : moz-landing-system : lando
2020-04-06 16:13:17 +00:00
Andrew McCreight
4babb2b5ab
Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
...
Patch by bhackett and jlaster. Also reviewed by mccr8.
Differential Revision: https://phabricator.services.mozilla.com/D60197
--HG--
extra : moz-landing-system : lando
2020-02-27 17:39:15 +00:00
Ciure Andrei
00dd87f6f4
Backed out changeset d407a28318e6 (bug 1609815) for causing windows ming bustages CLOSED TREE
...
--HG--
extra : histedit_source : b2c748e31e0f6ba8fcf9960a336e0bbd361b07e6
2020-02-27 07:05:19 +02:00
Andrew McCreight
b197e1f783
Bug 1609815 - Remove Web Replay C++ implementation. r=jgilbert,jandem,gbrown
...
Patch by bhackett and jlaster. Also reviewed by mccr8.
Differential Revision: https://phabricator.services.mozilla.com/D60197
--HG--
extra : moz-landing-system : lando
2020-02-27 04:43:48 +00:00
Brian Hackett
091f2992d2
Bug 1573938 - Never collect wrapper JSObjects when recording/replaying, r=mccr8.
...
Differential Revision: https://phabricator.services.mozilla.com/D42011
--HG--
extra : moz-landing-system : lando
2019-08-16 20:51:12 +00:00
Emilio Cobos Álvarez
8d47bdf9ba
Bug 1566684 - Make sure to unlink rule declarations before unlinking css::Rule. r=smaug,emilio
...
Rules and their declarations are a single object as far as the CC is concerned. They have a single nsCycleCollectionISupports and they are represented by a single node in the CC graph. That single object has two nsWrapperCache instances in it that point to different JS objects, and we need to make sure that the ordering of the unlink operations for those nsWrapperCache instances is handled correctly.
Differential Revision: https://phabricator.services.mozilla.com/D38326
--HG--
extra : moz-landing-system : lando
2019-07-22 18:33:29 +00:00
Ryan Hunt
00e98538aa
Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D21106
--HG--
extra : rebase_source : ea3f51c2c11247114deccbc86e90fb02b8a97257
2019-02-25 16:05:29 -06:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Brian Hackett
52b33afe4e
Bug 1207696 Part 7 - Ensure deterministic interaction of GC with CC and object references, r=smaug.
...
--HG--
extra : rebase_source : 5d9e7ebd1dc242ca648193ed1f27ae91d19006de
2018-07-23 14:46:37 +00:00
Peter Van der Beken
0a2e4b8cb7
Bug 1146316 - Remove nsWrapperCache::SetIsNotDOMBinding and IsDOMBinding(). r=bz.
...
--HG--
extra : rebase_source : cd36e7afb4f6ebcd042ea40d9403546a683375ad
2018-04-05 17:22:41 +02:00
Chris Peterson
37efe4d0e6
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
...
MozReview-Commit-ID: DCPTnyBooIe
--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
Jon Coppeard
eb728b65cf
Bug 1414279 - Expose wrappers when they are preserved r=smaug a=dveditz
2017-11-07 11:46:31 +00:00
Boris Zbarsky
bd29adfa95
Bug 1189822 part 5. Remove the now-unnecessary DOMProxyHandler::ClearExternalRefsForWrapperRelease function. r=peterv
...
All DOMProxyHandler::ClearExternalRefsForWrapperRelease now does is clear a backpointer to the expando, and that's handled during reflector finalization already.
2017-05-17 00:52:53 -04:00
Bill McCloskey
34a4f034bb
Bug 1359245 - Remove references to context from the cycle collector (r=mccr8)
...
MozReview-Commit-ID: 1QoNEiZMvBf
2017-04-27 15:34:46 -07:00
Olli Pettay
8aa472a93c
Bug 1326507, trace after traverse, r=mccr8
...
--HG--
extra : rebase_source : 496a186306372567fb917c2d21488fe5a87c5f75
2017-01-03 21:46:49 +02:00
Andrew McCreight
5b9c57b7a2
Bug 1301301, part 1 - Unify NoteJSObject and NoteJSScript into NoteJSChild. r=smaug
...
This will let my next patch pass in other GC things.
This should not change behavior in any important way.
MozReview-Commit-ID: FykviKKvQzI
2016-09-23 15:42:13 -07:00
Boris Zbarsky
5afc8a9e03
Bug 1294747. Make sure we expose the expando of a [OverrideBuiltins] proxy to active JS when it gets cleared from the proxy. r=peterv
...
This should also fix bug 1296775 and bug 1290359.
There's a very good chance it will also fix bug 1293386, bug 1292855, bug
1289452, and bug 1303340: those would get hit if we happened to start _another_
gc after the expando died but while it was still in the Rooted. All of them
seem to be dying under the domClass->mGetProto call, which could finish up a GC
that kills the expando and then do _another_ one, causing the Rooted to try to
mark a dead object.
2016-09-15 15:04:56 -04:00
Jan de Mooij
a53986bf29
Bug 1302448 part 1 - Rename CycleCollectedJSRuntime to CycleCollectedJSContext. r=mccr8
...
--HG--
rename : xpcom/base/CycleCollectedJSRuntime.cpp => xpcom/base/CycleCollectedJSContext.cpp
rename : xpcom/base/CycleCollectedJSRuntime.h => xpcom/base/CycleCollectedJSContext.h
extra : rebase_source : 075214b5057f151520926715b6154e99ae80a0b3
2016-09-14 15:47:32 +02:00
Olli Pettay
5ca565690e
Bug 1120016 - Allocate short lived JS wrappers in the Nursery, r=mccr8,terrence
2015-12-31 15:21:49 +02:00
Wes Kocher
792ca14825
Backed out changeset 0d55a6e4e98e (bug 1120016) for 980 b2g hazards
...
--HG--
extra : commitid : 27OIHVsa17S
2015-12-30 16:34:18 -08:00
Olli Pettay
2066f6d7b3
Bug 1120016 - Allocate short lived JS wrappers in the Nursery, r=mccr8,terrence
...
--HG--
extra : rebase_source : 3d51b7fc9962a93eb6071328db84b5b327225246
2015-12-30 19:16:13 +02:00
Ryan VanderMeulen
fb6b2747d5
Bug 1180017 - Fix up the badly-horked backout and re-land.
...
CLOSED TREE
--HG--
extra : amend_source : 0b7ac18429b248cf05cfe33f6b2f6efdf1602c38
extra : histedit_source : bdb11dafa100809ec17491e5711fb0b507e023c6%2C5e4134650a804859dc8b3078688fa4655052263f
2015-07-29 12:31:47 -04:00
Jim Blandy
4e8fc0bdcb
Bug 1180017 - Give GCCellPtr is<T> and to<T> methods, replacing isFoo and toFoo methods. Fix callers. r=terrence
2015-07-03 15:06:23 -07:00
Carsten "Tomcat" Book
25a2a75a56
Backed out changeset 465793bc6fcf (bug 1180017) for suspicion of causing bug 1188799
2015-07-29 15:27:12 +02:00
Jim Blandy
ff7cc06ef6
Bug 1180017: Give GCCellPtr is<T> and as<T> methods, replacing isFoo and toFoo methods. Fix callers. r=terrence
...
--HG--
extra : rebase_source : 4a381c5d8427ad2995426e65c69af1597b1557c2
2015-07-07 09:52:01 -07:00
Jeff Gilbert
9afb8379f2
Bug 1182369
- Remove js/Class.h include from nsWrapperCache.h. - r=bz
2015-07-09 12:32:04 -07:00
Tom Schuster
fcb11bbe71
Bug 1131003 - Move jsproxy.h to js/Proxy.h. r=efaust
...
--HG--
rename : js/src/jsproxy.h => js/public/Proxy.h
2015-02-10 19:58:18 +01:00
Terrence Cole
e4a4d0c7fa
Bug 1105069 - Part 14: Convert NoteJSChild to GCCellPtr; r=mccr8, r=jonco
...
--HG--
extra : rebase_source : 2338e0a57779401f9bc4744bc2fa59a4b31d76bf
2014-12-05 09:38:34 -08:00
Ehsan Akhgari
0653303071
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
...
--HG--
extra : rebase_source : 01709017e97fdc96d1d53eb881efc1792118edc4
2014-09-01 20:49:25 -04:00
Phil Ringnalda
117bb1a341
Backed out 6 changesets (bug 1060982
, bug 1061058, bug 1060987, bug 1061060, bug 1060930) for build bustage
...
CLOSED TREE
Backed out changeset c23b8418e6be (bug 1060987)
Backed out changeset a8cddc6bdffc (bug 1061060)
Backed out changeset b5af5cbdac3f (bug 1060982
)
Backed out changeset 4912d451011a (bug 1060930)
Backed out changeset bdacbf453238 (bug 1061058)
Backed out changeset da6c71a8f5ae (bug 1060987)
2014-09-01 16:48:51 -07:00
Ehsan Akhgari
6c932dea6c
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
2014-09-01 18:00:53 -04:00
Olli Pettay
b1b4cf61fc
Bug 937303 - Make CC logger to pass information about compartments, r=mccr8
2013-11-12 15:53:51 +02:00
Andrew McCreight
3047b2a24e
Bug 912747 - Change nsCycleCollectionHoldDrop.h to mozilla/HoldDropJSObjects.h. r=khuey
...
--HG--
rename : xpcom/glue/nsCycleCollectionHoldDrop.h => xpcom/glue/HoldDropJSObjects.h
2013-09-10 08:29:43 -07:00
Andrew McCreight
01af9297c7
Bug 883920 - use templates for {Hold,Drop}JSObjects. r=peterv
2013-08-16 13:10:17 -07:00
Ms2ger
5dcc1ed0f0
Bug 886408 - Move nsContentUtils::ReleaseWrapper into nsWrapperCache; r=mccr8
2013-08-02 09:04:01 +02:00
Ms2ger
b7bef21f7f
Bug 884268 - Part b: Move nsContentUtils::PreserveWrapper to nsWrapperCache; r=smaug
2013-06-23 09:15:42 +02:00
Ms2ger
4842331722
Bug 884268 - Part a: Move nsContentUtils::CheckCCWrapperTraversal to nsWrapperCache; r=smaug
2013-06-23 09:15:10 +02:00