Simon Giesecke
b13b4d3deb
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 09:40:12 +00:00
Simon Giesecke
c49d17f0db
Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 09:39:24 +00:00
Cosmin Sabou
a40ede8ab7
Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE
...
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
2020-07-03 11:49:58 +03:00
Simon Giesecke
4c5ca225c9
Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth
...
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).
Differential Revision: https://phabricator.services.mozilla.com/D82018
2020-07-03 08:08:27 +00:00
Simon Giesecke
b14f5d4a12
Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82016
2020-07-03 08:08:05 +00:00
Simon Giesecke
85c8c0062e
Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D81078
2020-07-01 20:14:23 +00:00
Andrea Marchesini
5def6bbc8c
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 11:02:53 +00:00
Razvan Maries
f7cb24cc7e
Backed out 8 changesets (bug 1648141
) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE
...
Backed out changeset e9b4ca0ee700 (bug 1648141
)
Backed out changeset b9bb847cee47 (bug 1648141
)
Backed out changeset 11dfce46ec14 (bug 1648141
)
Backed out changeset d824d2f67f27 (bug 1648141
)
Backed out changeset e5b8292e7095 (bug 1648141
)
Backed out changeset c1a3d5fa0c61 (bug 1648141
)
Backed out changeset 24fdb83db3cd (bug 1648141
)
Backed out changeset 749d894dde52 (bug 1648141
)
2020-06-29 13:59:16 +03:00
Andrea Marchesini
82d0167e5e
Bug 1648141
- IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D80924
2020-06-29 10:25:08 +00:00
Jean-Yves Avenard
87438519f0
Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
...
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.
This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget
Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Jean-Yves Avenard
ea34205395
Bug 1646054 - P1. Remove EventTargetWrapper class. r=froydnj
...
We also establish the intent of bug 1602167 on the TaskQueue object
Differential Revision: https://phabricator.services.mozilla.com/D80351
2020-06-22 13:55:21 +00:00
Simon Giesecke
d11275bd72
Bug 1632128 - Dissolve FileHandleResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D75053
2020-05-14 09:42:33 +00:00
Simon Giesecke
4fc4c0a9d9
Bug 1632128 - Dissolve ResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74890
2020-05-14 09:42:23 +00:00
Simon Giesecke
9ee13d3ec4
Bug 1632128 - De-virtualize IDBFileRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74875
2020-05-14 09:42:21 +00:00
Simon Giesecke
5f4d07aff0
Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74874
2020-05-14 09:42:18 +00:00
Simon Giesecke
ae0940c00a
Bug 1632128 - Use mozilla::Variant for FileHandleResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D74870
2020-05-14 09:42:16 +00:00
Simon Giesecke
7a8f68d96f
Bug 1632128 - Use mozilla::Variant for ResultHelper. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71936
2020-05-14 09:42:13 +00:00
Simon Giesecke
a892bc01f6
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
078debe589
Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
...
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
98b9d42815
Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
ssengupta
cf852bbfb9
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
Andrew Sutherland
06937e8b14
Bug 1631970 - Delay converting uint64 results to JSVals. r=sg
...
The rooting hazard analysis is getting upset because of the usage where
a non-GCThing JSVal is declared on the stack and AcquireTransaction() is
called. The analysis doesn't know that it's guaranteed that the value is
NaN-boxed and can't be a GC thing. It also doesn't know that the SafeRefPtr
can't already have a value so a release is impossible.
Arguably the hazard analysis doesn't need to know these things though.
This fix delays the point at which we convert the uint64 into a JS::Value.
The [call to GetResult](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/dom/indexedDB/IDBRequest.cpp#300 )
already has a rooted result and the (Auto)JSAPI initialized, so this is
arguably cleaner and less scary in terms of holding raw pointers in the
ResultHelper that aren't necessary.
This fix doesn't correct the ResultTypeJSValHandle which is a similar
situation, except it's a reference to
[UndefinedHandleValue](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/js/src/vm/Value.cpp#23 )
which is I suppose more fine from a GC perspective. Still somewhat ugly
as used in ResultHelper, but I'm presuming we'll clean ResultHelper up
in the future to use a Variant, at which point we can explicitly indicate
we want `undefined`.
Differential Revision: https://phabricator.services.mozilla.com/D74800
2020-05-12 10:39:00 +00:00
Simon Giesecke
6d8be8c785
Bug 1623278 - Make transaction actors refcounted. r=dom-workers-and-storage-reviewers,nika,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D71933
2020-05-06 12:20:32 +00:00
Simon Giesecke
ecfe1e0e4d
Bug 1618542 - Add use of new transformation algorithms in ActorsChild. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D69044
2020-04-21 14:35:03 +00:00
Simon Giesecke
18c7f261c4
Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D67287
2020-04-21 14:32:51 +00:00
Simon Giesecke
da859a31b2
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:43 +00:00
Simon Giesecke
02753c9665
Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D65710
--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:39 +00:00
André Bargull
14ca007916
Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj
...
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.
Differential Revision: https://phabricator.services.mozilla.com/D68561
--HG--
extra : moz-landing-system : lando
2020-03-28 16:00:09 +00:00
André Bargull
73a498ec0c
Bug 1625138 - Part 38: Replace mozilla::IsSame with std::is_same in dom/. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D68557
--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:21 +00:00
André Bargull
cae4e1fdbc
Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert
...
Differential Revision: https://phabricator.services.mozilla.com/D68401
--HG--
extra : moz-landing-system : lando
2020-03-28 13:35:31 +00:00
Simon Giesecke
393a8cb4a2
Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65167
--HG--
extra : moz-landing-system : lando
2020-03-19 11:35:03 +00:00
Mihai Alexandru Michis
2922453b6e
Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages.
...
CLOSED TREE
Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
2020-03-19 13:30:26 +02:00
Simon Giesecke
59bc885b82
Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D65710
--HG--
extra : moz-landing-system : lando
2020-03-19 09:34:40 +00:00
Simon Giesecke
f4b6d69804
Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D65167
--HG--
extra : moz-landing-system : lando
2020-03-19 09:57:27 +00:00
Simon Giesecke
ad3730c81e
Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
...
Based on a patch supplied by janv@mozilla.com
Differential Revision: https://phabricator.services.mozilla.com/D67129
--HG--
extra : moz-landing-system : lando
2020-03-17 11:28:49 +00:00
Simon Giesecke
f28bafa279
Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D64131
--HG--
extra : moz-landing-system : lando
2020-03-11 17:30:33 +00:00
Simon Giesecke
1fabf7b51c
Bug 1617170 - Encapsulate StructuredCloneReadInfo members. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D64078
--HG--
extra : moz-landing-system : lando
2020-03-11 17:20:05 +00:00
Simon Giesecke
2c98fa92a7
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-07 09:31:48 +00:00
Andreea Pavel
110347c99a
Backed out 8 changesets (bug 1617170) for build bustages at nsTArray.h on a CLOSED TREE
...
Backed out changeset ed7eaba53757 (bug 1617170)
Backed out changeset 0021ab4bcf77 (bug 1617170)
Backed out changeset 92f4ef8809ec (bug 1617170)
Backed out changeset c9561cb90821 (bug 1617170)
Backed out changeset 739dafac70bc (bug 1617170)
Backed out changeset 51c699b06d04 (bug 1617170)
Backed out changeset 2ae6b424f492 (bug 1617170)
Backed out changeset 6acafdd56175 (bug 1617170)
2020-03-06 17:57:23 +02:00
Simon Giesecke
63db82d1eb
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-06 15:34:18 +00:00
shindli
ff75fdf21a
Backed out 5 changesets (bug 1617170) for toolchains bustages CLOSED TREE
...
Backed out changeset cc2aadaf5923 (bug 1617170)
Backed out changeset bda38a16aac3 (bug 1617170)
Backed out changeset 5d3ed69aca66 (bug 1617170)
Backed out changeset 90dfe1253fe4 (bug 1617170)
Backed out changeset f1a4f3952931 (bug 1617170)
2020-03-06 14:55:58 +02:00
Simon Giesecke
517784f1bc
Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D63681
--HG--
extra : moz-landing-system : lando
2020-03-06 12:30:35 +00:00
Simon Giesecke
efe737d7c3
Bug 1613340 - Remove const_cast relating to CursorResponse. r=jld,dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61672
--HG--
extra : moz-landing-system : lando
2020-03-03 13:51:18 +00:00
Simon Giesecke
20603da0aa
Bug 1613340 - Remove const_cast relating to SerializedStructuredCloneReadInfo. r=jld,dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61671
--HG--
extra : moz-landing-system : lando
2020-03-03 13:50:48 +00:00
Simon Giesecke
a27fa59c89
Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
...
Differential Revision: https://phabricator.services.mozilla.com/D61670
--HG--
extra : moz-landing-system : lando
2020-03-03 13:45:26 +00:00
Simon Giesecke
e4bf6784c3
Bug 1613854 - Avoid copying non-trivial IPDL params. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D62023
--HG--
extra : moz-landing-system : lando
2020-02-18 16:37:49 +00:00
Simon Giesecke
e26d6083c0
Bug 1613854 - Pass nsresult/bool/int* by value instead of const &. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D61992
--HG--
extra : moz-landing-system : lando
2020-02-27 12:17:47 +00:00
Eric Rahm
124379887c
Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
...
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.
Differential Revision: https://phabricator.services.mozilla.com/D63745
--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
David Major
c4e3b2d209
Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
...
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.
Differential Revision: https://phabricator.services.mozilla.com/D62327
--HG--
extra : moz-landing-system : lando
2020-02-10 20:52:56 +00:00
Boris Zbarsky
c9e8a8042b
Bug 1611509 part 3. Remove the Date type from Web IDL. r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D61054
--HG--
extra : moz-landing-system : lando
2020-01-27 08:50:35 +00:00