We occasionally get reports of UI unresponsiveness immediately following the
download phase of the stub installer. The longest operation that runs on the
main thread during this phase is validating the code signature of the full
installer. This patch moves that work (which is done in a native NSIS plugin)
to a separate thread. Hopefully this helps resolve the hangs.
I've also converted the build files for the plugin from Visual C++ 6 to 2017,
just to avoid the inconvenience of needing to pull up VC6 to build it.
MozReview-Commit-ID: CKje2a8M62i
--HG--
extra : rebase_source : ec9a11268eed3c4f9e0783532b0e910289e809f9
I'm also adding a "StartMenuShortcut" option as an alias for "StartMenuShortcuts",
because I could not stop leaving off the 's' while testing this patch, so I
figure I'm not the only one making that mistake and getting frustrated.
MozReview-Commit-ID: Fdsc6CTBJr4
--HG--
extra : rebase_source : c57295e0936b6721bc75d6f11f33bad6691b96de
This fixes a bug which the main bug 986081 patch exposes because it tries to
cancel a download in InetBgDl and then show a dialog box immediately afterward.
Without this patch, doing that very early on in the request (meaning before any
redirect is fully handled) would result in a 10 second UI hang.
MozReview-Commit-ID: 1zBxZrllFC
--HG--
extra : rebase_source : 523b2b37035a7fc6f435acd1f7437fbbbcf2adc6
Bug 1361326 required rebuilding the 7-zip self-extractor executable, which is
stored in binary form in the tree. I accidentally built that binary with all
compiler optimizations disabled. This binary is built from identical code as
the one from bug 1361326, the only difference is this one was built with /O2
instead of /Od.
MozReview-Commit-ID: L07EXZoQEa7
--HG--
extra : rebase_source : 9c3a28ba61827c15a49a7b6bd1f184b725b4ff0d
Add the new-to-ATK relation types to the ATK headers we maintain and
map those relation types to the internal equivalents. No new tests
because we have sufficient coverage for the internal relations and
currently lack a means to test platform accessibility API exposure.
Previously each new installation of any Firefox channel in any location would
just overwrite the Windows registry keys which register us as a candidate for
the default browser setting and for all of our potential file and protocol associations.
This meant that only the most recent installation (across all channels) was ever
selectable in those settings.
It also meant that creating a new installation when one was already present
tripped Windows 10's shenanigans alarm, because it saw the registration for an
existing application getting clobbered by a new one and couldn't tell that they
were really the same application.
The response to that alarm going off is to reset the default browser to Edge,
and maybe or maybe not generate a system notification about that. This is the
cause of bug 1324617. Obviously we would like to prevent that outcome.
So with this commit we generate new registration entries for each installation,
by adding a hash of the install path to the relevant identifiers.
MozReview-Commit-ID: Fz1xDtittMi
--HG--
extra : rebase_source : e0bc19e4abc1b32133f56458daf625527ce188b0
Previously each new installation of any Firefox channel in any location would
just overwrite the Windows registry keys which register us as a candidate for
the default browser setting and for all of our potential file and protocol associations.
This meant that only the most recent installation (across all channels) was ever
selectable in those settings.
It also meant that creating a new installation when one was already present
tripped Windows 10's shenanigans alarm, because it saw the registration for an
existing application getting clobbered by a new one and couldn't tell that they
were really the same application.
The response to that alarm going off is to reset the default browser to Edge,
and maybe or maybe not generate a system notification about that. This is the
cause of bug 1324617. Obviously we would like to prevent that outcome.
So with this commit we generate new registration entries for each installation,
by adding a hash of the install path to the relevant identifiers.
MozReview-Commit-ID: Fz1xDtittMi
--HG--
extra : rebase_source : 3b3523c108502aebd08fd4912c3ab50baf3c0359
Ciure Andrei
Matt Howell
Samuel Thibault
Sylvestre Ledru
Tom Ritter
Adam Gashlin
Csoregi Natalia
Narcis Beleuzu
Andreea Pavel
Chris Manchester
James Willcox
Joanmarie Diggs
Lee Salzman
Carsten "Tomcat" Book
Wes Kocher
Joel Maher
Sebastian Hengst
Robert Strong
Aaron Klotz
Alexander Surkov
Jan Varga