d835eb1793
Bug 1727925 - Part 3: Migrate six more windows10-32 test suites from AWS to Azure r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D124192
2021-09-10 11:51:00 +00:00
5f03e76d19
Bug 1308103 - Replace PL_strcmp/PL_strncmp with strcmp/strncmp in extensions/pref/autoconfig r=mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D123880
2021-09-09 19:36:11 +00:00
4ca3a60f1d
Bug 1714200: annotate tests that fail in regular suites but pass when run in isolation. r=jmaher DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D124907
2021-09-08 18:14:00 +00:00
11bfa90d06
Bug 1602940 - Automated replacements to use Services.uuid. r=Gijs,necko-reviewers,preferences-reviewers,kershaw
...
Depends on D124391
Differential Revision: https://phabricator.services.mozilla.com/D124392
2021-09-06 09:53:52 +00:00
5397b4f0a9
Bug 1727491 - Remove support for BOMless unlabeled Latin1 Supplement-range UTF-16LE|BE. r=emk
...
Differential Revision: https://phabricator.services.mozilla.com/D123596
2021-09-01 09:13:29 +00:00
44fd3a7047
Bug 1726532 - part 2: Make `mozSpellChecker::SetupDoc()` treat succeeded state as error if valid offset/length are not available when they are required r=m_kato
...
`TextServicesDocument::LastSelectedBlock()` may return `NS_OK` with
`UINT32_MAX` for both offset and length of the block. The assertions causes
the new test not runnable in debug build. So, we should make the situation
as an error case if they are required.
Ideally, we should fix the odd behavior, but it's not safe for uplift.
Therefore, this patch just adds the wallpapers.
Depends on D123282
Differential Revision: https://phabricator.services.mozilla.com/D123283
2021-08-24 03:29:21 +00:00
922488424d
Bug 1726532 - part 1: Make `OffsetEntryArray::WillSetSelection()` use offset in text node when it sets a DOM node point r=m_kato
...
This is a mistake at replacing the argument value `aOffset` to
`aOffsetInTextInBlock`.
https://searchfox.org/mozilla-central/diff/886c96059ef6408618040356017028621bc574b9/editor/spellchecker/TextServicesDocument.cpp#1662
And also make `mozSpellChecker::Replace()` stop replacing if
`TextServicesDocument` fails to set selection or insert text because if
`TextServicesDocument` succeeded to insert text, but failed to delete text,
the loop becomes an infinite loop.
Differential Revision: https://phabricator.services.mozilla.com/D123282
2021-08-24 03:29:21 +00:00
75ed803f7c
Bug 1725145 - fixes for linking in the hybrid build env. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D122344
2021-08-22 10:21:56 +00:00
250fa0d795
Bug 1725145 - header files fixes in the hybrid build env. r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D122343
2021-08-22 10:21:55 +00:00
a466d4aa0a
Bug 1687314 - Improve behavior of GetChannelResultStoragePrincipal and StoragePrincipalHelper::Create when handling NullPrincipal. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D122381
2021-08-17 12:51:22 +00:00
329f65c790
Bug 1725593 - Get rid of SendCheckAndSuggest sync IPC. r=masayuki,ipc-reviewers,mccr8
...
Depends on D122579
Differential Revision: https://phabricator.services.mozilla.com/D122580
2021-08-16 01:40:00 +00:00
3401597785
Bug 1725593 - Don't use SendCheckAndSuggest. r=masayuki
...
By bug 1719110, we replace sync IPC's spell checker suggestion with async
version. So we should remove this sync IPC call.
Differential Revision: https://phabricator.services.mozilla.com/D122579
2021-08-16 01:39:59 +00:00
0cfda7bb4a
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-08-12 12:39:25 +00:00
ae8827c0c3
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-08-12 12:39:23 +00:00
b3d74be7b8
Bug 1705659 - Make GetAuthenticator work with nsACString r=necko-reviewers,dragana
...
Depends on D112602
Differential Revision: https://phabricator.services.mozilla.com/D112597
2021-08-12 12:39:22 +00:00
0b4372e828
Bug 1721968 - Remove support for lucetc for rlbox. r=firefox-build-system-reviewers,shravanrn,mhentges
...
Differential Revision: https://phabricator.services.mozilla.com/D120700
2021-08-11 21:58:52 +00:00
49cc605308
Bug 1719110 - Don't use sync IPC to show suggestion by spellchecker. r=Gijs
...
CheckCurrentWord on content process causes sync IPC, so I would like to remove
this call on content process. New nsIEditorSpellChecker.suggest method can
avoid it.
Differential Revision: https://phabricator.services.mozilla.com/D119937
2021-08-10 03:55:25 +00:00
a6944a1428
Bug 1719110 - Add nsIEditorSpellCheck.suggest to get rid of PRemoteSpellcheckEngine.CheckAndSuggest. r=masayuki
...
When getting suggestions from spellchecker's result, we use sync IPC
(`PRemoteSpellcheckEngine.CheckAndSuggest`). This is used by showing context
menu only on Gecko. So I think that we can remove this IPC if we add async API
to get spellchecker suggestions.
And in comm-central's code, `CheckCurrentWord` and `GetSuggestedWord` seems to
use on spellchecker dialog (content/dialogs/EdSpellCheck.js in mail and suite)
that runs on parent process. So c-c won't use this IPC method.
So I would like to add the promise version of getting spellchecker's
suggestion.
Differential Revision: https://phabricator.services.mozilla.com/D119936
2021-08-10 03:55:25 +00:00
f6f5a3bca5
Bug 1721665 - Do not overwrite private browsing permission lifetime when removing permissions. r=timhuang,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D121749
2021-08-09 14:46:07 +00:00
e5b57b5d4c
Bug 1706292 - Do not clone principal for CookieJarSettings cookie permission check. r=timhuang,ckerschb
...
For every cookie permission check CookieJarSettings::CookiePermission has to create a new principal.
This is slow. It uses a cloned principal so it can strip the origin attributes which should not be
used for the permission check.
With this patch we no longer need to clone the principal. We pass in the original principal and perform
the OA stripping on an OA copy in BasePrincipal::EqualsForPermission.
Before, EqualsForPermission was guaranteed to get a content principal, because ClonePrincipalForPermission
enforced it. BasePrincipal::EqualsForPermission was refactored to account for non content principals.
Differential Revision: https://phabricator.services.mozilla.com/D120834
2021-07-30 15:01:07 +00:00
c638f51ce3
Bug 1718292 - Part 1: Disable failing xpcshell tests on Windows 10 2004 r=jmaher,necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D119633
2021-07-26 16:38:22 +00:00
e2a1db5178
Bug 1713735 - Add the bits necessary to build wasm sandbox libs with wasm2c. r=firefox-build-system-reviewers,mhentges
...
For the moment, it's opt-in via explicitly setting `LUCETC` to an empty
string.
Differential Revision: https://phabricator.services.mozilla.com/D119939
2021-07-16 02:38:41 +00:00
cc92ef732d
Bug 1708448 - Move property and element functions into js/public/PropertyAndElement.h. r=nbp
...
Differential Revision: https://phabricator.services.mozilla.com/D119619
2021-07-13 11:52:42 +00:00
1fc0882ecc
Bug 1718607 - Make `TextServicesDocument` use `uint32_t` for offset in DOM node r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D118955
2021-06-30 09:07:35 +00:00
744db845c6
Bug 1700534 - Coalesce RLBox wasmboxed libraries. r=firefox-build-system-reviewers,shravanrn,bholley,andi,mhentges
...
Differential Revision: https://phabricator.services.mozilla.com/D116440
2021-06-22 05:31:33 +00:00
c0624f4771
Bug 1713757 - Make `mozInlineSpellChecker`, `mozInlineSpellWordUtil` and `TextServicesDocument` use `EditorBase` instead of `TextEditor` r=m_kato
...
Depends on D117117
Differential Revision: https://phabricator.services.mozilla.com/D117118
2021-06-09 09:02:31 +00:00
1030b2a3e3
Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D116547
2021-06-08 17:45:26 +00:00
7240e461cc
Bug 1715123 - Remove unused method broadcastPermissionsForPrincipalToAllContentProcesses in PermissionManager r=timhuang,necko-reviewers,dragana
...
Depends on D116850
Differential Revision: https://phabricator.services.mozilla.com/D116852
2021-06-08 08:08:48 +00:00
9aee13c478
Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-06-07 17:57:24 +00:00
e8904db16a
Backed out 5 changesets (bug 1699480) for causing lint failures.
...
CLOSED TREE
Backed out changeset 5ed626994de6 (bug 1699480)
Backed out changeset e4be23f4dbe9 (bug 1699480)
Backed out changeset 68b5f5c2f1e6 (bug 1699480)
Backed out changeset 425aa354f1ca (bug 1699480)
Backed out changeset e3005001299c (bug 1699480)
2021-06-07 20:52:25 +03:00
648ddb2f54
Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-06-07 17:02:26 +00:00
aa5e042347
Bug 1682240 - Kill ntlm_auth process instead of waiting for it to complete r=necko-reviewers,kershaw
...
This avoids hangs when the process might be unresponsive.
Differential Revision: https://phabricator.services.mozilla.com/D116715
2021-06-07 07:15:37 +00:00
ca49f15f7d
Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) as requested by valentin for causing regressions. CLOSED TREE
...
Backed out changeset d920aa17a468 (bug 669675)
Backed out changeset adad38c05584 (bug 1705659)
Backed out changeset 361c177ed131 (bug 1705659)
Backed out changeset 46e559f45338 (bug 1705659)
Backed out changeset 3c9556a8df55 (bug 1705659)
Backed out changeset a179695a56c9 (bug 1705659)
Backed out changeset e688986c7011 (bug 1705659)
Backed out changeset de990e6c944d (bug 1705659)
Backed out changeset 0ea348abee78 (bug 1705659)
Backed out changeset 2f0aacbd42b1 (bug 1705659)
Backed out changeset c977551bad6e (bug 1705659)
Backed out changeset 5449d9e08034 (bug 1705659)
Backed out changeset b6b51bc167ac (bug 1705659)
Backed out changeset 27e709923ecb (bug 472823)
2021-05-31 13:16:34 +03:00
f271c866cf
Bug 1687263: part 4) Defer and in some cases avoid removing spellchecking-ranges. r=smaug
...
Removing ranges is expensive. This reduces flickering of the spelling
mistakes and prevents 100% CPU usage of 1 core on slower machines.
The essence of this patch is, that when text doesn't change, all
existing spellchecking ranges are reused.
Before this patch, removing ranges was done as part of the time slice in
`mozInlineSpellChecker::SpellCheckSlice`. That is, slow removals of
ranges contributed to the amount of words to be spellchecked
asynchronously.
Therefore, the amount of words to be spellchecked in one chunk could
increase from the minimum, `INLINESPELL_MINIMUM_WORDS_BEFORE_TIMEOUT` to
the maxium `INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK`.
Consequently, the asynchronous checking might take longer. If that turns
out to be problematic, reducing
`INLINESPELL_MAXIMUM_CHUNKED_WORDS_PER_TASK` could be a fix.
Differential Revision: https://phabricator.services.mozilla.com/D116096
2021-05-28 07:56:13 +00:00
81d2b2a2d9
Bug 1687263: part 3) Move removing ranges into `CheckWordsAndUpdateRangesForMisspellings`. r=smaug
...
This might lead to increased exceeding of the time slice, because the
ranges are removed after the time limit was checked. Therefore, this
change should only be landed together with the following review which
will remove unnecessary remove- and add-operations for ranges. It's a
separate review only to simplify reviewing and potential debugging.
Differential Revision: https://phabricator.services.mozilla.com/D116095
2021-05-28 07:56:13 +00:00
80b835b192
Bug 1687263: part 2) Add `NodeOffsetRange::operator==(const nsRange& aRange)`. r=smaug
...
The fix of bug 1687263 will require determining which `nsRange`s of a
previous time slice to keep and for which `NodeOffsetRange`s to create
new `nsRange`s. The operator will be used in a following review.
Differential Revision: https://phabricator.services.mozilla.com/D116094
2021-05-28 07:56:12 +00:00
ed9c8cebed
Bug 1687263: part 1) Add `NodeOffset::operator==(const RangeBoundary)`. r=smaug
...
Required for the following review.
Differential Revision: https://phabricator.services.mozilla.com/D116093
2021-05-28 07:56:12 +00:00
59984954da
Bug 1708422: part 21) Reduce scope of `erv` variable in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115687
2021-05-26 10:04:36 +00:00
0694578bb0
Bug 1708422: part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Clearer.
Differential Revision: https://phabricator.services.mozilla.com/D115686
2021-05-26 10:04:36 +00:00
93ac6f9a56
Bug 1708422: part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug
...
Clearer and helps to simplify its caller.
Differential Revision: https://phabricator.services.mozilla.com/D115597
2021-05-26 10:04:35 +00:00
69c6a23516
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-26 09:27:21 +00:00
16a4c26f4c
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-26 09:27:20 +00:00
1fb3a73493
Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
...
Depends on D112597
Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-26 09:27:19 +00:00
40b6793a72
Bug 1700051: part 45) Remove outdated part of comment in <mozInlineSpellChecker.cpp>. r=smaug
...
Depends on D113300
Differential Revision: https://phabricator.services.mozilla.com/D113301
2021-05-25 10:08:15 +00:00
ae69b73075
Bug 1540037 - part 18: Move `ReplaceTextAsAction()` and `ReplaceSelectionAsSubAction()` to `EditorBase` r=m_kato
...
They are used by setting text value of `TextEditor` or replacing a misspelled
word with a new word in both `TextEditor` and `HTMLEditor`. Therefore,
they should be in the `EditorBase` rather than `TextEditor`.
Note that the path of the former case may be in a hot path. Therefore, we need
to keep redirecting to `TextEditor` for keeping the performance only in the
case.
Depends on D115785
Differential Revision: https://phabricator.services.mozilla.com/D115786
2021-05-25 04:26:14 +00:00
55db5ff457
Bug 1708422: part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug
...
Hides details.
Differential Revision: https://phabricator.services.mozilla.com/D115469
2021-05-20 13:00:01 +00:00
e74f6c42f1
Bug 1708422: part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115366
2021-05-20 09:03:30 +00:00
b05af40fa3
Bug 1708422: part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115352
2021-05-20 09:03:30 +00:00
e5983d6bde
Bug 1708422: part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114333
2021-05-20 09:03:29 +00:00
c080bbd4cc
Bug 1708422: part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114332
2021-05-20 09:03:28 +00:00
Michelle Goossens
Nicklas Boman
Ben Hearsum
Mark Banner
Henri Sivonen
Masayuki Nakano
Andi-Bogdan Postelnicu
Paul Zuehlcke
Makoto Kato
Valentin Gosu
Mike Hommey
Tooru Fujisawa
Deian Stefan
Julian Descottes
Dylan Roeh
Alexandru Michis
Brindusan Cristian
Mirko Brodesser