mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
700 513 коммитов 615 Ветки 98 Теги 5,7 GiB
Граф коммитов

186 Коммитов

Автор SHA1 Сообщение Дата
Kristen Wright 05a7022978 Bug 1626388 - Convert dom.select_events.textcontrols.enabled to static pref r=njn 
Converts dom.select_events.textcontrols.enabled to a static pref.

Differential Revision: https://phabricator.services.mozilla.com/D69614

--HG--
extra : moz-landing-system : lando
 2020-04-06 23:30:18 +00:00
Mirko Brodesser e5aee55330 Bug 1626665: part 4) Reorder code in `nsFrameSelection::MoveCaret` to allow `nsPeekOffsetStruct::mDirection` to become `const`. r=hsivonen 
`nsPeekOffsetStruct` contains a mixture or input and output members.
This simplifies reasoning about them.

Depends on D69573

Differential Revision: https://phabricator.services.mozilla.com/D69769

--HG--
extra : moz-landing-system : lando
 2020-04-06 08:45:01 +00:00
Mirko Brodesser e7cdb1cf10 Bug 1623858: part 16) Annotate `nsFrameSelection::HandleTableSelection` with `[[nodiscard]]`. r=hsivonen 
Depends on D68575

Differential Revision: https://phabricator.services.mozilla.com/D68576

--HG--
extra : moz-landing-system : lando
 2020-03-30 08:35:36 +00:00
Mirko Brodesser 4c2e63fddc Bug 1623858: part 15) Remove some conditions in `nsFrameSelection::TakeFocus` which are always true. r=hsivonen 
Differential Revision: https://phabricator.services.mozilla.com/D68575

--HG--
extra : moz-landing-system : lando
 2020-03-30 08:32:42 +00:00
Mirko Brodesser 803698911f Bug 1624633: part 1) Move `Selection::mRanges` to `StyledRanges` struct. r=hsivonen 
This allows methods operating on the ranges to be moved to that struct.

To see where this leads to, consider the following reviews.

Differential Revision: https://phabricator.services.mozilla.com/D68217

--HG--
extra : moz-landing-system : lando
 2020-03-27 11:21:25 +00:00
Mirko Brodesser ad4d7454de Bug 1622752: annotate `Selection::ScrollIntoView` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D67002

--HG--
extra : moz-landing-system : lando
 2020-03-16 21:04:46 +00:00
Emilio Cobos Álvarez 04828e3a4a Bug 253870 - Make disabled form controls selectable. r=masayuki,MarcoZ 
This rejiggers a bit the way selection focus is handled so that focusing a
disabled form control with the mouse handles selection properly, and hides the
document selection and so on.

This matches the behavior of other browsers as far as I can tell.

Given now readonly and disabled editors behave the same, we can simplify a bit
the surrounding editor code.

Differential Revision: https://phabricator.services.mozilla.com/D66464

--HG--
extra : moz-landing-system : lando
 2020-03-19 13:18:16 +00:00
Mirko Brodesser c602e0e0d7 Bug 1623333: part 4) Assert Selection's type is `eNormal` in relevant methods accessing `mFrameSelection`. r=smaug 
Helps to determine which methods of `nsFrameSelection` are intended to
be called only for the `eNormal` Selection.

Driven by the idea that state of `nsFrameSelection` relevant only for
the `eNormal` Selection should later move to a `NormalSelection` class.

Differential Revision: https://phabricator.services.mozilla.com/D67445

--HG--
extra : moz-landing-system : lando
 2020-03-19 11:08:58 +00:00
Mirko Brodesser d252ed1175 Bug 1623333: part 2) Declare `Selection::mSelectionType` `const`. r=smaug 
Simplifies reasoning about it.

Differential Revision: https://phabricator.services.mozilla.com/D67328

--HG--
extra : moz-landing-system : lando
 2020-03-19 09:25:02 +00:00
Mirko Brodesser f7f372d8a6 Bug 1621620: part 2) Declare `nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree` `const`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D66394

--HG--
extra : moz-landing-system : lando
 2020-03-18 16:33:13 +00:00
Mirko Brodesser 86eec2f9fe Bug 1623040: split `nsRange::SetSelection` into `RegisterSelection` and `UnregisterSelection`. r=smaug 
The name "SetSelection" was misleading, because it did more than a
setter.

Differential Revision: https://phabricator.services.mozilla.com/D67126

--HG--
extra : moz-landing-system : lando
 2020-03-18 09:06:10 +00:00
Simon Giesecke 8aa47bcfb7 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert 
Differential Revision: https://phabricator.services.mozilla.com/D66016

--HG--
extra : moz-landing-system : lando
 2020-03-17 09:38:32 +00:00
Mihai Alexandru Michis 58bc354025 Backed out changeset 9eeee9ec66d9 (bug 253870) for causing failures in browser_bug1261299.js 
CLOSED TREE
 2020-03-16 22:32:41 +02:00
Emilio Cobos Álvarez 9f28f89085 Bug 253870 - Make disabled form controls selectable. r=masayuki,MarcoZ 
This rejiggers a bit the way selection focus is handled so that focusing a
disabled form control with the mouse handles selection properly, and hides the
document selection and so on.

This matches the behavior of other browsers as far as I can tell.

Given now readonly and disabled editors behave the same, we can simplify a bit
the surrounding editor code.

Differential Revision: https://phabricator.services.mozilla.com/D66464

--HG--
extra : moz-landing-system : lando
 2020-03-16 17:41:07 +00:00
Mirko Brodesser ec9cb4d8ef Bug 1622199: annotate `Selection::AddRangeAndSelectFramesAndNotifyListeners` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D66759

--HG--
extra : moz-landing-system : lando
 2020-03-13 15:46:13 +00:00
Henri Sivonen 7d98d5c9e0 Bug 1618219 - Use BrowsingContext for activeness check in nsFrameSelection.cpp. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D65956

--HG--
extra : moz-landing-system : lando
 2020-03-11 15:56:04 +00:00
Mirko Brodesser 76ae1d169f Bug 1620952: part 9) Rename `nsFrameSelection::GetBatching` to `IsBatching`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D66061

--HG--
extra : moz-landing-system : lando
 2020-03-11 09:18:18 +00:00
Mirko Brodesser 1535e53831 Bug 1620952: part 7) Group batching members. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D66059

--HG--
extra : moz-landing-system : lando
 2020-03-11 09:18:02 +00:00
Mirko Brodesser c1d76e9941 Bug 1620952: part 6) Group `mDesiredPos` and `mDesiredPosSet`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65961

--HG--
extra : moz-landing-system : lando
 2020-03-11 09:17:55 +00:00
Mirko Brodesser 2ab206b6d4 Bug 1620952: part 5) Group limiter members in `nsFrameSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65960

--HG--
extra : moz-landing-system : lando
 2020-03-11 09:17:47 +00:00
Mirko Brodesser 9aa383b1f7 Bug 1620952: part 4) Group caret members in `nsFrameSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65959

--HG--
extra : moz-landing-system : lando
 2020-03-10 14:08:11 +00:00
Mirko Brodesser b4e19dc9cb Bug 1620952: part 3) Group delayed mouse event members in `nsFrameSelection`. r=jfkthame 
Simplifies analyzing and further refactoring `nsFrameSelection`.

Differential Revision: https://phabricator.services.mozilla.com/D65957

--HG--
extra : moz-landing-system : lando
 2020-03-10 12:41:13 +00:00
Mirko Brodesser b58f603d3f Bug 1620952: part 2) Remove `nsFrameSelection::Init`. r=jfkthame 
Will allow to declare some members const.

Differential Revision: https://phabricator.services.mozilla.com/D65954

--HG--
extra : moz-landing-system : lando
 2020-03-10 12:41:05 +00:00
Mirko Brodesser f48facbc7d Bug 1619549: part 6) Factor out code from `nsFrameSelection::HandleDrag` to `MaintainedRange::AdjustContentOffsets`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65297

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:19:39 +00:00
Mirko Brodesser 6679773961 Bug 1619549: part 5) Move core of `nsFrameSelection::MaintainSelection` to `MaintainedRange`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65120

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:19:29 +00:00
Mirko Brodesser 4deab48718 Bug 1619549: part 4) Move `nsFrameSelection::AdjustForMaintainedSelection` to `MaintainedRange`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65119

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:19:26 +00:00
Mirko Brodesser 410e3284f4 Bug 1619549: part 3) Use `RefPtr` in `nsFrameSelection::HandleClick`. r=jfkthame 
Simplifies following simplifications.

Differential Revision: https://phabricator.services.mozilla.com/D65118

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:19:10 +00:00
Mirko Brodesser b1ecc4e48d Bug 1619549: part 2) Add assertion to `nsFrameSelection::HandleClick`. r=jfkthame 
Helps reasoning about it.

Differential Revision: https://phabricator.services.mozilla.com/D65117

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:19:02 +00:00
Mirko Brodesser 1dcf5265e1 Bug 1619549: part 1) Group `mMaintainRange` and `mMaintainedAmount` in `MaintainedRange`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D65106

--HG--
extra : moz-landing-system : lando
 2020-03-09 14:18:55 +00:00
Mirko Brodesser 3b935e0da5 Bug 1619617: part 2) Annotate `UnselectCells` with `MOZ_CAN_RUN_SCRIPT`. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D65512

--HG--
extra : moz-landing-system : lando
 2020-03-06 12:03:30 +00:00
Mirko Brodesser efbaffc13c Bug 1615581: part 19) Decouple `UpdateSelectionCacheOnRepaintSelection` from `nsFrameSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63482

--HG--
extra : moz-landing-system : lando
 2020-03-03 09:15:22 +00:00
Mirko Brodesser 2e40a7367b Bug 1615581: part 18) Move core of `nsFrameSelection::HandleTableSelection` to `TableSelection::HandleSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63481

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:34 +00:00
Mirko Brodesser 4e70ce992b Bug 1615581: part 17) Correct style in `nsFrameSelection::HandleTableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63480

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:36 +00:00
Mirko Brodesser b0148d9b7a Bug 1615581: part 16) Move `nsFrameSelection::SelectRowOrColumn` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63324

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:38 +00:00
Mirko Brodesser 88584c4608 Bug 1615581: part 15) Update style in `nsFrameSelection::SelectRowOrColumn`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63323

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:17 +00:00
Mirko Brodesser b2c626c5ff Bug 1615581: part 14) Move `SelectBlockOfCells` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63307

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:19 +00:00
Mirko Brodesser 4b67e294f7 Bug 1615581: part 13) Move `mDragSelectingCells` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63297

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:22 +00:00
Mirko Brodesser e8f4f2644a Bug 1615581: part 12) Decouple `AddCellsToSelection` from `nsFrameSelection`. r=jfkthame 
Simplifies reasoning about `nsFrameSelection` and allows to decouple
more code from it.

Differential Revision: https://phabricator.services.mozilla.com/D63296

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:24 +00:00
Mirko Brodesser 7ee453e1fb Bug 1615581: part 11) Use free function `SelectCellElement` in `AddCellsToSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63295

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:26 +00:00
Mirko Brodesser eb1d4d2a75 Bug 1615581: part 10) Update style in `nsFrameSelection::AddCellsToSelection`. r=jfkthame 
Simplifies reviewing the following part.

Differential Revision: https://phabricator.services.mozilla.com/D63294

--HG--
extra : moz-landing-system : lando
 2020-03-02 15:09:29 +00:00
Narcis Beleuzu 44ec37a8cf Backed out 10 changesets (bug 1615581) for bustages on nsFrameSelection.cpp . CLOSED TREE 
Backed out changeset 47087b5b4e42 (bug 1615581)
Backed out changeset 1489a8cb97e9 (bug 1615581)
Backed out changeset 1f89d7b3668a (bug 1615581)
Backed out changeset ea9869a4fb04 (bug 1615581)
Backed out changeset 9678a5d6a970 (bug 1615581)
Backed out changeset 13fd32562d0c (bug 1615581)
Backed out changeset c3c657e53988 (bug 1615581)
Backed out changeset 5272f4d02c88 (bug 1615581)
Backed out changeset 83dbbfb4b4e8 (bug 1615581)
Backed out changeset 9aa0aef619ed (bug 1615581)
 2020-03-02 17:05:00 +02:00
Mirko Brodesser 523f549231 Bug 1617165: part 2) Rename `nsFrameSelection::PostReason` and `PopReason`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63668

--HG--
extra : moz-landing-system : lando
 2020-03-02 13:48:24 +00:00
Mirko Brodesser bbb9d9ba21 Bug 1615581: part 19) Decouple `UpdateSelectionCacheOnRepaintSelection` from `nsFrameSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63482

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:56 +00:00
Mirko Brodesser c5f6e249b8 Bug 1615581: part 18) Move core of `nsFrameSelection::HandleTableSelection` to `TableSelection::HandleSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63481

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:54 +00:00
Mirko Brodesser 4a5e298cee Bug 1615581: part 17) Correct style in `nsFrameSelection::HandleTableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63480

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:51 +00:00
Mirko Brodesser 9cb478e6df Bug 1615581: part 16) Move `nsFrameSelection::SelectRowOrColumn` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63324

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:44 +00:00
Mirko Brodesser 6b59f98679 Bug 1615581: part 15) Update style in `nsFrameSelection::SelectRowOrColumn`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63323

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:41 +00:00
Mirko Brodesser 795f2590f4 Bug 1615581: part 14) Move `SelectBlockOfCells` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63307

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:59:37 +00:00
Mirko Brodesser ee9cbbd1d4 Bug 1615581: part 13) Move `mDragSelectingCells` to `TableSelection`. r=jfkthame 
Differential Revision: https://phabricator.services.mozilla.com/D63297

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:37 +00:00
Mirko Brodesser 49b48fa2d9 Bug 1615581: part 12) Decouple `AddCellsToSelection` from `nsFrameSelection`. r=jfkthame 
Simplifies reasoning about `nsFrameSelection` and allows to decouple
more code from it.

Differential Revision: https://phabricator.services.mozilla.com/D63296

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:25:34 +00:00