treewide changes to convert incorrect usages of string.Length() to string.IsEmpty().
thanks to afatecha@idea.com.py (Ariel Fatecha) for the patch. r=dwitte, sr=jst.
got the ok from Asa to land into a closed tree.
nsHTMLEditor::SetFinalSize]
- A one line fix in HideResizers() which prevents the
reported crash by setting mIsResizing to false. I assume
we can't be resizing if the resize handles are being hidden.
The assertion and null check in SetFinalSize() are just because
I'm paranoid, but they should never be triggered if HideResizers()
is called first.
- The changes in StartResizing() makes it so that we don't create
a new mouse motion listener if we already have one. We were
creating a new listener each time we clicked on the handles, and
never unregistering the old one ... this meant that the old
listeners could be triggered if the editor were ever destroyed
and the document left in tact ... allowing us to crash because the
listeners keep an un-addref'd pointer to the HTMLEditor. Note that
this crash is not likely to be hit in Mozilla since we always
destroy the document and editor in Composer and MailCompose, but
it can happen in an embedding context.
r=glazman@netscape.comsr=sfraser@netscape.com
subtree
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
- jfrancis' fix for netscape bug 615240 (applying mozilla patch
on branch. Fixing problems of improper handling of del and
backspace keys with file attachments.) which was originally
landed in revision 1.445.6.3. This patch is necessary to make
the fix for bug 200549 work properly.
r=sfraser@netscape.comsr=kin@netscape.com
mozilla/editor/libeditor/html/nsHTMLEditorMouseListener.cpp
mozilla/editor/libeditor/html/nsHTMLEditorMouseListener.h
- Modified nsHTMLEditorMouseListener::MouseDown() to
call FindUserSelectAllNode() so that the root of a
-moz-user-select:all subtree gets selected during
a double or context click.
- Modified nsHTMLEditorMouseListener so that it stores an nsHTMLEditor*
instead of an nsIEditor* so we could have access to FindUserSelectAllNode().
r=brade@netscape.comsr=sfraser@netscape.com
subtrees
mozilla/layout/html/base/src/nsFrame.cpp
- Added utility method ContentContainsPoint()
- Modified HandlePress() to allow selection of images, hrs and
-moz-user-select:all subtrees, and then disable selection
processing of drag events.
mozilla/editor/libeditor/html/nsHTMLDataTransfer.cpp
- Modified InsertFromDrop() so that it prevents a drop from
happening in a -moz-user-select:all subtree. (Temporary
workaround to avoid bug 195957 and bug 195959)
r=mjudge@netscape.comsr=sfraser@netscape.com
mozilla/editor/idl/nsIEditor.idl
mozilla/editor/libeditor/base/nsEditor.cpp
mozilla/editor/libeditor/base/PlaceholderTxn.cpp
mozilla/editor/libeditor/html/nsHTMLCSSUtils.cpp
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
mozilla/editor/libeditor/text/nsTextEditRules.cpp
- Renamed nsIEditor::Do() to nsIEditor::DoTransaction() so that it
can be called from JavaScript.
- Cleaned up nsEditor::Begin/EndUpdateViewBatch() so that
nothing happens outside the check of mUpdateCount.
- Modified PlaceholderTxn.cpp so that it checks to see
if a merged transaction implements nsPIEditorTransaction
before attempting to cast it to (EditorTxn*).
mozilla/editor/ui/composer/content/EditorCommandsDebug.js
mozilla/editor/ui/composer/content/editorOverlay.xul
mozilla/editor/ui/composer/locale/en-US/editorOverlay.dtd
- Added debug menu items to test execution of foreign transactions
via the txnmgr and editor.
r=jfrancis@netscape.comsr=sfraser@netscape.com
178304 - deleting only char in text node places caret in previous block
174867 - caret in wrong place after delete-to-end in list
181898 - select into mailcite, type: inserted text is in cite
r=brade; sr=kin
Moved nsFileSpec and related classes into this obsolete library.
Moved nsRegistry and related libreg functionality into the obsolete library.
Updated many callers using the obsolete nsFile spec to use nsIFile and Necko to do file IO.
Combined the following DLLs (source -> dest)
uriloader -> docshell
shistory -> docshell
jsurl -> jsdom
gkview -> gklayout
Moved nsAdapterEnumerator out of xpcom/ds and into mailnews, since they're the only consumer
Modifed the xpt_link tool so that you can specify a �only include� cid list that can mask CID�s that you are not interested in.
Added build options:
Prevent the building of xpinstall (--disable-xpinstall)
Prevent the building js component loader (--disable-jsloader)
A build option to only build a single profile (--enable-single-profile)
A build flag to only built the required xpfe components (--disable-xpfe-components).
Removal or hiding of unused functions and classes including nsEscape*, nsDequeIterator, nsRecyclingAllocatorImpl, nsDiscriminatedUnion, nsOpaqueKey, nsCRT::strlen, NS_NewCommandLineService
Bug 194240, r/sr = darin, alec.
editor/libeditor/base/nsSelectionState.cpp
- Reworked the logic in SelAdjJoinNodes() to avoid adding aOldLeftNodeLength twice to the calculated offset when the start/end node is the parent.
editor/libeditor/html/nsHTMLDataTransfer.cpp
editor/libeditor/text/nsPlaintextDataTransfer.cpp
- Modified the InsertFromDrop() to use an nsAutoTrackDOMPoint, instead of relying on range gravity, to calculate the correct insert position after deleting the current selection.
r=jfrancis@netscape.comsr=sfraser@netscape.com
For the default Mozilla build, this includes Composer and Mail Composition.
Embeddors willing to disable this feature should look at |nsHTMLEditor::SetIsImageResizingEnabled()|
Displays eight resizing handles plus an info box. Images are resized real-time.
Uses HTML attributes in pure HTML mode (mail composition for instance) and CSS properties when available.
Undoable and Redoable. Does not grind coffe and make a good expresso yet.
Thanks if you really read to that line.
b=47066, r=brade, r=cmanske (for the algo part inheriting from the XBL patch), sr=kin
180034 editor should respect the select_all style
183836 New list item should not reset inline styles
179384 Merging blocks via forward delete sends selection to front of document
98434 IME does not work correctly at the last characters in the text field (patch courtesy of Shotaro Kamio)
r=jfrancis,brade,cmanske sr=kin
and removed via the DOM. Clean up the nsIDocument stylesheet accessors. Clean
up nsIDocumentObserver stylesheet stuff a bit. Make style sheets visible in
the CSSOM (though not completely accessible) from the moment the load is kicked
off. Make us have sheet objects that can be manipulated via CSSOM even for
failed loads. Bug 107567, bug 47734, bug 57225, bug 178407.
r=sicking, sr=peterv.
could not revert to HTML attributes default value,
VALIGN attribute on table elements was not CSSized,
page colors of new documents were not CSSized,
bad design in |nsEditor::CloneAttributes()|,
new image width/height/border attributes were not CSSized,
error in EdTableProps.js
b=167712, b=167716, r=brade, r=jfrancis, sr=kin
mozilla/content/base/public/nsISelectionController.idl
mozilla/content/base/src/nsSelection.cpp
mozilla/editor/composer/src/nsEditorShell.cpp
mozilla/editor/idl/nsIPlaintextEditor.idl
mozilla/editor/libeditor/base/nsEditor.cpp
mozilla/editor/libeditor/base/nsEditor.h
mozilla/editor/libeditor/html/nsHTMLDataTransfer.cpp
mozilla/editor/libeditor/html/nsHTMLEditor.cpp
mozilla/editor/libeditor/text/nsEditorEventListeners.cpp
mozilla/editor/libeditor/text/nsPlaintextDataTransfer.cpp
mozilla/editor/libeditor/text/nsPlaintextEditor.cpp
mozilla/editor/txtsvc/src/nsTextServicesDocument.cpp
mozilla/editor/ui/dialogs/content/EdTableProps.js
mozilla/embedding/components/find/src/nsWebBrowserFind.cpp
mozilla/extensions/xmlterm/base/mozXMLTermSession.cpp
mozilla/layout/base/public/nsIFrameSelection.h
mozilla/layout/html/base/src/nsPresShell.cpp
mozilla/layout/html/forms/src/nsGfxTextControlFrame2.cpp
mozilla/mailnews/compose/src/nsMsgCompose.cpp
mozilla/xpfe/browser/resources/content/viewPartialSource.js
- Added aIsSynchronous arg to the ScrollSelectionIntoView()
method of nsISelectionController and nsIFrameSelection.
Updated all callers to pass new arg.
- Modified selection to post a plevent to call which does the
call to ScrollIntoView() in the async ScrollIntoView() case.
- Edits in text widgets now use asynchronous reflow, paint,
and scroll processing full time.
- Removed redundant ScrollSelectionIntoView() calls in the
editor event listeners.
- Editor IME code now forced to flush reflows and paints before
getting caret coordinates.
r=jfrancis@netscape.comsr=waterson@netscape.com
Modified TypeInState::NotifySelectionChanged() to work around
bogus selection changed notifications (bug 140303). We now
call reset when the collapsed selection changes position, or
becomes uncollapsed.
mozilla/editor/libeditor/html/TypeInState.cpp
mozilla/editor/libeditor/html/TypeInState.h
r=jfrancis@netscape.comsr=attinasi@netscape.com
Browser based listeners can now registers themselves using the AddGroupedEventListener and passing the system event group (which can be gotten via the nsIDOMEventReceiver interface). These listeners will now fire after all content based listeners have processed.
In this initial version of the checkin most browser listeners are still left in the original content group for stability purposes.
width, and don't wrap quotes in <pre> or <span>, to work around various
editor bugs. Detect quoted blocks at output time, and continue our
existing behavior of not wrapping quoted text. r=jfrancis,bratell, sr=alecf.
fix chinese ime candidate window position problem.
we need the nsAutoPlaceHolderBatch destroctor called before hitting
GetCaretCoordinates so the states in Frame system sync with content
therefore, we put the nsAutoPlaceHolderBatch into a inner block
{
117418: warnings in nsWSRunObject.cpp
98286: splitting paragraphs broken
101041: block transformations could grab too much beyon selection
82813: whitespace handling code needs to do right thing with preformatted text
99545 &
103677: new blocks not always pre-populated with br
41336: better handling of mailcites when splitting or deleting them or portions of them
partial fix for:
46474: creating new blocks kills style settings
r=fm, sr=kin
117418: warnings in nsWSRunObject.cpp
98286: splitting paragraphs broken
101041: block transformations could grab too much beyon selection
82813: whitespace handling code needs to do right thing with preformatted text
99545 &
103677: new blocks not always pre-populated with br
41336: better handling of mailcites when splitting or deleting them or portions of them
partial fix for:
46474: creating new blocks kills style settings
r=fm, sr=kin
and bug 124375 (composer / editor hang when delete blank lines)
Allow start/end points to be set to empty text nodes to prevent
infinite loop.
r=glazman@netscape.comsr=sfraser@netscape.com,shaver@mozilla.org
* 113691 : Composer freezes when removing multiple ol or ul tags.
* 113290 : Freezes when deleting some formatted text.
* 112144 : Attempt to reply to mail freezes entire Mozilla.
* 103685 : Caret disappears after deleting a blockquote w/ paragraph style.
* 121282 : Pressing enter causes caret to jump from end of <p> to the<h1>.
* 117418 : rewrote some code in nsWSRunObject.cpp: fixed warnings in GetWSNodes().
* 114911 : can't join two lists using delete key.
* 120000 : Indent list inside table causes table to split.
r=fm;sr=kin
brade%netscape.com
jfrancis%netscape.com
timeless%mozdev.org
dwitte%stanford.edu
glazman%netscape.com
kaie%netscape.com
jaggernaut%netscape.com
alecf%netscape.com
bzbarsky%mit.edu
kin%netscape.com
sfraser%netscape.com
henry.jia%sun.com
bryner%netscape.com
sspitzer%netscape.com
dougt%netscape.com
jkeiser%netscape.com
neil%parkwaycc.co.uk
darin%netscape.com
cbiesinger%web.de
jst%netscape.com
dbaron%dbaron.org
sdagley%netscape.com
cmanske%netscape.com
akkana%netscape.com
sicking%bigfoot.com
caillon%returnzero.com
blizzard%redhat.com
hyatt%netscape.com
mjudge%netscape.com
seawood%netscape.com
dbaron%fas.harvard.edu
pinkerton%netscape.com
joki%netscape.com
bienvenu%netscape.com
ducarroz%netscape.com
ftang%netscape.com