Depends on D10586
Adds a new `type` param to the `change` object passed from server to the client to describe the change type. For changes to rules, the client marks the whole rule as either added or removed and styles it accordingly in the Changes panel.
Change types for declarations are not used at this time, but are put in for consistency and future-proofing.
Differential Revision: https://phabricator.services.mozilla.com/D11116
--HG--
extra : moz-landing-system : lando
Depends on D10585
Renames the logChange() to logDeclarationChange() to distinguish it from the newly introduced logSelectorChange() method which tracks selector rename by logging two changes: a whole rule remove using the old selector and a whole rule insertion add using the new selector.
MozReview-Commit-ID: 9VoVMHYXumE
Differential Revision: https://phabricator.services.mozilla.com/D10586
--HG--
extra : moz-landing-system : lando
Depends on D10584
Other methods for tracking changes need to make use of the CSS rule
metadata (selector, rule index, ancestors, etc). This extracts that
logic into an accessor on the StyleRuleActor to facilitate reuse.
The CSS rule metadata will be augmented with information about a CSS
change (declarations added or removed) before being tracked.
MozReview-Commit-ID: xXec1XgUhk
Differential Revision: https://phabricator.services.mozilla.com/D10585
--HG--
extra : moz-landing-system : lando
Depends on D10582
Improves the reducer for tracking CSS changes to handle more than one
CSS declaration changed in one operation. This is a requirement for
tracking whole rule removal or whole rule addition, like it happens
when renaming a CSS selector in the Rules view.
MozReview-Commit-ID: 25pf2GRiH4D
Differential Revision: https://phabricator.services.mozilla.com/D10584
--HG--
extra : moz-landing-system : lando
This isn't strictly necessary for this patch series, but it adds an
optimization to improve performance for React rendering and solves
warnings thrown while using React in dev mode.
MozReview-Commit-ID: ujqOa9qUsd
Differential Revision: https://phabricator.services.mozilla.com/D10582
--HG--
extra : moz-landing-system : lando
In many places we were using bounds to calculate an objects dimensions but that obviously doesn't work when an object is rotated e.g.
{F588303}
Also, we were using `getBoxQuads()`, which gives the co-ordinates of the translated object. We were then applying the transform matrix to the canvas even though the coordinates came from the object **after** it was already transformed.
Anyhow, now we get the dimensions of objects as if they are not transformed and then apply the transformation matrix, which gives a great result every time.
Differential Revision: https://phabricator.services.mozilla.com/D9805
--HG--
extra : moz-landing-system : lando
At first, I wanted it is better to call DebuggerServer.destroy() when
`devtools.debugger.remote-enabled` will set to false. Likewise, call
DebuggerServer.init() in case of true. But, because DebuggerServer.init() is
called by various context such as RemoteDebugger, restoring is difficult after
destroying. In this patch, simply, we make avoiding to call
DebuggerServer.closeAllListener() from inside of ServerSocketConnection.
Depends on D10864
Differential Revision: https://phabricator.services.mozilla.com/D10865
--HG--
extra : moz-landing-system : lando
Yet another approach. In the previous D9889 approach, both DebuggerSerever and
SocketServerListener retain the connections duplicately, it will be possible to
be difficult for the management. In this approach, only DebuggerSerever retains
the connections, then when ServerSocketListener was removed, removes the
connections as well that were linked the ServerSocketListener.
Differential Revision: https://phabricator.services.mozilla.com/D10864
--HG--
extra : moz-landing-system : lando
Converted uses of defer to new Promise/async await in devtools dom directory
Differential Revision: https://phabricator.services.mozilla.com/D10876
--HG--
extra : moz-landing-system : lando
This patches fixes a bug where hitting Cmd+F while
the filter input of the console was focused was
triggering codeMirror search addon, displaying the
search UI *in* JsTerm.
To prevent this, we add the ability for any consumer
of the Editor component to disable the search addon.
In the editor, in such case, we simply don't initialize
the event listeners that activate the search addon.
A test case is added to ensure we don't regress this.
Differential Revision: https://phabricator.services.mozilla.com/D11037
--HG--
extra : moz-landing-system : lando
- removes duplication of logic to create each panel.
- removes needless exposing of panel instances as properties on `inspector`:
- `inspector.layoutview`
- `inspector.fontinspector`
- `inspector.animationinspector`
- `inspector.changesview`
- updates tests to not rely on those exposed properties and instead
call `inspector.getPanel(toolId)` (previously created panels are stored
and a reference is returned).
- consolidates panel `destroy()` so we don't have to remember to
destroy them individually.
MozReview-Commit-ID: GVkP6z7FxKt
Differential Revision: https://phabricator.services.mozilla.com/D10053
--HG--
extra : moz-landing-system : lando
- Make notificationbox buttons and closing affordance visible when overflowing,
- Apply ellipsis to message when overflowing (using the width=0 to not break flex layout),
- Add title to show potentially truncated message on hover,
- Simplify layout (remove the unnecessary nested flexbox layout).
TESTED=Locally using some mocked notification buttons. Run styleeditor and shared/component tests.
Spacing between "No throttling" and the dropdown icon is now consistent with "HAR"
Differential Revision: https://phabricator.services.mozilla.com/D10808
--HG--
extra : moz-landing-system : lando
- removes duplication of logic to create each panel.
- removes needless exposing of panel instances as properties on `inspector`:
- `inspector.layoutview`
- `inspector.fontinspector`
- `inspector.animationinspector`
- `inspector.changesview`
- updates tests to not rely on those exposed properties and instead
call `inspector.getPanel(toolId)` (previously created panels are stored
and a reference is returned).
- consolidates panel `destroy()` so we don't have to remember to
destroy them individually.
MozReview-Commit-ID: GVkP6z7FxKt
Differential Revision: https://phabricator.services.mozilla.com/D10053
--HG--
extra : moz-landing-system : lando
David Walsh
Julian Descottes
Micah Tigley
Razvan Caliman
Michael Ratcliffe
Csoregi Natalia
Patrick Brosset
Daisuke Akatsuka
Logan Smyth
Daniel Varga
Andreea Pavel
sreeise
Collin Wing
Alexandre Poirot
Nicolas Chevobbe
Gurzau Raul
Vincent R
Kristin Taylor
Narcis Beleuzu
tanhengyeow
vinoth
arthur.iakab
Jonathan Kingston
Jan Odvarko
Kris Maglione