* Move shared open-in-new and print icons into toolkit and update references
* The pendingpaint.png reference will be removed in bug 1679133
Differential Revision: https://phabricator.services.mozilla.com/D101239
TLS error report sending was disabled by default in bug 1579906. The server
that ingested these reports has been decommissioned as well, so this patch
removes this dead code.
Differential Revision: https://phabricator.services.mozilla.com/D99405
This makes it more adaptable to toolbaritem-combined-buttons with varying
numbers of buttons.
I'm planning to introduce a usage of toolbaritem-combined-buttons with only two
buttons in bug 1650835 (a regular button and a dropmarker button), and the
dropmarker button is hidden when the item is shown in the panel, so we end up
with just one visible button, and the max-width was making it look silly.
This was the last reference to menuPanelButtonWidth, so we can remove the hack
was introduced in bug 963365. The max-width was needed originally because we had
a three-column layout in the panel, and each button could have wrapping text, so
-moz-box-flex wouldn't have enforced a fixed column width.
But the three-column layout is gone, and our current toolbaritem-combined-buttons
(zoom + edit buttons) don't require wrapping text.
Differential Revision: https://phabricator.services.mozilla.com/D98214
This patch moves the following SVGs from browser to toolkit so that a subsequent
patch can load panel-icon-folder.svg and connection-mixed-active-loaded.svg from
toolkit. The other two SVGs are moved to minimize a change in CSS and JS.
- panel-icon-folder.svg
- panel-icon-magnifier.svg
- connection-mixed-active-loaded.svg
- connection-mixed-passive-loaded.svg
Differential Revision: https://phabricator.services.mozilla.com/D98699
This patch moves the following SVGs from browser to toolkit so that a subsequent
patch can load panel-icon-folder.svg and connection-mixed-active-loaded.svg from
toolkit. The other two SVGs are moved to minimize a change in CSS and JS.
- panel-icon-folder.svg
- panel-icon-magnifier.svg
- connection-mixed-active-loaded.svg
- connection-mixed-passive-loaded.svg
Differential Revision: https://phabricator.services.mozilla.com/D98699
We use the border to create space when dragging items to/from the toolbar,
so we shouldn't be changing its colour to create a visual border.
Differential Revision: https://phabricator.services.mozilla.com/D99240
This was a little harder than it seemed like it should be because we show/hide
the title separator in two places, in `UrlbarView.updateRow` and in the CSS.
This patch gets rid of the show/hide in `updateRow`, so now we show/hide only in
the CSS. The decision to show/hide in `updateRow` was based on whether the
result has action text (`actionSetter`) or is a URL (`setURL`). We already had a
`has-url` attribute that corresponds directly to `setURL`, so adding a similar
`has-action` attribute that corresponds to `actionSetter` lets us show/hide only
in the CSS.
The second part of this patch is to actually fix the bug. For that, the existing
`show-action-text` attribute does part of what we want in the CSS: It forces the
action to be shown when a one-off is selected and there's no selected row. In
addition to that, we need to show the action when both a restyled search and a
one-off are selected, so this adds a new `restyled-search` attribute. We need
both attributes because we do not want to show the action for a restyled search
when some other row plus a one-off are selected (to match the current behavior).
Depends on D97843
Differential Revision: https://phabricator.services.mozilla.com/D98429
This was a little harder than it seemed like it should be because we show/hide
the title separator in two places, in `UrlbarView.updateRow` and in the CSS.
This patch gets rid of the show/hide in `updateRow`, so now we show/hide only in
the CSS. The decision to show/hide in `updateRow` was based on whether the
result has action text (`actionSetter`) or is a URL (`setURL`). We already had a
`has-url` attribute that corresponds directly to `setURL`, so adding a similar
`has-action` attribute that corresponds to `actionSetter` lets us show/hide only
in the CSS.
The second part of this patch is to actually fix the bug. For that, the existing
`show-action-text` attribute does what we want in the CSS; the only problem is
that we currently set it only when there's no selected row, but we need to also
set it when there's no selected row but a one-off is selected. We have a similar
block -- the one with a comment about restyling the heuristic to look like a
search result -- so I removed the block that currently sets/removes the
attribute and moved the set/removal there. I also renamed the attribute
`restyled-search` to better semantically describe what's happening, but if you
disagree I can restore the old name.
Depends on D97843
Differential Revision: https://phabricator.services.mozilla.com/D98429
* Add prefs for each local search shortcut
* Remove the `update2.localOneOffs` pref since it's not necessary with the three
new prefs
* Modify preferences UI by adding a new row in the engines tree for each local
shortcut
* Add `UrlbarUtils.LOCAL_SEARCH_MODES` so we have a single place where local
search modes and their properties are defined
* Add a new test file for the preferences UI
* Modify browser_oneOffs.js to test the three new preferences
Differential Revision: https://phabricator.services.mozilla.com/D97376
Sam Foster
Dana Keeler
Dão Gottwald
Tim Nguyen
Sonia Singla
amy churchwell
Kartik Gautam
Gijs Kruitbosch
Molly Howell
Dorel Luca
Markus Stange
Toshihito Kikuchi
Narcis Beleuzu
Csoregi Natalia
Drew Willcoxon
Brindusan Cristian
Cristina Coroiu
Razvan Maries
Erica Wright
Bogdan Tara
Jared Wein