59984954da
Bug 1708422: part 21) Reduce scope of `erv` variable in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115687
2021-05-26 10:04:36 +00:00
0694578bb0
Bug 1708422: part 20) Const-qualify some variables in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Clearer.
Differential Revision: https://phabricator.services.mozilla.com/D115686
2021-05-26 10:04:36 +00:00
93ac6f9a56
Bug 1708422: part 19) Replace output arguments with a single argument in `mozInlineSpellWordUtil::GetNextWord`. r=smaug
...
Clearer and helps to simplify its caller.
Differential Revision: https://phabricator.services.mozilla.com/D115597
2021-05-26 10:04:35 +00:00
69c6a23516
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-26 09:27:21 +00:00
16a4c26f4c
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-26 09:27:20 +00:00
1fb3a73493
Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
...
Depends on D112597
Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-26 09:27:19 +00:00
40b6793a72
Bug 1700051: part 45) Remove outdated part of comment in <mozInlineSpellChecker.cpp>. r=smaug
...
Depends on D113300
Differential Revision: https://phabricator.services.mozilla.com/D113301
2021-05-25 10:08:15 +00:00
ae69b73075
Bug 1540037 - part 18: Move `ReplaceTextAsAction()` and `ReplaceSelectionAsSubAction()` to `EditorBase` r=m_kato
...
They are used by setting text value of `TextEditor` or replacing a misspelled
word with a new word in both `TextEditor` and `HTMLEditor`. Therefore,
they should be in the `EditorBase` rather than `TextEditor`.
Note that the path of the former case may be in a hot path. Therefore, we need
to keep redirecting to `TextEditor` for keeping the performance only in the
case.
Depends on D115785
Differential Revision: https://phabricator.services.mozilla.com/D115786
2021-05-25 04:26:14 +00:00
55db5ff457
Bug 1708422: part 18) Factor `mozInlineSpellChecker::SpellCheckerSlice::IsInNoCheckRange` out. r=smaug
...
Hides details.
Differential Revision: https://phabricator.services.mozilla.com/D115469
2021-05-20 13:00:01 +00:00
e74f6c42f1
Bug 1708422: part 17) Rename `words` to `normalizedWords` in `mozInlineSpellChecker::SpellCheckerSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115366
2021-05-20 09:03:30 +00:00
b05af40fa3
Bug 1708422: part 16) Rename `mozInlineSpellChecker::SpellCheckerTimeSlice` to `mozInlineSpellChecker::SpellCheckerSlice`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D115352
2021-05-20 09:03:30 +00:00
e5983d6bde
Bug 1708422: part 14) Extend documentation of `mozInlineSpellChecker::SpellCheckerTimeSlice::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114333
2021-05-20 09:03:29 +00:00
c080bbd4cc
Bug 1708422: part 13) Factor code out to `mozInlineSpellChecker::SpellCheckerTimeSlice::RemoveRanges`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114332
2021-05-20 09:03:28 +00:00
a89ff13783
Bug 1708422: part 12) Move some code into `mozInlineSpellChecker::SpellCheckerTimeSlice::ShouldSpellCheckRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114331
2021-05-20 09:03:28 +00:00
9c30eeb984
Bug 1708422: part 11) Remove unnecessary block scope in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114105
2021-05-20 09:03:28 +00:00
ddbcce9316
Bug 1708422: part 10) Factor `ShouldSpellCheckRange` out. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114104
2021-05-20 09:03:27 +00:00
882cc710a4
Bug 1708422: part 9) Declare `mozInlineSpellChecker::ShouldSpellCheckNode` `static`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114103
2021-05-20 09:03:27 +00:00
19a242b989
Bug 1708422: part 8) Move `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Simplifies `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute`.
Differential Revision: https://phabricator.services.mozilla.com/D114102
2021-05-20 09:03:26 +00:00
a2355f8bc1
Bug 1708422: part 7) Annotate `mozInlineSpellChecker::SpellCheckerTimeSlice` as `MOZ_STACK_CLASS`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114101
2021-05-20 09:03:26 +00:00
92c6fda0fa
Bug 1708422: part 6) Change some pointer members of `mozInlineSpellChecker::SpellCheckerTimeSlice` to references. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114100
2021-05-20 09:03:26 +00:00
d99bbf18cb
Bug 1708422: part 5) Surround statements in `mozInlineSpellChecker::SpellCheckerTimeSlice::Execute` with curly braces. r=smaug
...
To match the style guide.
Differential Revision: https://phabricator.services.mozilla.com/D114099
2021-05-20 09:03:25 +00:00
4e3d4abbad
Bug 1708422: part 4) Break out method object for `mozInlineSpellChecker::DoSpellCheck`. r=smaug
...
Should help to simplify it. Please read the following reviews before
commenting on this one.
Differential Revision: https://phabricator.services.mozilla.com/D114098
2021-05-20 09:03:25 +00:00
d488467816
Bug 1699480 - Back out permissions changes at AC's request, r=geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D115515
2021-05-19 18:07:28 +00:00
6b729f46ac
Backed out 2 changesets (bug 1653659) for causing failures at test_hunspell.js. CLOSED TREE
...
Backed out changeset 018859776d85 (bug 1653659)
Backed out changeset b187a1b158df (bug 1653659)
2021-05-18 04:05:15 +03:00
351efdd226
Bug 1653659 - Part 3: Only allow non-empty paths in RLBoxHunspell r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-17 18:19:27 +00:00
ff4369ad7c
Bug 1699480 - Add setPermission, update onContentPermissionRequest to use ContentPermission, and let Gecko manage and persist permissions in GV. r=agi,geckoview-reviewers,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D112042
2021-05-17 15:55:21 +00:00
ff7e90c539
Bug 1708422: part 3) Add some documentation to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D114097
2021-05-17 13:46:59 +00:00
6bb805571d
Backed out 2 changesets (bug 1653659) for Mochitest failures in mochitest/events/test_focus_general.html. CLOSED TREE
...
Backed out changeset 523e4bc2aa47 (bug 1653659)
Backed out changeset fac526423ccb (bug 1653659)
2021-05-14 21:45:58 +03:00
a31d580731
Bug 1653659 - Part 3: Safely handle empty strings in RLBoxHunspell r=tjr
...
Differential Revision: https://phabricator.services.mozilla.com/D114925
2021-05-14 13:30:48 +00:00
c46e217683
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-10 09:26:01 +00:00
6a64e4c3cf
Bug 1597751 - Import default permissions for privateBrowsing. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D98200
2021-05-06 17:46:32 +00:00
574bea557a
Backed out 14 changesets (bug 1705659, bug 472823, bug 669675) for causing bustages in nsHttpChannelAuthProvider.cpp
...
CLOSED TREE
Backed out changeset 42561f42313d (bug 669675)
Backed out changeset 2aee05c2d6f3 (bug 1705659)
Backed out changeset ff4348e0a307 (bug 1705659)
Backed out changeset 897868e22c81 (bug 1705659)
Backed out changeset c808bf01dfe8 (bug 1705659)
Backed out changeset 5c13ec25cc2e (bug 1705659)
Backed out changeset 4337214c8846 (bug 1705659)
Backed out changeset 18d3a604336a (bug 1705659)
Backed out changeset 3af362aa2b25 (bug 1705659)
Backed out changeset 36eff14cf2ea (bug 1705659)
Backed out changeset 8af29f96ac77 (bug 1705659)
Backed out changeset eab68e8bea29 (bug 1705659)
Backed out changeset 05492b6578a9 (bug 1705659)
Backed out changeset 3259a8cb3db1 (bug 472823)
2021-05-06 17:37:17 +03:00
ec981ec694
Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
...
Depends on D112604
Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-05-06 13:17:23 +00:00
b690e62ff7
Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
...
Depends on D112601
Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-05-06 13:17:22 +00:00
3618a7ca40
Bug 1705659 - Make auth code use nsACString instead of raw char pointers r=necko-reviewers,dragana
...
Depends on D112597
Differential Revision: https://phabricator.services.mozilla.com/D112598
2021-05-06 13:17:21 +00:00
31acb9e00c
Backed out 2 changesets (bug 1708116) for causing xpcshell failures in test_udpsocket_offline.js and bc failures in browser_cookies_ipv6.js. CLOSED TREE
...
Backed out changeset 0c9b303226f1 (bug 1708116)
Backed out changeset e3be13d3c045 (bug 1708116)
2021-05-06 16:35:48 +03:00
301361bdfb
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-06 10:06:46 +00:00
f7b8c6b3d1
Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE
...
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
2021-05-04 18:41:36 +03:00
5ae9a468e0
Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D113752
2021-05-04 14:05:59 +00:00
d5244623ea
Bug 1700051: part 51) Const-qualify `mozInlineSpellStatus::mCreatedRange`. r=smaug
...
Depends on D113758
Differential Revision: https://phabricator.services.mozilla.com/D113759
2021-04-30 07:47:30 +00:00
9de2425774
Bug 1700051: part 50) Add `aRange` to `mozInlineSpellStatus`'s constructor. r=smaug
...
Preparation to const-qualify `mozInlineSpellStatus::mCreatedRange`.
Differential Revision: https://phabricator.services.mozilla.com/D113758
2021-04-30 07:47:29 +00:00
ee42c2c184
Bug 1708422: part 2) Rename `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to `mozInlineSpellChecker::CheckWordsAndAddRangesForMisspellings`. r=smaug
...
Clearer.
Differential Revision: https://phabricator.services.mozilla.com/D113780
2021-04-30 07:43:28 +00:00
1407f0e9c5
Bug 1708422: part 1) Factor `mozInlineSpellChecker::AddRangesForMisspelledWords` out. r=smaug
...
Abstracts details away.
Differential Revision: https://phabricator.services.mozilla.com/D113779
2021-04-30 07:43:28 +00:00
5d7b6d2db6
Bug 1700051: part 48) Slightly simplify `mozInlineSpellWordUtil::FindRealWordContaining`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113654
2021-04-29 09:40:53 +00:00
e817cf406f
Bug 1700051: part 47) Change `aWords` argument of `mozInlineSpellChecker::CheckCurrentWordsNoSuggest` to const reference. r=smaug
...
This separates checking from modification.
Differential Revision: https://phabricator.services.mozilla.com/D113517
2021-04-28 07:34:33 +00:00
734a2382c1
Bug 1700051: part 46) Const-qualify `mozInlineSpellStatus::mAnchorRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113489
2021-04-28 07:34:33 +00:00
2508edc4c5
Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi
...
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)
\# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D113294
2021-04-26 15:52:25 +00:00
ab4f8bcdcd
Bug 1700051: part 44) Reduce `mozInlineSpellStatus::PositionToCollapsedRange` to `static` method. r=smaug
...
Potentially, this changes behavior, but it shouldn't. Historically,
creating a `nsRange` needed the Document, but it doesn't anymore.
Differential Revision: https://phabricator.services.mozilla.com/D113300
2021-04-26 12:14:49 +00:00
ecf6017483
Bug 1700051: part 43) Const-qualify `mozInlineSpellStatus::PositionToCollapsedRange`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113103
2021-04-26 07:40:43 +00:00
cfb0e08cb4
Bug 1700051: part 42) Const-qualify `mozInlineSpellStatus::mOp`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113100
2021-04-26 07:40:08 +00:00
23d745343c
Bug 1700051: part 41) Const-qualify `mozInlineSpellStatus::mNewNavigationPositionOffset`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D113099
2021-04-26 07:40:08 +00:00
44c7f6cb03
Bug 1700051: part 40) Const-qualify `mozInlineSpellStatus::mForceNavigationWordCheck`. r=smaug
...
Makes `mozInlineSpellStatus` slightly less confusing and always
initializes `mForceNavigationWordCheck`.
Differential Revision: https://phabricator.services.mozilla.com/D113098
2021-04-26 07:40:07 +00:00
8a9f37b534
Bug 1706716 green up mda, xpcshell, browser-chrome, reftest for apple silicon. r=necko-reviewers,extension-reviewers,preferences-reviewers,application-update-reviewers,zombie,ahal,bytesized
...
Differential Revision: https://phabricator.services.mozilla.com/D113001
2021-04-22 18:39:40 +00:00
df29e1a8f4
Bug 1706894: part 3) Change `MapDOMPositionToSoftTextOffset`'s argument to `const` reference. r=smaug
...
More efficient.
Depends on D113080
Differential Revision: https://phabricator.services.mozilla.com/D113081
2021-04-22 13:35:39 +00:00
25f87040f2
Bug 1706894: part 2) In `NodeOffsetRange` use `std::move` and return `const` references instead of copies. r=smaug
...
More efficient.
Depends on D113079
Differential Revision: https://phabricator.services.mozilla.com/D113080
2021-04-22 13:35:38 +00:00
1eccfda320
Bug 1706894: part 1) Use `std::move` in `DOMTextMapping`'s constructor. r=smaug
...
More efficient.
Differential Revision: https://phabricator.services.mozilla.com/D113079
2021-04-22 13:35:38 +00:00
11f3568a7e
Bug 1700051: part 39) Add logging when `SoftText::AdjustBeginAndBuildText` adjusts `mBegin.mOffset`. r=smaug
...
Depends on D112972
Differential Revision: https://phabricator.services.mozilla.com/D112973
2021-04-22 07:15:55 +00:00
3c01a158ee
Bug 1700051: part 38) Add more verbose logging to `mozInlineSpellStatus`. r=smaug
...
Helps to comprehend the program flow.
Differential Revision: https://phabricator.services.mozilla.com/D112972
2021-04-22 07:15:55 +00:00
ff55282cb1
Bug 1706613: part 2) Change `NS_ASSERTION`s to `MOZ_ASSERT`s in `mozInlineSpellWordUtil`. r=smaug
...
Depends on D112958
Differential Revision: https://phabricator.services.mozilla.com/D112959
2021-04-21 13:06:57 +00:00
d45f47b9a0
Bug 1706613: part 1) Change `NS_ASSERTION`s to `MOZ_ASSERT`s in `mozInlineSpellChecker`. r=smaug
...
Helps to detect violations during Try runs.
Differential Revision: https://phabricator.services.mozilla.com/D112958
2021-04-21 13:06:56 +00:00
1856c367b5
Bug 1700051: part 37) Reduce accessibility of `SoftText::mEnd` to `private`. r=smaug
...
Depends on D112732
Differential Revision: https://phabricator.services.mozilla.com/D112733
2021-04-21 07:40:35 +00:00
d514c2e238
Bug 1700051: part 36) Reduce accessibility of `SoftText::mBegin` to `private`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D112732
2021-04-21 07:40:34 +00:00
d44f4cc342
Bug 1700051: part 35) Reduce accessibility of `mSoftText.mDOMMapping` to `private`. r=smaug
...
Depends on D112551
Differential Revision: https://phabricator.services.mozilla.com/D112552
2021-04-20 07:49:13 +00:00
7198e709e8
Bug 1700051: part 34) Reduce accessibility of `mSoftText.mValue` to `private`. r=smaug
...
Depends on D112550
Differential Revision: https://phabricator.services.mozilla.com/D112551
2021-04-20 07:49:13 +00:00
8e5146d57b
Bug 1700051: part 33) Move `AdjustSoftBeginAndBuildSoftText` to `SoftText`. r=smaug
...
Depends on D112549
Differential Revision: https://phabricator.services.mozilla.com/D112550
2021-04-20 07:49:13 +00:00
5af84ee6ee
Bug 1700051: part 32) Move `InvalidateWords` to `SoftText`. r=smaug
...
It's clearer.
Differential Revision: https://phabricator.services.mozilla.com/D112549
2021-04-20 07:49:12 +00:00
c7077c610e
Bug 1700051: part 31.5) Move `mSoftTextDOMMapping` to `SoftText`. r=smaug
...
Depends on D112544
Differential Revision: https://phabricator.services.mozilla.com/D112545
2021-04-20 07:49:12 +00:00
12f19abd5f
Bug 1700051: part 31.4) Move `mSoftTextValid` to `SoftText`. r=smaug
...
Depends on D112543
Differential Revision: https://phabricator.services.mozilla.com/D112544
2021-04-20 07:49:11 +00:00
64c83abf72
Bug 1700051: part 31.3) Move `mSoftEnd` to `SoftText`. r=smaug
...
Depends on D112542
Differential Revision: https://phabricator.services.mozilla.com/D112543
2021-04-20 07:49:11 +00:00
f9be3581cf
Bug 1700051: part 31.2) Move `mSoftBegin` to `SoftText`. r=smaug
...
Depends on D112541
Differential Revision: https://phabricator.services.mozilla.com/D112542
2021-04-20 07:49:11 +00:00
1b13e1f445
Bug 1700051: part 31.1) Factor `SoftText` out. r=smaug
...
The `mSoft*` members belong together and will be moved to `SoftText` in
the following reviews.
Depends on D112540
Differential Revision: https://phabricator.services.mozilla.com/D112541
2021-04-20 07:49:10 +00:00
acff2bb77d
Bug 1700051: part 30) Narrow scope of `newOffset`. r=smaug
...
Presumably allows simplifying the code around it. See the following
review.
Differential Revision: https://phabricator.services.mozilla.com/D112540
2021-04-20 07:49:10 +00:00
70371eb59b
Bug 1700051: part 29) Refactor `TextNodeContainsDOMWordSeparator` to `FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
More descriptive and separates input- from output-arguments.
Differential Revision: https://phabricator.services.mozilla.com/D112180
2021-04-16 08:10:11 +00:00
2ac0000c8a
Bug 1700051: part 28) Refactor `WordSplitState<T>::GetDOMWordSeparatorOffset` to `WordSplitState<T>::FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
The method name is clearer and input and ouput are separated more
clearly.
Differential Revision: https://phabricator.services.mozilla.com/D112026
2021-04-15 08:38:42 +00:00
2357740bfb
Bug 1700051: part 27) Rename `mozInlineSpellWordUtil::BuildSoftText` to `mozInlineSpellWordUtil::AdjustSoftBeginAndBuildSoftText`. r=smaug
...
Ideally, the method itself should be refactored. I'll need to think
about how to properly do that. For now, the new name reflects more
clearly what the method does.
Depends on D110242
Differential Revision: https://phabricator.services.mozilla.com/D110243
2021-03-31 09:04:46 +00:00
74905cb822
Bug 1700051: part 26) Correct typo in comment of `mozInlineSpellWordUtil::BuildSoftText`. r=smaug
...
Depends on D110241
Differential Revision: https://phabricator.services.mozilla.com/D110242
2021-03-31 09:04:46 +00:00
c4cd5efacd
Bug 1700051: part 25) Change `mozInlineSpellWordUtil::BuildRealWords` to return the built words. r=smaug
...
Depends on D110240
Differential Revision: https://phabricator.services.mozilla.com/D110241
2021-03-31 09:04:45 +00:00
7814efb66a
Bug 1700051: part 24) Refactor `mozInlineSpellWordUtil::SplitDOMWord` to `mozInlineSpellWordUtil::SplitDOMWordAndAppendTo`. r=smaug
...
More explicit and preparation for further `const`-correctness.
Depends on D110090
Differential Revision: https://phabricator.services.mozilla.com/D110240
2021-03-31 08:33:09 +00:00
5cf3a4fde1
Bug 1700051: part 23) `const`-qualify more methods of `mozInlineSpellWordUtil`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D110090
2021-03-30 14:43:16 +00:00
8f90ed40d6
Bug 1700051: part 22) `const`-qualify some members of `mozInlineSpellStatus`. r=smaug
...
Depends on D110084
Differential Revision: https://phabricator.services.mozilla.com/D110085
2021-03-30 08:45:04 +00:00
76015c271a
Bug 1700051: part 21) Simplify `mozInlineSpellStatus`'s initialization. r=smaug
...
Depends on D110083
Differential Revision: https://phabricator.services.mozilla.com/D110084
2021-03-30 08:45:03 +00:00
a4864650c7
Bug 1700051: part 20) Merge `mozInlineSpellStatus`'s constructor and its `Init` method. r=smaug
...
Allows to `const`-qualify some members.
Differential Revision: https://phabricator.services.mozilla.com/D110083
2021-03-30 08:45:03 +00:00
b8bb3ce56e
Bug 1700051: part 19) `const`-qualify and rename `mozInlineSpellChecker::SpellCheckSelectionIsFull`. r=smaug
...
Depends on D109895
Differential Revision: https://phabricator.services.mozilla.com/D109896
2021-03-29 08:03:11 +00:00
217df64f78
Bug 1700051: part 18) Throw more `const` on `mozInlineSpellChecker`. r=smaug
...
Depends on D109882
Differential Revision: https://phabricator.services.mozilla.com/D109895
2021-03-29 08:03:11 +00:00
9fbe592b0f
Bug 1700051: part 17) Add `mozInlineSpellChecker::GetDisabledAsyncToken()`. r=smaug
...
Allows unfriending some class from `mozInlineSpellChecker`.
Depends on D109881
Differential Revision: https://phabricator.services.mozilla.com/D109882
2021-03-29 08:03:10 +00:00
2eaf6f3625
Bug 1700051: part 16) Qualify `mozInlineSpellWordUtil::GetRootNode` `const`. r=smaug
...
Depends on D109880
Differential Revision: https://phabricator.services.mozilla.com/D109881
2021-03-29 08:03:10 +00:00
4aabcc8b6a
Bug 1700051: part 15) Qualify `mozInlineSpellWordUtil::MakeRange` `const`. r=smaug
...
Depends on D109879
Differential Revision: https://phabricator.services.mozilla.com/D109880
2021-03-29 08:03:10 +00:00
c3a6b19580
Bug 1700051: part 14) Qualify `mozInlineSpellWordUtil::Init`'s argument `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109879
2021-03-29 08:03:09 +00:00
17b3805751
Bug 1700051: part 13) Reduce accessibility of `mozInlineSpellStatus`'s constructor to `private`. r=smaug
...
Prevents users of `mozInlineSpellStatus` forgetting to initialize it.
Differential Revision: https://phabricator.services.mozilla.com/D109748
2021-03-26 09:21:13 +00:00
14313e8270
Bug 1700051: part 12) Declare `mozInlineSpellStatus::mSpellChecker` `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109747
2021-03-26 09:21:12 +00:00
c15083e2e7
Bug 1700051: part 11) Change `mozInlineSpellStatus::InitForRange` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109746
2021-03-26 09:21:12 +00:00
7d02c05467
Bug 1700051: part 10) Change `mozInlineSpellStatus::InitForSelection` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109745
2021-03-26 09:21:11 +00:00
ad87ef090b
Bug 1700051: part 9) Change `mozInlineSpellStatus::CreateForNavigation` to return `Result<...,...>`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109744
2021-03-26 09:21:11 +00:00
5dde374aaf
Bug 1700051: part 8) Change `mozInlineSpellStatus::InitForNavigation` to static factory method. r=smaug
...
The next part changes its return type to `Result<..., nsresult>`.
Differential Revision: https://phabricator.services.mozilla.com/D109743
2021-03-26 09:21:11 +00:00
d38cbe5571
Bug 1700051: part 7) Change `mozInlineSpellStatus::CreateForEditorChange` to return `Result<..., ...>`. r=smaug
...
Separates input from output more clearly.
Differential Revision: https://phabricator.services.mozilla.com/D109742
2021-03-26 09:21:10 +00:00
daed84a8f4
Bug 1700051: part 6) Change `mozInlineSpellStatus::InitForEditorChange` to static factory method. r=smaug
...
Preparation so that some members of `mozInlineSpellStatus` can become
`const`-qualified.
The method's return value will be changed to
`Result<UniquePtr<mozInlineSpellStatus>, nsresult>>` in a separate
review.
Differential Revision: https://phabricator.services.mozilla.com/D109741
2021-03-26 09:21:10 +00:00
00a2d5f7d4
Bug 1675614 - Process spellcheck in chunks in the parent process, since it's also async. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D109692
2021-03-26 04:19:46 +00:00
cc730d05dd
Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108588
2021-03-24 17:56:50 +00:00
613e20d136
Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
0954ebd22d
Bug 708901 - Migrate to nsTHashSet in extensions/spellcheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109335
2021-03-24 17:56:49 +00:00
Mirko Brodesser
Valentin Gosu
Masayuki Nakano
Dylan Roeh
Butkovits Atila
Deian Stefan
Dorel Luca
Paul Zuehlcke
Alexandru Michis
Brindusan Cristian
Sandor Molnar
Andi-Bogdan Postelnicu
Joel Maher
Matt Woodrow
Simon Giesecke