Граф коммитов

9 Коммитов

Автор SHA1 Сообщение Дата
Kyle Huey 1a61e70130 Bug 757284: Restore Blob.mozSlice, with a deprecation warning. r=sicking 2012-05-25 11:44:38 -07:00
Masatoshi Kimura 396343dd66 Bug 721569 - Tests. r=sicking
--HG--
rename : content/base/test/test_blobbuilder.html => content/base/test/test_blobconstructor.html
2012-03-12 21:45:00 -07:00
Dão Gottwald 635a192024 Bug 725289 followup, replace remaining mozSlize with slice 2012-02-16 12:43:08 +01:00
Matthew Schranz 5e505cd07f Bug 725289 - Removed moz prefix in Blob.mozSlice. r=sicking
--HG--
rename : dom/workers/test/fileReadMozSlice_worker.js => dom/workers/test/fileReadSlice_worker.js
rename : dom/workers/test/fileMozSlice_worker.js => dom/workers/test/fileSlice_worker.js
rename : dom/workers/test/test_fileReadMozSlice.xul => dom/workers/test/test_fileReadSlice.xul
rename : dom/workers/test/test_fileMozSlice.xul => dom/workers/test/test_fileSlice.xul
2012-02-16 11:22:25 +01:00
Jonas Sicking 904c1e5607 Bug 669433 Part 3: Make first argument to Blob.slice optional and defaulting to 0. r=khuey 2011-07-11 19:41:55 -07:00
Jonas Sicking 4e6a9c5461 Bug 649150: Make sure that all blobs and files sent using FormData have a filename in the encoded submission. r=mounir 2011-06-29 11:03:36 -07:00
Kyle Huey 27d8e6cbb0 Bug 648997: Implement BlobBuilder spec as MozBlobBuilder. r=sicking.
Note that there is one key difference between this implementation and the spec.  In this patch MozBlobBuilder.getBlob("content/type"); returns a Blob and clears the MozBlobBuilder.  In the spec the BlobBuilder is not cleared.  Thus,

let bb = new MozBlobBuilder();
MozBlobBuilder.append("foo");
let blob1 = MozBlobBuilder.getBlob("content/type");
// blob1 contains "foo"
MozBlobBuilder.append("bar");
let blob2 = MozBlobBuilder.getBlob("content/type");
// blob2 contains "bar", the spec says it should contain "foobar".

IMO, the spec behavior optimizes for the wrong case.  BlobBuilder will probably be used mostly as a one-shot API.  Additionally, the spec requires the BlobBuilder to hang on to potentially large amounts of memory between the getBlob() call and when the BlobBuilder is GCd.

These issues have been raised on the listserv.
2011-05-20 10:18:45 -07:00
Kyle Huey 18e6d04d41 Backed out changeset b8404a1d3153 2011-05-20 17:00:13 -07:00
Kyle Huey c8f3d0d068 Bug 648997: Implement BlobBuilder spec as mozBlobBuilder. r=sicking.
Note that there is one key difference between this implementation and the spec.  In this patch mozBlobBuilder.getBlob("content/type"); returns a Blob and clears the mozBlobBuilder.  In the spec the BlobBuilder is not cleared.  Thus,

let bb = new mozBlobBuilder();
mozBlobBuilder.append("foo");
let blob1 = mozBlobBuilder.getBlob("content/type");
// blob1 contains "foo"
mozBlobBuilder.append("bar");
let blob2 = mozBlobBuilder.getBlob("content/type");
// blob2 contains "bar", the spec says it should contain "foobar".

IMO, the spec behavior optimizes for the wrong case.  BlobBuilder will probably be used mostly as a one-shot API.  Additionally, the spec requires the BlobBuilder to hang on to potentially large amounts of memory between the getBlob() call and when the BlobBuilder is GCd.

These issues have been raised on the listserv.
2011-05-20 10:18:45 -07:00