Граф коммитов

21652 Коммитов

Автор SHA1 Сообщение Дата
Alexandre Poirot 24fa559f26 Bug 1620280 - [devtools] Wait for source actor when fetching frames. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90429
2020-10-01 14:22:38 +00:00
Alexandre Poirot db80068f12 Bug 1620280 - [devtools] Simplify things around sourceLoading promise. r=jdescottes
This was relevant before as we were calling "ThreadActor.getSources"/"StyleSheets.getStyleSheets",
and by the time these requests resolved, we would have navigated to a new URL and need to ignore their response.
I think it is safe to drop this now as these requests may still be pending if we use legacy listeners,
but the call to unwatchResources should immediately unregister _onResourceAvailable and ignore any pending data
coming late.

Differential Revision: https://phabricator.services.mozilla.com/D90428
2020-10-01 14:22:36 +00:00
Alexandre Poirot 5a5149d736 Bug 1620280 - [devtools] Ensure calling unwatchResources. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90427
2020-10-01 14:22:31 +00:00
Alexandre Poirot 2cf7b7a8e4 Bug 1620280 - [devtools] Convert SourceMapService to use SOURCE resource. r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D88298
2020-10-01 14:22:23 +00:00
Alexandre Poirot 4367d1b79f Bug 1620280 - [devtools] Implement and use a SOURCE resource. r=jdescottes,bomsy,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D86916
2020-10-01 14:22:21 +00:00
Olli Pettay 8a508eaa66 Bug 1668357 - Disable tests which fail when fission and session-history-in-parent are enabled, r=peterv,marionette-reviewers,whimboo
In many cases with wpt, most of the tests in the file pass, but it is rather time consuming to annotate
.ini files case by case.

Differential Revision: https://phabricator.services.mozilla.com/D91977
2020-10-01 10:23:47 +00:00
Alexandre Poirot afb3e68613 Bug 1654587 - [devtools] Remove now-unused async-storage and async-store-helper modules. r=jdescottes,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D91737
2020-09-30 17:43:13 +00:00
Alexandre Poirot ccb945702d Bug 1654587 - [devtools] Use a shared asyncStore instance between Debugger Frontend and TargetMixin. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91736
2020-09-30 17:42:28 +00:00
Nicolas Chevobbe cf8a17b642 Bug 1668271 - [devtools] Fix variable name in sources.js. r=bomsy.
We rename soureActor to a proper sourceActor.

Depends on D91934

Differential Revision: https://phabricator.services.mozilla.com/D91935
2020-10-01 06:36:19 +00:00
Nicolas Chevobbe 9f48da9ccd Bug 1668271 - [devtools] Remove unused insertSourceActor function in source-actors.js .r=bomsy.
The function isn't used anywhere in the codebase, so we can safely remove it.

Differential Revision: https://phabricator.services.mozilla.com/D91934
2020-10-01 06:35:19 +00:00
Alexandre Poirot 774d67d856 Bug 1667999 - [devtools] Remove unused devtools-modules's modules. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91889
2020-09-30 17:42:56 +00:00
Alexandre Poirot 2a02be0b6f Bug 1667999 - [devtools] Land in-tree devtools-environment package. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91735
2020-09-30 17:40:11 +00:00
Alexandre Poirot 32bcd00441 Bug 1667999 - [devtools] Land in-tree devtools-contextmenu package. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91734
2020-09-30 17:38:58 +00:00
Alexandre Poirot 2daa29851f Bug 1667999 - [devtools] Land in-tree devtools-config package. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91733
2020-09-30 17:39:01 +00:00
Alexandre Poirot eb3020eed5 Bug 1667999 - [devtools] Land in-tree devtools-modules package. r=jdescottes
/!\ in order to take the new package in packages/ folder in account,
you have to run `yarn` before `node bin/bundle.js`

Differential Revision: https://phabricator.services.mozilla.com/D91732
2020-09-30 17:38:50 +00:00
Alexandre Poirot d7ed96dfed Bug 1667999 - [devtools] Update devtools bundles. r=jdescottes,nchevobbe
This is done by doing:
$ cd devtools/client/debugger
$ yarn
$ node bin/bundle.js

I'm doing this first in order to better highlight the impact of introduce new packages in-tree.

Differential Revision: https://phabricator.services.mozilla.com/D91731
2020-09-30 16:34:27 +00:00
Nicolas Chevobbe 6e140506a1 Bug 1662734 - [devtools] Create an actual WorkerTargetActor and use it in startup/worker.js . r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This patch adds a simple WorkerTargetActor, which is similar to the mock target
actor we had in startup/worker.js.

Its spec file is empty at the moment, and it does not have an associated front,
but that might change with Bug 1633712 where we will at least have events for
resources available/destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D91128
2020-09-29 14:47:34 +00:00
Nicolas Chevobbe 056b9542f2 Bug 1573779 - [devtools] Rename WorkerTargetActorList to WorkerDescriptorActorList. r=jdescottes.
This class is creating (and handling) WorkerDescriptorActor now, so we rename
it to make it explicit.

Differential Revision: https://phabricator.services.mozilla.com/D91557
2020-09-29 14:31:10 +00:00
Nicolas Chevobbe f315ff58cd Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-29 14:30:24 +00:00
Dorel Luca f826d52619 Backed out 3 changesets (bug 1573779, bug 1662734) for Geckoview failures. CLOSED TREE
Backed out changeset 0adff4f08b28 (bug 1662734)
Backed out changeset c6bb84f2a032 (bug 1573779)
Backed out changeset 0c605800aa6b (bug 1573779)
2020-09-29 12:59:39 +03:00
Tom Schuster 002deb9621 Bug 1645284 - When taking a fullscreen screenshot accept any DPR, but try again when too large. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D91508
2020-09-29 06:13:54 +00:00
Nicolas Chevobbe 68ba8f3d46 Bug 1662734 - [devtools] Create an actual WorkerTargetActor and use it in startup/worker.js . r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This patch adds a simple WorkerTargetActor, which is similar to the mock target
actor we had in startup/worker.js.

Its spec file is empty at the moment, and it does not have an associated front,
but that might change with Bug 1633712 where we will at least have events for
resources available/destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D91128
2020-09-28 12:29:11 +00:00
Nicolas Chevobbe bda0dabd83 Bug 1573779 - [devtools] Rename WorkerTargetActorList to WorkerDescriptorActorList. r=jdescottes.
This class is creating (and handling) WorkerDescriptorActor now, so we rename
it to make it explicit.

Differential Revision: https://phabricator.services.mozilla.com/D91557
2020-09-29 01:54:32 +00:00
Nicolas Chevobbe 4914f8c614 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-28 12:27:22 +00:00
Frederic Wang 0eebca3c33 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-26 03:04:56 +00:00
Narcis Beleuzu 679469fad8 Backed out changeset 239f29a99c4f (bug 1667118) for bc failure on browser_parsable_css.js . CLOSED TREE 2020-09-25 23:39:15 +03:00
Frederic Wang 5461921d85 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-25 18:37:39 +00:00
Mihai Alexandru Michis cc04d2696e Backed out changeset b08319695e21 (bug 1667118) for causing xpcshell failures in test_css-properties-db.js
CLOSED TREE
2020-09-25 16:40:33 +03:00
Frederic Wang eb4b491896 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-25 12:04:53 +00:00
Julian Descottes 4fd39a83f2 Bug 1618693 - [devtools] Remove LocalTabTargetFront and move localtab logic to TabDescriptorFront r=ochameau
The goal of this revision is to unify the various tab & frame target fronts on the client side so that they are all simple instances of BrowsingContextTargetFront.
This will simplify https://bugzilla.mozilla.org/show_bug.cgi?id=1644397 . At the moment all targets emitted by the watcher are turned into BrowsingContextTargetFront by target list (https://searchfox.org/mozilla-central/rev/35d927df97900a57ecb562ad13909e392440b0fb/devtools/client/fronts/watcher.js#37). Removing `LocalTabTargetFront` means we don't have to introduce this concept to TargetList.

The first top target of a content toolbox will be a BrowsingContextTargetFront, same as all the future ones, even if they are provided by the watcher.

Differential Revision: https://phabricator.services.mozilla.com/D91106
2020-09-25 09:55:14 +00:00
Kris Maglione bbfbd2f113 Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-25 02:01:15 +00:00
Razvan Maries ed260c95a0 Backed out changeset 08538390d573 (bug 1667118) for perma failures on test_css-properties-db.js. CLOSED TREE 2020-09-25 00:12:10 +03:00
Razvan Maries 8de1e9f262 Backed out changeset 737f0e3e2f94 (bug 1660057) for xpcshell perma failures. CLOSED TREE 2020-09-24 23:25:54 +03:00
Frederic Wang c828ccef71 Bug 1667118 - Rename -moz-math-script-level to math-depth. r=emilio
This renames the internal -moz-math-script-level property in order to
prepare for full math-depth support. Currently, the property is guarded
under a disabled-by-default flag, so there should be no observable
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D91285
2020-09-24 18:44:41 +00:00
Kris Maglione 04dc79653a Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-24 18:35:58 +00:00
Nicolas Chevobbe 2129e51ab1 Bug 1662522 - Fix browser_jsterm_evaluation_context_selector.js failures. r=bomsy.
In Bug 1660416, the separator element in the list of context was turned
into an hr element. But the test helper that checks the list wasn't updated,
which made the test fail (the test only runs when fission is enabled, which
is why it wasn't backed-out).
This patch fixes the helper by  retrieving hr elements from the list.

Differential Revision: https://phabricator.services.mozilla.com/D90820
2020-09-24 10:47:08 +00:00
Alexandre Poirot fe0eb445f3 Bug 1663614 - Wait for state instead of TRACK_CHANGE events. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D91114
2020-09-24 07:11:28 +00:00
Alexandre Poirot a326ee8f09 Bug 1663614 - Throttle resources on the client side from ResourceWatcher. r=jdescottes,bomsy
Because of this, in netmonitor stubs tests, the resource objects ends up loosing
"intermediate" state and now contains all information that we gathered by the time
we emit throttled resources.
The only way to address that would be to do an archived copy of each resource state,
but I don't think we want to do that...

Differential Revision: https://phabricator.services.mozilla.com/D89628
2020-09-24 11:04:57 +00:00
Alexandre Poirot 5406b6049d Bug 1663614 - Do not use EventEmitter API in ResourceWatcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90259
2020-09-24 07:11:18 +00:00
Kyle Knaggs 6f5a5f833b Bug 1664531 - Adds placeholder text to the CodeMirror instances used to create conditional breakpoints and logpoints r=bomsy
Before this patch the CodeMirror instance used to create Conditional Breakpoints and Logpoints did not have placeholder text.

This patch adds placeholder text to this CodeMirror instance by:

1. Adding the CodeMirror addon responsible for creating placeholder text.
2. Updating `webpack.config.js`.
3. Regenerating `codemirror.bundle.js`.
4. Matching the color of the placholder text in these CodeMirror instances to the color of placeholder text in the rest of the Debugger.

{F2456834}

Differential Revision: https://phabricator.services.mozilla.com/D89962
2020-09-20 23:01:28 +00:00
Alexandre Poirot fad9e1690b Bug 1663649 - [devtools] Enable target switching by default. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D91020
2020-09-23 17:50:20 +00:00
Frederic Wang aec8cecc03 Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-23 13:04:48 +00:00
Alexandre Poirot 3dad2d6583 Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D90394
2020-09-23 11:29:38 +00:00
Alexandre Poirot 1ce63dfa6b Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes
This help modifying redux state only once and prevent many uncesarry copies of the whole messages/network events Maps.
This will also later help getting rid of WebConsoleWrapper throttling in favor of upcoming ResourceWatcher one,
as we could call only one action from onResourceAvailable/Updated.

Differential Revision: https://phabricator.services.mozilla.com/D90367
2020-09-23 11:29:30 +00:00
Narcis Beleuzu 85b4b24cfc Backed out changeset 9480237e1e6f (bug 1665975) for xpcshell failure on test_css-properties-db.js. CLOSED TREE 2020-09-23 13:06:21 +03:00
Frederic Wang ff5e02320a Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-23 08:14:38 +00:00
Nicolas Chevobbe 224212d3d4 Bug 1607569 - Re-enable browser_console_webconsole_private_browsing.js. r=ochameau.
It looks like the issue it was disabled for no longer exists.

Differential Revision: https://phabricator.services.mozilla.com/D90845
2020-09-22 05:19:43 +00:00
Nicolas Chevobbe 35d927df97 Bug 1664493 - Add a test for logging in RDM. r=bradwerth.
This wasn't tested before, and a regression slipped through (that was luckily
fixed by Bug 1664493).
This should prevent future breakages.

Differential Revision: https://phabricator.services.mozilla.com/D90880
2020-09-21 15:29:01 +00:00
Itiel e44be6b134 Bug 1631202 - Convert all uses of :-moz-any to :is in devtools/ r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D90692
2020-09-21 19:35:23 +00:00
Alexandre Poirot 5c7bbf87ee Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes
This will ultimately help get rid of throttling done in WebConsoleWrapper
in favor of the upcoming one to be done from ResourceWatcher.

Differential Revision: https://phabricator.services.mozilla.com/D90366
2020-09-21 16:46:42 +00:00
Alexandre Poirot 2ab106a0fc Bug 1665709 - Use same listener for NETWORK_EVENT and NETWORK_EVENT_STACKTRACE in order to guarantee event order. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D90288
2020-09-21 16:46:40 +00:00
Kriyszig f56222395b Bug 1659516 - Remove compatibility.css import in tooltip.css that leads to the css being loaded twice r=mtigley,daisuke
If we open the Compatibility panel, the rules panel ill import the
tooltip.css for rendering the tooltips. However, the tooptip.css
imports compatibility.css and now the styles are not only unnecessarily
parsed but also on opening the Compatiblity panel, this stylesheet is
loaded and parsed again leading to the stylesheet
being loaded twice and hence these styles are applied twice for
each element in the compatibility panel unnecessarily.
We get all the necessary styles for the compatibility tooltip into
the tooltip.css (adding the necessary changes needed to handle the
color differences in the background) and remove the import of the
external compatibility.css

Differential Revision: https://phabricator.services.mozilla.com/D90533
2020-09-21 15:36:29 +00:00
Kyle Knaggs 34c6a27d2f Bug 1659565 - Add padding and prevent vertical bounce in the Watch Expressions and XHR Breakpoints panes r=bomsy
Before this patch, there were some UX polish issues present in both the Watch Expressions and the XHR Breakpoints pane. These issues were:
1. Whenever a list of elements was displayed in either of these panes it did not possess the `4px` of vertical `padding` that is typical of lists in the Debugger.
2. The Add Watch Expression input was often not removed from the UI until after the updated list of Watch Expressions was rendered.
3. Whenever a user attempts to edit an existing Watch Expression or XHR Breakpoint they experienced significant "vertical bounce" due to a difference in height between the original markup and the form that replaced it.

This patch addresses these issues by:
1. Relocating the inputs used to create new Watch Expressions and XHR Breakpoints outside of the `<ul>` elements in these panes.
2. Relocating the `hideInput()` function call to `componentWillReceiveProps()` ensuring that the Add Watch Expression input does not persist after the list of Watch Expressions has been updated.
3. Modifying the height of the forms used to edit existing Watch Expressions and XHR Breakpoints so that there is no vertical bounce whenever a user attempts to edit an existing Watch Expression or XHR Breakpoint.

In addition to these changes, Snapshot tests and Mochitest selectors were updated where relevant while minor refactors were also done in order to improve the legibility of the code.

{F2447136}

Differential Revision: https://phabricator.services.mozilla.com/D88101
2020-09-21 14:23:39 +00:00
Nicolas Chevobbe 2486f9106a Bug 1665505 - Check that highlighter isn't destroyed before calling finalize. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D90854
2020-09-21 13:27:05 +00:00
Bogdan Tara 2991b8c066 Backed out changeset 0da5103ba772 (bug 1665975) for mozglue_static::panic_hook mass crashes CLOSED TREE 2020-09-21 10:07:03 +03:00
Frederic Wang 1ac695dbdc Bug 1665975 - Implement the math-style property. r=emilio
This patch renames the internal -moz-math-display to math-style and
exposes it under the layout.css.math-style.enabled preference. The
initial value becomes "normal" but that does not affect the default
MathML behavior since the UA style sheet sets the math-style property
explicitly on <math> tags. WPT tests are updated to use the syntax
approved by the CSSWG.

Intent to prototype: https://groups.google.com/forum/#!msg/mozilla.dev.platform/1hQQ7ISudGo/_yLEckEeBQAJ

Differential Revision: https://phabricator.services.mozilla.com/D90731
2020-09-21 05:41:51 +00:00
Ben b9ef9df4b8 Bug 1606626 - Implement STOMP WebSocket message parsing. r=Honza,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D89265
2020-09-20 16:30:59 +00:00
Cristina Coroiu 94d6bce87e Bug 1518675 - disable browser_flexbox_container_and_item_accordion_state.js on linux and win for frequent failures r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D90785
2020-09-19 10:08:36 +00:00
Julian Descottes b1e5acf772 Bug 1665547 - [devtools] Throttle calls to _selectColor in SwatchColorPickerTooltip r=rcaliman
This revision introduces throttling for the color picker widget used in the DevTools Inspector Rules view.

The color picker widget can emit a lot a requests when clicking and dragging the mouse on the color "palette".
Locally I measured up to 200 requests per second. Since each request needs to apply the color to the element before the next request can be processed, this results in a bad user experience where requests will keep being applied for several seconds after the user finished using the widget.

Using throttling allows to cap the number of requests we emit, while still making sure the last value is correctly sent to the server.

Differential Revision: https://phabricator.services.mozilla.com/D90530
2020-09-18 15:01:52 +00:00
Razvan Caliman 20a40b7e0a Bug 1572662 - Remove unnecessary getRuleViewSelectorHighlighterIcon() from tests r=jdescottes
Depends on D90249

These calls to `getRuleViewSelectorHighlighterIcon` appear to [wait for the selector icon to be generated](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/rules/views/rule-editor.js#162-197) from an async operation. But they don't test anything to do with that DOM structure. Test seem to pass without it.

Differential Revision: https://phabricator.services.mozilla.com/D90250
2020-09-16 14:40:11 +00:00
Razvan Caliman 4137708c26 Bug 1572662 - Update tests for SelectorHighlighter r=jdescottes
Depends on D90248

This patch combines two test helpers into one: removes `getRuleViewSelectorHighlighterIcon()` and folds its logic into `clickSelectorIcon()`.
The other callsites for `getRuleViewSelectorHighlighterIcon()` are removed in D90250.

The augmented `clickSelectorIcon()` will toggle the selector highlighter accordingly (on or off for the given selector depending on its current state). It returns a promise that resolves with the event data from either the "highlighter-hidden" or "highlighter-shown" events emitted by the selector highlighter. Tests check this data for the expected results.

Tests no longer use mocks for selector highlighter. They test the real thing.

Differential Revision: https://phabricator.services.mozilla.com/D90249
2020-09-17 14:00:38 +00:00
Razvan Caliman bfb2186d26 Bug 1572662 - Update logic to toggle SelectorHighlighter from the new React-based Rules view r=jdescottes
Depends on D90247

The new React-based Rules view is a stalled project, but not yet abandoned.
This patch updates the logic to toggle the selector highlighter so it doesn't fall too far behind in parity with the legacy but still active Rules view.

Flip this pref to test the new Rules view: `devtools.inspector.new-rulesview.enabled`.
It will add a new Rules panel to the Inspector sidebar at the far right end of the tabs.
To avoid confusion and bugs, disable 3-pane mode so you only see one Inspector sidebar panel at a time.

Differential Revision: https://phabricator.services.mozilla.com/D90248
2020-09-17 12:43:16 +00:00
Razvan Caliman ebfa44cb82 Bug 1572662 - Update logic to toggle SelectorHighlighter from Rules view r=jdescottes
Depends on D90246

This patch updates the logic to toggle the selector highlighter (icon next to CSS selectors in the Rules view) using the process-agnostic approach introduced in `HighlightersOverlay`.

There are 3 main chunks of logic:

- A) Introduce event delegation in the Rules view (`CssRuleView.handleEvent()`)
- B) Introduce generic handler for highligther events in Rules view (`CssRuleView.handleHighlighterEvent()`)
- C) Toggle the selector highlighter using the `HighlightersOverlay.showHighlighterTypeForNode()`/`HighlightersOverlay.hideHighlighterType()` methods with the `SELECTOR` highlighter type.

### Part A
With Part A, CssRuleView.handleEvent(), we're laying the groundwork to have the Rules view react to events within its DOM tree.

Currently, `HighlightersOverlay` is doing too much. Along with managing highlighters, it acts as an event delegate for the Rules view and Computed view via [HighlightersOverlay.addToView()](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/shared/highlighters-overlay.js#415-428). This adds [cumbersome logic to check the target](https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/devtools/client/inspector/shared/highlighters-overlay.js#1402-1428) of an event in order to know whether to react to it. This isn't wrong per-se, but it concentrates DOM knowledge from a broad part of the Inspector away from where it is generated.

Ideally, `HighlightersOverlay` should only manage highlighters. It should be called from various endpoints without regard to who is calling and in reaction to which events.

The intent is to reuse this `CssRuleView.handleEvent()` for:
- toggling the CSS Transforms Highlighter by reacting to mouseover events from corresponding CSS values
- toggling the Flexbox / Grid / Shapes highlighters by reacting to clicks on corresponding swatch icons next to CSS values

### Part B
Part B, `CssRuleView.handleHighlighterEvent()`, adds a generic highlighter event handler to the Rules view. Checking the event name and highlighter type, the Rules view can update itself in reaction to highlighters triggered from elsewhere in the Inspector.

In this patch, we're using it to toggle the active CSS class name on the selector highlighter icon in response to "highlighter-shown" / "highlighter-hidden" events of the `SELECTOR` highlighter type.

Probably a bit overkill here. But it gets more useful with the Flexbox and Grid Highlighters which have call sites in multiple places with indicators that need to be reconciled:

- Flex/Grid badges in Markup view
- Checkboxes in Layout panel
- Swatch icons for Flex and Grid in Rules view

### Part C
Part C replaces the legacy toggling logic for selector highlighter with the abstract methods in `HighligthersOverlay`, does some slight clean-up, and fixes some bugs in the previous implementation.

All CSS rules matching the same selector will be marked when the selector is active (see inline comment)
When editing a selector, the selector highlighter for another CSS rule will no longer be hidden (see inline comment)

Differential Revision: https://phabricator.services.mozilla.com/D90247
2020-09-18 10:34:08 +00:00
Razvan Caliman f36f05b770 Bug 1572662 - Clean-up SelectorHighlighter and clarify code comments r=jdescottes
Depends on D90245

Differential Revision: https://phabricator.services.mozilla.com/D90246
2020-09-16 10:09:11 +00:00
Razvan Caliman 020ea4af5e Bug 1572662 - Remove unused option to customize fill color on SelectorHighlighter and BoxModelHighlighter r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90245
2020-09-16 13:43:57 +00:00
Brindusan Cristian 66762b6cd1 Backed out 3 changesets (bug 1665306, bug 1665305, bug 1665293) for dt failures at browser_webconsole_network_attach.js. CLOSED TREE
Backed out changeset 5d5f176f7231 (bug 1665306)
Backed out changeset 241fc01aced8 (bug 1665305)
Backed out changeset 5055331a7b6e (bug 1665293)
2020-09-18 10:40:54 +03:00
Alexandre Poirot 759d42fc7d Bug 1665306 - Process "network updates" in console with only one `networkUpdateRequest` action call. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90394
2020-09-17 17:51:56 +00:00
Alexandre Poirot 2e59c20206 Bug 1665305 - Process "message network updates" in console with only one `networkMessageUpdate` action call. r=jdescottes
This help modifying redux state only once and prevent many uncesarry copies of the whole messages/network events Maps.
This will also later help getting rid of WebConsoleWrapper throttling in favor of upcoming ResourceWatcher one,
as we could call only one action from onResourceAvailable/Updated.

Differential Revision: https://phabricator.services.mozilla.com/D90367
2020-09-17 16:39:27 +00:00
Alexandre Poirot d2243d5672 Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes
This will ultimately help get rid of throttling done in WebConsoleWrapper
in favor of the upcoming one to be done from ResourceWatcher.

Differential Revision: https://phabricator.services.mozilla.com/D90366
2020-09-17 15:28:43 +00:00
Olli Pettay 3f30b17ab9 Bug 1665165 - Disable some bfcache tests on Fission, r=jesup
Differential Revision: https://phabricator.services.mozilla.com/D90303
2020-09-17 17:36:24 +00:00
Anurag Aggarwal 8d0f4c8eca Bug 1536103 - Removed some unused devtools in tree placeholder documentation.r=firefox-source-docs-reviewers,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D73499
2020-05-01 20:22:02 +00:00
Dorel Luca 72ef712fd0 Backed out 10 changesets (bug 1518999) for GeckoView failures in PanZoomControllerTest.scroll. CLOSED TREE
Backed out changeset 7b5bdd071d05 (bug 1518999)
Backed out changeset 401e488734dd (bug 1518999)
Backed out changeset c13e51e17329 (bug 1518999)
Backed out changeset 2a2d67ba15b8 (bug 1518999)
Backed out changeset 3d4d84003227 (bug 1518999)
Backed out changeset 972731762965 (bug 1518999)
Backed out changeset f21b13582dad (bug 1518999)
Backed out changeset 13a4c749a802 (bug 1518999)
Backed out changeset 5a6cea5fd344 (bug 1518999)
Backed out changeset c3bb552e76a3 (bug 1518999)
2020-09-17 02:58:34 +03:00
Sean Feng 98c02ed2b5 Bug 1518999 - Refactor some performance.getEntries related tests r=mstange
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.

Depends on D66463

Differential Revision: https://phabricator.services.mozilla.com/D68645
2020-09-10 19:11:44 +00:00
Julian Descottes cd81a91915 Bug 1664821 - Remove What's New panel r=ochameau,Honza
Differential Revision: https://phabricator.services.mozilla.com/D90443
2020-09-16 16:43:10 +00:00
Razvan Caliman 8f69605f28 Bug 1665341 - Remove obsolete BoxModelRenderer. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90402
2020-09-16 14:05:30 +00:00
Alexandre Poirot e42450ee93 Bug 1664438 - Ignore errors when destroying target scoped fronts. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90237
2020-09-16 08:15:03 +00:00
Alexandre Poirot 2e547c4dcf Bug 1664438 - Destroy pending protocol.js requests when a remote connector closes. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D90236
2020-09-16 08:15:01 +00:00
Kriyszig d79006ce23 Bug 1653520 - Remove code replication in the compatibility actor by moving UserSettings to shared folder r=daisuke,mtigley,devtools-backward-compat-reviewers
Instead of replicationg the browser list fetch using the
preference on the server side, we send the browser list from the
client side to the CompatibilityActor to get the declaration block
compatibility issues.
This way the pref setting is retained completely on the client
side and server doesn't have code duplication.

Differential Revision: https://phabricator.services.mozilla.com/D87613
2020-09-15 14:26:39 +00:00
Kriyszig da1f86f883 Bug 1657537 - Part 2 - Move MDNCompatibility library and related files to devtools/server/actors/compatibility r=daisuke,mtigley
This moves the MDNCompatibility library and the related datasets
and tests to the server side. It also moves the compatibility actor
file intot he compatibility directory.
The links to these files have been updated and the library tests have
been moved to the new location.

Differential Revision: https://phabricator.services.mozilla.com/D86521
2020-09-15 14:26:36 +00:00
Kriyszig 4825b53af6 Bug 1657537 - Part 1 - Move the ISSUE_TYPE property to devtools/shared/constants.js r=mtigley
Most of the client side imports from the MDNCompatibility library
is to access the MDNCompatibility.ISSUE_TYPE property.
This patch moves the property into devtools/shared/constants.js
from where it can be accessed on both the client and server side.

Differential Revision: https://phabricator.services.mozilla.com/D86519
2020-09-15 14:26:23 +00:00
Razvan Maries 2332c87b6a Bug 1661612 - Disabled browser_net_persistent_logs.js on all platforms. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D90016
2020-09-14 13:54:21 +00:00
Hubert Boma Manilla b6435b8ee8 Bug 1663979 - Theme support for messages raw section r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D90260
2020-09-15 14:49:06 +00:00
Hubert Boma Manilla 795fbdf4ae Bug 1661709 - Test for requests blocked by extensions r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D89309
2020-09-15 11:17:19 +00:00
Daisuke Akatsuka d22402eef0 Bug 1644193: Update stylesheeet watcher test. r=ochameau
Depends on D89283

Differential Revision: https://phabricator.services.mozilla.com/D89884
2020-09-14 23:35:19 +00:00
Daisuke Akatsuka aa9f77e93e Bug 1644193: Make walker.getStyleSheetOwnerNode() to reflect resource watcher. r=ochameau
Depends on D89282

Differential Revision: https://phabricator.services.mozilla.com/D89283
2020-09-14 23:37:39 +00:00
Daisuke Akatsuka 581ea9af20 Bug 1644193: Implement addStyleSheet function. r=ochameau,devtools-backward-compat-reviewers
Depends on D89280

Differential Revision: https://phabricator.services.mozilla.com/D89281
2020-09-14 23:37:39 +00:00
Daisuke Akatsuka eb8b319b2c Bug 1644193: Reflect added stylesheets. r=ochameau
Depends on D89277

Differential Revision: https://phabricator.services.mozilla.com/D89280
2020-09-11 08:11:08 +00:00
Daisuke Akatsuka 1a2e261447 Bug 1644193: Implement update function. r=ochameau
Depends on D88540

Differential Revision: https://phabricator.services.mozilla.com/D89277
2020-09-11 08:10:25 +00:00
Daisuke Akatsuka 3908e7a6d9 Bug 1644193: Implement basic server-side stylesheets watcher. r=ochameau
Depends on D88531

Differential Revision: https://phabricator.services.mozilla.com/D88540
2020-09-14 21:29:47 +00:00
Daisuke Akatsuka 1b9df15f05 Bug 1644193: Make media rules to be resource based. r=ochameau
Depends on D88759

Differential Revision: https://phabricator.services.mozilla.com/D89106
2020-09-09 03:57:49 +00:00
Daisuke Akatsuka 3fd81e0284 Bug 1664842: Introduce async watch function. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D88759
2020-09-14 21:12:52 +00:00
Julian Descottes ab325d894c Bug 1664437 - Fix uri logging in WindowGlobalLogger r=ochameau
Depends on D89909

Differential Revision: https://phabricator.services.mozilla.com/D89910
2020-09-14 17:02:31 +00:00
Julian Descottes 7ad7cc6bec Bug 1664437 - Update WindowGlobalLogger to format logs on several lines r=ochameau
Depends on D89908

Differential Revision: https://phabricator.services.mozilla.com/D89909
2020-09-14 17:01:46 +00:00
Julian Descottes 7bad920441 Bug 1664437 - Extract DevTools WindowGlobalLogger to a dedicated module r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89908
2020-09-14 16:53:08 +00:00
Christoph Kerschbaumer c5f8f358db Bug 1664393: Load all images in reps/ in devtools using chrome:. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89883
2020-09-14 12:24:07 +00:00
Alexandre Poirot f7030caf73 Bug 1663877 - Wait for EVENT_TIMINGS, even when netmonitor is filtering. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D89595
2020-09-13 19:10:05 +00:00
Alexandre Poirot 558845f4c3 Bug 1663875 - Wait for the request completion in WebSocket test. r=bomsy
These tests was racy, but I couldn't find any opened intermittent on bugzilla?

Differential Revision: https://phabricator.services.mozilla.com/D89569
2020-09-13 12:48:09 +00:00
Jan de Mooij 927eea2c81 Bug 1663847 part 2 - Change Debugger.Environment.callee getter to calleeScript getter. r=tcampbell,jdescottes
The callee getter returned |undefined| for certain functions because it's
hard to recover the callee consistently for all environments (and we can't
return the internal canonical function). See also bug 1414684.

This patch fixes that by exposing the script instead of the callee. Devtools is
only interested in the displayName and parameterNames properties and those are
also available on scripts (the previous patch adds Script.parameterNames).

Differential Revision: https://phabricator.services.mozilla.com/D89701
2020-09-11 09:24:34 +00:00
Julian Descottes a66edac6cb Bug 1663941 - Do not call onAvailable if cached server resources are empty r=ochameau
Depends on D89609

Differential Revision: https://phabricator.services.mozilla.com/D89611
2020-09-10 20:52:39 +00:00
Julian Descottes 4512e67b05 Bug 1663941 - Do not call ResourceWatcher onAvailable callback with empty arrays of ressources r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89609
2020-09-09 15:03:21 +00:00
Christoph Kerschbaumer af3ae708f9 Bug 1664177: Load all images in devtools/client/debugger/images using chrome:. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89727
2020-09-10 17:04:35 +00:00
Razvan Caliman 6d25af4eda Bug 1646028 - Rename show/hide events for CssTransformHighlighter to avoid conflicts with generic highlighter events. r=jdescottes
Depends on D85863

Follow-up for code review https://phabricator.services.mozilla.com/D81526#inline-471516

Renaming existing events emitted on behalf of `CssTransformHighlighter` to avoid conflict and confusion with the generic show/hide highlighter events introduced in HighlightersOverlay. When migrating the CssTransformHighlighter to the Fission-ready highlighters approach, these event names will go away completely.

Differential Revision: https://phabricator.services.mozilla.com/D89570
2020-09-10 12:00:17 +00:00
Razvan Caliman 7a1fde5f19 Bug 1646028 - Hide the correct Box Model Highlighter before a node screenshot. r=jdescottes
Depends on D85862

Differential Revision: https://phabricator.services.mozilla.com/D85863
2020-09-10 11:57:58 +00:00
Razvan Caliman dc11adf8a2 Bug 1646028 - Fix Inspector tests using node reps to use Box Model Highlighter r=jdescottes
Depends on D85861

Differential Revision: https://phabricator.services.mozilla.com/D85862
2020-09-10 11:57:25 +00:00
Razvan Caliman b5059faeb3 Bug 1646028 - Update Animation Inspector to use Box Model Highlighter r=jdescottes
Depends on D85860

Differential Revision: https://phabricator.services.mozilla.com/D85861
2020-09-10 11:57:12 +00:00
Razvan Caliman c16d2d8551 Bug 1646028 - Update Box Model diagram to use Box Model Highlighter. r=jdescottes
Depends on D85859

The Box Model diagram in the Layout sidebar panel of the Inspector shows a Box Model Highlighter on hover over its components parts: margin, border, padding, content.

This patch routes the calls to the highlighter to use the approach introduced in `HighlightersOverlay` in D81526

Differential Revision: https://phabricator.services.mozilla.com/D85860
2020-09-10 11:57:09 +00:00
Razvan Caliman ee0de8141e Bug 1646028 - Update Markup view to use Box Model Highlighter. r=jdescottes
Depends on D85858

The Markup view uses the highlighter in a few places:
- while hovering over nodes in the node tree
- while hovering over nodes in the breadcrumbs view under the node tree
- after clicking a node from the node tree, a highlighter is shown, then it is automatically hidden after a delay

This patch routes all calls to show and hide the highlighter to the newly implemented approach in `HighlightersOverlay` which ensures hiding existing instances before showing others regardless of target.

A slight change is made in `HighlightersOverlay` to allow passing in an option to automatically hide the highlighter after a delay. This removes the need for discrete handling of timers within the markup view (removes [_brieflyShowBoxModel](https://searchfox.org/mozilla-central/source/devtools/client/inspector/markup/markup.js#742-756)) and enables reusing this mechanism with the Node Picker after picking (see `onPickerPicked` in [this diff](https://phabricator.services.mozilla.com/D81528?vs=321451&id=332813#toc) from D81528)

`HighlightersOverlay.showHighlighterTypeForNode()` no longer skips duplicate calls with the same highlighter type and nodeFront if the options provided are different between calls.  This supports scheduling autohide on an already visible highlighter. Use case: in the node tree, hover over a node (shows highlighter), then click on the node (shows highlighter again, but schedules autohide after a delay)

NOTE: This automatic hiding after a delay can cause intermittent test failures. Slow running tests can find themselves without a highlighter midway through the checks. To mitigate this, while testing, highlighters are not automatically hidden.  See `HIGHLIGHTER_AUTOHIDE_TIMER` in [this diff](https://phabricator.services.mozilla.com/D81528?vs=321451&id=332813#toc) from D81528. Tests which explicitly check the autohide behavior can reinstate `inspector.HIGHLIGHTER_AUTOHIDE_TIMER`.

Tests are updated to invoke actual highlighters and listen to their events. No more mocking.

Differential Revision: https://phabricator.services.mozilla.com/D85859
2020-09-10 11:55:57 +00:00
Razvan Caliman e66da30f07 Bug 1646028 - Add test helpers for waiting on highlighter events r=jdescottes
Depends on D81528

Differential Revision: https://phabricator.services.mozilla.com/D85858
2020-09-10 11:55:03 +00:00
Razvan Caliman c8f858e552 Bug 1646028 - Update Node Picker to use Box Model Highlighter. r=ochameau,jdescottes
Depends on D81526

This patch updates tests pertaining only to node picker behavior. Run one-by-one, they're all expected to pass.

However, running the whole Inspector test suite at this point in the commit series will fail some other tests because:
- we're updating shared test helpers here without also updating the other tests;
- there is inter-dependence in the other tests between node picker and markup view which is being migrated to the new highlighters approach in D81530

The rest of the tests are getting updated in the subsequent patches in this commit series.

Differential Revision: https://phabricator.services.mozilla.com/D81528
2020-09-10 11:54:25 +00:00
Razvan Caliman 8e4b6b2a5b Bug 1646028 - Add generic highlighter manager to HighlightersOverlay. r=ochameau
Depends on D81525

Introduced a centralized way in `HighlightersOverlay` to invoke highlighters by type, automatically managing previously active highlighters.

First some context.
`HighlightersOverlay` is a bit of a misnomer. It already does a few things:
- provides methods to manually invoke some highlighters (Flex/Grid/Shapes/BoxModel)
- provides a way to delegate mouse events from Rules view / Computed view / Markup and invoke highlighters based on the event's target node
- manages state of Flex/Grid highlighters to be able to restore them on page refresh
- exposes the node that is highlighted by a particular highlighter
- misc handlers for events that require hiding highlighters by type (ex mutation events)

The changes in this patch add the core functionality which will automatically manage the visibility of highlighters regardless of their node's host frame:
- `this._activeHighlighters` is a Map which maps a highlighter type to the currently visible highlighter instance and its corresponding `NodeFront`
- `showHighlighterTypeForNode(type, nodeFront, options)` invokes a highlighter type for a given `NodeFront` while toggling off any existing highlighter for that type. For situations where multiple highlighters of the same type can be visible at the same time (ex: Grid), this is where we could manage their visibility.
- `hideHighlighterType(type)` hides all highlighters of a given type; can be followed-up with a more specific `hideHighlighterTypeForNode()` when needed
- `getNodeForActiveHighlighter(type)` returns the `NodeFront` currently highlighted by a highlighter type. This is an abstracted replacement for `flexboxHighlighterShown`, `geometryEditorHighlighterShown`, etc.

##### Accommodation for tests

To mitigate the fact that many tests and some consumers expect [exact event names](https://searchfox.org/mozilla-central/search?path=&q=-highlighter-shown) to be fired, like "box-model-highlighter-shown", instead of generic shown/hidden events with the highlighter type property as event data, we introduce a temporary map, `HIGHLIGHTER_EVENTS`, from which we pick the event to fire according to the highlighter type. As we progress in refactoring, the intent is for this map to slowly go away.


##### Intent for refactoring

The intent is for all client-side consumers to invoke highlighters via these methods. For example:
```
this.inspector.highlighters.showHighlighterTypeForNode(
      "BoxModelHighlighter",
      nodeFront
    )
```

See another example of this in the migration of `FlexboxHighligther` in D79694.

##### Future plans

In the medium-term, it's likely we'll move this part of `HighligthersOverlay` from inspector to toolbox and rename it `HighlightersManager`. This way, other consumers, like Debugger and Console can also use it [instead of the existing approach](https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/devtools/client/framework/toolbox.js#3503-3557). Haven't attempted this yet. Pending updates to the Flexbox, Grid, Shapes and CSS Transform highlighters so when we migrate paths from `inspector.highlighters` to ️ `toolbox.highlighters` is done in one go for all tests and consumers.

Differential Revision: https://phabricator.services.mozilla.com/D81526
2020-09-10 12:00:34 +00:00
Alexandre Poirot cab0355a25 Bug 1663974 - Unwatch for resources when closing the debugger. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89626
2020-09-09 16:27:48 +00:00
Alexandre Poirot 4a2d9abbd1 Bug 1663974 - Fix rebase, unwatch for network event stack trace resource. r=jdescottes
I'm slicing this in this bug. This new resource type was added while I added the code for calling unwatchResources...

Differential Revision: https://phabricator.services.mozilla.com/D89625
2020-09-09 16:25:11 +00:00
Alexandre Poirot 46d48b5555 Bug 1663873 - Unwatch for resources when closing the toolbox. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89560
2020-09-09 13:03:15 +00:00
Alexandre Poirot e3fcd6b59f Bug 1663873 - Unwatch for resources when closing the inspector. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89559
2020-09-09 11:55:02 +00:00
Alexandre Poirot bdfead3b8b Bug 1616381 - Do not try to emit error packets when the actor is destoyed. r=jdescottes
I also added another early return in order to avoid trying to send a method response
if the actor is destroyed, as it isn't really useful and would also throw.
Both ifs added by this changeset fixes the test failure independently of the other one.
But I think we would benefit from both.
The one in writeError would avoid throwing exception in the last change catch handler
and so avoid unhandled promise rejections.
The one in sendReturn probably helps having more meaningful error report!

Differential Revision: https://phabricator.services.mozilla.com/D89682
2020-09-10 09:14:47 +00:00
Emilio Cobos Álvarez a3c20c9800 Bug 1662703 - Make appearance: button behave like auto. r=heycam
As per https://github.com/w3c/csswg-drafts/issues/5174.

Differential Revision: https://phabricator.services.mozilla.com/D89119
2020-09-10 08:58:09 +00:00
Julian Descottes d0215ae423 Bug 1663896 - Remove async for TargetList::unwatchTargets and update call sites r=ochameau
Depends on D89583

Differential Revision: https://phabricator.services.mozilla.com/D89608
2020-09-09 14:53:26 +00:00
Julian Descottes 193ac19715 Bug 1663896 - Always wait for _watchAllTargets to resolve in DevTools ResourceWatcher r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89583
2020-09-09 14:52:13 +00:00
Razvan Maries f0ac3ad62a Backed out changeset baab244deeb0 (bug 1662703) for perma failures on 482681.xhtml. CLOSED TREE 2020-09-10 04:50:23 +03:00
Emilio Cobos Álvarez af8bc3472b Bug 1662703 - Make appearance: button behave like auto. r=heycam
As per https://github.com/w3c/csswg-drafts/issues/5174.

Differential Revision: https://phabricator.services.mozilla.com/D89119
2020-09-08 23:03:58 +00:00
Julian Descottes fde673f31c Bug 1635461 - Remove watcher logic from Walker Actor r=ochameau,devtools-backward-compat-reviewers
Depends on D86163

Differential Revision: https://phabricator.services.mozilla.com/D86549
2020-09-09 17:14:07 +00:00
Julian Descottes 7909e64490 Bug 1635461 - Remove watcher logic from WalkerFront in favor of ResourceWatcher r=ochameau
Depends on D86162
The resource watcher already guarantees that listeners are only called once, caches resources etc.
Consequently, the client side logic currently implemented in the WalkerFront is redundant and should be removed.

Differential Revision: https://phabricator.services.mozilla.com/D86163
2020-09-09 16:08:56 +00:00
Julian Descottes 2eb6d9ccce Bug 1635461 - Use ResourceWatcher for root-node resources in tests r=ochameau
Depends on D86160

Differential Revision: https://phabricator.services.mozilla.com/D86162
2020-09-09 16:08:38 +00:00
Julian Descottes 7c18c7b9c9 Bug 1635461 - Use ResourceWatcher for root-node resources in MarkupView and HighlightersOverlay r=ochameau
Depends on D83311

Differential Revision: https://phabricator.services.mozilla.com/D86160
2020-09-09 16:08:21 +00:00
Julian Descottes 20769b1457 Bug 1635461 - Retrieve root NodeFront from Inspector::onResourceAvailable r=rcaliman
Depends on D83310

Differential Revision: https://phabricator.services.mozilla.com/D83311
2020-09-09 16:08:05 +00:00
Julian Descottes a034fbc33c Bug 1635461 - Rewrite Inspector::_getDefaultNodeForSelection as an async method r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D83310
2020-09-09 16:07:19 +00:00
Alexandre Poirot b1f86cb838 Bug 1663717 - Stop watching for resources in the console frontend. r=jdescottes
It looks like we forgot to re-enable this code.
Hopefully this doesn't break any test. Without that, DAMP is throwing
because of late onResourceAvailable calls.

This might tells us that the throttling should check if it is still
relevant to emit the throttled event? I'm not having such check yet.

Differential Revision: https://phabricator.services.mozilla.com/D89476
2020-09-08 20:49:54 +00:00
Hubert Boma Manilla d79aa27e63 Bug 1663524 - Tests for the Network Event Stacktrace r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89360
2020-09-08 22:41:09 +00:00
Jeff Walden 6d5beafab1 Bug 1663365 - Move various Object-related functions to a new js/public/Object.h header. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D89333
2020-09-08 22:55:38 +00:00
Alexandre Poirot fabd272d4a Bug 1663617 - Pass `updateType` via the update packet instead of storing it on the resource object. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D89435
2020-09-08 13:53:59 +00:00
Alexandre Poirot ebe9679c75 Bug 1663636 - Prevent trying to fetch font faces of destroyed node fronts. r=jdescottes
This isn't really related to EventLoop, but this is another exception thrown when running DAMP.
This time related to a request made against an already destroyed NodeFront.

Differential Revision: https://phabricator.services.mozilla.com/D89451
2020-09-08 16:31:03 +00:00
Alexandre Poirot 550422b87a Bug 1663636 - Prevent trying to resume destroyed documents. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D89450
2020-09-08 16:31:01 +00:00
Hubert Boma Manilla 1362cb7b8b Bug 1663524 - Legacy listener for the Network stacktrace r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D88858
2020-09-08 12:48:00 +00:00
Alexandre Poirot aea309243d Bug 1663567 - Fix browser_inspector_fission_frame_navigation.js failure on fission. r=jdescottes
`navigateIframeTo` now returns a resource object.

Differential Revision: https://phabricator.services.mozilla.com/D89438
2020-09-08 11:35:37 +00:00
Brad Werth fc3cb8fd99 Bug 1661283 Part 6: Add a test of NodeActor.isScrollable on various elements. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88683
2020-08-31 17:56:24 +00:00
Brad Werth 8ca8fd6962 Bug 1661283 Part 5: Add a test of GetOverflowingChildrenOfElement on the body element. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88682
2020-09-04 13:15:08 +00:00
Brad Werth ccf873b003 Bug 1661283 Part 4: Make NodeActor.initialize respect overflow debugging pref. r=gl
This also reuses a cached result of isScrollable, to avoid a second call.

Differential Revision: https://phabricator.services.mozilla.com/D88507
2020-09-02 23:52:37 +00:00
Brad Werth 75102cef12 Bug 1661283 Part 3: Make NodeActor.isScrollable use the new Element.hasVisibleScrollbars method. r=gl
This removes the need for the document/dom walk.

Differential Revision: https://phabricator.services.mozilla.com/D88506
2020-08-28 22:18:34 +00:00
Daisuke Akatsuka 8216959c5d Bug 1661622: See newState instead of old state. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D89359
2020-09-08 01:07:51 +00:00
Alexandre Poirot 8dd8e4b254 Bug 1660268 - Pass list of resources instead of unique resource from ResourceWatcher. r=nchevobbe
Here, I've tried to be especially careful about replacing `return` by `continue` in the added for..loops.

Differential Revision: https://phabricator.services.mozilla.com/D87768
2020-09-07 21:13:02 +00:00
Alexandre Poirot e61c347424 Bug 1660268 - Read targetFront from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87767
2020-09-07 20:58:14 +00:00
Alexandre Poirot 0b62c083a6 Bug 1660268 - Read resourceType from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87766
2020-09-07 20:58:12 +00:00
Daisuke Akatsuka 5ee0f8ed93 Bug 1661625: Get stylesheets traits if needed. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D89339
2020-09-07 21:05:41 +00:00
Csoregi Natalia 3034124827 Backed out 3 changesets (bug 1660268) for failures on browser_ext_devtools_network_targetSwitch.js. CLOSED TREE
Backed out changeset 749fda4e5eb1 (bug 1660268)
Backed out changeset 9d4c305f6b88 (bug 1660268)
Backed out changeset 7ec118209790 (bug 1660268)
2020-09-07 21:24:26 +03:00
Alexandre Poirot ecf3f1c8bc Bug 1660268 - Pass list of resources instead of unique resource from ResourceWatcher. r=nchevobbe
Here, I've tried to be especially careful about replacing `return` by `continue` in the added for..loops.

Differential Revision: https://phabricator.services.mozilla.com/D87768
2020-09-07 13:35:31 +00:00
Alexandre Poirot fdb1e4f37e Bug 1660268 - Read targetFront from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87767
2020-09-07 13:35:24 +00:00
Alexandre Poirot b42d571310 Bug 1660268 - Read resourceType from resource instead of onResource*** functions. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D87766
2020-09-07 13:35:21 +00:00
Julian Descottes 9e5bbe3162 Bug 1663421 - Remove deprecated newSource events from target front specs r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D89368
2020-09-07 12:50:06 +00:00
Alexandre Poirot 1b5d072163 Bug 1662126 - Make synchronization code related to resourceTypes reusable. r=nchevobbe
The idea here is to reuse this to communicate the breakpoints (and many other things).

Differential Revision: https://phabricator.services.mozilla.com/D88849
2020-09-07 08:32:44 +00:00
Alexandre Poirot 04f81fed65 Bug 1662126 - Share code in WatcherRegistry between targets and resouces. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88848
2020-09-07 08:32:37 +00:00
Alexandre Poirot acd17d815f Bug 1662126 - Convert WatcherRegistry Set to Arrays. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88847
2020-09-07 08:32:34 +00:00
Julian Descottes 3f96b9a6a1 Bug 1659835 - Show org.mozilla.fenix.nightly as Firefox Nightly r=daisuke
Depends on D87846

While testing the latest Fenix Nightly I noticed that the package name was org.mozilla.fenix.nightly

Differential Revision: https://phabricator.services.mozilla.com/D87847
2020-08-23 21:28:16 +00:00
Julian Descottes 5674c4ded7 Bug 1659835 - Set a default version name in DevTools adb-runtime r=daisuke
To my knowledge, versionName should always be defined via init, but adding a default value here to avoid potential issues.

Differential Revision: https://phabricator.services.mozilla.com/D87846
2020-08-23 21:23:18 +00:00
Emilio Cobos Álvarez 0cc4b1a206 Bug 1663231 - Make @font-face and @counter-style serialization closer other browsers and style rules. r=xidorn
Style rules serialize on one line and so should @font-face blocks.

Part of https://github.com/w3c/csswg-drafts/issues/4828.

Differential Revision: https://phabricator.services.mozilla.com/D89302
2020-09-05 00:42:43 +00:00
Julian Descottes 3a577649e6 Bug 1662067 - Set default preferences from about:debugging when connecting to remote runtimes r=daisuke,nchevobbe,devtools-backward-compat-reviewers
At the moment, it is easy to break remote debugging by reading preferences incorrectly.
Typically, creating a preference in the firefox preference index file will only create it for Firefox, not for mobile (Fenix).
When trying to read the preference from the server with the Services.prefs.get*Pref APIs, the call will throw unless a fallback value was specified.

A longer term solution is investigated at https://bugzilla.mozilla.org/show_bug.cgi?id=1660182, but for now this changeset allows about:debugging to set a few default values for preferences when connecting to a remote runtime.

Differential Revision: https://phabricator.services.mozilla.com/D88782
2020-09-03 07:49:33 +00:00
Gijs Kruitbosch 852a62520a Bug 1661629 - size tabdialogbox items correctly when shown in responsive design mode, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D89228
2020-09-03 14:10:12 +00:00
Nicolas Chevobbe 317a7ff2c2 Bug 1660466 - Fix attaching target/thread test intermittents. r=jdescottes.
Move the function taking care of closing the Browser Console to shared-head so
we can close it before closing the tabs opened during the test.

While attaching the worker, check that the Worker Debugger isn't closed, and
if it is, reject the promise. On the target list, catch rejection while attaching
and simply bail out so we don't call the rest of the code in onTargetAvailable.

Those guards are not enough to prevent any failure while attaching, so we're
wrapping calls to `attachAndInitThread`/`_onThreadInitialized` in try/catch
blocks to avoid test failures.

Differential Revision: https://phabricator.services.mozilla.com/D88766
2020-09-02 14:43:23 +00:00
Nicolas Chevobbe d5a9641120 Bug 1662054 - Add a destroy function to targetList. r=jdescottes.
At the moment, we don't have any guards in the targetList to _not_ execute the
creation/destruction listeners once the toolbox gets destroyed.
We only have a stopListening function on the targetList that is called when we
close the toolbox, but we can't rely only on that since it's also called when
doing a target switch (and working around that is very racy).

One solution would be to follow the common pattern we have everywhere by having
a destroy method that we would check before trying to call the listeners callback.

This might help with intermittent test failures.

Differential Revision: https://phabricator.services.mozilla.com/D88765
2020-09-02 14:39:42 +00:00
Hubert Boma Manilla 87bd8a1f81 Bug 1644191 - Server side network events listening r=nchevobbe,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D78867
2020-09-02 13:31:59 +00:00
Alexandre Poirot 2452f172af Bug 1661627 - Stop ignoring PDF print preview documents. r=nchevobbe
PDF print preview are using about:blank documents, which are ignored
by DevTools in order to save resources.
We avoid creating targets for these, very often, transcient documents.
I tried to find ways to distinguish typical temporary about:blank documents
from this print preview one.

Differential Revision: https://phabricator.services.mozilla.com/D88956
2020-09-02 07:38:59 +00:00
Daisuke Akatsuka 9027b60d6b Bug 1662324: Add tests for updating resource of STYLESHEET type. r=ochameau
Depends on D88531

Differential Revision: https://phabricator.services.mozilla.com/D88950
2020-09-02 03:57:21 +00:00
Andreea Pavel 32a988db57 Bug 1629729 - temporarily disable browser_container_tab.js on linux r=gbrown DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D84930
2020-09-01 16:28:50 +00:00
Emilio Cobos Álvarez 03baee9d8a Bug 1662478 - Rename ::file-chooser-button to ::file-selector-button, and enable it in all channels. r=jwatt
See https://github.com/w3c/csswg-drafts/issues/5049

Differential Revision: https://phabricator.services.mozilla.com/D88995
2020-09-01 22:58:10 +00:00
Alexandre Poirot 6578784678 Bug 1662066 - Print more information when waitFor() test helper fails. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88835
2020-09-01 09:11:29 +00:00
Alexandre Poirot 5d89a18f3b Bug 1662066 - Use a single waitFor test helper implementation. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88834
2020-09-01 09:11:34 +00:00
Alexandre Poirot 27c9bcc6c5 Bug 1662066 - Remove netmonitor waitFor test helper. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88833
2020-08-31 17:22:08 +00:00
Nicolas Chevobbe 50b96d5e2e Bug 1660416 - Use an hr element as a menu separator instead of a MenuItem. r=bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D87840
2020-09-01 07:46:54 +00:00
Daisuke Akatsuka a16d25d9f6 Bug 1659589: Remove error event listener that set to stylesheet actor. r=ochameau
Depends on D87047

Differential Revision: https://phabricator.services.mozilla.com/D88531
2020-09-01 01:44:28 +00:00
Daisuke Akatsuka b9e65b07d6 Bug 1659589: Implement update method in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Depends on D87046

Differential Revision: https://phabricator.services.mozilla.com/D87047
2020-08-28 06:27:53 +00:00
Daisuke Akatsuka e9b12ccb1d Bug 1659589: Implement getText in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Depends on D87044

Differential Revision: https://phabricator.services.mozilla.com/D87045
2020-08-28 06:07:33 +00:00
Daisuke Akatsuka f8c36ace27 Bug 1659589: Implement toggleDisabled in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
Depends on D87043

Differential Revision: https://phabricator.services.mozilla.com/D87044
2020-08-20 08:27:47 +00:00
manas 7268313809 Bug 1660818 - Add telemetry to track the number of times the scrollable badge is clicked. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88049
2020-08-31 21:21:29 +00:00
Julian Descottes 4d4be17fbc Bug 1662058 - Add fallback to get pref devtools.overflow.debugging.enabled from server r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88767
2020-08-31 08:37:13 +00:00
Anny Gakhokidze 652e7457ff Bug 1589102 - Part 16: Fix devtools/sharedbrowser_saveHeapSnapshot_e10s_01.js to wait for the browser to load, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D88232
2020-08-28 17:21:31 +00:00
Anny Gakhokidze aa5ab9056f Bug 1589102 - Part 5: Fix tests that relied on about:blank loads happening instantenously, r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D85083
2020-08-28 17:20:45 +00:00
Yury Delendik 0e0f07423b Bug 1661331 - Update wasmparser to version 3.1.1 r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D88325
2020-08-28 16:47:51 +00:00
Alexandre Poirot 45a188bf6b Bug 1661569 - Avoid mixing target actor of the many toolboxes. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88486
2020-08-28 05:48:53 +00:00
Cosmin Sabou 2a9db10f24 Backed out 7 changesets (bug 1518999) for causing browsertime failures. CLOSED TREE
Backed out changeset d93cb254eef5 (bug 1518999)
Backed out changeset a9715e73e862 (bug 1518999)
Backed out changeset e28081d16e3c (bug 1518999)
Backed out changeset c9d88f3f1f5b (bug 1518999)
Backed out changeset 9836adcc4e83 (bug 1518999)
Backed out changeset 9f01755d327f (bug 1518999)
Backed out changeset ef494065b8e2 (bug 1518999)
2020-08-28 06:27:11 +03:00
manas e251f1d7ee Bug 1660847 - Add test for scrollable badge click functionality. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D88099
2020-08-27 21:38:00 +00:00
Daisuke Akatsuka cb8195519b Bug 1659589: Get media-rules-changed event via resource watcher. r=ochameau
Depends on D87042

Differential Revision: https://phabricator.services.mozilla.com/D87043
2020-08-27 06:42:09 +00:00
Daisuke Akatsuka a936229ca0 Bug 1659589: Get property-change event via resource watcher. r=ochameau
Depends on D87041

Differential Revision: https://phabricator.services.mozilla.com/D87042
2020-08-26 08:37:18 +00:00
Daisuke Akatsuka b74df1cade Bug 1659589: Get style-applied event via resource watcher. r=ochameau,bomsy
Depends on D87040

Differential Revision: https://phabricator.services.mozilla.com/D87041
2020-08-27 22:31:52 +00:00
Daisuke Akatsuka 0adc3db50a Bug 1659589: Handle importing stylesheet from file using resource watcher mechanism to keep consistency. r=ochameau,devtools-backward-compat-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D87040
2020-08-27 22:31:52 +00:00
Sean Feng 4e5be39962 Bug 1518999 - Refactor some performance.getEntries related tests r=mstange
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.

Depends on D66463

Differential Revision: https://phabricator.services.mozilla.com/D68645
2020-08-24 22:11:58 +00:00
Alexandre Poirot 2effa77867 Bug 1660895 - Eagerly ignore loading or destroying documents. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88075
2020-08-26 20:31:57 +00:00
Alexandre Poirot 07e7e6e9b1 Bug 1660892 - Ignore window objects related to remote iframes in thread actor. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88074
2020-08-26 14:25:31 +00:00
Hubert Boma Manilla ad94cbe2d8 Bug 1661186 - Show the extension name for the blocked request r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D88253
2020-08-26 14:26:48 +00:00
Mihai Alexandru Michis 01a6dfae9d Backed out changeset 9d95edbd8386 (bug 1660892) for causing devtool timeouts.
CLOSED TREE
2020-08-26 15:39:48 +03:00
Alexandre Poirot 6238cd4670 Bug 1660892 - Ignore window objects related to remote iframes in thread actor. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88074
2020-08-26 08:48:23 +00:00
Alexandre Poirot 26f8349cef Bug 1660897 - Avoid updating the JS context selector too many times. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D88073
2020-08-25 05:31:37 +00:00
Nicolas Chevobbe aaa2b8be93 Bug 1659376 - Fix Browser Toolbox inspector when print preview is displayed.r=rcaliman.
The issue was that the getHighlighter request for the about:printpreview
target never settled. It appears that the document always stays in an
unitialized readyState, which was causing trouble.
Instead of relying only on readyState, we now call isDocumentReady, which
also checks if the document is loading.

Differential Revision: https://phabricator.services.mozilla.com/D87756
2020-08-25 07:08:12 +00:00
Nicolas Chevobbe a00c418cc2 Bug 1659376 - Extract isDocumentReady from WalkerActor to inspector utils file. r=rcaliman.
Differential Revision: https://phabricator.services.mozilla.com/D87755
2020-08-25 07:07:48 +00:00
Cody Welsh afc2d249b6 Bug 1654218 - Consolidate style assignments into objects. r=nchevobbe,jdescottes
Reduces explicit "elem.style.x = 'y' assignments by consolidating them
into associated Objects, and using `Object.assign` to make the style
modifications to the respective elements."

Depends on D86866

Differential Revision: https://phabricator.services.mozilla.com/D86867
2020-08-25 06:49:11 +00:00
Cosmin Sabou 7b214fd81a Backed out 6 changesets (bug 1518999) for geckoview failures on scrollToVerticalOnZoomedContentAuto.
Backed out changeset 10bf1552e301 (bug 1518999)
Backed out changeset e62cd63e3595 (bug 1518999)
Backed out changeset 1bf0b02bb0e0 (bug 1518999)
Backed out changeset 2203a9c52afa (bug 1518999)
Backed out changeset 10f07ca7a246 (bug 1518999)
Backed out changeset b90cf6b54c09 (bug 1518999)
2020-08-25 01:02:36 +03:00
Alexandre Poirot 1c24b4ceb7 Bug 1660032 - Make the JS Context selector scrollable. r=jdescottes,nchevobbe
I had to put it in toolbox.css as it wasn't working from EvaluationContextSelector.css.
I imagine that's because the context DOM element are actually in toolbox document rather than the console one.

Also, React must be re-creating all DOM elements anytime there is an update
as you can see the list scroll up, everytime there is an update.
We should probably have a look at that as well.

Differential Revision: https://phabricator.services.mozilla.com/D87620
2020-08-21 09:59:34 +00:00
Sean Feng ef7d515ffb Bug 1518999 - Refactor some performance.getEntries related tests r=mstange
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.

Depends on D66463

Differential Revision: https://phabricator.services.mozilla.com/D68645
2020-08-18 21:15:18 +00:00
manas 68019d8bda Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D87926
2020-08-23 23:05:13 +00:00
Daisuke Akatsuka 5341051fc9 Bug 1634045: Add a README for the compatibility panel. r=rcaliman,Honza
Differential Revision: https://phabricator.services.mozilla.com/D87981
2020-08-24 11:19:47 +00:00
Razvan Maries 5dd733dcb0 Backed out changeset 11f769ec943d (bug 1660266) for perma failures on browser_markup_overflow_badge.js. CLOSED TREE 2020-08-22 21:58:24 +03:00
manas 4ef56c529d Bug 1660266 - Encapsulate the code for finding overflow causing elements inside the Overflow Debugging pref. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D87926
2020-08-22 16:57:04 +00:00