As the motorola G5 and the Pixel 2 have been removed from CI we are also going to remove references to them in our documentation and taskcluster code.
Differential Revision: https://phabricator.services.mozilla.com/D199294
On macOS, there are no bootstrap toolchains for dmg and hfsplus, so
bootstrap_toolchain returns `None`. Later, `Path(None)` throws an exception.
The mozpack.dmg code handles the situation nicely and uses other tools that
are readily available on macOS.
Differential Revision: https://phabricator.services.mozilla.com/D199928
A previous patch added parsing `git remote -v`, preferring
`mozilla-unified` as the official upstream remote and falling
back to the first official-looking remote if unified was not
found. We assumed that a developer is either using mozilla-unified,
or is using a single-headed repo like central. This overlooks
the fact that it is possible to clone from central, and then
pull other repos in, creating a repo with multiple official
remotes.
Update the `get_upstream_remote` function to find all official
looking remotes instead of a single official remote, and change
the `get_remote_arg` function to return a list of `--remotes`
arguments to be passed to various Git commands. This allows
Git to take all official remotes into consideration and more
precisely find the commits which are not present on any official
upsteams.
Add a test for `get_mozilla_remote_args` while we are here.
Differential Revision: https://phabricator.services.mozilla.com/D199637
The issue we were encountering here was a missing metric for canva.com intermittently occuring
That ocured because of the location of that metric(first contentful paint) in the returned json moved locations for just canva.com, and so canva.com was removed whilst the problem debugged. Afterwards it was discovered that this issue was covering up another intermittent about json decoding error which was in turn resolved by removing code which removed "www." from links used with python requests.
Differential Revision: https://phabricator.services.mozilla.com/D199238
pacman_install() uses sudo pacman -S to install packages, which requires the user to enter their password for sudo even if there's nothing to do. Checking for installed packages using pacman -Q allows us to skip calling sudo when all packages are already installed.
Differential Revision: https://phabricator.services.mozilla.com/D199242
While this message was sometimes useful to help troubleshoot for end
users, it's causing issues parsing `stdout` (since it can't use the mach
logging infrastructure due to being too early in the startup). We also
can't use `stderr` since some mozharness scripts treat any `stderr`
output as a full error.
Differential Revision: https://phabricator.services.mozilla.com/D198451
It's not technically an error, but we can't make it debug level output
since the mach logging isn't available this early on startup. There's
precedent for using `stderr` output elsewhere in `site.py`, though it
usually precedes an exception being raised.
Differential Revision: https://phabricator.services.mozilla.com/D198307
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel
Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:
```
33153 security.ui.protectionspopup open protectionspopup_cfr impression {"message": "PROTECTIONS_PANEL_1"}
```
and
```
34932 security.ui.protectionspopup click protectionspopup_cfr
```
Differential Revision: https://phabricator.services.mozilla.com/D192968
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Depends on D189872
Differential Revision: https://phabricator.services.mozilla.com/D194312
The protections panel message should show once when the panel is first opened; after that it will be collapsed by default and can be shown again by clicking the "info" button on the panel
Messaging system previously sent the following pings on message show, and when the "learn more" link was clicked:
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“IMPRESSION”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
and
```
{“message_id”:“PROTECTIONS_PANEL_1",“event”:“CLICK”,“addon_version”:“20231106094018",“locale”:“en-US”,“client_id”:“6fabd2de-3d0a-4b11-be4c-86b0ea1a1144",“browser_session_id”:“4b0f34b1-75ef-4704-907e-18d84e5187c3",“pingType”:“whats-new-panel”}
```
This patch replaces these pings with 'RecordEvents' telemetry on the `protectionsPopup` object:
```
33153 security.ui.protectionspopup open protectionspopup_cfr impression {"message": "PROTECTIONS_PANEL_1"}
```
and
```
34932 security.ui.protectionspopup click protectionspopup_cfr
```
Differential Revision: https://phabricator.services.mozilla.com/D192968
In bug 1866395 I added a function to return the canonical Firefox
remote and use it when determining the base ref. I overlooked
that this also needs to be used for `get_branch_nodes` to avoid
returning a set of branch nodes that doesn't begin from the same
base ref. Move the building of the `--remotes` arg to a separate
function and use it in `get_branch_nodes`.
Differential Revision: https://phabricator.services.mozilla.com/D198032
This patch fixes the mozperftest docs to mention mochitest in the writing section, as well as fixes the `info` calls so that they mention the JSON.stringify requirement.
Differential Revision: https://phabricator.services.mozilla.com/D196853
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Differential Revision: https://phabricator.services.mozilla.com/D194312
Notification can be triggered locally via this snippet:
```js
BrowserSearch.removalOfSearchEngineNotificationBox("Google", "Foogle")
```
Differential Revision: https://phabricator.services.mozilla.com/D194312
For some reason, in some files, file elements are under file elements.
Python's ElementTree's findall doesn't work like DOM's
getElementsByTagName, and doesn't find them. So manually recurse.
Differential Revision: https://phabricator.services.mozilla.com/D197278
andrej
Rob Lemley
Tiaan Louw
Jeff Muizelaar
Noemi Erli
Connor Sheehan
Perry McManis
Tom Marble
Stanca Serban
Julian Nagele
Alexandre Lissy
Cristian Tuns
Jonathan Kew
Gregory Pappas
ahochheiden
Gabriel Bustamante
serge-sans-paille
mcarare
Mike Hommey
Narcis Beleuzu
Henrik Skupin
Emily McMinn
Hanna Jones
Alex Finder
Greg Mierzwinski
Norisz Fay
Cosmin Sabou
Landry Breuil
Tom Schuster
Michael Froman
Joel Maher
Dimi
Logan Rosen