Граф коммитов

228 Коммитов

Автор SHA1 Сообщение Дата
Simon Giesecke 963a76c6fc Bug 1619307 - Fixed assertion in IDBTransaction::Run. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64984

--HG--
extra : moz-landing-system : lando
2020-03-04 13:10:54 +00:00
Simon Giesecke 92b7ccc53b Bug 1613340 - Remove const_cast relating to DatabaseSpec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61668

--HG--
extra : moz-landing-system : lando
2020-03-03 13:44:25 +00:00
Simon Giesecke fff839290a Bug 1609957 - Fix race condition in determining the last request before commit. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D60642

--HG--
extra : moz-landing-system : lando
2020-02-27 10:05:48 +00:00
Eric Rahm 124379887c Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.

Differential Revision: https://phabricator.services.mozilla.com/D63745

--HG--
extra : moz-landing-system : lando
2020-02-24 19:26:40 +00:00
Boris Zbarsky b88d5ac5a8 Bug 1612213 part 1. Switch most consumers of ThrowDOMException to the new methods. r=smaug,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D61267

--HG--
extra : moz-landing-system : lando
2020-02-03 20:19:11 +00:00
Simon Giesecke 37b6637a59 Bug 1497007 - Replace CanAcceptRequests by the now equivalent IsActive. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D59834

--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:09 +00:00
Simon Giesecke 2181db6537 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673

--HG--
extra : moz-landing-system : lando
2020-01-17 12:47:17 +00:00
Simon Giesecke 0bcde245c0 Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713

--HG--
extra : moz-landing-system : lando
2020-01-17 10:11:58 +00:00
Csoregi Natalia 8ee62c60e1 Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke 25cbe0ce57 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673

--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:29 +00:00
Simon Giesecke 378b2a112d Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713

--HG--
extra : moz-landing-system : lando
2020-01-14 11:14:52 +00:00
Simon Giesecke a5e45033f2 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 15:23:52 +00:00
Csoregi Natalia 8c7b4f143a Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke a48be584a9 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993

--HG--
extra : moz-landing-system : lando
2020-01-10 14:21:18 +00:00
Simon Giesecke 9f35b34d2d Bug 1600283 - Removed unused include directives. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55516

--HG--
extra : moz-landing-system : lando
2019-12-19 09:57:40 +00:00
Simon Giesecke 6033119f9a Bug 1497007 - Added IDBTransaction.commit method, with a minimal implementation. r=ttung,hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D46277

--HG--
extra : moz-landing-system : lando
2019-12-10 10:24:18 +00:00
Simon Giesecke b727e2abc1 Bug 1598164 - Implement transaction inactive state according to spec. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55142

--HG--
extra : moz-landing-system : lando
2019-12-04 12:59:09 +00:00
Simon Giesecke 5e243f8d78 Bug 1598164 - Made some boolean flags in IDBTransaction FlippedOnce to reduce statefulness. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55081

--HG--
extra : moz-landing-system : lando
2019-12-03 15:32:18 +00:00
Simon Giesecke 6c42eb0661 Bug 1598164 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Depends on D54322

Differential Revision: https://phabricator.services.mozilla.com/D55079

--HG--
extra : moz-landing-system : lando
2019-11-28 15:05:28 +00:00
Simon Giesecke 90427d7da3 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322

--HG--
extra : moz-landing-system : lando
2019-11-28 16:00:29 +00:00
Simon Giesecke 9e2165d850 Bug 1598164 - Make use of std::copy_if/MakeBackInserter in IDBTransaction::AbortInternal. r=dom-workers-and-storage-reviewers,ytausky
Depends on D54322

Differential Revision: https://phabricator.services.mozilla.com/D54732

--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke 55a2f652bc Bug 1598164 - Use scoped enums in IDBTransaction. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54321

--HG--
extra : moz-landing-system : lando
2019-11-27 10:54:57 +00:00
Simon Giesecke 49f97fef21 Bug 1497007 - Improve exception messages. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D52355

--HG--
extra : moz-landing-system : lando
2019-11-20 10:23:47 +00:00
Simon Giesecke 19128f8aae Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231

--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:20 +00:00
Simon Giesecke cdbb1aa771 Bug 1497007 - Extracted GetIndexedDBThreadLocal function. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46949

--HG--
extra : moz-landing-system : lando
2019-11-11 08:25:05 +00:00
Simon Giesecke bb8fe42e53 Bug 1497007 - Replace custom for loops by range-based for and appropriate algorithms. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46948

--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:53 +00:00
Simon Giesecke 2b36ecbd21 Bug 1497007 - Minor improvements. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46947

--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:45 +00:00
Simon Giesecke cd8018b798 Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46946

--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:32 +00:00
Simon Giesecke 35990e4306 Bug 1497007 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46945

--HG--
extra : moz-landing-system : lando
2019-11-11 08:24:25 +00:00
shindli 7c774ed0a3 Backed out 8 changesets (bug 1497007) for causing build bustages in /builds/worker/workspace/build/src/dom/indexedDB/IDBTransaction.cpp CLOSED TREE
Backed out changeset 15de0d72f1c4 (bug 1497007)
Backed out changeset 7056932f6422 (bug 1497007)
Backed out changeset 7304fae8c436 (bug 1497007)
Backed out changeset be22a95de04b (bug 1497007)
Backed out changeset 98ac48b5f1ef (bug 1497007)
Backed out changeset 562d3cda9fa3 (bug 1497007)
Backed out changeset 3f96e71be2e3 (bug 1497007)
Backed out changeset 3d9e86698c9f (bug 1497007)
2019-11-08 16:28:53 +02:00
Simon Giesecke 67ff3f2964 Bug 1497007 - Added explaining comments. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D47231

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:45 +00:00
Simon Giesecke 66ba8c7bd1 Bug 1497007 - Extracted GetIndexedDBThreadLocal function. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46949

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:25 +00:00
Simon Giesecke f5146ed829 Bug 1497007 - Replace custom for loops by range-based for and appropriate algorithms. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46948

--HG--
extra : moz-landing-system : lando
2019-11-08 13:33:13 +00:00
Simon Giesecke a90f156203 Bug 1497007 - Minor improvements. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46947

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:58 +00:00
Simon Giesecke d905508bee Bug 1497007 - Extracted HasTransactionChild and DoWithTransactionChild functions. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46946

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:46 +00:00
Simon Giesecke df38d08c1d Bug 1497007 - Use const where easily possible. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46945

--HG--
extra : moz-landing-system : lando
2019-11-08 13:29:39 +00:00
Simon Giesecke 9804c8f159 Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 14:40:37 +00:00
Cosmin Sabou 1211bbc800 Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke 1db45a09bf Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-11-05 12:48:36 +00:00
Oana Pop Rus cb31d323be Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
Simon Giesecke 3feb8e1ebe Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
Simon Giesecke bd2e4939bc Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46576

--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
Tom Tung f3eb98601f Bug 1563299 - Update the mAbortCode if the IDBTransaction has been aborted yet to correct the IDB_LOG; r=asuth
IDBTransaction generates IDB_LOG base on the mAbortCode, but it fires event
according to the argument "aResult" of FireCompleteOrAbortEvents(). It's
possible to have a situation that IDBTransaction hasn't been aborted yet, but
the transaction on the parent process is aborted and propagate the reason to
IDBTransaction. In this case, IDBTransaction would still fire an abort event as
expected. However, the IDB_LOG would show that it fired a complete event.

Therefore, this patch corrects the behavior and adds an assertion to ensure it's
only possible that parent process tells child process to abort at the last
minate rather than the case of parent is canceling the abort.

Differential Revision: https://phabricator.services.mozilla.com/D36900

--HG--
extra : moz-landing-system : lando
2019-07-26 13:29:04 +00:00
Andrea Marchesini da174a4757 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga 7af208ab28 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini 788d12712b Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Sylvestre Ledru 265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jeff Gilbert 5b753da289 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Andrea Marchesini dbb6b928ed Bug 1455256 - Port more components to WorkerRef - part 4 - IDB Transaction, r=asuth 2018-06-18 16:37:21 -04:00
Emilio Cobos Álvarez fffb25b74f Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00