Currently we don't implement transparency at all in BMP images except for an
odd-duck case of BMPs within ICOs.
This patch does the following.
- It implements transparency properly for 16bpp and 32bpp images via bitfield
masking. (For 32bpp images this also requires handling colors via bitfield
masking.) The patch maintains the existing BMP-within-ICO transparency
handling.
- It also reworks BitFields::Value::Set().
* It now works correctly if the run of 1s goes all the way to bit 31 (the
old code didn't set mBitWidth).
* If the mask is 0, will give an mRightShift of 0 (old code gave 32, and
right-shifting by 32 is dodgy).
* It's now easier to read.
- It renames transparent.bmp as transparent-if-within-ico.bmp. Ironically
enough this file currently uses BITFIELDS compression and is WinBMPv5 format,
which means it contains well-specified alpha data. In order to use it to test
the hacky BMP-within-ICO transparency scheme the patch changes it to be
WinBMPv3 format with RGB compression (i.e. no compression). I left the
now-excess bytes (including the bitfields) in the info header in place
because that's allowed -- thanks to the start of the pixel data being
specified by the |dataoffset| field -- they'll just be ignored.
- It tweaks the naming of the relevant gtests and some of their finer details
to work with the new way of doing things.
This fixes all four remaining failures in bmpsuite.
--HG--
rename : image/test/gtest/transparent.bmp => image/test/gtest/transparent-if-within-ico.bmp
extra : rebase_source : 2f4838d04bbae4fac00cc69e8d75469105a5de3b
This patch implements proper color-scaling, instead of bit-shifting, and uses
it for 16bpp images.
It also cleans up the code relating to color masking in the process, by making
BitFields a proper class and introducing the Value class within it.
This fixes sub-optimal handling of four images in bmpsuite.
We have 52 passes and 5 known fails. Three of the passes have higher fuzziness
allowances than they should, so really there are 8 files that we need to
improve on.
--HG--
extra : rebase_source : 23738272b38c7d03c90e425e8170fc3fabc4c021
This adjusts existing reftest annotations for tests that fail on 10.8
that are showing up as failing on 10.10 as well to be marked using >=
version tests rather than == version tests.
These tests were originally marked as failing on 2.3 so that Android 2.3 could be enabled in production. Something today made them start passing again, so remove the failing annotations.
Looking at the code coverage information reveals that this is currently untested.
--HG--
extra : rebase_source : 31063dad0af0694d2ece75942a23cbfd3a60a6b1
-moz-samplesize allows decoding at a lower resolution.
This is valuable for saving memory when we know that
we don't need a large version of the image.
--HG--
extra : rebase_source : 0373c23bd4a8b5963329ea1ccf13f075c1264909
Nicholas Nethercote
Seth Fowler
Wes Kocher
Gijs Kruitbosch
Justin Wood
Phil Ringnalda
Alexandre Lissy
Seth Fowler
L. David Baron
Ryan VanderMeulen
Tom Schuster
Matt Woodrow
Jonathan Watt
Michael Wu
Jeff Muizelaar
CJKu
Vincent Chen
Daniel Holbert
Geoff Brown