3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
fe0cb896ea
Give radio buttons and checkboxes a useful baseline, and switch checkboxes from text-bottom to baseline alignment (to match radios). b=402940 r+sr=bzbarsky a=blocking1.9+
2008-03-07 09:57:34 -08:00
9d7f938b99
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
db47d007bc
Bug 370303: Cleanup in layout/forms. r+sr=roc.
2007-02-15 10:58:31 +00:00
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
eb31b955a4
Bug 326883 - Cleanup unused methods. r+sr=roc
2006-02-16 00:30:29 +00:00
00eb53b26a
Remove old native widget code that we were only keeping around for viewer. b=326417 r+sr=roc
2006-02-08 20:09:19 +00:00
77bca74243
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
b65c655ed9
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
2005-12-12 23:53:06 +00:00
1c34e68034
Bug 106386 Correct misspellings in source code
...
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
2005-11-20 22:05:24 +00:00
64a0fbd45f
Bug 311827: Make GetAttr return a bool rather then an nsresult.
...
r/sr=bz
2005-10-28 11:25:24 +00:00
fed343c43a
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
6655b13eac
Bug 301313 : Remove mPresContext in /layout/forms/, patch by Andreas Lange <mozilla@lange.cx>, r+sr=roc
2005-08-16 12:20:58 +00:00
50de4a3e1d
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
2005-04-28 23:48:28 +00:00
74e2aa375a
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
5c02a6978c
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
e2527bce29
Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky
2004-07-21 01:05:44 +00:00
708b56cff4
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
17f81274ba
Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky
2004-04-13 03:11:05 +00:00
92499cbd13
Inline TwipsToPixels and PixelsToTwips on nsIPresContext. Bug 229371, r+sr=dbaron.
2004-02-11 04:57:07 +00:00
d81619b4fa
Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky
2003-10-31 20:19:18 +00:00
e43f5a49fd
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
57124d8115
Replace computation of max-element-size (height and width) with max-element-width alone, since the max-element-height is practically unused and not meaningful for layout. b=186953 r+sr=bzbarsky
2003-01-09 14:26:32 +00:00
cb84e04c70
Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com
2002-12-18 23:38:09 +00:00
d33d3708fe
Align text inputs, buttons, comboboxes to baseline with respect to the
...
text around them (bug 167236). Fix width sizing issues for <input
type="button/reset/submit"> (bugs 79927, 36364). Fix nonuniform heights
of form controls (bug 70251). Patch is on bug 167236, r=jkeiser,
sr=roc+moz, moa=rods
2002-11-12 19:17:51 +00:00
4d507d3aff
Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com
2002-06-04 00:44:04 +00:00
66238732c8
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-23 22:26:36 +00:00
5d88648182
Backing out Bernd's checkin for bug 110596 to fix crashes / weird display. b=118991 r=bernd
2002-01-09 19:17:46 +00:00
17e7536dd9
add form frames to debug reflow bug 115096 r=karnaze sr=attinasi
2002-01-07 19:55:56 +00:00
748ebbcd0d
bug 113424 - mechanism for percent height frames inside table cells to receive special height reflow. sr=attinasi, r=alexsavulov
2001-12-07 14:51:12 +00:00
daeed9f51f
Ensure that text inputs, checkboxes and radios paint over inline element backgrounds that are behind them. Fix a few build warnings. b=107244 r=rods sr=waterson
2001-11-03 06:23:19 +00:00
6d64ded4f2
Checking in John Keiser's <jkeiser@iname.com> fix for *tons* of form submission and <select> related bugs, see tracking bug 34297 for details. r=rods@netscape.com, sr=jst@netscape.com
2001-11-02 07:40:01 +00:00
4e12e44b2f
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2001-09-28 20:14:13 +00:00
e908dd0313
bug 68998 - added extra param to Paint, PaintChild, PaintChildren used by tables in standard mode. sr=waterson, r=alexsavulov.
2001-09-19 12:35:19 +00:00
3994612354
removing unneeded/unused code/methods
...
r=kmcclusk, sr=waterson
2000-11-30 21:39:28 +00:00
cd56c0575b
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2000-10-28 22:17:53 +00:00
9a6d92a433
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2000-10-27 22:43:51 +00:00
9abec73fbe
DOM string changes. All nsString& in DOM interfaces (and interfaces needed by DOM implementations) have been changed to nsAReadableString& and nsAWritableString&. String implementation additions (sanctioned by scc) to support DOM needs. Bug 49091. r=vidur,jst,scc
2000-08-23 17:27:06 +00:00
23c1105112
moved the RegUnRegAccessKey to the Destroy method
...
b=47302 r=kmcclusk
2000-08-02 22:12:11 +00:00
aa7305bcb3
Elimination of nsIFocusableContent and improvements to tabbing r=saari
2000-04-04 23:55:31 +00:00
6948ab66ea
Added static method for getting the absolute rect in twips and pixels
...
moved from nsComboboxControlFrame.cpp
r=dcone b=18895
2000-03-21 15:18:07 +00:00
9499e0c6a9
Moved GetScreenHeight from Combobox frame to here. duplicated the SkipRelfow method to
...
some rework, and I can if def it in and out
b=18895 r=kmcclusk
2000-03-18 13:45:30 +00:00
3aecf61eed
modified the reflow method for better handling incremental and for optimization
...
b=28593, r=buster,kmclusk a=jar
2000-03-03 04:28:59 +00:00
fab88c6406
changing nsCOMPtr to weak references for PresContext
...
a=leaf, r=self, bug=bloat&leak went up
2000-02-09 23:20:56 +00:00
Benjamin Smedberg
dbaron@dbaron.org
dbaron%dbaron.org
sharparrow1%yahoo.com
roc+%cs.cmu.edu
pavlov%pavlov.net
timeless%mozdev.org
cvshook%sicking.cc
gavin%gavinsharp.com
jst%mozilla.jstenback.com
neil%parkwaycc.co.uk
bryner%brianryner.com
rbs%maths.uq.edu.au
gerv%gerv.net
uid502
bryner%netscape.com
jkeiser%netscape.com
bzbarsky%mit.edu
dbaron%fas.harvard.edu
bernd.mielke%snafu.de
karnaze%netscape.com
jst%netscape.com
rods%netscape.com
warren%netscape.com
hyatt%netscape.com