fea9dab7f2
Bug 1651714 - Reduce expensive includes for TabMessageUtils.h. r=smaug
...
With these changes, on my Linux analysis with ClangBuildAnalyzer, the
top two expensive headers, DOMTypes.h and TabMessageUtils.h are no longer
among the 30 most expensive headers.
Differential Revision: https://phabricator.services.mozilla.com/D82935
2020-07-15 13:24:20 +00:00
a7153982e8
Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
...
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
93c5659e4a
Bug 1644896 - Reintroduce an EnsureReadCompleted() in PermissionManager, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D83465
2020-07-14 07:36:14 +00:00
5a7b4e2136
Bug 1644896 - Add the shutdown blocker during the PermissionManager::initDB, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83360
2020-07-14 07:23:57 +00:00
2aa62ff0f3
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 20:18:40 +00:00
e0ac748fab
Backed out 2 changesets (bug 1644896) for XPCshell failures on widget/headless/tests/test_headless.js. CLOSED TREE
...
Backed out changeset f501e7db25a8 (bug 1644896)
Backed out changeset 2d984add3abb (bug 1644896)
2020-07-13 23:11:40 +03:00
c14aa7655d
Bug 1644896 - Add the shutdown blocker during the PermissionManager::initDB, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D83360
2020-07-13 17:48:30 +00:00
8a5c2d57b1
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 17:48:20 +00:00
51562a8355
Backed out changeset 73b12096811d (bug 1644896) for mochitest crashes CLOSED TREE
2020-07-13 12:32:28 +03:00
6955bc5543
Bug 1644896 - Destroy PermissionManager on shutdown, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D82211
2020-07-13 08:23:27 +00:00
9d78661f88
Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
6a39211860
Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 21:42:25 +00:00
b355fcc4bf
Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE
...
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
2020-07-09 23:19:26 +03:00
d09458dc51
Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 17:59:16 +00:00
61e4a0be9b
Bug 1649729 - Get rid of MOZ_ACCESS_THREAD_BOUND macro. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D81843
2020-07-01 13:13:23 +00:00
9364b353d4
Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80631
2020-07-01 08:42:31 +00:00
e3c223da3e
Bug 1648010 - Fix uses of NS_LITERAL_STRING with C string literals. r=geckoview-reviewers,agi,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80861
2020-07-01 08:34:12 +00:00
cd8b8939b9
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
788cd2c41f
Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81681
2020-06-30 18:34:51 +00:00
5b1b63de75
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-30 09:44:00 +00:00
adaed940e7
Backed out changeset 34d09061d827 (bug 1648134) for failures on test_permmanager_remove_add_update.js. CLOSED TREE
2020-06-29 20:43:54 +03:00
dc7bad122c
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D81292
2020-06-29 14:37:19 +00:00
1d1ef81356
Bug 1645997 - Use BrowsingContext to get the top-level window context in PermissionDelegateHandler.cpp r=baku
...
We used the Document::GetWindowContext() to get the window context
related to the doucment. But, this could return a nullptr if the
document is detached from the window or the docuemnt is destoried.
We move to use the BrowsingContext instead which won't return a nullptr
in these cases.
Differential Revision: https://phabricator.services.mozilla.com/D79897
2020-06-19 12:31:29 +00:00
d5b9be12ce
Bug 1603712 - Remove intl.charset.detector.ng.enabled pref and resulting dead code. r=Gijs,fluent-reviewers,valentin,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D79101
2020-06-15 15:32:21 +00:00
f5adef2650
Bug 1587743 - Part 3: Using WindowContext to test delegated permissions. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D79134
2020-06-12 16:32:03 +00:00
8422436b6c
Bug 1587743 - Part 2: Removing mTopLevelPrincipal from the PermissionDelegateHandler. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D79133
2020-06-12 16:31:56 +00:00
eab7aa2b87
Bug 1587743 - Part 1: Pre-compute the delegated permissions for the top-level content and store it in the WindowContext. r=baku,nika
...
In order to delegate the permission to the top-level window, in this
patch, we pre-compute the permissions of the top-level context and set
them to the top-level WindowContext. So, the cross-origin iframe can
know the permission of the top-level window through the WindowContext.
Thus, the permission can be delegated in Fission.
Differential Revision: https://phabricator.services.mozilla.com/D79132
2020-06-12 16:31:49 +00:00
b1f63ced7e
Bug 1632845 - Firefox gets stuck when quit from the dock if the user cancels quitting from a beforeunload prompt r=Gijs,spohl,necko-reviewers,geckoview-reviewers,dragana,agi
...
Return NSTerminateCancel from applicationShouldTerminate when the user chooses to "Stay on Page".
Differential Revision: https://phabricator.services.mozilla.com/D78839
2020-06-09 18:20:36 +00:00
53b848ce2f
Bug 1644073 - Remove storageAccessAPI permission from preload list r=baku
...
We add storageAccessAPI permission to perload list in Bug 1499442.
In the recent ETP fission works, we have ensured that the user interaction
permission check can only happen either in the parent process or in the
content processes that load principal to check. This means we don't need
to preload it anymore.
Differential Revision: https://phabricator.services.mozilla.com/D78639
2020-06-08 11:24:05 +00:00
b8d216c8f6
Bug 1637553 - Reduce array copy in spell checker loop. r=masayuki
...
Actually, we always clone spell checker range array per IPC call into spell
check loop. But we can use `std::move` to reduce unnecessary copy.
Also, `mozInlineSpellWordUtil::GetNextWord` always returns NS_OK, so
this should use boolean value to know whether loop is done.
Differential Revision: https://phabricator.services.mozilla.com/D75111
2020-05-27 14:33:12 +00:00
89958b377a
Bug 1640605 - Remove IsInAnonymousSubtree / IsRootOfAnonymousSubtree. r=edgar
...
In favor of the NativeAnonymous versions which they forward to.
Done automatically with:
rg -l 'IsInAnonymousSubtree' | xargs sed -i 's/IsInAnonymousSubtree/IsInNativeAnonymousSubtree/g'
And removing the function definitions afterwards.
Differential Revision: https://phabricator.services.mozilla.com/D76681
2020-05-25 11:43:51 +00:00
badadf3f93
Bug 1596855 - Update browser_permmgr_sync.js for Fission. r=pbz
...
The test was updated to ensure that under Fission we're not syncing
all permission information to a "parent" content process, and instead
just to the specific iframe that needs it.
Differential Revision: https://phabricator.services.mozilla.com/D76103
2020-05-20 16:45:01 +00:00
68dab10ed9
Bug 1629274 - Fix Intermittent failure in test_permmanager_removeall.js, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D74590
2020-05-11 08:34:04 +00:00
8bc8cd34b1
Bug 1635693 - Ensure permissionManager DB connection is active only if the initialization completed, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D74385
2020-05-08 16:23:15 +00:00
011b59d595
Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
...
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.
This was done automatically with a new eslint rule that will be introduced in
the next commit. One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS. The rule will be disabled for that instance.
Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
6a983da8c3
Bug 1626570 - Improve handling of copying arrays in extensions/spellcheck. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D72319
2020-04-30 09:36:26 +00:00
38afb32dc5
Bug 1626555 - Make `dom/base` buildable outside of `unified-build` environment. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D69183
2020-04-29 09:02:05 +00:00
59f0df8747
Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 17:26:04 +00:00
ce17a27917
Backed out changeset b1f668b65e69 (bug 1627220) for causing xpcshell failures at extensions/permissions/test/unit/test_permmanager_expiration.js
...
CLOSED TREE
2020-04-27 17:49:53 +03:00
105e5e23f6
Bug 1627220 - Skip expired permissions in getAllWithTypePrefix and getAllForPrincipal. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D72454
2020-04-27 11:40:53 +00:00
ea62971514
Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
...
***
Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-23 13:11:56 +00:00
b611a44386
Backed out changeset a2bff0eef797 (bug 1623417) for causing xpcshell failures in test_permmanager_matchesuri.js CLOSED TREE
2020-04-20 20:09:23 +03:00
bb11628699
Bug 1623417 - Refactor nsPermission.cpp r=ckerschb
...
***
Differential Revision: https://phabricator.services.mozilla.com/D67371
2020-04-20 15:59:44 +00:00
85532d60f8
Bug 1626076 - Make it possible to use DataStorage on socket process r=keeler,dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D68877
2020-04-20 09:41:58 +00:00
c0401ba16f
Bug 1620402 - Refactor nsPermissionManager.cpp r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D65606
2020-04-20 09:53:40 +00:00
7be9697324
Bug 1629450 - reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku
...
Started failing following https://hg.mozilla.org/mozilla-central/rev/f1d9689ea300
Differential Revision: https://phabricator.services.mozilla.com/D70930
--HG--
extra : moz-landing-system : lando
2020-04-15 07:23:11 +00:00
7e719a42a0
Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku
...
After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.
Differential Revision: https://phabricator.services.mozilla.com/D70675
--HG--
extra : moz-landing-system : lando
2020-04-14 08:34:17 +00:00
68d9c71f19
Bug 1629273 - Fix intermittent failure in test_permmanager_load_invalid_entries.js, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70639
--HG--
extra : moz-landing-system : lando
2020-04-14 07:55:52 +00:00
98eff139c5
Bug 1363541 - Modernize the PermissionManager - part 6 - moving code around, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70164
--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:53 +00:00
9f0376cefe
Bug 1363541 - Modernize the PermissionManager - part 5 - headers, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D70041
--HG--
extra : moz-landing-system : lando
2020-04-11 13:42:30 +00:00
Simon Giesecke
Frederik Braun
Andrea Marchesini
Dorel Luca
Bogdan Tara
Kris Maglione
Csoregi Natalia
Tim Huang
Henri Sivonen
Haik Aftandilian
Dimi Lee
Makoto Kato
Emilio Cobos Álvarez
Johann Hofmann
Ian Moody
Andi-Bogdan Postelnicu
Daniel Varga
Sebastian Streich
Noemi Erli
Kershaw Chang
Magnus Melin