Andrea Marchesini
9f4ca5a041
Bug 1310483 - Implement nsIURIWithQuery for having query part in simple URI, r=valentin
2016-11-14 13:04:33 +01:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Eric Rahm
ee9ba04219
Bug 1262948 - Remove warning from URL constructor. r=baku
...
Remove warning if constructing a new URI fails. An exception is still thrown on failure.
2016-08-15 11:16:25 -07:00
Geoff Lankow
d14b295017
Bug 1287657 - Context menu items should not be disabled for media with a blob URL; r=kinetik, r=baku
2016-07-25 22:41:52 +12:00
Andrea Marchesini
8183e57459
Bug 1279493 - Use blob URLs exclusively rather than having mediastream and mediasource URLs, r=smaug
2016-07-21 14:31:43 +02:00
Andrea Marchesini
be759d0233
Bug 1286955. Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
2016-07-15 22:35:12 -04:00
Carsten "Tomcat" Book
e75558e07b
Backed out changeset cf2bb72412a0 (bug 1286955) for hazard failures
2016-07-16 10:03:27 +02:00
Andrea Marchesini
fccb098fcb
Bug 1286955. Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
2016-07-15 22:35:12 -04:00
Andrea Marchesini
9b8df4a1d1
Bug 1270185 - create dom/url for URL API and its tests, r=ehsan
...
--HG--
rename : dom/base/URL.cpp => dom/url/URL.cpp
rename : dom/base/URL.h => dom/url/URL.h
rename : dom/base/URLSearchParams.cpp => dom/url/URLSearchParams.cpp
rename : dom/base/URLSearchParams.h => dom/url/URLSearchParams.h
rename : dom/base/test/file_url.jsm => dom/url/tests/file_url.jsm
rename : dom/workers/test/file_url.jsm => dom/url/tests/file_worker_url.jsm
rename : dom/workers/test/jsm_url_worker.js => dom/url/tests/jsm_url_worker.js
rename : dom/workers/test/test_bug883784.jsm => dom/url/tests/test_bug883784.jsm
rename : dom/workers/test/test_bug883784.xul => dom/url/tests/test_bug883784.xul
rename : dom/base/test/test_unknown_url_origin.html => dom/url/tests/test_unknown_url_origin.html
rename : dom/base/test/test_url.html => dom/url/tests/test_url.html
rename : dom/base/test/test_url.xul => dom/url/tests/test_url.xul
rename : dom/base/test/test_urlExceptions.html => dom/url/tests/test_urlExceptions.html
rename : dom/base/test/test_urlSearchParams.html => dom/url/tests/test_urlSearchParams.html
rename : dom/base/test/test_urlSearchParams_utf8.html => dom/url/tests/test_urlSearchParams_utf8.html
rename : dom/base/test/test_url_data.html => dom/url/tests/test_url_data.html
rename : dom/base/test/test_url_empty_port.html => dom/url/tests/test_url_empty_port.html
rename : dom/base/test/test_url_malformedHost.html => dom/url/tests/test_url_malformedHost.html
rename : dom/base/test/test_urlutils_stringify.html => dom/url/tests/test_urlutils_stringify.html
rename : dom/workers/test/test_url.html => dom/url/tests/test_worker_url.html
rename : dom/workers/test/test_url.xul => dom/url/tests/test_worker_url.xul
rename : dom/workers/test/test_urlApi.html => dom/url/tests/test_worker_urlApi.html
rename : dom/workers/test/test_urlSearchParams.html => dom/url/tests/test_worker_urlSearchParams.html
rename : dom/workers/test/test_url_exceptions.html => dom/url/tests/test_worker_url_exceptions.html
rename : dom/workers/test/urlApi_worker.js => dom/url/tests/urlApi_worker.js
rename : dom/workers/test/urlSearchParams_worker.js => dom/url/tests/urlSearchParams_worker.js
rename : dom/workers/test/url_exceptions_worker.js => dom/url/tests/url_exceptions_worker.js
rename : dom/workers/test/url_worker.js => dom/url/tests/url_worker.js
2016-06-29 07:44:18 +02:00