e92f158606
Backed out 4 changesets (bug 1734590) for failures on test_xmlserializer.js. CLOSED TREE
...
Backed out changeset e492f8fd3d53 (bug 1734590)
Backed out changeset 0af985bb7569 (bug 1734590)
Backed out changeset 3751b93ae994 (bug 1734590)
Backed out changeset 45059121c015 (bug 1734590)
2021-10-08 14:41:06 +03:00
a21b07a094
Bug 1734590 - Eliminate use of LineBreaker::DeprecatedNext in nsXMLContentSerializer.cpp. r=TYLin
...
The behavior change of Next() vs DeprecatedNext() here is OK, because if DeprecatedNext()
failed to find a break position then we'd end up reaching the "simple fallback logic"
below, which will just advance to the next space or end-of-text anyhow.
The only case, then, where this results in a change of behavior would be if there's a
space that the line-breaker does *not* consider a valid break, so that instead it
advances to end-of-text, where previously we'd have reached the fallback code and
used the (invalid) space as a break. So (a) this is a really obscure edge-case, and
(b) the new behavior would be more correct anyhow.
Differential Revision: https://phabricator.services.mozilla.com/D127805
2021-10-08 10:05:51 +00:00
b53e11a558
Bug 1734267 remove unused aWindowId parameter from MediaEngine::EnumerateDevices() r=pehrsons
...
Added in https://hg.mozilla.org/mozilla-central/rev/f0219139820a .
Unused since https://hg.mozilla.org/mozilla-central/rev/1248d2f659a9 .
Differential Revision: https://phabricator.services.mozilla.com/D127603
2021-10-08 09:26:53 +00:00
2040c8827e
Bug 1725539 - p4. Document the new GC scheduling code r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D123099
2021-10-08 05:02:28 +00:00
655d28c9ce
Bug 1725539 - p3. Don't re-create the GC runner before tha parent replies r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D123098
2021-10-08 05:02:27 +00:00
f0a1c9464c
Bug 1725539 - p2. Provide an ordering of GC reasons r=smaug
...
GC reasons clobber each-other as follows:
USER_INACTIVE > FULL_GC_TIMER > all others.
To ensure that if multiple timers fire we still do the strongest GC
requested.
Differential Revision: https://phabricator.services.mozilla.com/D122556
2021-10-08 05:02:27 +00:00
5d7d2b08cb
Bug 1725539 - p1. Fix and simplify the logic for mWantAtLeastRegularGC r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D122555
2021-10-08 05:02:27 +00:00
9c12e87bb7
Bug 1733876 Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato
...
The purpose of this patch is to remove LineBreaker::Prev(), and audit
the deprecated LineBreaker::DeprecatedNext() (added in bug 1733872).
Add blockquotecite gtest to make sure short line wrapping with
blockquote citation still works. The testcase's behavior is not changed.
Differential Revision: https://phabricator.services.mozilla.com/D127385
2021-10-07 23:01:42 +00:00
6e8b20ae7f
Bug 1733876 Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato
...
This is required by Part 5.
Differential Revision: https://phabricator.services.mozilla.com/D127384
2021-10-07 23:01:41 +00:00
e296f6d00d
Bug 1733876 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato
...
This patch only moves logic, and shouldn't change the behavior.
Differential Revision: https://phabricator.services.mozilla.com/D127383
2021-10-07 23:01:41 +00:00
afe1ba25ee
Bug 1733876 Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser
...
With this edge case explicitly considered, it will be easier for the
following patches to simplify logic in `FindWrapIndexForContent()`.
Differential Revision: https://phabricator.services.mozilla.com/D127382
2021-10-07 23:01:40 +00:00
11076c9ddf
Bug 1733876 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser
...
Differential Revision: https://phabricator.services.mozilla.com/D127381
2021-10-07 23:01:40 +00:00
4ab0a903c6
Bug 1678627: Implement a mechanism to fire bookmark-time-changed event. r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D125924
2021-10-07 22:10:20 +00:00
23950c9b84
Bug 1733722 - part2 : add test. r=bryce
...
Depends on D127339
Differential Revision: https://phabricator.services.mozilla.com/D127340
2021-10-07 21:33:58 +00:00
2c7a5e9c88
Bug 1733722 - part1 : add telemetry probe to record if video codec can use hardware decoding. r=bryce
...
Differential Revision: https://phabricator.services.mozilla.com/D127339
2021-10-07 21:33:58 +00:00
6d82d33655
Backed out 5 changesets (bug 1733876) for causing build windows bustages CLOSED TREE
...
Backed out changeset f7f60a86bf47 (bug 1733876)
Backed out changeset 6f0a6fcd5f5e (bug 1733876)
Backed out changeset b06880832da2 (bug 1733876)
Backed out changeset 2a6422635d37 (bug 1733876)
Backed out changeset dd5f9ce8a831 (bug 1733876)
2021-10-07 21:12:58 +03:00
26c14b3225
Backed out 24 changesets (bug 1678373) for causing bc failures in browser_tab_visibility_and_play_time.js
...
CLOSED TREE
Backed out changeset 1886dbd81c46 (bug 1678373)
Backed out changeset aeff26b5b1ae (bug 1678373)
Backed out changeset 261d8e4483d4 (bug 1678373)
Backed out changeset 89cb5ae23632 (bug 1678373)
Backed out changeset b1eaedd192ab (bug 1678373)
Backed out changeset 58a3eb19c818 (bug 1678373)
Backed out changeset b027ec789cbe (bug 1678373)
Backed out changeset fd596a84feb9 (bug 1678373)
Backed out changeset 1f0ed0392ae2 (bug 1678373)
Backed out changeset ac2be1df81af (bug 1678373)
Backed out changeset bf6d47905d78 (bug 1678373)
Backed out changeset a9fe4f310962 (bug 1678373)
Backed out changeset a15316058968 (bug 1678373)
Backed out changeset 217cdfd46120 (bug 1678373)
Backed out changeset c33c8411129b (bug 1678373)
Backed out changeset 3b854fc36abf (bug 1678373)
Backed out changeset e47c82bcb49a (bug 1678373)
Backed out changeset 2a77cbba1c9f (bug 1678373)
Backed out changeset 65206afede36 (bug 1678373)
Backed out changeset bd04930155f4 (bug 1678373)
Backed out changeset 034e8edd4619 (bug 1678373)
Backed out changeset ed1e56487c4c (bug 1678373)
Backed out changeset b7673d20c521 (bug 1678373)
Backed out changeset 5a93251e2fea (bug 1678373)
2021-10-07 20:36:47 +03:00
896d7904fd
Bug 1733876 Part 5 - Simply line wrapping logic involving line breaker in FindWrapIndexForContent(). r=m_kato
...
The purpose of this patch is to remove LineBreaker::Prev(), and audit
the deprecated LineBreaker::DeprecatedNext() (added in bug 1733872).
Add blockquotecite gtest to make sure short line wrapping with
blockquote citation still works. The testcase's behavior is not changed.
Differential Revision: https://phabricator.services.mozilla.com/D127385
2021-10-07 17:10:15 +00:00
d08912596c
Bug 1733876 Part 4 - Allow GetUnicharStringWidth() to support mozilla::Span substring argument. r=m_kato
...
This is required by Part 5.
Differential Revision: https://phabricator.services.mozilla.com/D127384
2021-10-07 17:10:15 +00:00
060d72b1fb
Bug 1733876 Part 3 - Consolidate logic dealing with and without aLineBreaker in FindWrapIndexForContent(). r=m_kato
...
This patch only moves logic, and shouldn't change the behavior.
Differential Revision: https://phabricator.services.mozilla.com/D127383
2021-10-07 17:10:14 +00:00
6993f02a9e
Bug 1733876 Part 2 - Run line wrapping algorithm only if content of current line is not empty. r=m_kato,mbrodesser
...
With this edge case explicitly considered, it will be easier for the
following patches to simplify logic in `FindWrapIndexForContent()`.
Differential Revision: https://phabricator.services.mozilla.com/D127382
2021-10-07 17:10:14 +00:00
431bd8d5d2
Bug 1733876 Part 1 - Remove unused kNoFlags in nsPlainTextSerializer.cpp. r=mbrodesser
...
Differential Revision: https://phabricator.services.mozilla.com/D127381
2021-10-07 17:10:14 +00:00
9fbc18ca4c
Bug 1733384 - Make inert not modify the computed style. r=sefeng,layout-reviewers,jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D127422
2021-10-07 17:00:36 +00:00
a76e403529
Bug 1678373 - Remove mAudibleState. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D127559
2021-10-07 15:44:59 +00:00
c3e0d55a5d
Bug 1678373 - Don't count muted time without an audio track, but start counting time as soon as an audio track is added. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D126912
2021-10-07 15:44:58 +00:00
13eff79a3a
Bug 1678373 - Count muted time correct when seeking while muted. r=alwu
...
The counter was paused, but `mIsMuted` was getting desynchronized. It's best to
reset the media element muted state, visibility and media content when paused,
they are set again properly in ::Play, preventing any issue.
It is necessary to reset the media content after reporting telemetry, because a
media content of MEDIA_HAS_NOTHING isn't reported.
Differential Revision: https://phabricator.services.mozilla.com/D125845
2021-10-07 15:44:58 +00:00
dc9fb0994e
Bug 1678373 - Add telemetry probes for audible and muted media. r=alwu data-review=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D125694
2021-10-07 15:44:57 +00:00
6a8e954392
Bug 1678373 - Add a testcase for MEDIA_PLAY_TIME_MS. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125693
2021-10-07 15:44:56 +00:00
4fc40231a3
Bug 1678373 - Prepare tests for test-cases without video. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125692
2021-10-07 15:44:56 +00:00
7ca1f38445
Bug 1678373 - Fix displaying the media element by using display: block. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125691
2021-10-07 15:44:56 +00:00
b422324e29
Bug 1678373 - Put the new and old value in the assert to diagnose failures better. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125690
2021-10-07 15:44:55 +00:00
2e756eee23
Bug 1678373 - Add tests for muted and audible audio. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125689
2021-10-07 15:44:55 +00:00
410e29319c
Bug 1678373 - Add a telemetry probe for understanding how media content with audio content is played back. r=alwu data-review=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D125089
2021-10-07 15:44:54 +00:00
82125c0639
Bug 1678373 - Add a way to measure the duration a media was muted. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125088
2021-10-07 15:44:54 +00:00
ef0bfbff05
Bug 1678373 - Fix a typo in the accumulator names. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125087
2021-10-07 15:44:54 +00:00
6dc847cdf6
Bug 1678373 - Expose audio telemetry counters as chrome-only attributes like their video counterparts. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125084
2021-10-07 15:44:53 +00:00
94b7678216
Bug 1678373 - Rename chrome-only telemetry counter attributes to distinguish audio and video. r=alwu,webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D125083
2021-10-07 15:44:53 +00:00
521f23c69b
Bug 1678373 - Make the test more robust, and check constant/increasing accumulators a bit more. r=alwu
...
This was failing locally sometimes. Resolving a Promise is not very
deterministic: it can take some time, or be almost instantaneous. It's simpler
to block the main thread for a time duration longer than the clock resolution of
the OS. Generally, the worst clock resolution is on Windows, it's by default
16ms, and resolving a Promise is often a lot faster than 16ms, so we could have
had the same value here, but the code was correct. The reason that it passed was
because of this code. This is currently changing a lot in Windows, but 30ms is a
good middle ground I thought. The clock resolution on macOS/Linux
desktop/Android/anything else such as BSDs is a lot better than 16ms (in the
microsecond/nanosecond range depending on the kernel), so we're good there.
Differential Revision: https://phabricator.services.mozilla.com/D125082
2021-10-07 15:44:53 +00:00
5b350b7fc5
Bug 1678373 - The test was failing because the video ended early. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125081
2021-10-07 15:44:52 +00:00
575630f8df
Bug 1678373 - Don't detach the media element from the tree for checking play time probes: it pauses the media element per spec. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125080
2021-10-07 15:44:52 +00:00
16baeacc14
Bug 1678373 - Add initial accumulator for audio. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125079
2021-10-07 15:44:51 +00:00
d7ef88efff
Bug 1678373 - Add a way to specify the type of content (audio/video/both) in the TelemetryProbesReporter, change a bit visibility event handling. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125078
2021-10-07 15:44:51 +00:00
26de5c39a8
Bug 1678373 - Move the call to report that media telemetry has been reported. r=alwu
...
Needed for report audio telemetry in a later patch.
Differential Revision: https://phabricator.services.mozilla.com/D125077
2021-10-07 15:44:51 +00:00
1f3a23567c
Bug 1678373 - Only call into the telemetry state change code when the state changes. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125076
2021-10-07 15:44:50 +00:00
b934a76011
Bug 1678373 - Rename mTotalPlayTime and friends to mention it's about video. r=alwu
...
Differential Revision: https://phabricator.services.mozilla.com/D125075
2021-10-07 15:44:50 +00:00
8c4f4eeecc
Bug 1627379 - disable test_unregister_invalid_json.js on Win_QR for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D127791
2021-10-07 15:21:17 +00:00
e67c38d728
Bug 1734523 - Remove the use of MozbuildObject.mozconfig in mozwebidlcodegen. r=firefox-build-system-reviewers,mhentges
...
Differential Revision: https://phabricator.services.mozilla.com/D127765
2021-10-07 15:19:03 +00:00
ef6201cb3e
Bug 1698522: Process name setting cleanup r=nika,dveditz
...
Differential Revision: https://phabricator.services.mozilla.com/D108446
2021-10-07 14:57:10 +00:00
4d927c1fb4
Backed out 4 changesets (bug 1733384) for causing failures at browser_windowPrompt.js. CLOSED TREE
...
Backed out changeset fa609fadac26 (bug 1733384)
Backed out changeset dd1936d9fe17 (bug 1733384)
Backed out changeset 1a073e40ab1a (bug 1733384)
Backed out changeset 65708a4c708f (bug 1733384)
2021-10-07 17:52:51 +03:00
92b7c2a045
Bug 1734238 - Wheel event should be dispatched to the remote target that requests the pointer lock; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D127810
2021-10-07 14:13:50 +00:00
Csoregi Natalia
Jonathan Kew
Karl Tomlinson
Paul Bone
Ting-Yu Lin
Daisuke Akatsuka
alwu
Noemi Erli
Alexandru Michis
Emilio Cobos Álvarez
Paul Adenot
Butkovits Atila
Mike Hommey
Randell Jesup
Edgar Chen